| *** electrofelix has joined #openstack-jjb | 07:25 | |
| *** electrofelix has quit IRC | 17:50 | |
| aricg | ssbarnea_: the api for build blocker was broken by this change https://review.openstack.org/#/c/476746 zxiiro-pto is out could you please review the propose fix? https://review.openstack.org/#/c/608092/ | 18:21 |
|---|---|---|
| ssbarnea_ | aricg: but this change does not pass CI, without this it doesn't make any sense to review it. | 18:22 |
| ssbarnea_ | aricg: i can understand you want to fix it but it needs to pass the tests first. | 18:23 |
| aricg | ssbarnea_: understood, but the test didnt catch this last time, so it is also broken in some way | 18:28 |
| ssbarnea_ | nothing can be merged without getting all-greens | 18:29 |
| openstackgerrit | Aric Gardner proposed openstack-infra/jenkins-job-builder master: Fix 'block-level' Build Blocker Plugin Property https://review.openstack.org/608092 | 18:41 |
| aricg | ssbarnea_: the test passed originally | 18:44 |
| aricg | Patch Set 2: | 18:44 |
| aricg | I'm not very confident in the tests right now. Hopefully my change in the tests from 'global' to 'node' without updating the xml will cause the tests to fail. | 18:44 |
| aricg | The reason I believe they're passing currently is because the default 'blockLevel' is GLOBAL, and there was technically nothing set to change that in the YAML file. | 18:44 |
| aricg | so we changed it so it would fail | 18:44 |
| aricg | i have set it back so that it passes | 18:44 |
| aricg | but I think it warrents a deeper look | 18:44 |
| aricg | ssbarnea_: its +1 now https://review.openstack.org/#/c/608092/3 | 20:13 |
| ssbarnea_ | aricg: thanks, i added +2, now just wait for another core to +2 and we can +W | 20:16 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!