| *** hashar has joined #openstack-jjb | 08:06 | |
| *** ssbarnea|bkp has quit IRC | 08:14 | |
| *** openstackgerrit has quit IRC | 08:22 | |
| *** ssbarnea|bkp has joined #openstack-jjb | 10:23 | |
| abelur | I see that we seem to calling JJBConfig() from the tests which is read the global config (~/.config/<user>/jenkins-jobs.ini), instead of the default JJB config? | 12:55 |
|---|---|---|
| abelur | https://www.irccloud.com/pastebin/RpWkHPpw/test_multiple_same_anchor_in_multiple_toplevel_yaml | 12:56 |
| abelur | ssbarnea: should we be reading the default config which is set for the tests instead of global config? | 12:57 |
| ssbarnea | abelur: yep, unless we want to test exactly the loading of user-config (which should be mocked anyway). if tests are failing due to your user config, is clearly a bug. testing should not be afected by it. | 12:58 |
| abelur | ssbarnea: once I renamed my jenkins_jobs.ini ... all tests are passing? | 12:59 |
| abelur | ssbarnea: anyway we can pass a param to JJBConfig() to suggest reading the defualt config defined for the test ... | 13:00 |
| abelur | ssbarnea: at this point am not sure if the default conf is defined for thoese tests :/ | 13:01 |
| ssbarnea | abelur: do a CR for it, and don't forget to mention the bug in description. | 13:01 |
| abelur | ssbarnea: ack | 13:04 |
| *** openstackgerrit has joined #openstack-jjb | 14:46 | |
| openstackgerrit | Anil Belur proposed openstack-infra/jenkins-job-builder master: Add support for "Build / Publish Docker Image" https://review.openstack.org/601291 | 14:46 |
| openstackgerrit | Anil Belur proposed openstack-infra/jenkins-job-builder master: docker-pull-image: Pull Docker image from Docker Hub/Registry https://review.openstack.org/602982 | 15:06 |
| *** hashar is now known as hasharDinner | 16:55 | |
| *** harlowja has joined #openstack-jjb | 17:36 | |
| *** harlowja has quit IRC | 17:58 | |
| *** harlowja has joined #openstack-jjb | 19:50 | |
| *** harlowja has quit IRC | 20:22 | |
| *** harlowja has joined #openstack-jjb | 20:25 | |
| *** ktdreyer_ has joined #openstack-jjb | 22:56 | |
| *** waynr has quit IRC | 23:00 | |
| *** ktdreyer has quit IRC | 23:00 | |
| *** hasharDinner has quit IRC | 23:05 | |
| *** waynr has joined #openstack-jjb | 23:07 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!