| zxiiro | I'm flying to Amsterdam tomorrow and will be out for a ~3 weeks. gonna release JJB tonight | 01:12 |
|---|---|---|
| zxiiro | Guess I should review and see if there's patches to merge first. | 01:14 |
| *** harlowja has quit IRC | 01:18 | |
| openstackgerrit | Merged openstack-infra/jenkins-job-builder master: email: Utilize convert_mapping_to_xml https://review.openstack.org/600795 | 01:25 |
| openstackgerrit | Merged openstack-infra/jenkins-job-builder master: hue-light: Add commas to mapping tuple https://review.openstack.org/602617 | 01:26 |
| openstackgerrit | Merged openstack-infra/jenkins-job-builder master: copyartifact-build-selector: Utilize convert_mapping_to_xml https://review.openstack.org/596532 | 01:29 |
| openstackgerrit | Merged openstack-infra/jenkins-job-builder master: Fix options.update is not 'all' if no config https://review.openstack.org/603803 | 01:33 |
| openstackgerrit | Merged openstack-infra/jenkins-job-builder master: build-keeper: Add support for RunCondition https://review.openstack.org/593419 | 01:43 |
| *** hashar has joined #openstack-jjb | 06:15 | |
| openstackgerrit | Jaime Melis proposed openstack-infra/jenkins-job-builder master: gitlab-merge-request: Add support for 2.x https://review.openstack.org/600804 | 08:51 |
| *** ssbarnea|bkp2 has joined #openstack-jjb | 09:38 | |
| ssbarnea|bkp2 | zxiiro this seems important for at least 3 people, lets merge it unless you see a problem with it https://review.openstack.org/#/c/572179/ | 09:38 |
| ssbarnea|bkp2 | zxiiro also https://review.openstack.org/#/c/588154/ seems harmless. | 09:40 |
| openstackgerrit | Merged openstack-infra/jenkins-job-builder master: config-file-provider: Add tests https://review.openstack.org/593372 | 11:38 |
| openstackgerrit | Anil Belur proposed openstack-infra/jenkins-job-builder master: cucumber-reports: Add support for new options https://review.openstack.org/599218 | 12:28 |
| *** hashar has quit IRC | 12:32 | |
| openstackgerrit | Anil Belur proposed openstack-infra/jenkins-job-builder master: jclouds: Utilize convert_mapping_to_xml https://review.openstack.org/602615 | 12:35 |
| *** ssbarnea|bkp has joined #openstack-jjb | 12:51 | |
| openstackgerrit | Anil Belur proposed openstack-infra/jenkins-job-builder master: docker-container: Improve support for more options https://review.openstack.org/603135 | 12:52 |
| *** ssbarnea|bkp2 has quit IRC | 12:54 | |
| *** hashar has joined #openstack-jjb | 13:03 | |
| openstackgerrit | Anil Belur proposed openstack-infra/jenkins-job-builder master: docker-custom-build-env: Add support for new options https://review.openstack.org/603150 | 13:09 |
| zxiiro | ssbarnea|bkp: approved the 2nd one. let me do a quick jenkins-jobs test against opendaylight with the first patch. | 13:39 |
| openstackgerrit | Merged openstack-infra/jenkins-job-builder master: docker-custom-build-env: Add support for new options https://review.openstack.org/603150 | 13:43 |
| ssbarnea|bkp | zxiiro another one https://review.openstack.org/588938 | 13:44 |
| openstackgerrit | Merged openstack/python-jenkins master: Add folder credential support https://review.openstack.org/588154 | 13:46 |
| openstackgerrit | Merged openstack-infra/jenkins-job-builder master: gitlab-merge-request: Add support for 2.x https://review.openstack.org/600804 | 13:49 |
| *** openstackgerrit has quit IRC | 14:07 | |
| *** openstackgerrit has joined #openstack-jjb | 14:11 | |
| openstackgerrit | Merged openstack/python-jenkins master: Check for 'Location' header in the response https://review.openstack.org/572179 | 14:11 |
| ssbarnea|bkp | zxiiro: https://review.openstack.org/#/c/583535/ old git-review one. | 14:18 |
| zxiiro | ssbarnea|bkp: gotta head to the airport (heading to Amsterdam today) I'll take a look a bit later but looks like Darraugh and Tomas are still having a discussion there? | 14:19 |
| zxiiro | oh yeah the openstack-infra people were talking about potentially adding us as core reviewers in git-review | 14:19 |
| zxiiro | I guess I should spend more time reviewing things over there | 14:20 |
| zxiiro | ssbarnea|bkp: gave you a +1 | 14:20 |
| ssbarnea|bkp | zxiiro: thanks, and have fun in AMS | 14:20 |
| Liskni_si | I don't think we're having any discussion any more in any commit related to tja-fast-get-jobs. I addressed everything Darragh pointed out and haven't heard from him ever since. | 14:22 |
| Liskni_si | (But I may have missed something. Asked him here a few days ago, didn't get an answer either.) | 14:22 |
| zxiiro | Liskni_si: sounds good. I'll try to find some time to review it. From my perspective if jenkins-jobs test passes against the opendaylight jjb repo I'm good. | 14:31 |
| zxiiro | python-jenkin's broke us a few times, so I'm being more cautious about releases of it now. | 14:32 |
| Liskni_si | zxiiro: you'd need a live jenkins instance to notice a breakage | 14:32 |
| Liskni_si | (just so you know what needs to be tested) | 14:33 |
| zxiiro | yeah, I was thinking of hooking our jenkins system into openstack's gerrit to report when a patch breaks us but haven't had time to investigate getting that done just yet. | 14:33 |
| Liskni_si | Anyway, thanks for taking the time to look at it. If I was travelling by an airplane, I'd probably be just stressed and do nothing. :-) | 14:34 |
| zxiiro | ssbarnea|bkp: that reminds me, I had to revert 2 of your python-jenkins patches https://review.openstack.org/596404 & https://review.openstack.org/596403 | 14:35 |
| zxiiro | ssbarnea|bkp: you should probably resurrect them if you need them. | 14:35 |
| zxiiro | but those 2 patches broke us when it got released and deployed | 14:35 |
| ssbarnea|bkp | zxiiro unlikely that i will need them but I know where to search for them if needed. | 14:36 |
| openstackgerrit | Sorin Sbarnea proposed openstack-infra/jenkins-job-builder master: Blueocean configuration for multibranch project https://review.openstack.org/566404 | 15:11 |
| *** hashar is now known as hasharAway | 15:18 | |
| *** ssbarnea|bkp has quit IRC | 17:18 | |
| *** harlowja has joined #openstack-jjb | 17:21 | |
| *** ktdreyer_ is now known as ktdreyer | 17:39 | |
| harlowja | does the github scm option `ssh-checkout: true` also take a credential id? | 17:41 |
| harlowja | (if say i pass a string instead of true) | 17:42 |
| harlowja | seems like not supported yet | 18:42 |
| harlowja | (durn) | 18:42 |
| *** ssbarnea|bkp has joined #openstack-jjb | 18:42 | |
| *** ssbarnea|bkp has quit IRC | 19:31 | |
| *** hasharAway has quit IRC | 21:30 | |
| *** ssbarnea|bkp has joined #openstack-jjb | 21:52 | |
| *** ssbarnea|bkp2 has joined #openstack-jjb | 23:01 | |
| *** ssbarnea|bkp has quit IRC | 23:03 | |
| *** harlowja has quit IRC | 23:54 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!