| *** larainema has joined #openstack-jjb | 03:33 | |
| *** _xela_ has quit IRC | 06:09 | |
| *** hashar has joined #openstack-jjb | 07:23 | |
| *** electrofelix has joined #openstack-jjb | 08:16 | |
| *** ssbarnea|ruck has quit IRC | 12:13 | |
| abelur | electrofelix: kien-ha: can you guys take look at the change please https://review.openstack.org/#/c/584583/3 | 14:45 |
|---|---|---|
| abelur | and weigh your opinions | 14:45 |
| *** openstackgerrit has quit IRC | 15:31 | |
| *** openstackgerrit has joined #openstack-jjb | 15:47 | |
| openstackgerrit | Tan Heng Yeow proposed openstack-infra/jenkins-job-builder master: ci-skip: Refactor to improve readability https://review.openstack.org/593286 | 15:47 |
| electrofelix | abelur: I've taken a look, based on some of the previous comments around avoiding the ambiguity of config options that are mutually exclusive being able to be set at the same time, I think you should go further with the change and alter how the '--views-only' and '--jobs-only' options are recorded in the CLI to make them use the same option with different values set | 15:54 |
| abelur | electrofelix: so should we have a single option in the config file, which rewires to add_jobs and add_views internal flags ? | 15:58 |
| electrofelix | take a look at the review, I'm thinking the config option as currently defined in your change is fine 'update = all|jobs|views', but the code to establish from the options what is set versus the config file is quite messy and instead we should change how the CLI stores the value of --views-only or --jobs-only to follow the same idea of the config option | 15:59 |
| electrofelix | use a single target to be updated by both options called 'update', setting '--jobs-only' sets it to 'jobs' setting '--views-only' sets it to 'views' and by default it's set to 'all'. So it matches the config file option behaviour and values. | 16:00 |
| abelur | electrofelix: alirght, thanks | 16:02 |
| *** hashar has quit IRC | 16:34 | |
| *** hashar has joined #openstack-jjb | 17:09 | |
| *** electrofelix has quit IRC | 17:25 | |
| *** mnencia has quit IRC | 17:25 | |
| *** hrubi has quit IRC | 17:25 | |
| *** hashar has quit IRC | 17:27 | |
| *** mnencia has joined #openstack-jjb | 17:40 | |
| *** Odd_Bloke has quit IRC | 21:09 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!