| *** caphrim007 has joined #openstack-jjb | 01:28 | |
| *** caphrim007 has quit IRC | 01:32 | |
| *** caphrim007 has joined #openstack-jjb | 01:34 | |
| *** caphrim007_ has joined #openstack-jjb | 01:35 | |
| *** caphrim007 has quit IRC | 01:39 | |
| *** riuvshyn has joined #openstack-jjb | 02:45 | |
| *** riuvshyn has quit IRC | 02:50 | |
| *** larainema has quit IRC | 04:08 | |
| *** larainema has joined #openstack-jjb | 06:24 | |
| *** hashar has joined #openstack-jjb | 06:28 | |
| *** riuvshyn has joined #openstack-jjb | 07:01 | |
| *** electrofelix has joined #openstack-jjb | 08:38 | |
| *** vickyc has joined #openstack-jjb | 09:59 | |
| vickyc | Hi maintainers, it looks like PyYAML 4.1 was released 12 hours ago (a major release), which broke the `!!python/tuple` syntax in JJB. I have a reproducer here that works with JJB 2.0.10 + PyYAML 3.12, but not with PyYAML 4.1: https://gist.github.com/vickychijwani/12a5920a0c94965aec6a8e607d597042 | 10:23 |
|---|---|---|
| vickyc | Maybe JJB should specify PyYAML>=3.10.0,<4 ? | 10:25 |
| zxiiro | vickyc: propose a patch and we can discuss in the patch | 12:29 |
| *** tanhengyeow has joined #openstack-jjb | 12:38 | |
| tanhengyeow | Hi everyone, this is my proposal to improve JJB if I were to get selected for the ODL internship: https://docs.google.com/document/d/1z6S-6fYhOKOU_iAv-xB0TkqincjJfzjMFe-YcImCEG0/edit#heading=h.waldbjad2v9n | 12:40 |
| tanhengyeow | Please let me know if there are other tasks that I can potentially work on too :) thank you! | 12:40 |
| openstackgerrit | Vicky Chijwani proposed openstack-infra/jenkins-job-builder master: Constrain PyYAML to v3.x. https://review.openstack.org/578372 | 12:48 |
| vickyc | zxiiro: here it is: https://review.openstack.org/578372 :) | 12:52 |
| *** hashar is now known as idoine | 12:59 | |
| zxiiro | tanhengyeow: please send it to the mailing list https://groups.google.com/forum/#!forum/jenkins-job-builder | 13:54 |
| zxiiro | tanhengyeow: I would introduce yourself and explain what you plan to do this summer as folks may not know who you are. | 13:55 |
| tanhengyeow | Alright, sounds good! Thanks for the tip :) | 13:55 |
| zxiiro | tanhengyeow: you're doing the opendaylight internship program correct? | 13:55 |
| tanhengyeow | Yes, but things have not set in place i.e. I haven't get confirmation so far | 13:56 |
| zxiiro | tanhengyeow: if you're doing the opendaylight intership program please post to both mailing lists https://groups.google.com/forum/#!forum/jenkins-job-builder and https://lists.opendaylight.org/mailman/listinfo/dev using the [releng] topic | 13:56 |
| zxiiro | tanhengyeow: doesn't matter. it's good to introduce yourself to the communities so that they know who you are and they can make suggestions on what they'd like to see done. | 13:56 |
| tanhengyeow | Alright! Thanks for the heads up Thanh Ha! | 13:58 |
| tanhengyeow | Also, I have a question on ODL's mailing list. Do I send an email from my personal account with title "[releng] ......." ? I saw that the threads start with [opendaylight-dev] and I wonder if that's added by the mailing list automatically | 13:59 |
| zxiiro | tanhengyeow: you have to add [releng] manually if you want those subscribed to that topic to see it | 14:02 |
| zxiiro | tanhengyeow: the list will add the list name automatically like [opendaylight-dev] | 14:02 |
| tanhengyeow | Ah ok, so it seems "[releng] [Insert title here]" will do, thank you! | 14:02 |
| zxiiro | tanhengyeow: use whatever email you plan on contributing as and will be reachable at. Make sure you subscribe to both lists since as the intern you will try to satisfy the needs of the opendaylight community as well as the JJB community. | 14:03 |
| tanhengyeow | zxiiro: Got it! Is it ok if I use a different emails for the ODL dev mailing list and the JJB google group mailing lists? I will contribute using a non gmail account but I'll be active in the gmail account for email updates as well | 14:10 |
| zxiiro | tanhengyeow: you don't need gmail to post to the google groups | 14:11 |
| zxiiro | tanhengyeow: just send an email to the list address and I believe it will go through | 14:11 |
| zxiiro | tanhengyeow: it will be easier for you to put both lists in the same email send line anyway | 14:11 |
| tanhengyeow | Right, thanks! | 14:12 |
| zxiiro | tanhengyeow: have you been doing code reviews? | 14:14 |
| tanhengyeow | Not atm, just submitting patches so far | 14:14 |
| zxiiro | tanhengyeow: imo as an intern for you to get the most out of your internship you should spend some time everyday doing code review on the project. Open Source is not just about contributing code but also about accepting code from others. Participating in code reviews are one way to get that experience. | 14:14 |
| zxiiro | tanhengyeow: additionally you can learn a lot from reading and understanding other people's code (and other contributors comments to code review). | 14:15 |
| tanhengyeow | Alright! I'll add that to my list :) | 14:15 |
| zxiiro | JJB is a slow moving project so there's not too many contributions to the project each week. You'll probably see 1-3 contributions a week so staying on top of code reviews is pretty easy and a low ask on time. | 14:16 |
| zxiiro | tanhengyeow: if you haven't done this already go to this page https://review.openstack.org/#/settings/projects and add "openstack-infra/jenkins-job-builder" and sign up for email notifications for the project for new changes, new patch sets, all comments, and submitted changes. | 14:17 |
| zxiiro | tanhengyeow: then you'll get an email notification every time a new contribution comes into the project. | 14:17 |
| zxiiro | tanhengyeow: filter that into an email queue, and then check it a few times a day to participate in code reviews :) | 14:18 |
| tanhengyeow | Sounds good! I learnt quite a bit from code reviews to my patches so I definitely believe I'll learn as well by reviewing work from others | 14:18 |
| zxiiro | tanhengyeow: If you stay ontop of all this in addition to contributing your own code, becoming a committer on the project by the end of your internship is a very real possibility (assuming you're interested in that, it looks good on your resume to be maintainer of an open source project). | 14:19 |
| zxiiro | tanhengyeow: good luck | 14:20 |
| tanhengyeow | zxiiro: Sounds cool! Thanks for everything so far haha. Btw may I ask how do most of you stay online most of the time? | 14:21 |
| zxiiro | tanhengyeow: I use IRC Cloud. if you don't want to pay for it, you can ask kien-ha how he setup his to not logout with the free version. | 14:22 |
| tanhengyeow | Ah I see, so most of you pay for the service to stay online I suppose? | 14:22 |
| zxiiro | tanhengyeow: no there's many ways | 14:27 |
| zxiiro | tanhengyeow: ZNC bouncer is the most common way and it's free but you have to have your own server to install the bouncer on | 14:27 |
| zxiiro | tanhengyeow: I use IRC Cloud because it has a nice mobile app | 14:28 |
| zxiiro | tanhengyeow: if you don't want to pay for a service and would rather roll your own ZNC bouncer is the way to go. | 14:28 |
| tanhengyeow | Cool, I'll look into that :) | 14:39 |
| *** caphrim007_ has quit IRC | 14:52 | |
| *** caphrim007_ has joined #openstack-jjb | 14:53 | |
| kien-ha | tanhengyeow: yeah I use Heroku with Irccloud to stay connected. if you do a quick Google search of the two, you'll find many great guides on how to set them up together to stay connected. | 15:09 |
| tanhengyeow | kien-ha: thank you! guess this was it https://vijaikumar.in/keeping-your-irccloud-client-always-connected-for-free-82db71b3cff3 | 15:10 |
| *** kien_ has joined #openstack-jjb | 15:17 | |
| kien-ha | tanhengyeow: Yep! that's the one. | 15:28 |
| openstackgerrit | Roman Iuvshyn proposed openstack-infra/jenkins-job-builder master: Adds wrapper for vault plugin https://review.openstack.org/577628 | 15:28 |
| *** riuvshyn has quit IRC | 15:36 | |
| *** riuvshyn has joined #openstack-jjb | 15:46 | |
| *** riuvshyn has quit IRC | 15:50 | |
| *** idoine is now known as hashar | 16:07 | |
| *** riuvshyn has joined #openstack-jjb | 16:20 | |
| *** hashar is now known as hasharAway | 16:28 | |
| *** riuvshyn has quit IRC | 16:28 | |
| *** riuvshyn has joined #openstack-jjb | 16:55 | |
| *** riuvshyn has quit IRC | 16:59 | |
| *** kien_ has quit IRC | 17:00 | |
| *** riuvshyn has joined #openstack-jjb | 17:27 | |
| *** ssbarnea[m] has joined #openstack-jjb | 17:28 | |
| *** riuvshyn has quit IRC | 17:36 | |
| *** electrofelix has quit IRC | 17:46 | |
| *** riuvshyn has joined #openstack-jjb | 17:55 | |
| openstackgerrit | Roman Iuvshyn proposed openstack-infra/jenkins-job-builder master: Adds wrapper for vault plugin https://review.openstack.org/577628 | 18:05 |
| *** riuvshyn has quit IRC | 18:19 | |
| *** tanhengyeow has quit IRC | 18:36 | |
| ssbarnea[m] | zxiiro: regarding !!python/tuple -- do we really need something like this? | 19:02 |
| zxiiro | ssbarnea[m]: I have no idea i never used that feature before | 19:02 |
| ssbarnea[m] | me neither and i am inclined to drop support for non standard yaml gimmiks. | 19:07 |
| *** hasharAway is now known as hashar | 19:09 | |
| zxiiro | ssbarnea[m]: why? it's something JJB supports and is documented. | 19:09 |
| zxiiro | ssbarnea[m]: https://docs.openstack.org/infra/jenkins-job-builder/definition.html#variable-references | 19:10 |
| zxiiro | ssbarnea[m]: I'd be inclined to keep stuff that people are using. | 19:10 |
| zxiiro | ssbarnea[m]: if you want to drop support that would be a major version change. by first deprecated in a 2.x release and then eventually releasing a 3.x release to remove all deprecated code. | 19:11 |
| ssbarnea[m] | yes, i still want to see / understand the use case for it | 19:11 |
| ssbarnea[m] | i insist on this because my impression is that the error we get is not due to a new bug but more of a more restrictive yaml parser, and more restrictive means easier to lint. | 19:17 |
| ssbarnea[m] | zxiiro: if you can: https://review.openstack.org/#/c/576878/ | 19:19 |
| zxiiro | ssbarnea[m]: I +2'd it | 19:20 |
| zxiiro | I tried it for a project I had but had to back out of it | 19:20 |
| zxiiro | I'll have to try with a different project | 19:21 |
| *** riuvshyn has joined #openstack-jjb | 19:39 | |
| *** riuvshyn has quit IRC | 21:24 | |
| *** hashar has quit IRC | 21:42 | |
| *** kienha has joined #openstack-jjb | 22:22 | |
| *** riuvshyn has joined #openstack-jjb | 23:25 | |
| *** riuvshyn has quit IRC | 23:30 | |
| *** kienha has quit IRC | 23:57 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!