| *** caphrim007 has joined #openstack-jjb | 01:03 | |
| *** caphrim007 has quit IRC | 01:07 | |
| *** caphrim007 has joined #openstack-jjb | 01:21 | |
| *** caphrim007 has quit IRC | 01:22 | |
| *** caphrim007 has joined #openstack-jjb | 01:44 | |
| *** caphrim007 has quit IRC | 01:49 | |
| *** caphrim007 has joined #openstack-jjb | 02:00 | |
| *** caphrim007 has quit IRC | 02:02 | |
| *** caphrim007 has joined #openstack-jjb | 02:02 | |
| openstackgerrit | qingszhao proposed openstack-infra/jenkins-job-builder master: change default python 3 env in tox to 3.5 https://review.openstack.org/576680 | 02:30 |
|---|---|---|
| *** caphrim007_ has joined #openstack-jjb | 02:50 | |
| *** caphrim007 has quit IRC | 02:54 | |
| *** r-mibu has quit IRC | 03:43 | |
| *** kien-ha has quit IRC | 03:44 | |
| *** kien-ha has joined #openstack-jjb | 03:46 | |
| *** r-mibu has joined #openstack-jjb | 03:46 | |
| *** larainema has quit IRC | 03:48 | |
| *** zxiiro has quit IRC | 03:49 | |
| *** spalger has quit IRC | 03:49 | |
| *** abelur has quit IRC | 03:50 | |
| *** jplf has quit IRC | 03:50 | |
| *** r-mibu has quit IRC | 03:51 | |
| *** kien-ha has quit IRC | 03:51 | |
| *** openstack has joined #openstack-jjb | 04:32 | |
| *** ChanServ sets mode: +o openstack | 04:32 | |
| *** kien-ha has joined #openstack-jjb | 05:21 | |
| *** abelur has joined #openstack-jjb | 05:25 | |
| *** zxiiro has joined #openstack-jjb | 05:25 | |
| *** spalger has joined #openstack-jjb | 05:29 | |
| *** larainema has joined #openstack-jjb | 05:31 | |
| *** kien-ha has quit IRC | 05:39 | |
| *** larainema has quit IRC | 05:48 | |
| *** spalger has quit IRC | 05:55 | |
| *** abelur has quit IRC | 05:55 | |
| *** zxiiro has quit IRC | 05:57 | |
| *** kien-ha has joined #openstack-jjb | 06:10 | |
| *** spalger has joined #openstack-jjb | 06:12 | |
| *** r-mibu has joined #openstack-jjb | 06:17 | |
| *** jplf has joined #openstack-jjb | 06:19 | |
| *** zxiiro has joined #openstack-jjb | 06:21 | |
| *** larainema has joined #openstack-jjb | 06:21 | |
| *** abelur has joined #openstack-jjb | 06:24 | |
| *** kbidarka_ has joined #openstack-jjb | 06:30 | |
| kbidarka_ | ssbarnea, testing job creation via jjb fails for python3.6 , https://pastebin.com/TkRjsAQT , related to this commit I guess , https://github.com/openstack-infra/jenkins-job-builder/commit/144ace119bc320927371f0bad7fc41fb566def12 | 06:35 |
| kbidarka_ | or may be i am missing something | 06:36 |
| *** hashar has joined #openstack-jjb | 07:19 | |
| *** kbidarka_ has quit IRC | 08:07 | |
| openstackgerrit | Kevin de Berk proposed openstack-infra/jenkins-job-builder master: multibranch: Configurable script-path https://review.openstack.org/576128 | 08:09 |
| openstackgerrit | Kevin de Berk proposed openstack-infra/jenkins-job-builder master: multibranch-bitbucket: discover strategies https://review.openstack.org/576179 | 08:54 |
| *** kbidarka has joined #openstack-jjb | 09:28 | |
| *** electrofelix has joined #openstack-jjb | 09:34 | |
| ssbarnea | kbidarka: zxiiro electrofelix : this change is fixing py3 issue: https://review.openstack.org/#/c/576504/ -- needs to go in asap | 09:37 |
| kbidarka | ssbarnea, yeah thanks | 09:41 |
| ssbarnea | zxiiro: around here? | 12:09 |
| *** caphrim007_ has quit IRC | 13:13 | |
| *** caphrim007 has joined #openstack-jjb | 13:19 | |
| *** caphrim007 has quit IRC | 13:24 | |
| *** hashar is now known as hasharAway | 13:39 | |
| zxiiro | ssbarnea: merged | 13:54 |
| ssbarnea | hurrah! | 13:54 |
| zxiiro | electrofelix: opinion on https://review.openstack.org/576603 ? I know you didn't like that we added al lthe basepython so we reverted it with a compromise if it makes sense to you. | 13:54 |
| ssbarnea | good that we didn't release that one. also glad that we have enough people using master in order to spot problems. | 13:55 |
| zxiiro | I'm not sure who qingszhao is working for but seems like this contributor is blindly patching every openstack project the same way | 13:55 |
| ssbarnea | my oppinion on revert basepython, lets try to delay it, last merge should avoid big problems. | 13:56 |
| ssbarnea | haha! the big py3 migration :D | 13:56 |
| ssbarnea | i was a bit worried that we do not have a gate for py36 | 13:56 |
| ssbarnea | i think we need at least one for py34 and one for py36. --- the py35 one is less important because is in between the other two. | 13:57 |
| electrofelix | zxiiro: it was more that the person was making changes without realising they could solve their problem without needing to patch anything | 14:01 |
| zxiiro | ssbarnea: agreed. Personally I'd recommend keeping at least whatever version the latest CentOS supports because RedHat / CentOS is the slowest distro heh | 14:03 |
| openstackgerrit | Merged openstack-infra/jenkins-job-builder master: Allow jjb to be called as a module https://review.openstack.org/576504 | 14:03 |
| openstackgerrit | Sorin Sbarnea proposed openstack/python-jenkins master: Adopt use of pre-commit hooks https://review.openstack.org/576878 | 14:33 |
| *** caphrim007 has joined #openstack-jjb | 15:32 | |
| *** caphrim007 has quit IRC | 15:32 | |
| *** caphrim007 has joined #openstack-jjb | 15:33 | |
| *** caphrim007 has quit IRC | 15:33 | |
| *** caphrim007 has joined #openstack-jjb | 15:33 | |
| openstackgerrit | Kevin de Berk proposed openstack-infra/jenkins-job-builder master: multibranch-bitbucket: Configure server address https://review.openstack.org/576146 | 15:41 |
| *** hasharAway is now known as hashar | 16:01 | |
| ssbarnea | zxiiro electrofelix : ready for review https://review.openstack.org/#/c/576878/ | 16:23 |
| zxiiro | ssbarnea: I thought pbr managed the version for us | 16:25 |
| ssbarnea | zxiiro: it does. | 16:26 |
| ssbarnea | i am not sure I understand the question, as my change is unrelated to version | 16:27 |
| zxiiro | ssbarnea: your patch touched conf.py which is a docs change and you set version at the top | 16:27 |
| ssbarnea | i only moved the import to the top of the file to make the linter happy | 16:27 |
| zxiiro | ah I missed that | 16:27 |
| zxiiro | I thought it was being added | 16:28 |
| zxiiro | ssbarnea: yeah usually in projects I've worked on we ignore conf.py for sphinx in style checkers | 16:29 |
| zxiiro | that's why i was confused | 16:29 |
| ssbarnea | i decided that less ignores makes it easier | 16:30 |
| ssbarnea | i know, my approach so far was to ignore it too BUT this proved to break the docs multiple times. | 16:30 |
| zxiiro | ssbarnea: cool, I'll have to take a look at it later. I'm pretty busy today with internal stuff. | 16:32 |
| zxiiro | I want to make sure I understand how that pre-config hook things work | 16:32 |
| ssbarnea | just do a "pip install pre-commit" | 16:33 |
| ssbarnea | that should be enough to get them working. | 16:33 |
| ssbarnea | to run the hooks manually do "pre-commit run" or "pre-commit --all" --- without all will check only last commit. | 16:33 |
| ssbarnea | it is very fast because all repors are cached and shared, so only first time it will clone. | 16:34 |
| ssbarnea | i really find the implementation beautiful | 16:34 |
| ssbarnea | i plan to add support for our bashate tomorrow | 16:34 |
| ssbarnea | there are few other really handy hooks that I want to enable but not in the first round, read https://pre-commit.com/hooks.html | 16:35 |
| ssbarnea | just by reading their names you will figure out what they do. and is *FAST*, like doing linting in 2-3 seconds even with >10 hooks. | 16:36 |
| *** electrofelix has quit IRC | 17:59 | |
| *** caphrim007_ has joined #openstack-jjb | 18:05 | |
| *** caphrim007 has quit IRC | 18:09 | |
| *** hashar is now known as hasharAway | 18:10 | |
| *** kbidarka_ has joined #openstack-jjb | 18:32 | |
| *** kbidarka has quit IRC | 18:36 | |
| *** kbidarka_ has quit IRC | 18:57 | |
| *** caphrim007_ has quit IRC | 19:05 | |
| *** caphrim007 has joined #openstack-jjb | 19:05 | |
| *** zaro__ has joined #openstack-jjb | 19:18 | |
| *** zaro__ has quit IRC | 19:25 | |
| *** zaro__ has joined #openstack-jjb | 19:25 | |
| openstackgerrit | Daniel Watkins proposed openstack-infra/jenkins-job-builder master: Refactor duplicated code in xml_config.py https://review.openstack.org/576950 | 19:41 |
| *** hasharAway has quit IRC | 22:25 | |
| *** caphrim007_ has joined #openstack-jjb | 23:15 | |
| *** caphrim007 has quit IRC | 23:19 | |
| *** caphrim007_ has quit IRC | 23:19 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!