Tuesday, 2018-04-17

openstackgerritMerged openstack-infra/jenkins-job-builder master: fix spelling errors  https://review.openstack.org/56173500:09
*** caphrim007_ has joined #openstack-jjb00:33
*** caphrim007 has quit IRC00:35
*** caphrim007_ has quit IRC00:37
openstackgerritAnil Belur proposed openstack-infra/jenkins-job-builder master: Add support for build status Job Filter plugin  https://review.openstack.org/54819601:25
openstackgerritAnil Belur proposed openstack-infra/jenkins-job-builder master: Add support for user relevance job filter  https://review.openstack.org/55177001:25
openstackgerritAnil Belur proposed openstack-infra/jenkins-job-builder master: Add support for regex job filters  https://review.openstack.org/55176001:25
openstackgerritAnil Belur proposed openstack-infra/jenkins-job-builder master: Add support for job type filter  https://review.openstack.org/55176101:25
openstackgerritAnil Belur proposed openstack-infra/jenkins-job-builder master: Add support for parameter job filter  https://review.openstack.org/55176201:25
openstackgerritAnil Belur proposed openstack-infra/jenkins-job-builder master: Add support for other views job filter  https://review.openstack.org/55176301:25
openstackgerritAnil Belur proposed openstack-infra/jenkins-job-builder master: Add support for scmtype job filters  https://review.openstack.org/55176401:25
openstackgerritAnil Belur proposed openstack-infra/jenkins-job-builder master: Add support for secured jobs filter  https://review.openstack.org/55176601:25
openstackgerritAnil Belur proposed openstack-infra/jenkins-job-builder master: Add support for user permissions job filter  https://review.openstack.org/55176701:25
openstackgerritAnil Belur proposed openstack-infra/jenkins-job-builder master: Add support for upstream downstream job filter  https://review.openstack.org/55176901:25
openstackgerritAnil Belur proposed openstack-infra/jenkins-job-builder master: Add support for unclassified job filters  https://review.openstack.org/55176801:25
*** caphrim007 has joined #openstack-jjb02:32
abeluranyone know what is causing these pep8 failures here ? http://logs.openstack.org/62/551762/2/check/tox-pep8/e2a7855/job-output.txt.gz03:17
*** caphrim007_ has joined #openstack-jjb03:18
*** caphrim007 has quit IRC03:22
openstackgerritAnil Belur proposed openstack-infra/jenkins-job-builder master: Add support for fallback Job Filters  https://review.openstack.org/54909104:22
openstackgerritAnil Belur proposed openstack-infra/jenkins-job-builder master: Add support for build status Job Filter plugin  https://review.openstack.org/54819604:22
openstackgerritAnil Belur proposed openstack-infra/jenkins-job-builder master: Add support for user relevance job filter  https://review.openstack.org/55177004:22
openstackgerritAnil Belur proposed openstack-infra/jenkins-job-builder master: Add support for regex job filters  https://review.openstack.org/55176004:22
openstackgerritAnil Belur proposed openstack-infra/jenkins-job-builder master: Add support for job type filter  https://review.openstack.org/55176104:22
openstackgerritAnil Belur proposed openstack-infra/jenkins-job-builder master: Add support for parameter job filter  https://review.openstack.org/55176204:22
openstackgerritTrevor Bramwell proposed openstack-infra/jenkins-job-builder master: Fix Parameter: Credentials Plugin docs example  https://review.openstack.org/56178605:22
openstackgerritAnil Belur proposed openstack-infra/jenkins-job-builder master: Add support for other views job filter  https://review.openstack.org/55176306:35
*** hashar has joined #openstack-jjb06:53
*** ssbarnea_ has joined #openstack-jjb07:16
openstackgerritAnil Belur proposed openstack-infra/jenkins-job-builder master: Add support for other views job filter  https://review.openstack.org/55176307:28
openstackgerritAnil Belur proposed openstack-infra/jenkins-job-builder master: Add support for scmtype job filters  https://review.openstack.org/55176407:29
*** smyers has quit IRC07:39
*** smyers has joined #openstack-jjb07:40
openstackgerritEduardo Gonzalez proposed openstack/python-jenkins master: Fix docstrings params  https://review.openstack.org/56181807:40
*** electrofelix has joined #openstack-jjb07:57
openstackgerritAnil Belur proposed openstack-infra/jenkins-job-builder master: Add support for secured jobs filter  https://review.openstack.org/55176608:13
openstackgerritEduardo Gonzalez proposed openstack/python-jenkins master: Fix docstrings params  https://review.openstack.org/56181808:18
openstackgerritAnil Belur proposed openstack-infra/jenkins-job-builder master: Add support for user permissions job filter  https://review.openstack.org/55176708:26
openstackgerritEduardo Gonzalez proposed openstack/python-jenkins master: Use proper code highlight in docs  https://review.openstack.org/56183108:28
openstackgerritKen Dreyer proposed openstack/python-jenkins master: add jenkins_urlopen() method  https://review.openstack.org/56183508:53
openstackgerritKen Dreyer proposed openstack/python-jenkins master: build_job: return queue item identifier  https://review.openstack.org/56183608:53
openstackgerritKen Dreyer proposed openstack/python-jenkins master: add get_queue_item() method  https://review.openstack.org/56183708:53
openstackgerritAnil Belur proposed openstack-infra/jenkins-job-builder master: Add support for fallback Job Filters  https://review.openstack.org/54909109:21
openstackgerritAnil Belur proposed openstack-infra/jenkins-job-builder master: Add support for build status Job Filter plugin  https://review.openstack.org/54819609:21
openstackgerritAnil Belur proposed openstack-infra/jenkins-job-builder master: Add support for user relevance job filter  https://review.openstack.org/55177009:21
openstackgerritAnil Belur proposed openstack-infra/jenkins-job-builder master: Add support for regex job filters  https://review.openstack.org/55176009:21
openstackgerritAnil Belur proposed openstack-infra/jenkins-job-builder master: Add support for job type filter  https://review.openstack.org/55176109:21
openstackgerritAnil Belur proposed openstack-infra/jenkins-job-builder master: Add support for parameter job filter  https://review.openstack.org/55176209:21
openstackgerritAnil Belur proposed openstack-infra/jenkins-job-builder master: Add support for other views job filter  https://review.openstack.org/55176309:21
openstackgerritAnil Belur proposed openstack-infra/jenkins-job-builder master: Add support for scmtype job filters  https://review.openstack.org/55176409:21
openstackgerritAnil Belur proposed openstack-infra/jenkins-job-builder master: Add support for secured jobs filter  https://review.openstack.org/55176609:21
openstackgerritAnil Belur proposed openstack-infra/jenkins-job-builder master: Add support for user permissions job filter  https://review.openstack.org/55176709:21
openstackgerritMerged openstack/python-jenkins master: Use proper code highlight in docs  https://review.openstack.org/56183109:33
openstackgerritMerged openstack/python-jenkins master: Fix docstrings params  https://review.openstack.org/56181809:35
openstackgerritAnil Belur proposed openstack-infra/jenkins-job-builder master: Add support for upstream downstream job filter  https://review.openstack.org/55176909:38
openstackgerritAnil Belur proposed openstack-infra/jenkins-job-builder master: Add support for upstream downstream job filter  https://review.openstack.org/55176909:52
openstackgerritAnil Belur proposed openstack-infra/jenkins-job-builder master: Add support for unclassified job filters  https://review.openstack.org/55176811:02
openstackgerritAnil Belur proposed openstack-infra/jenkins-job-builder master: Add support for regex job filters  https://review.openstack.org/55176012:11
openstackgerritAnil Belur proposed openstack-infra/jenkins-job-builder master: Add support for job type filter  https://review.openstack.org/55176112:11
openstackgerritAnil Belur proposed openstack-infra/jenkins-job-builder master: Add support for parameter job filter  https://review.openstack.org/55176212:11
openstackgerritAnil Belur proposed openstack-infra/jenkins-job-builder master: Add support for other views job filter  https://review.openstack.org/55176312:11
openstackgerritAnil Belur proposed openstack-infra/jenkins-job-builder master: Add support for scmtype job filters  https://review.openstack.org/55176412:11
openstackgerritAnil Belur proposed openstack-infra/jenkins-job-builder master: Add support for secured jobs filter  https://review.openstack.org/55176612:11
openstackgerritAnil Belur proposed openstack-infra/jenkins-job-builder master: Add support for user permissions job filter  https://review.openstack.org/55176712:11
openstackgerritAnil Belur proposed openstack-infra/jenkins-job-builder master: Add support for upstream downstream job filter  https://review.openstack.org/55176912:11
openstackgerritAnil Belur proposed openstack-infra/jenkins-job-builder master: Add support for unclassified job filters  https://review.openstack.org/55176812:11
openstackgerritAnil Belur proposed openstack-infra/jenkins-job-builder master: Add support for upstream downstream job filter  https://review.openstack.org/55176912:31
openstackgerritAnil Belur proposed openstack-infra/jenkins-job-builder master: Add support for unclassified job filters  https://review.openstack.org/55176812:31
openstackgerritAnil Belur proposed openstack-infra/jenkins-job-builder master: Add support for upstream downstream job filter  https://review.openstack.org/55176913:00
openstackgerritAnil Belur proposed openstack-infra/jenkins-job-builder master: Add support for unclassified job filters  https://review.openstack.org/55176813:00
ktdreyerssbarnea: what type of change would you like to see for https://review.openstack.org/561835 ?13:13
*** caphrim007_ has quit IRC13:38
openstackgerritMerged openstack-infra/jenkins-job-builder master: Fix Parameter: Credentials Plugin docs example  https://review.openstack.org/56178613:43
*** hashar has quit IRC14:02
*** hashar has joined #openstack-jjb14:31
*** caphrim007 has joined #openstack-jjb15:50
*** caphrim007 has quit IRC15:50
*** caphrim007 has joined #openstack-jjb15:51
*** caphrim007 has quit IRC15:51
*** caphrim007 has joined #openstack-jjb15:51
*** hashar is now known as hasharAway16:05
ssbarneaelectrofelix: zxiiro : please have a look at https://review.openstack.org/#/c/561835/ -- this is the most important change right now beacause there are lots of others waiting for it.16:54
ssbarneapython-jenkins is unable to return response headers now, and they are needed in few cases (like build() one).16:54
ssbarneastill, i am not sure if the function naming proposed is what we want.16:55
zxiiroyeah I don't like the naming it's not clear what the difference is16:55
zxiirothis is a change in the api no?16:56
zxiirooh no i read it backwards16:56
zxiirook16:56
zxiirossbarnea: I'm good with it, just the name could be improved...16:57
ssbarneazxiiro: this is why I asked, I wanted to propose something better but didn16:57
ssbarneadidn't know exactly what16:58
ssbarneai wonder if is possible to return an object that would behave like a string but also contain the headers.16:58
zxiirojenkins_request_url? I dunno heh16:59
ssbarneaso we would avoid adding a new function16:59
ssbarneawe know that current consumers expect to use the return value as a string. what if we start returning something that acts like a string.17:00
ssbarneaabelur: hi! how is going with your patches?17:11
electrofelixzxiiro: jenkins_request or jenkins_request_url, either works17:15
electrofelixssbarnea: we could do that, but I think splitting to have something that returns the response object as is reasonable17:15
*** electrofelix has quit IRC17:18
ssbarneapropose some good function name17:18
openstackgerritMerged openstack-infra/jenkins-job-builder master: Fix Postbuildscript Plugin Info Lookup  https://review.openstack.org/56127917:26
zxiirossbarnea: want to go with jenkins_request_url? sounds like eletrofelix is on board with that one at least.17:42
zxiirossbarnea: then we can close that one out.17:42
openstackgerritKen Dreyer proposed openstack/python-jenkins master: add jenkins_request() method  https://review.openstack.org/56183518:23
openstackgerritKen Dreyer proposed openstack/python-jenkins master: build_job: return queue item identifier  https://review.openstack.org/56183618:23
openstackgerritKen Dreyer proposed openstack/python-jenkins master: add get_queue_item() method  https://review.openstack.org/56183718:23
ktdreyerI think "jenkins_request()" is an intuitive name18:26
ktdreyerit gives you closer access to the "request"18:26
zxiiroktdreyer: +1 sounds good to me. Was just about to comment, looks like you updated the commit message but didn't update the code.18:26
ktdreyergah, sorry zxiiro , will fix that now18:26
openstackgerritKen Dreyer proposed openstack/python-jenkins master: add jenkins_request() method  https://review.openstack.org/56183518:28
openstackgerritKen Dreyer proposed openstack/python-jenkins master: build_job: return queue item identifier  https://review.openstack.org/56183618:28
openstackgerritKen Dreyer proposed openstack/python-jenkins master: add get_queue_item() method  https://review.openstack.org/56183718:28
ktdreyerthere we go zxiiro18:28
zxiiroktdreyer: approved18:29
ktdreyerwoot18:29
openstackgerritMerged openstack/python-jenkins master: add jenkins_request() method  https://review.openstack.org/56183518:45
openstackgerritMajor Hayden proposed openstack-infra/jenkins-job-builder master: Add support for aggregated test results  https://review.openstack.org/56203119:07
ssbarneazaro__: is https://review.openstack.org/#/c/201784/ still wanted or ok to abandon?19:08
openstackgerritMerged openstack/python-jenkins master: build_job: return queue item identifier  https://review.openstack.org/56183619:08
openstackgerritMerged openstack/python-jenkins master: add get_queue_item() method  https://review.openstack.org/56183719:27
*** hasharAway has quit IRC21:11
abelurssbarnea: yeah ... sorry for the noise here, had to rebase some of the changes yesterday21:32
*** ssbarnea_ has quit IRC23:45

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!