openstackgerrit | Merged openstack-infra/jenkins-job-builder master: fix spelling errors https://review.openstack.org/561735 | 00:09 |
---|---|---|
*** caphrim007_ has joined #openstack-jjb | 00:33 | |
*** caphrim007 has quit IRC | 00:35 | |
*** caphrim007_ has quit IRC | 00:37 | |
openstackgerrit | Anil Belur proposed openstack-infra/jenkins-job-builder master: Add support for build status Job Filter plugin https://review.openstack.org/548196 | 01:25 |
openstackgerrit | Anil Belur proposed openstack-infra/jenkins-job-builder master: Add support for user relevance job filter https://review.openstack.org/551770 | 01:25 |
openstackgerrit | Anil Belur proposed openstack-infra/jenkins-job-builder master: Add support for regex job filters https://review.openstack.org/551760 | 01:25 |
openstackgerrit | Anil Belur proposed openstack-infra/jenkins-job-builder master: Add support for job type filter https://review.openstack.org/551761 | 01:25 |
openstackgerrit | Anil Belur proposed openstack-infra/jenkins-job-builder master: Add support for parameter job filter https://review.openstack.org/551762 | 01:25 |
openstackgerrit | Anil Belur proposed openstack-infra/jenkins-job-builder master: Add support for other views job filter https://review.openstack.org/551763 | 01:25 |
openstackgerrit | Anil Belur proposed openstack-infra/jenkins-job-builder master: Add support for scmtype job filters https://review.openstack.org/551764 | 01:25 |
openstackgerrit | Anil Belur proposed openstack-infra/jenkins-job-builder master: Add support for secured jobs filter https://review.openstack.org/551766 | 01:25 |
openstackgerrit | Anil Belur proposed openstack-infra/jenkins-job-builder master: Add support for user permissions job filter https://review.openstack.org/551767 | 01:25 |
openstackgerrit | Anil Belur proposed openstack-infra/jenkins-job-builder master: Add support for upstream downstream job filter https://review.openstack.org/551769 | 01:25 |
openstackgerrit | Anil Belur proposed openstack-infra/jenkins-job-builder master: Add support for unclassified job filters https://review.openstack.org/551768 | 01:25 |
*** caphrim007 has joined #openstack-jjb | 02:32 | |
abelur | anyone know what is causing these pep8 failures here ? http://logs.openstack.org/62/551762/2/check/tox-pep8/e2a7855/job-output.txt.gz | 03:17 |
*** caphrim007_ has joined #openstack-jjb | 03:18 | |
*** caphrim007 has quit IRC | 03:22 | |
openstackgerrit | Anil Belur proposed openstack-infra/jenkins-job-builder master: Add support for fallback Job Filters https://review.openstack.org/549091 | 04:22 |
openstackgerrit | Anil Belur proposed openstack-infra/jenkins-job-builder master: Add support for build status Job Filter plugin https://review.openstack.org/548196 | 04:22 |
openstackgerrit | Anil Belur proposed openstack-infra/jenkins-job-builder master: Add support for user relevance job filter https://review.openstack.org/551770 | 04:22 |
openstackgerrit | Anil Belur proposed openstack-infra/jenkins-job-builder master: Add support for regex job filters https://review.openstack.org/551760 | 04:22 |
openstackgerrit | Anil Belur proposed openstack-infra/jenkins-job-builder master: Add support for job type filter https://review.openstack.org/551761 | 04:22 |
openstackgerrit | Anil Belur proposed openstack-infra/jenkins-job-builder master: Add support for parameter job filter https://review.openstack.org/551762 | 04:22 |
openstackgerrit | Trevor Bramwell proposed openstack-infra/jenkins-job-builder master: Fix Parameter: Credentials Plugin docs example https://review.openstack.org/561786 | 05:22 |
openstackgerrit | Anil Belur proposed openstack-infra/jenkins-job-builder master: Add support for other views job filter https://review.openstack.org/551763 | 06:35 |
*** hashar has joined #openstack-jjb | 06:53 | |
*** ssbarnea_ has joined #openstack-jjb | 07:16 | |
openstackgerrit | Anil Belur proposed openstack-infra/jenkins-job-builder master: Add support for other views job filter https://review.openstack.org/551763 | 07:28 |
openstackgerrit | Anil Belur proposed openstack-infra/jenkins-job-builder master: Add support for scmtype job filters https://review.openstack.org/551764 | 07:29 |
*** smyers has quit IRC | 07:39 | |
*** smyers has joined #openstack-jjb | 07:40 | |
openstackgerrit | Eduardo Gonzalez proposed openstack/python-jenkins master: Fix docstrings params https://review.openstack.org/561818 | 07:40 |
*** electrofelix has joined #openstack-jjb | 07:57 | |
openstackgerrit | Anil Belur proposed openstack-infra/jenkins-job-builder master: Add support for secured jobs filter https://review.openstack.org/551766 | 08:13 |
openstackgerrit | Eduardo Gonzalez proposed openstack/python-jenkins master: Fix docstrings params https://review.openstack.org/561818 | 08:18 |
openstackgerrit | Anil Belur proposed openstack-infra/jenkins-job-builder master: Add support for user permissions job filter https://review.openstack.org/551767 | 08:26 |
openstackgerrit | Eduardo Gonzalez proposed openstack/python-jenkins master: Use proper code highlight in docs https://review.openstack.org/561831 | 08:28 |
openstackgerrit | Ken Dreyer proposed openstack/python-jenkins master: add jenkins_urlopen() method https://review.openstack.org/561835 | 08:53 |
openstackgerrit | Ken Dreyer proposed openstack/python-jenkins master: build_job: return queue item identifier https://review.openstack.org/561836 | 08:53 |
openstackgerrit | Ken Dreyer proposed openstack/python-jenkins master: add get_queue_item() method https://review.openstack.org/561837 | 08:53 |
openstackgerrit | Anil Belur proposed openstack-infra/jenkins-job-builder master: Add support for fallback Job Filters https://review.openstack.org/549091 | 09:21 |
openstackgerrit | Anil Belur proposed openstack-infra/jenkins-job-builder master: Add support for build status Job Filter plugin https://review.openstack.org/548196 | 09:21 |
openstackgerrit | Anil Belur proposed openstack-infra/jenkins-job-builder master: Add support for user relevance job filter https://review.openstack.org/551770 | 09:21 |
openstackgerrit | Anil Belur proposed openstack-infra/jenkins-job-builder master: Add support for regex job filters https://review.openstack.org/551760 | 09:21 |
openstackgerrit | Anil Belur proposed openstack-infra/jenkins-job-builder master: Add support for job type filter https://review.openstack.org/551761 | 09:21 |
openstackgerrit | Anil Belur proposed openstack-infra/jenkins-job-builder master: Add support for parameter job filter https://review.openstack.org/551762 | 09:21 |
openstackgerrit | Anil Belur proposed openstack-infra/jenkins-job-builder master: Add support for other views job filter https://review.openstack.org/551763 | 09:21 |
openstackgerrit | Anil Belur proposed openstack-infra/jenkins-job-builder master: Add support for scmtype job filters https://review.openstack.org/551764 | 09:21 |
openstackgerrit | Anil Belur proposed openstack-infra/jenkins-job-builder master: Add support for secured jobs filter https://review.openstack.org/551766 | 09:21 |
openstackgerrit | Anil Belur proposed openstack-infra/jenkins-job-builder master: Add support for user permissions job filter https://review.openstack.org/551767 | 09:21 |
openstackgerrit | Merged openstack/python-jenkins master: Use proper code highlight in docs https://review.openstack.org/561831 | 09:33 |
openstackgerrit | Merged openstack/python-jenkins master: Fix docstrings params https://review.openstack.org/561818 | 09:35 |
openstackgerrit | Anil Belur proposed openstack-infra/jenkins-job-builder master: Add support for upstream downstream job filter https://review.openstack.org/551769 | 09:38 |
openstackgerrit | Anil Belur proposed openstack-infra/jenkins-job-builder master: Add support for upstream downstream job filter https://review.openstack.org/551769 | 09:52 |
openstackgerrit | Anil Belur proposed openstack-infra/jenkins-job-builder master: Add support for unclassified job filters https://review.openstack.org/551768 | 11:02 |
openstackgerrit | Anil Belur proposed openstack-infra/jenkins-job-builder master: Add support for regex job filters https://review.openstack.org/551760 | 12:11 |
openstackgerrit | Anil Belur proposed openstack-infra/jenkins-job-builder master: Add support for job type filter https://review.openstack.org/551761 | 12:11 |
openstackgerrit | Anil Belur proposed openstack-infra/jenkins-job-builder master: Add support for parameter job filter https://review.openstack.org/551762 | 12:11 |
openstackgerrit | Anil Belur proposed openstack-infra/jenkins-job-builder master: Add support for other views job filter https://review.openstack.org/551763 | 12:11 |
openstackgerrit | Anil Belur proposed openstack-infra/jenkins-job-builder master: Add support for scmtype job filters https://review.openstack.org/551764 | 12:11 |
openstackgerrit | Anil Belur proposed openstack-infra/jenkins-job-builder master: Add support for secured jobs filter https://review.openstack.org/551766 | 12:11 |
openstackgerrit | Anil Belur proposed openstack-infra/jenkins-job-builder master: Add support for user permissions job filter https://review.openstack.org/551767 | 12:11 |
openstackgerrit | Anil Belur proposed openstack-infra/jenkins-job-builder master: Add support for upstream downstream job filter https://review.openstack.org/551769 | 12:11 |
openstackgerrit | Anil Belur proposed openstack-infra/jenkins-job-builder master: Add support for unclassified job filters https://review.openstack.org/551768 | 12:11 |
openstackgerrit | Anil Belur proposed openstack-infra/jenkins-job-builder master: Add support for upstream downstream job filter https://review.openstack.org/551769 | 12:31 |
openstackgerrit | Anil Belur proposed openstack-infra/jenkins-job-builder master: Add support for unclassified job filters https://review.openstack.org/551768 | 12:31 |
openstackgerrit | Anil Belur proposed openstack-infra/jenkins-job-builder master: Add support for upstream downstream job filter https://review.openstack.org/551769 | 13:00 |
openstackgerrit | Anil Belur proposed openstack-infra/jenkins-job-builder master: Add support for unclassified job filters https://review.openstack.org/551768 | 13:00 |
ktdreyer | ssbarnea: what type of change would you like to see for https://review.openstack.org/561835 ? | 13:13 |
*** caphrim007_ has quit IRC | 13:38 | |
openstackgerrit | Merged openstack-infra/jenkins-job-builder master: Fix Parameter: Credentials Plugin docs example https://review.openstack.org/561786 | 13:43 |
*** hashar has quit IRC | 14:02 | |
*** hashar has joined #openstack-jjb | 14:31 | |
*** caphrim007 has joined #openstack-jjb | 15:50 | |
*** caphrim007 has quit IRC | 15:50 | |
*** caphrim007 has joined #openstack-jjb | 15:51 | |
*** caphrim007 has quit IRC | 15:51 | |
*** caphrim007 has joined #openstack-jjb | 15:51 | |
*** hashar is now known as hasharAway | 16:05 | |
ssbarnea | electrofelix: zxiiro : please have a look at https://review.openstack.org/#/c/561835/ -- this is the most important change right now beacause there are lots of others waiting for it. | 16:54 |
ssbarnea | python-jenkins is unable to return response headers now, and they are needed in few cases (like build() one). | 16:54 |
ssbarnea | still, i am not sure if the function naming proposed is what we want. | 16:55 |
zxiiro | yeah I don't like the naming it's not clear what the difference is | 16:55 |
zxiiro | this is a change in the api no? | 16:56 |
zxiiro | oh no i read it backwards | 16:56 |
zxiiro | ok | 16:56 |
zxiiro | ssbarnea: I'm good with it, just the name could be improved... | 16:57 |
ssbarnea | zxiiro: this is why I asked, I wanted to propose something better but didn | 16:57 |
ssbarnea | didn't know exactly what | 16:58 |
ssbarnea | i wonder if is possible to return an object that would behave like a string but also contain the headers. | 16:58 |
zxiiro | jenkins_request_url? I dunno heh | 16:59 |
ssbarnea | so we would avoid adding a new function | 16:59 |
ssbarnea | we know that current consumers expect to use the return value as a string. what if we start returning something that acts like a string. | 17:00 |
ssbarnea | abelur: hi! how is going with your patches? | 17:11 |
electrofelix | zxiiro: jenkins_request or jenkins_request_url, either works | 17:15 |
electrofelix | ssbarnea: we could do that, but I think splitting to have something that returns the response object as is reasonable | 17:15 |
*** electrofelix has quit IRC | 17:18 | |
ssbarnea | propose some good function name | 17:18 |
openstackgerrit | Merged openstack-infra/jenkins-job-builder master: Fix Postbuildscript Plugin Info Lookup https://review.openstack.org/561279 | 17:26 |
zxiiro | ssbarnea: want to go with jenkins_request_url? sounds like eletrofelix is on board with that one at least. | 17:42 |
zxiiro | ssbarnea: then we can close that one out. | 17:42 |
openstackgerrit | Ken Dreyer proposed openstack/python-jenkins master: add jenkins_request() method https://review.openstack.org/561835 | 18:23 |
openstackgerrit | Ken Dreyer proposed openstack/python-jenkins master: build_job: return queue item identifier https://review.openstack.org/561836 | 18:23 |
openstackgerrit | Ken Dreyer proposed openstack/python-jenkins master: add get_queue_item() method https://review.openstack.org/561837 | 18:23 |
ktdreyer | I think "jenkins_request()" is an intuitive name | 18:26 |
ktdreyer | it gives you closer access to the "request" | 18:26 |
zxiiro | ktdreyer: +1 sounds good to me. Was just about to comment, looks like you updated the commit message but didn't update the code. | 18:26 |
ktdreyer | gah, sorry zxiiro , will fix that now | 18:26 |
openstackgerrit | Ken Dreyer proposed openstack/python-jenkins master: add jenkins_request() method https://review.openstack.org/561835 | 18:28 |
openstackgerrit | Ken Dreyer proposed openstack/python-jenkins master: build_job: return queue item identifier https://review.openstack.org/561836 | 18:28 |
openstackgerrit | Ken Dreyer proposed openstack/python-jenkins master: add get_queue_item() method https://review.openstack.org/561837 | 18:28 |
ktdreyer | there we go zxiiro | 18:28 |
zxiiro | ktdreyer: approved | 18:29 |
ktdreyer | woot | 18:29 |
openstackgerrit | Merged openstack/python-jenkins master: add jenkins_request() method https://review.openstack.org/561835 | 18:45 |
openstackgerrit | Major Hayden proposed openstack-infra/jenkins-job-builder master: Add support for aggregated test results https://review.openstack.org/562031 | 19:07 |
ssbarnea | zaro__: is https://review.openstack.org/#/c/201784/ still wanted or ok to abandon? | 19:08 |
openstackgerrit | Merged openstack/python-jenkins master: build_job: return queue item identifier https://review.openstack.org/561836 | 19:08 |
openstackgerrit | Merged openstack/python-jenkins master: add get_queue_item() method https://review.openstack.org/561837 | 19:27 |
*** hasharAway has quit IRC | 21:11 | |
abelur | ssbarnea: yeah ... sorry for the noise here, had to rebase some of the changes yesterday | 21:32 |
*** ssbarnea_ has quit IRC | 23:45 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!