| *** ckonstanski has joined #openstack-jjb | 03:33 | |
| ssbarnea | abelur: see https://gist.github.com/ssbarnea/9391dd85cae1524d7ac968cbe95c8185 | 07:03 |
|---|---|---|
| abelur | ssbarnea: Is this from xml from the .yaml file from the fixtures/tests? | 07:06 |
| ssbarnea | abelur: nope. this is result from creating very simple view, refresh page to see yaml source. | 07:08 |
| abelur | ssbarnea: looks like something is wrong with the yaml to xml conversion? | 07:08 |
| ssbarnea | yep, trying to debug now. looks like creation is using the base class used for jobs instead of views. | 07:09 |
| abelur | ssbarnea: yeah, that is possibly the reason why we see that <builder/>, <publisher/> at the end of the xml output | 07:26 |
| ssbarnea | testing a fix now | 07:26 |
| *** openstackgerrit has joined #openstack-jjb | 07:28 | |
| openstackgerrit | Sorin Sbarnea proposed openstack-infra/jenkins-job-builder master: fix: avoid non job attributes on views https://review.openstack.org/553956 | 07:28 |
| abelur | ssbarnea: if that issue was not caught in the tests, then there is a bigger problem to deal with :( | 07:30 |
| ssbarnea | abelur: indeed, i was thinking about the same thing. why this was not discovered during testing. | 07:31 |
| ssbarnea | abelur: i have a idea, tests are using only snippets, not entire job definitions, maybe this is what is causing it. | 07:32 |
| abelur | agreed ... | 07:33 |
| abelur | if we narrow down the changes which introduced the issue, then it would be easier to see why/what the test output looked like | 07:34 |
| ssbarnea | i am looking inside tests/base.py and my impression is that *all* tests are testing XML output from a single specific module, not the combined output. | 07:37 |
| ssbarnea | this means that we would fail to spot when two modules are generating invalid output. | 07:37 |
| ssbarnea | i don't know the testing code well enough to figure out how to address it | 07:38 |
| ssbarnea | " pub = self.klass(registry)" line | 07:39 |
| openstackgerrit | Sorin Sbarnea proposed openstack-infra/jenkins-job-builder master: Add risk testing tox environment https://review.openstack.org/550087 | 09:36 |
| openstackgerrit | Anil Belur proposed openstack-infra/jenkins-job-builder master: Add support for fallback Job Filters https://review.openstack.org/549091 | 09:40 |
| openstackgerrit | Sorin Sbarnea proposed openstack-infra/jenkins-job-builder master: Add risk testing tox environment https://review.openstack.org/550087 | 09:44 |
| ssbarnea | zaro__: zxiiro abelur : ^^ risk gate working, please review it. | 10:01 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!