| *** caphrim007_ has joined #openstack-jjb | 00:05 | |
| *** caphrim007_ has quit IRC | 00:07 | |
| *** caphrim007_ has joined #openstack-jjb | 00:07 | |
| *** caphrim007_ has quit IRC | 00:08 | |
| *** caphrim007 has quit IRC | 00:09 | |
| *** caphrim007 has joined #openstack-jjb | 01:15 | |
| *** caphrim007 has quit IRC | 01:20 | |
| openstackgerrit | Jonathan Rajotte proposed openstack-infra/jenkins-job-builder master: Fix: Set True as default value for query_plugins_info https://review.openstack.org/533844 | 02:37 |
|---|---|---|
| openstackgerrit | Jonathan Rajotte proposed openstack-infra/jenkins-job-builder master: Revert "Fix: use False for default value of query_plugins_info" https://review.openstack.org/533855 | 03:15 |
| *** caphrim007 has joined #openstack-jjb | 03:35 | |
| *** caphrim007 has joined #openstack-jjb | 03:45 | |
| *** caphrim007_ has joined #openstack-jjb | 04:02 | |
| *** caphrim007 has quit IRC | 04:06 | |
| openstackgerrit | Jonathan Rajotte proposed openstack-infra/jenkins-job-builder master: Fix: initialize builder['plugins_info'] to None https://review.openstack.org/533956 | 05:36 |
| openstackgerrit | Jonathan Rajotte proposed openstack-infra/jenkins-job-builder master: Fix: set True as default value for query_plugins_info https://review.openstack.org/533844 | 05:36 |
| *** hashar has joined #openstack-jjb | 08:14 | |
| *** electrofelix has joined #openstack-jjb | 11:01 | |
| electrofelix | ssbarnea: added a few more comments, think it would be worth fixing the config issue for all test classes using the test scenarios code, wasn't able to see any difference around setting OS_STDOUT_CAPTURE or OS_STDERR_CAPTURE so not sure what effect they are supposed to have | 13:28 |
| ssbarnea | electrofelix: i agree with you that those two may not be really a most. but I remember seeing the the _NOCAPTURE ones were deprecated. | 13:47 |
| ssbarnea | if you want I can experiment more and try to remove anything that does not seem essential | 13:47 |
| ssbarnea | i know for sure that the trick with os.path.isfile is needed to isolate from real config files on disk. | 13:48 |
| ssbarnea | electrofelix: just tell me which path you would prefer and I will follow it. I just want to sort this our faster in order to be able to focus on other things, like finishing the multibranch patch | 13:49 |
| electrofelix | ssbarnea: if you switch the tests.base module function to default to a blank config file if not is provided when looking up the scenarios it will fix the problem with the config for all tests, even those that are not obviously affected now but might be depending on what options are selected | 13:49 |
| ssbarnea | electrofelix: glad to hear that, wanted to do the same but was not sure. is true, I had test failing due to my local config in the past. | 13:51 |
| electrofelix | ssbarnea: just want to get the bottom of how the OS_* variables should impact, already set in some places, just would like to know what to look at to understand the impact and how to use in the future, don't think we need to split the patch up | 13:57 |
| ssbarnea | electrofelix: in fact my impression is that we cannot run the tests without capturing the logging anyway. so the 3rd one should not even exist as is always enabled. | 13:59 |
| ssbarnea | i had few cases where logging messages were not captured and they were displayed before the capture started. obviously that the tests failed. capturing stderr and stdout helps as it allows me to see where these messages ended up in. | 14:00 |
| ssbarnea | i am in MTG, so expect slower responses, but I will catch up with all msg. | 14:02 |
| electrofelix | ssbarnea: that's possibly due to use of the logging fixtures rather than using testr's capture of the logging | 14:19 |
| openstackgerrit | Jan Hruban proposed openstack-infra/jenkins-job-builder master: Allow template-name in the global defaults https://review.openstack.org/394945 | 15:00 |
| openstackgerrit | Jan Hruban proposed openstack-infra/jenkins-job-builder master: Fix the formatter regex https://review.openstack.org/534338 | 15:09 |
| *** caphrim007_ has quit IRC | 15:34 | |
| *** hashar has quit IRC | 16:32 | |
| *** caphrim007 has joined #openstack-jjb | 16:57 | |
| *** openstackgerrit has quit IRC | 17:33 | |
| *** electrofelix has quit IRC | 18:57 | |
| *** electrofelix has joined #openstack-jjb | 18:58 | |
| *** hashar has joined #openstack-jjb | 20:07 | |
| *** caphrim007_ has joined #openstack-jjb | 21:57 | |
| *** caphrim007 has quit IRC | 22:01 | |
| *** caphrim007_ has quit IRC | 22:56 | |
| *** caphrim007 has joined #openstack-jjb | 22:56 | |
| *** caphrim007_ has joined #openstack-jjb | 23:46 | |
| *** caphrim00_ has joined #openstack-jjb | 23:47 | |
| *** caphrim00_ has quit IRC | 23:48 | |
| *** caphrim007 has quit IRC | 23:49 | |
| *** caphrim007_ has quit IRC | 23:50 | |
| *** caphrim007 has joined #openstack-jjb | 23:53 | |
| *** caphrim007 has quit IRC | 23:58 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!