| *** hashar has joined #openstack-jjb | 07:42 | |
| openstackgerrit | Evgeni Golov proposed openstack-infra/jenkins-job-builder master: gitlab trigger: add support for different MR events https://review.openstack.org/513712 | 08:00 |
|---|---|---|
| *** electrofelix has joined #openstack-jjb | 08:44 | |
| mnencia | Hi, I see that the folder support has been merged and it is a wonderful notice! I'm wondering if this is the right channel to ask for python-jenkins issue. This is very annoying and is related to folder support https://review.openstack.org/#/c/504536/ | 09:51 |
| mnencia | the bug is https://bugs.launchpad.net/python-jenkins/+bug/1698815 | 09:52 |
| openstack | Launchpad bug 1698815 in Python Jenkins "get_jobs fails when space in folder name" [Undecided,In progress] - Assigned to Andrew Mellen (mellena1) | 09:52 |
| zxiiro | mnencia: good question I don't know who can help on python-jenkins. At least I'm not a committer over there. | 13:57 |
| zxiiro | zaro: electrofelix, any of you guys know who python-jenkins folks are? | 13:57 |
| zxiiro | mnencia: interesting... You guys use jenkins paths with spaces in them without issue? (apart from the python-jenkins not letting you do it) | 13:59 |
| zxiiro | mnencia: In my projects I've banned the use of spaces because a lot of tools seem to fall over | 13:59 |
| electrofelix | zxiiro: I must have missed it coming through, thought I had a filter set up to let me know | 14:02 |
| electrofelix | zxiiro: zaro has approval rights, can't recall who else | 14:03 |
| mnencia | zxiiro I agree that spaces in paths should be banned, but we are trying to migrate a lot of legacy stuff in an incremental way... | 15:21 |
| *** hashar is now known as hasharAway | 15:54 | |
| zaro | zxiiro: kevin mitchell | 16:15 |
| zxiiro | zaro: thanks! | 16:17 |
| zxiiro | mnencia: ^ looks like your patch got through. | 16:30 |
| mnencia | \o/ | 16:35 |
| zxiiro | zaro: electrofelix: What's the state of python-jenkins. Considering JJB needs it and OpenStack doesn't use Jenkins anymore... Do we need more committers on that project? | 16:48 |
| zxiiro | Do I need to step up? | 16:48 |
| zxiiro | electrofelix: Also curious if you were able to make any progress on the YAML parser issue this weekend? I have a project that is blocked and needs JJB 2.0 so it's becoming more important for my org to get it rolled out. (unless we can backport the pipeline project | 16:50 |
| electrofelix | zxiiro: I think knowing who to ping is a start, it's definitely a question to be raised with openstack-infra as to how the two projects should be managed going forward | 17:01 |
| electrofelix | zxiiro: I think I know where I need to make the changes which is a starting, took me a while to work through how the code works again, and I will want to get pycharm in place to do some live debugging just to be sure as otherwise it's a bit of a black box | 17:02 |
| zxiiro | electrofelix: ah ok. | 17:03 |
| electrofelix | I think the main problem is just how efficient it's going to be when hitting that point | 17:06 |
| zxiiro | right | 17:08 |
| zxiiro | electrofelix: I'm working with Kien to get patches that are just adding new plugin support merged. Hopefully we can cleanup the open tickets in Gerrit. It's down to 4 pages now since yesterday. | 17:09 |
| electrofelix | I think https://github.com/openstack-infra/jenkins-job-builder/blob/master/jenkins_jobs/registry.py#L441-L442 is the point where we need to check if the function 'func' has some extra attribute data that will require calling expand_macros on a subset of the component_data | 17:09 |
| electrofelix | but I have concerns that there will be some template data missing at that point, hence the desire to spend some more time and use pycharm to do some live inspection of what is getting passed around | 17:10 |
| zxiiro | electrofelix: sounds good. thanks for looking into it. | 17:10 |
| electrofelix | Do we have a copy of the macros that used to work? | 17:12 |
| zxiiro | electrofelix: I think a minimal test you can make is a macro that pulls in another macro | 17:13 |
| zxiiro | electrofelix: but if you want a full test you can pull this https://github.com/opendaylight/releng-builder | 17:14 |
| zxiiro | electrofelix: don't forget to "git submodule update --init" since we have a submodule there that needs to load | 17:14 |
| zxiiro | electrofelix: basically "jenkins-jobs test" against that repo will fail with the YAML Parser patch. if you revert that patch it passes. | 17:14 |
| electrofelix | perfect, I'd like to use some real data so when I'm looking via a debugger the data present should be representative of a real use case | 17:15 |
| zxiiro | electrofelix: I think we use several different types so it will be a good test coverage for you. including macros that pull macros, modules that support loading other modules, etc.. | 17:16 |
| zxiiro | we're a heavy user of those expansion things. | 17:17 |
| *** electrofelix has quit IRC | 18:23 | |
| openstackgerrit | Ivan Remizov proposed openstack-infra/jenkins-job-builder master: Add nested job groups https://review.openstack.org/514819 | 20:42 |
| *** hasharAway has quit IRC | 20:53 | |
| openstackgerrit | Ivan Remizov proposed openstack-infra/jenkins-job-builder master: Add nested job groups https://review.openstack.org/514819 | 20:57 |
| openstackgerrit | Vasily Gorin proposed openstack-infra/jenkins-job-builder master: Add NodeJS executor build step https://review.openstack.org/514349 | 22:01 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!