| *** electrofelix has joined #openstack-jjb | 08:38 | |
| *** hashar has joined #openstack-jjb | 09:01 | |
| *** hashar has quit IRC | 13:28 | |
| *** hashar has joined #openstack-jjb | 13:28 | |
| waynr | wooo i actually remember the meeting | 13:47 |
|---|---|---|
| waynr | helps that i'm two timezones closer to UTC | 13:47 |
| zxiiro | nice | 13:48 |
| zxiiro | electrofelix: we meeting today? | 13:48 |
| electrofelix | sounds like it | 13:50 |
| electrofelix | I've been distracted, working on getting a DevOpsDays Conference going locally | 13:50 |
| zxiiro | oh nice. I signed up for the online one | 13:50 |
| waynr | this old engineer i used to work with always refused to say the word "meeting" | 13:50 |
| waynr | instead he always said the word "beating" | 13:50 |
| waynr | "time for a beating" | 13:50 |
| zxiiro | that sounds less fun and 'meeting' is already not that fun haha | 13:51 |
| zxiiro | fun sounding | 13:51 |
| waynr | well i'm a judoka so in the right context a beating is actually quite fun ;) | 13:51 |
| waynr | electrofelix: nice! I volunteered at the portland devopsdays conference a couple months ago | 13:51 |
| zxiiro | I guess that makes sense in that case | 13:52 |
| zxiiro | alright should we start since we're all here anyway? | 13:52 |
| waynr | sure | 13:52 |
| zxiiro | #startmeeting jjb | 13:53 |
| openstack | Meeting started Fri Sep 8 13:53:14 2017 UTC and is due to finish in 60 minutes. The chair is zxiiro. Information about MeetBot at http://wiki.debian.org/MeetBot. | 13:53 |
| openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 13:53 |
| openstack | The meeting name has been set to 'jjb' | 13:53 |
| zxiiro | #chair waynr electrofelix | 13:53 |
| openstack | Current chairs: electrofelix waynr zxiiro | 13:53 |
| zxiiro | #topic jjb-2.0 | 13:53 |
| zxiiro | I guess this is really our only topic at the moment unless someone else wants us to discuss something later? | 13:54 |
| zxiiro | electrofelix: so I think we should get this https://review.openstack.org/333076 landed asap before another patch is merged that breaks this again. | 13:54 |
| waynr | hmm wasn't there someone else were were considering as a jjb core a month or two ago? did that ever happen? | 13:54 |
| waynr | s/er w/ w/ | 13:55 |
| electrofelix | I was hoping to understand the purpose of the __deepcopy__ a bit more | 13:56 |
| zxiiro | just looked at the last meetings notes I don't see it | 13:56 |
| zxiiro | #info zxiiro thinks https://review.openstack.org/333076 should land asap | 13:56 |
| zxiiro | #info electrofelix wants to understand the purpose of __deepcopy__ a bit more | 13:57 |
| zxiiro | #action electrofelix to review https://review.openstack.org/333076 | 13:57 |
| zxiiro | electrofelix: ok | 13:57 |
| waynr | #info waynr also thinks https://review.openstack.org/333076 should land sooner rather than later | 13:57 |
| zxiiro | #link https://review.openstack.org/#/q/status:open+project:openstack-infra/jenkins-job-builder+branch:master+topic:2.0-config-format 2.0 config format | 13:58 |
| zxiiro | waynr: electrofelix: ^ I think we decided to go with this? if so we should probably merge those patches | 13:58 |
| zxiiro | looks like there's a few merge conflicts for 3 of the patches. I can look into fixing that | 13:58 |
| zxiiro | #action zxiiro to resolve merge conflicts in https://review.openstack.org/#/q/status:open+project:openstack-infra/jenkins-job-builder+branch:master+topic:2.0-config-format | 13:59 |
| waynr | i can review those patches | 13:59 |
| waynr | might need reminders occasionally though ;) | 14:00 |
| electrofelix | zxiiro: I'm go with that, I'll start reviewing and will look out for the updates | 14:00 |
| zxiiro | sounds good | 14:00 |
| zxiiro | #action electrofelix & waynr to review 2.0-config-format patches | 14:00 |
| zxiiro | #link https://etherpad.openstack.org/p/jjb_api_v2.0 EtherPad of JJB 2.0 items | 14:00 |
| zxiiro | ok i think this is the last thing... electrofelix, waynr anything from the etherpad we want to discuss? | 14:01 |
| electrofelix | waynr: can you help me understand what's happening with __deepcopy__, what changed to require it? | 14:01 |
| electrofelix | guess we can discuss after the meeting | 14:01 |
| waynr | yeah i can go over that with you | 14:02 |
| waynr | during meeting or not | 14:02 |
| zxiiro | yeah we can talk about that now too | 14:02 |
| zxiiro | electrofelix: there was an email thread about it | 14:02 |
| waynr | i have to look it over again myself actually but i remember thinking it looked legit | 14:02 |
| electrofelix | waynr: was it not added recently? | 14:04 |
| zxiiro | electrofelix: the jinja patch needs it. Let me look up the email thread... | 14:04 |
| electrofelix | ah found it | 14:04 |
| zxiiro | electrofelix: oh? you got it? ok | 14:04 |
| *** openstackgerrit has joined #openstack-jjb | 14:09 | |
| openstackgerrit | Thanh Ha proposed openstack-infra/jenkins-job-builder master: Default groovy-postbuild to newest plugin format https://review.openstack.org/478372 | 14:09 |
| openstackgerrit | Thanh Ha proposed openstack-infra/jenkins-job-builder master: Default slack to newest plugin config format https://review.openstack.org/478669 | 14:11 |
| openstackgerrit | Thanh Ha proposed openstack-infra/jenkins-job-builder master: Default conditional-publisher to newest plugin format https://review.openstack.org/478378 | 14:12 |
| zxiiro | electrofelix: waynr alright I fixed the 3 merge conflicts in the meantime. | 14:13 |
| zxiiro | anything else we want to discuss during the meeting? | 14:13 |
| zxiiro | electrofelix: I think the only other thing for JJB 2.0 is you mentioned you wanted to redo the config plugin system. Any progress on that? | 14:14 |
| electrofelix | yes, just not quite ready with the second patch, I almost forgot I had a question on it before I made a change | 14:17 |
| electrofelix | https://github.com/openstack-infra/jenkins-job-builder/blob/master/jenkins_jobs/modules/helpers.py#L490 | 14:19 |
| electrofelix | with the changes we've made to get plugin configuration information from specific plugin sections, I think this __future__ section should be dropped for the v2 release for individual plugin behaviour and instead added to the two plugins it affects | 14:20 |
| zxiiro | agreed. I think that's the right thing to do | 14:20 |
| zxiiro | waynr: ^ | 14:21 |
| electrofelix | as in a) switch it to default to taking the order from the yaml, and b) place the ability to use the old behaviour under "[plugin 'trigger_parameter...'] use_old_param_order = True" | 14:21 |
| electrofelix | or something like that, that was the last thing blocking ensuring that only the 'plugins' namespace needed to be passed to the plugins | 14:21 |
| waynr | that sounds good to me | 14:23 |
| waynr | well it'll break JJB for my ex coworkers but all they will have to do is avoid upgrading or chang their config files | 14:24 |
| electrofelix | were they using that option? | 14:24 |
| zxiiro | #info electrofelix asks if we should move param order setting to inside plugin sections for V2 | 14:25 |
| electrofelix | or rather were they using trigger parameterized plugins and relying on the old behaviour of using the order defined in the code for the precedence of the parameters? | 14:25 |
| zxiiro | #agreed We will move the param order config into plugins section. | 14:25 |
| waynr | oh wait | 14:25 |
| waynr | nevermind, i was confused...i was misremembering something and misreading what you wrote | 14:26 |
| waynr | it won't break anything for excoworkers of mine | 14:26 |
| electrofelix | as in predefined-parameters would be overridden by current-parameters even if the yaml put it afterwards | 14:26 |
| electrofelix | yeah, I just realised it might cause you to think I meant about the project params precedence order ;) | 14:27 |
| waynr | yah i see what you mean now | 14:27 |
| zxiiro | electrofelix: I feel confused now. so currently if someone lists a parameter last it will take precedence over the same parameter if it's defined above? | 14:30 |
| zxiiro | electrofelix: so with the change what happens? | 14:30 |
| zxiiro | electrofelix: it will take the first defined parameter listed? | 14:30 |
| electrofelix | zxiiro: in the trigger parameter plugins, the original code hardcoded the order the XML was emitted for each of the possible settings, however Jenkins allowed you to order them to control which ones would override others and thus control the value of the parameter passed to the triggered build | 14:32 |
| electrofelix | so a user might assume that they could order the yaml definition for that plugin in the same way to decide that the can pass through 'current-parameters', and then override a single parameter by placing the 'predefined-parameter' block afterwards | 14:33 |
| electrofelix | unfortunately this was not supported by the code at the time and instead it would enforce a specific order https://github.com/openstack-infra/jenkins-job-builder/blob/master/jenkins_jobs/modules/helpers.py#L475-L486 | 14:33 |
| zxiiro | electrofelix: oh i see. ok understood | 14:34 |
| electrofelix | So to change it to allow it to be controlled based on the order the user would specify to match what jenkins allowed, and at the same time not break any existing ones needed to allow switching between old hardcoded order and new user defined order | 14:34 |
| electrofelix | ;) | 14:34 |
| zxiiro | i think i never noticed this because i almost exclusively use only string parameters | 14:35 |
| waynr | do you pass parameters to downstream jobs? | 14:36 |
| zxiiro | yes | 14:36 |
| zxiiro | in that case i almost exclusively run only paramters from property files | 14:37 |
| waynr | well anyway i agree with dispensing with the __future__ config section in favor of the plugin specific config section | 14:39 |
| zxiiro | Yeah. As long as we document it. I think it's fair game for V2 | 14:40 |
| zxiiro | ok anything else to discuss? If I'm correct I think V2 is just blocked on 3 things at the moment: | 14:41 |
| zxiiro | 1) YAML Parser patch | 14:41 |
| zxiiro | 2) Plugin namespace config | 14:41 |
| zxiiro | 3) 2.0-config-format | 14:41 |
| zxiiro | which all have action items so I think we're on track to getting 2.0 out. | 14:41 |
| zxiiro | if we can get 1) and 3) merged soon we'll be a little closer. | 14:42 |
| zxiiro | electrofelix: think you can get YAML Parser patch in today? should we try to iron it out now that everyone's here? | 14:42 |
| zxiiro | #action electrofelix to continue working on plugin namespace config patch | 14:43 |
| electrofelix | just approved, I'd been experimenting with it as we talked and read back over the email thread as well | 14:44 |
| zxiiro | awesome | 14:44 |
| zxiiro | alright if there's nothing else I guess we can end the meeting? | 14:44 |
| waynr | +1 | 14:45 |
| electrofelix | I think I'm good with all of the reviews for '3', so I'll try to get something up soon for '2' | 14:45 |
| zxiiro | great. sounds good | 14:45 |
| zxiiro | #endmeeting | 14:46 |
| openstack | Meeting ended Fri Sep 8 14:46:01 2017 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 14:46 |
| openstack | Minutes: http://eavesdrop.openstack.org/meetings/jjb/2017/jjb.2017-09-08-13.53.html | 14:46 |
| openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/jjb/2017/jjb.2017-09-08-13.53.txt | 14:46 |
| openstack | Log: http://eavesdrop.openstack.org/meetings/jjb/2017/jjb.2017-09-08-13.53.log.html | 14:46 |
| zxiiro | waynr: electrofelix: if nothing else comes up my gut feeling is we can probably do a 2.0 beta release next meeting and maybe a final release by next month? | 14:46 |
| electrofelix | I'll grab the champegne | 14:46 |
| waynr | woooo | 14:47 |
| openstackgerrit | Thanh Ha proposed openstack-infra/jenkins-job-builder master: Allow update to provide plugin_info via yaml https://review.openstack.org/326722 | 14:52 |
| openstackgerrit | Merged openstack-infra/jenkins-job-builder master: Move macro expansion into YamlParser. https://review.openstack.org/333076 | 15:41 |
| *** hashar is now known as hasharAway | 15:45 | |
| waynr | woo | 15:46 |
| *** electrofelix has quit IRC | 17:50 | |
| *** yland has joined #openstack-jjb | 18:18 | |
| *** yland is now known as Guest64518 | 18:18 | |
| *** hasharAway has quit IRC | 18:28 | |
| *** hashar has joined #openstack-jjb | 18:29 | |
| *** hashar has quit IRC | 20:32 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!