| *** smyers has quit IRC | 00:01 | |
| *** smyers has joined #openstack-jjb | 00:02 | |
| *** yland has quit IRC | 01:05 | |
| *** hashar has joined #openstack-jjb | 06:23 | |
| *** electrofelix has joined #openstack-jjb | 09:23 | |
| *** hashar has quit IRC | 09:39 | |
| *** hashar has joined #openstack-jjb | 09:39 | |
| *** hashar has quit IRC | 09:42 | |
| *** hashar has joined #openstack-jjb | 09:44 | |
| *** hashar has quit IRC | 10:07 | |
| *** hashar has joined #openstack-jjb | 10:07 | |
| *** hashar_ has joined #openstack-jjb | 10:13 | |
| *** hashar has quit IRC | 10:13 | |
| *** hashar_ is now known as hashar | 11:36 | |
| *** hashar has quit IRC | 12:07 | |
| *** hashar has joined #openstack-jjb | 12:20 | |
| *** hashar is now known as hasharAway | 17:02 | |
| *** electrofelix has quit IRC | 18:01 | |
| zxiiro | so I found a strange case where sometimes jjb doesn't parse the defaults. I'm not exactly sure why / when it happens | 19:25 |
|---|---|---|
| zxiiro | but some of my templates the defaults.yaml works and others it seems to ignore it. | 19:25 |
| *** hasharAway has quit IRC | 20:45 | |
| waynr | hmm can you come up with minimal reproduction cases? | 21:32 |
| zxiiro | trying to. but haven't figured out what the minimal is yet. I'll keep trying to figure it out. | 21:46 |
| zxiiro | It only happens in my massive jjb repo | 21:47 |
| waynr | hmm what do you mean by "parse the defaults" | 21:48 |
| waynr | interpolation of variables into template strings? | 21:49 |
| zxiiro | waynr: let's say you have a job-template with a macro that has a variable "{var}". normally if "var: value" was defined in defaults.yaml and the project did not define it. it will use the value from defaults.yaml | 21:49 |
| zxiiro | waynr: everytime I make a simple job that as far as I can tell does the same thing. It works as expected. but in my big jjb repo i noticed some jobs don't pick up the defaults for some reason unless i explicitly define it at the project level. | 21:50 |
| zxiiro | waynr: might be an edge case. I guess I'll try stripping out sections of the job template until i can find where it's happening. | 21:50 |
| waynr | hmm interesting | 21:51 |
| waynr | zxiiro: so does this happen to use the refactored macro expansion code? | 21:59 |
| zxiiro | waynr: no it happens even in the old code | 22:00 |
| zxiiro | or rather i mean i happens in both codes | 22:00 |
| waynr | okay | 22:00 |
| zxiiro | We use variable overriding in several places so it's probably has something to do with that... | 22:01 |
| zxiiro | although one thing I'd love to have is the ability to set a default variable at the macro level too. | 22:01 |
| waynr | yeah that would make sense | 22:01 |
| waynr | if that feature is added i hope it is built on top of https://review.openstack.org/#/c/333076/ | 22:04 |
| zxiiro | oh yeah we need that merged | 22:06 |
| zxiiro | i'll ping electrofelix next time i see him | 22:06 |
| zxiiro | I want to get that merged before another patch breaks it | 22:06 |
| waynr | cool cool | 22:07 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!