| openstackgerrit | Thanh Ha proposed openstack-infra/jenkins-job-builder master: Move macro expansion into YamlParser. https://review.openstack.org/333076 | 00:28 |
|---|---|---|
| openstackgerrit | Merged openstack-infra/jenkins-job-builder master: Update cvs to use convert_mapping_to_xml() https://review.openstack.org/479632 | 00:31 |
| *** Guest5481 has quit IRC | 01:33 | |
| *** larainema has quit IRC | 08:18 | |
| *** larainema has joined #openstack-jjb | 08:21 | |
| *** electrofelix has joined #openstack-jjb | 09:19 | |
| *** openstackgerrit has quit IRC | 11:17 | |
| *** yland has joined #openstack-jjb | 14:55 | |
| zxiiro | waynr: so the jinja patch broke your macro expansion patch https://review.openstack.org/333076 | 15:02 |
| zxiiro | waynr: you know how to fix it? | 15:02 |
| zxiiro | Odd_Bloke: ^ | 15:02 |
| zxiiro | Odd_Bloke: it's one of the patches we need to get into JJB so we can release 2.0. So I'm trying to get it through quickly... | 15:03 |
| Odd_Bloke | zxiiro: Yep, looking at it ATM. | 15:12 |
| Odd_Bloke | zxiiro: There are a couple of issues; one is that jinja2.Template isn't deepcopy'able; we can work around that by generating the template at format-time instead of storing it against the class. | 15:13 |
| zxiiro | Odd_Bloke: cool thanks! | 15:13 |
| Odd_Bloke | zxiiro: The other is that "!include-jinja2: {some_template}" returns a LazyLoader, which includes a reference to a LocalLoader, which includes a reference to an open file object (which can't be copied). | 15:13 |
| Odd_Bloke | For that one, I think we can just copy the reference to the LocalLoader if it's finished parsing, | 15:14 |
| *** openstackgerrit has joined #openstack-jjb | 15:14 | |
| openstackgerrit | Yolande Amate proposed openstack-infra/jenkins-job-builder master: Add support for jira_changelog_trigger https://review.openstack.org/493336 | 15:14 |
| openstackgerrit | Yolande Amate proposed openstack-infra/jenkins-job-builder master: Add support for jira_comment_trigger https://review.openstack.org/492266 | 15:35 |
| Odd_Bloke | zxiiro: Just sent email. | 15:39 |
| zxiiro | Odd_Bloke: thanks! | 15:40 |
| *** yland has quit IRC | 15:53 | |
| *** yland has joined #openstack-jjb | 16:06 | |
| *** yland is now known as Guest30640 | 16:06 | |
| openstackgerrit | Yolande Amate proposed openstack-infra/jenkins-job-builder master: Update openstack to use convert_mapping_to_xml() https://review.openstack.org/479996 | 16:47 |
| zxiiro | Guest30640: ^ The 2 yaml inputs files should not even appear in the change list. | 17:02 |
| *** Guest30640 has quit IRC | 17:31 | |
| *** Guest30640 has joined #openstack-jjb | 17:49 | |
| *** electrofelix has quit IRC | 18:13 | |
| *** Guest30640 is now known as yland | 18:21 | |
| openstackgerrit | Yolande Amate proposed openstack-infra/jenkins-job-builder master: Update openstack to use convert_mapping_to_xml() https://review.openstack.org/479996 | 18:27 |
| *** yland has quit IRC | 20:14 | |
| *** yland has joined #openstack-jjb | 20:41 | |
| openstackgerrit | Yolande Amate proposed openstack-infra/jenkins-job-builder master: Update archive to use convert_mapping_to_xml() https://review.openstack.org/476960 | 22:32 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!