opendevreview | Merged openstack/ironic-python-agent master: docs: remove tinyipa references https://review.opendev.org/c/openstack/ironic-python-agent/+/954534 | 03:57 |
---|---|---|
opendevreview | luocanhui proposed openstack/sushy master: Optimize unit testing https://review.opendev.org/c/openstack/sushy/+/954691 | 06:34 |
rpittau | good morning ironic! happy friday! o/ | 08:19 |
queensly[m] | Good morning, happy friday ! | 08:44 |
FreemanBoss[m] | Happy Friday | 08:49 |
abongale | good morning ironic! | 08:58 |
dtantsur | TheJulia: JFYI after the current round of comments I'm going to put the deferred tasks spec on the back burner until I figure out the local RPC situation. | 11:38 |
opendevreview | Verification of a change to openstack/ironic-python-agent master failed: Split hardware manager initialize out of evaluate_hardware_support https://review.opendev.org/c/openstack/ironic-python-agent/+/954139 | 12:04 |
iurygregory | good morning ironic, happy friday | 12:17 |
TheJulia | dtantsur: ++ | 13:30 |
opendevreview | cid proposed openstack/ironic master: Replace GreenThreadPoolExecutor in conductor https://review.opendev.org/c/openstack/ironic/+/952939 | 13:30 |
opendevreview | Merged openstack/ironic-python-agent master: Split hardware manager initialize out of evaluate_hardware_support https://review.opendev.org/c/openstack/ironic-python-agent/+/954139 | 14:19 |
opendevreview | Verification of a change to openstack/ironic-python-agent master failed: Graceful way for hardware managers to ignore certain devices https://review.opendev.org/c/openstack/ironic-python-agent/+/954024 | 14:37 |
opendevreview | Verification of a change to openstack/ironic-python-agent master failed: Trivial: avoid root logger in modules https://review.opendev.org/c/openstack/ironic-python-agent/+/954243 | 14:50 |
TheJulia | good morning! | 14:52 |
opendevreview | Julia Kreger proposed openstack/ironic master: WIP: Set the backend to threading. https://review.opendev.org/c/openstack/ironic/+/953683 | 14:54 |
TheJulia | cardoe: I'm kind of on the fence regarding https://review.opendev.org/c/openstack/ironic/+/953414 with the test state, I can see it was a result of the mock changes more than anything, just wondering if we should be caring more, or not. dtantsur you might have an opinion here, I guess I could go either way | 15:08 |
TheJulia | Overall, I think name makes ton of sense, its more about the test and regression risk on other future changes | 15:08 |
TheJulia | dtantsur: at least a sensible error now for the single process runtime | 15:20 |
TheJulia | https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_891/openstack/8914508bce824ea28aa3cd110b986777/logs/ironic.log | 15:20 |
dtantsur | yep, exactly as expected | 15:20 |
* dtantsur copying tls_utils from IPA | 15:21 | |
TheJulia | heh | 15:38 |
opendevreview | Dmitry Tantsur proposed openstack/ironic master: [Very WIP] Switch from local RPC to automated JSON RPC on localhost https://review.opendev.org/c/openstack/ironic/+/954755 | 15:44 |
dtantsur | TheJulia: this is the rough shape for it ^^^. As untested as untested things can only be untested. | 15:44 |
TheJulia | dtantsur: maybe stack it on top of the threading change to just see if it gets things at all close? | 15:45 |
dtantsur | I want to run some local testing first but I won't get to it today | 15:45 |
dtantsur | early feedback welcome though | 15:45 |
dtantsur | ugh, some leftover code, let me fix it | 15:46 |
opendevreview | Dmitry Tantsur proposed openstack/ironic master: [Very WIP] Switch from local RPC to automated JSON RPC on localhost https://review.opendev.org/c/openstack/ironic/+/954755 | 15:54 |
cardoe | TheJulia: so https://review.opendev.org/c/openstack/ironic/+/953414 is being done because other code in Ironic requires the interface to have a name field. | 16:00 |
cardoe | Essentially today you cannot run the redfish inspector and let it create the ports and have that node work in Ironic. It will cause the conductor to throw an exception on accessing that field. | 16:00 |
cardoe | I asked Haseeb to make it more clear in the commit message. | 16:01 |
TheJulia | Okay, which one of you taught claude about ironic ;) | 16:01 |
cardoe | He's currently playing with inspection hooks and inspection rules which is why he mentioned that case but there's other cases. | 16:01 |
TheJulia | cardoe: I get that, my concern is much more the test since we have a loop, we previously tested validated multiple entires, the mock only reuturns one entry | 16:02 |
cardoe | ohh I can tell him to go fix up the tests. | 16:02 |
cardoe | re: claude and ironic... what do ya mean? I use the heck out of Claude. | 16:03 |
TheJulia | okay, thanks. I realize I'm likely being a bit over cautious in the testing | 16:03 |
TheJulia | eh, I'm giving it a spin and I've thus far been impressed | 16:03 |
cardoe | You're probably not. All my outstanding patches are literally idling because the tests all pass but real world cases are finding untested things. | 16:03 |
cardoe | I mean Claude Code and I are having a chat in the Ironic code base right now in a terminal window. | 16:04 |
TheJulia | I'm wondering what it thinks about making RPC objects remotable right now | 16:05 |
opendevreview | Dmitry Tantsur proposed openstack/ironic master: [WIP] Switch from local RPC to automated JSON RPC on localhost https://review.opendev.org/c/openstack/ironic/+/954755 | 16:26 |
dtantsur | TheJulia: this works locally ^^^ | 16:26 |
dtantsur | I'm a bit out of spoons, feel free to rebase it or otherwise | 16:27 |
TheJulia | I'm kind of trying to focus on the locking idea at the moment | 16:27 |
TheJulia | and I woke up with a migraine, so I don't expect to do much today | 16:27 |
TheJulia | but ack | 16:27 |
dtantsur | ouch, take care | 16:27 |
dtantsur | we can get back to it next week | 16:27 |
dtantsur | if anyone without migraine has cycles, please provide feedback on https://review.opendev.org/c/openstack/ironic/+/954755 | 16:28 |
dtantsur | it's working or close to. just needs unit tests and reno | 16:28 |
* dtantsur signs off, have a nice weekend | 16:29 | |
TheJulia | wow, looks like we have most of the substrate already for a remotable object | 16:38 |
TheJulia | ahhhhhhh | 16:57 |
TheJulia | I seeeeeee | 16:57 |
TheJulia | dtantsur: question for next week: Thoughts on something along the lines of "if we have sqlite configured" -> Automatically use remotable objects ? It looks relatively simple to route to the API layer, some of the indirection code in ironic is dead today, but it looks like the required bits for oslo.versionedobjects to do magic is there. The downside is we have a couple dbapi calls in the api surface which would need to be | 17:06 |
TheJulia | able to use objects instead. | 17:06 |
sa | Subject: Handling VirtualMedia under Systems path (HPE Superdome Redfish) Hi all, I'm working with HPE Superdome hardware and noticed that their Redfish implementation exposes VirtualMedia under `/redfish/v1/Systems/{id}/VirtualMedia/`, which differs from the common `/Managers/{id}/VirtualMedia/` path expected by sushy and Ironic. HPE confirms this is standard-compliant per Redfish, but Ironic fails to locate the media devices due to this layout. B | 17:40 |
sa | Before opening a bug or patch, is there known support or discussion around handling this variant? Any pointers welcome! | 17:40 |
opendevreview | Merged openstack/ironic-python-agent master: Graceful way for hardware managers to ignore certain devices https://review.opendev.org/c/openstack/ironic-python-agent/+/954024 | 17:45 |
TheJulia | oh, hi! | 17:47 |
TheJulia | oh, sa left! | 17:47 |
TheJulia | Anyway, yeah, they sent an email to the mailing list | 17:47 |
cardoe | So this goes with my quirks suggestion. | 17:59 |
cardoe | I still need to push that RFC patch. | 17:59 |
cardoe | But right now I’m on the side of I-10 cause the RV’s tire blew. I had to make a 20 minute ride to another place. And I have setup to get new tires at the new place on Monday…. | 18:00 |
TheJulia | cardoe: heh, near vegas? :) | 18:02 |
cardoe | Just outside of Pensacola, FL | 18:02 |
TheJulia | cardoe: ahh, I'm actually at National Indoor RV Center in Vegas right now | 18:02 |
* TheJulia hopefully gets to head home today | 18:03 | |
* TheJulia doesn't want to live in their back lot over the weekend | 18:03 | |
TheJulia | lol | 18:03 |
cardoe | Getting something new? | 18:03 |
TheJulia | Nah, lots of service work and new tires | 18:03 |
cardoe | lol. Do you made it to get the new tires. | 18:04 |
TheJulia | Well, it was semi-planned and then they were like "oh, over half of your other tires are at 5 years, what do you want to do?" | 18:06 |
TheJulia | so it went from 2 to 8 :( | 18:06 |
TheJulia | Technically, we could go to 7, but... we also don't know how well the rig was cared before we got it | 18:08 |
TheJulia | so one of those "well, this sucks, but it is what it is" scenarios | 18:09 |
TheJulia | cardoe: hopefully the blow-out wasn't that bad. | 18:20 |
cardoe | Definitely picked up some damage. | 18:23 |
cardoe | But yeah I agree. It sucks but such is life. | 18:24 |
cardoe | At least you know the condition you are in now and it’s safer. | 18:24 |
cardoe | The number of cars cutting over the lines and coming close to us is crazy. | 18:24 |
TheJulia | yup! hopefully your damage can get sorted quickly and easily. | 18:24 |
TheJulia | oh yeah, and its like it is intentional | 18:25 |
TheJulia | I saw that the last time I broke down | 18:25 |
cardoe | We have a Good Sam roadside so getting them to come help me swap it. | 18:25 |
TheJulia | Having/using an RV really changes your views on driving, spacing, and all | 18:25 |
TheJulia | oh good, glad they actually engaged | 18:25 |
TheJulia | I gave up on good sams in the past, but my last breakdown was outside Quartzite | 18:26 |
cardoe | 100%. People think we can stop on a dime and move out of their way. | 18:26 |
cardoe | First time trying good Sam. | 18:26 |
TheJulia | They seem to be really good back east, out west they seem useless | 18:26 |
TheJulia | I went with coachnet when we got our current motorhome | 18:26 |
cardoe | Well we made it and are now setup at the new place. It blew my handle bar by the door off! | 21:04 |
TheJulia | cardoe: 5th wheel or trailer? | 22:38 |
TheJulia | I'm guessing not a class a or c based upon your comment | 22:39 |
TheJulia | (because that would seem like a front wheel blowout and ugh) | 22:39 |
cardoe | travel trailer | 23:27 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!