| opendevreview | 雒海艇 proposed openstack/networking-generic-switch master: Add H3C devices support https://review.opendev.org/c/openstack/networking-generic-switch/+/947554 | 01:28 |
|---|---|---|
| opendevreview | Jacob Anders proposed openstack/sushy master: [WIP] Skipping UsbCd workaround on Supermicro ARS-111GL-NHR https://review.opendev.org/c/openstack/sushy/+/949116 | 04:34 |
| janders | 385772 | 04:36 |
| janders | oops | 04:36 |
| janders | :) | 04:37 |
| opendevreview | Elod Illes proposed openstack/bifrost unmaintained/zed: [CI][UM-only] Remove not defined kolla-ansible job https://review.opendev.org/c/openstack/bifrost/+/949057 | 10:00 |
| opendevreview | Jacob Anders proposed openstack/sushy master: [WIP] Skipping UsbCd workaround on Supermicro ARS-111GL-NHR https://review.opendev.org/c/openstack/sushy/+/949116 | 11:13 |
| TheJulia | janders: helps if you paste the website url too ;) | 13:06 |
| opendevreview | Jay Faulkner proposed openstack/ironic master: OSSA-2025-001: Disallow unsafe image file:// paths https://review.opendev.org/c/openstack/ironic/+/949172 | 13:29 |
| opendevreview | Jay Faulkner proposed openstack/ironic stable/2025.1: OSSA-2025-001: Disallow unsafe image file:// paths https://review.opendev.org/c/openstack/ironic/+/949173 | 13:30 |
| opendevreview | Jay Faulkner proposed openstack/ironic stable/2024.2: OSSA-2025-001: Disallow unsafe image file:// paths https://review.opendev.org/c/openstack/ironic/+/949174 | 13:30 |
| opendevreview | Jay Faulkner proposed openstack/ironic stable/2024.1: OSSA-2025-001: Disallow unsafe image file:// paths https://review.opendev.org/c/openstack/ironic/+/949175 | 13:31 |
| opendevreview | Jay Faulkner proposed openstack/ironic unmaintained/zed: OSSA-2025-001: Disallow unsafe image file:// paths https://review.opendev.org/c/openstack/ironic/+/949176 | 13:32 |
| opendevreview | Jay Faulkner proposed openstack/ironic unmaintained/yoga: OSSA-2025-001: Disallow unsafe image file:// paths https://review.opendev.org/c/openstack/ironic/+/949177 | 13:32 |
| opendevreview | Jay Faulkner proposed openstack/ironic unmaintained/xena: OSSA-2025-001: Disallow unsafe image file:// paths https://review.opendev.org/c/openstack/ironic/+/949179 | 13:33 |
| JayF | TheJulia: cid: cardoe: dtantsur: ^ please expedite review, announcement is in ~1h 30m | 13:33 |
| * dtantsur looking | 13:33 | |
| TheJulia | heh | 13:33 |
| TheJulia | Thanks JayF | 13:34 |
| JayF | no problem | 13:34 |
| dtantsur | JayF: https://review.opendev.org/c/openstack/ironic/+/949174/1/ironic/conf/conductor.py#173 sneaked into the backport | 13:37 |
| JayF | dtantsur: can you comment that on the review please | 13:38 |
| dtantsur | JayF: 2024.1 and 2024.2 need updating | 13:39 |
| dtantsur | would you be so kind to propose at least recent bugfix branches? | 13:39 |
| JayF | oh hell, I was supposed to do that too | 13:40 |
| JayF | I just forogt | 13:40 |
| JayF | and didn't make pre-patches for it | 13:40 |
| JayF | I'll cherry pick em in | 13:40 |
| dtantsur | thanks! | 13:40 |
| * JayF has a queue like 5 deep of things to do for this so it'll get there eventually | 13:40 | |
| JayF | heh I forgot antelope too somehow | 13:42 |
| opendevreview | Jay Faulkner proposed openstack/ironic unmaintained/2023.1: OSSA-2025-001: Disallow unsafe image file:// paths https://review.opendev.org/c/openstack/ironic/+/949182 | 13:43 |
| dtantsur | JayF: everything starting with 2024.2 and older has the same problem in conf/conductor.py | 13:44 |
| JayF | that's mostly what I'd expect | 13:44 |
| JayF | ty for the review I'm going to revise them once I get the draft ossa up | 13:45 |
| JayF | and bugfix branch patches written | 13:45 |
| dtantsur | cool | 13:45 |
| JayF | I have 26.0 / 27.0 / 28.0 is that right? | 13:45 |
| JayF | for bugfix | 13:45 |
| opendevreview | Jay Faulkner proposed openstack/ironic bugfix/28.0: OSSA-2025-001: Disallow unsafe image file:// paths https://review.opendev.org/c/openstack/ironic/+/949184 | 13:47 |
| opendevreview | Jay Faulkner proposed openstack/ironic bugfix/27.0: OSSA-2025-001: Disallow unsafe image file:// paths https://review.opendev.org/c/openstack/ironic/+/949185 | 13:47 |
| opendevreview | Jay Faulkner proposed openstack/ironic bugfix/26.0: OSSA-2025-001: Disallow unsafe image file:// paths https://review.opendev.org/c/openstack/ironic/+/949186 | 13:49 |
| opendevreview | Jay Faulkner proposed openstack/ironic master: OSSA-2025-001: Disallow unsafe image file:// paths https://review.opendev.org/c/openstack/ironic/+/949172 | 13:54 |
| opendevreview | Jay Faulkner proposed openstack/ironic stable/2025.1: OSSA-2025-001: Disallow unsafe image file:// paths https://review.opendev.org/c/openstack/ironic/+/949173 | 13:55 |
| arne_wiebalck | JayF: probably a stupid question ... is the link to the bug in launchpad supposed to be working (or is there some sort of quarantine on the bug)? | 13:56 |
| opendevreview | Jay Faulkner proposed openstack/ironic stable/2024.2: OSSA-2025-001: Disallow unsafe image file:// paths https://review.opendev.org/c/openstack/ironic/+/949174 | 13:56 |
| JayF | arne_wiebalck: embargo lifts at 1600 UTC | 13:56 |
| JayF | arne_wiebalck: what's your LP I'll add you to the bug | 13:56 |
| dtantsur | JayF: remind me please, we decided not to backport BLOCKED_FILE_URL_PATHS? | 13:58 |
| arne_wiebalck | JayF: should be arne-wiebalck | 13:58 |
| JayF | dtantsur: yes, specificlaly so it can be fully disabled if needed | 13:58 |
| JayF | dtantsur: I believe you requested that in the bug lol | 13:58 |
| dtantsur | JayF: I definitely never cared about that aspect, my comments were about having an empty allowlist by default | 13:58 |
| JayF | ah, okay | 13:58 |
| JayF | either way, it's still safe and sensible to do it that way | 13:58 |
| arne_wiebalck | (embargo, not quarantine ... thanks JayF!) | 13:59 |
| JayF | I misunderstood but that's the way of doing code review in launchpad on text files | 13:59 |
| opendevreview | Jay Faulkner proposed openstack/ironic stable/2024.1: OSSA-2025-001: Disallow unsafe image file:// paths https://review.opendev.org/c/openstack/ironic/+/949175 | 14:00 |
| * TheJulia slides more coffee to JayF | 14:00 | |
| JayF | who needs coffee when you are ACVE (Adrenaline-induced Continually Vibrating Engineer) | 14:01 |
| opendevreview | Jay Faulkner proposed openstack/ironic stable/2024.1: OSSA-2025-001: Disallow unsafe image file:// paths https://review.opendev.org/c/openstack/ironic/+/949175 | 14:02 |
| dtantsur | JayF: https://review.opendev.org/c/openstack/ironic/+/949175/3/ironic/conf/conductor.py | 14:02 |
| JayF | wow that wasn't even conflicting | 14:03 |
| JayF | it just happily injected that change | 14:03 |
| JayF | egad time to go cherry pick down that path again | 14:03 |
| TheJulia | Last call for master branch change review | 14:04 |
| opendevreview | Jay Faulkner proposed openstack/ironic stable/2024.1: OSSA-2025-001: Disallow unsafe image file:// paths https://review.opendev.org/c/openstack/ironic/+/949175 | 14:05 |
| dtantsur | JayF: sorry, I'm being pedantic again: https://review.opendev.org/c/openstack/ironic/+/949184 | 14:05 |
| dtantsur | tl;dr bugfix branches should be cherry-picked from 2025.1 because they're older than it | 14:05 |
| JayF | ah, and not get the blocked file version | 14:05 |
| JayF | good call | 14:05 |
| JayF | I don't hate review I'm glad you all are here looking | 14:05 |
| JayF | get it all done before the rush is over lol | 14:06 |
| dtantsur | I wish we had a private gerrit to work on these reviews before disclosure :) | 14:06 |
| TheJulia | That would be so much better | 14:07 |
| JayF | dtantsur: can you give me a +2 on everything 2024.1 and newer with my latest update? | 14:07 |
| JayF | dtantsur: I'm going to go fix bugfix, then if I get that, will rehydrate the unmaintained patches | 14:07 |
| frickler | JayF: ping me if you need help from infra side, I should be around until 20 UTCish. clark and fungi are a-travellin | 14:08 |
| dtantsur | JayF: I'm still on it, just got distracted by slack | 14:08 |
| JayF | I honestly just as much meant here, visually | 14:08 |
| JayF | so I know I won't backtrack again | 14:08 |
| opendevreview | Jay Faulkner proposed openstack/ironic bugfix/28.0: OSSA-2025-001: Disallow unsafe image file:// paths https://review.opendev.org/c/openstack/ironic/+/949184 | 14:09 |
| dtantsur | master-2024.1 done | 14:09 |
| opendevreview | Jay Faulkner proposed openstack/ironic bugfix/27.0: OSSA-2025-001: Disallow unsafe image file:// paths https://review.opendev.org/c/openstack/ironic/+/949185 | 14:09 |
| opendevreview | Jay Faulkner proposed openstack/ironic bugfix/26.0: OSSA-2025-001: Disallow unsafe image file:// paths https://review.opendev.org/c/openstack/ironic/+/949186 | 14:10 |
| JayF | okay cool, carrying the 2024.1 patch back now | 14:10 |
| JayF | I'm posting a 2023.2 (bobcat) to the bug as a courtesy too, if anyone wants to take a glance | 14:11 |
| JayF | but I assume if 2024.1 and 2023.1 are OK so is it | 14:11 |
| opendevreview | Jay Faulkner proposed openstack/ironic unmaintained/2023.1: OSSA-2025-001: Disallow unsafe image file:// paths https://review.opendev.org/c/openstack/ironic/+/949182 | 14:12 |
| opendevreview | Jay Faulkner proposed openstack/ironic unmaintained/zed: OSSA-2025-001: Disallow unsafe image file:// paths https://review.opendev.org/c/openstack/ironic/+/949176 | 14:13 |
| opendevreview | Jay Faulkner proposed openstack/ironic unmaintained/xena: OSSA-2025-001: Disallow unsafe image file:// paths https://review.opendev.org/c/openstack/ironic/+/949179 | 14:13 |
| opendevreview | Jay Faulkner proposed openstack/ironic unmaintained/yoga: OSSA-2025-001: Disallow unsafe image file:// paths https://review.opendev.org/c/openstack/ironic/+/949177 | 14:13 |
| dtantsur | I've done all maintained branches | 14:14 |
| JayF | UM 2024.1 looks good to me when reviewed in gerrit so posting the updated bobcat patch to the bug | 14:15 |
| JayF | I approved the (already 2x+2) master fix to get it into CI | 14:16 |
| JayF | If folks wanna leave +2s on the others, I can kick them into CI in order as things merge | 14:16 |
| JayF | to avoid thundering-herding ourselves | 14:16 |
| dtantsur | JayF: I have really bad news for you in https://zuul.opendev.org/t/openstack/status?project=*ironic* | 14:17 |
| dtantsur | it seems like the patches are failing unit tests | 14:17 |
| JayF | hm | 14:17 |
| JayF | that must be new or on stable branches | 14:17 |
| JayF | did not happen locally | 14:17 |
| dtantsur | ex https://4e5ec2ca134a121acd29-76b8ff4c2a9c5ff54963c666a21f5048.ssl.cf2.rackcdn.com/openstack/700880f7243542009054402243e2a53f/testr_results.html | 14:17 |
| dtantsur | JayF: this is my fault, essentially, you need s/urls/URLs/ in the tests too | 14:18 |
| JayF | oh hell | 14:18 |
| JayF | easy fix is easy tho | 14:18 |
| dtantsur | JayF: I'd change the string to "/dev is not permitted" | 14:18 |
| dtantsur | the "URLs" part is not really important | 14:18 |
| dtantsur | but any way you like | 14:18 |
| JayF | Well, we specifically, for that case, do not give information on what is permitted | 14:19 |
| JayF | because it's configuration and revealing that is potentially security sensitive | 14:19 |
| dtantsur | "Validation of image href file:///dev/sda1 failed, reason: Security: The path /dev is not permitted in file URLs" | 14:19 |
| dtantsur | JayF: for the pre-defined list, we do ^^^ | 14:19 |
| JayF | ah, I was looking at the /other/ failure | 14:19 |
| JayF | lol | 14:19 |
| dtantsur | aha :) | 14:20 |
| dtantsur | anyway, I don't insist on a large change, s/url/URL/ is enough | 14:20 |
| JayF | unless you feel VERY strongly about that verbiage change | 14:20 |
| JayF | yeah | 14:20 |
| JayF | ty | 14:20 |
| dtantsur | Ping me when they're ready for a new pass | 14:20 |
| TheJulia | If someone tries to source from a device, I'm going to have to create a pretty award plaque and we're going to have to hold an awards ceremony | 14:22 |
| JayF | "Please re-enable spacebar heating" | 14:22 |
| JayF | "For performance I image directly from a dedicated block device avoiding filesystem overhead" | 14:22 |
| JayF | hehe | 14:22 |
| TheJulia | No, we need to see if Gedde Wantanabe wants to revise his role as Kuni | 14:24 |
| TheJulia | Wheel of Fish! | 14:24 |
| * TheJulia wonders how many folks will get that reference | 14:24 | |
| fungi | i was planning to rewatch uhf next week actually | 14:25 |
| * fungi <- old | 14:25 | |
| opendevreview | Jay Faulkner proposed openstack/ironic master: OSSA-2025-001: Disallow unsafe image file:// paths https://review.opendev.org/c/openstack/ironic/+/949172 | 14:25 |
| TheJulia | fungi: Thank you! | 14:26 |
| TheJulia | JayF: are we re-cherry-picking that? | 14:26 |
| JayF | TheJulia: I'm just doing the patch on the test files | 14:26 |
| JayF | TheJulia: to avoid having to re-re-re-rebase | 14:27 |
| JayF | g-g-g-g-git rebase | 14:27 |
| JayF | going to be a bit slower as I'm ensuring unit tests pass on that module on each step now | 14:27 |
| opendevreview | Jay Faulkner proposed openstack/ironic stable/2025.1: OSSA-2025-001: Disallow unsafe image file:// paths https://review.opendev.org/c/openstack/ironic/+/949173 | 14:27 |
| TheJulia | ok | 14:28 |
| * TheJulia holds off then | 14:29 | |
| opendevreview | Jay Faulkner proposed openstack/ironic bugfix/28.0: OSSA-2025-001: Disallow unsafe image file:// paths https://review.opendev.org/c/openstack/ironic/+/949184 | 14:29 |
| opendevreview | Jay Faulkner proposed openstack/ironic bugfix/27.0: OSSA-2025-001: Disallow unsafe image file:// paths https://review.opendev.org/c/openstack/ironic/+/949185 | 14:30 |
| opendevreview | Jay Faulkner proposed openstack/ironic bugfix/26.0: OSSA-2025-001: Disallow unsafe image file:// paths https://review.opendev.org/c/openstack/ironic/+/949186 | 14:32 |
| opendevreview | Jay Faulkner proposed openstack/ironic stable/2024.2: OSSA-2025-001: Disallow unsafe image file:// paths https://review.opendev.org/c/openstack/ironic/+/949174 | 14:34 |
| opendevreview | Jay Faulkner proposed openstack/ironic stable/2024.1: OSSA-2025-001: Disallow unsafe image file:// paths https://review.opendev.org/c/openstack/ironic/+/949175 | 14:36 |
| opendevreview | Jay Faulkner proposed openstack/ironic unmaintained/2023.1: OSSA-2025-001: Disallow unsafe image file:// paths https://review.opendev.org/c/openstack/ironic/+/949182 | 14:38 |
| opendevreview | Jay Faulkner proposed openstack/ironic unmaintained/zed: OSSA-2025-001: Disallow unsafe image file:// paths https://review.opendev.org/c/openstack/ironic/+/949176 | 14:39 |
| opendevreview | Jay Faulkner proposed openstack/ironic unmaintained/yoga: OSSA-2025-001: Disallow unsafe image file:// paths https://review.opendev.org/c/openstack/ironic/+/949177 | 14:40 |
| opendevreview | Jay Faulkner proposed openstack/ironic unmaintained/xena: OSSA-2025-001: Disallow unsafe image file:// paths https://review.opendev.org/c/openstack/ironic/+/949179 | 14:41 |
| JayF | patches updated, ran unit tests against all supported branches before pushing | 14:41 |
| JayF | related note: we need to update tox contraint file links in tox.ini across many of these branches :) | 14:41 |
| TheJulia | the unmaintained ones? | 14:46 |
| JayF | yea | 14:46 |
| JayF | at least 2023.1 | 14:46 |
| TheJulia | I doubt anyone directly pulls of merged state since it is "unmaintained" | 14:46 |
| JayF | I mean more like, for developers | 14:47 |
| JayF | tox -epyxx doesn't work | 14:47 |
| TheJulia | that sets a pretty awful expectation that you need to do all your security patch management | 14:47 |
| TheJulia | yeah | 14:47 |
| JayF | because of the constraints link in the tox.ini | 14:47 |
| JayF | I don't care that much except not wanting to be surprised on busy mornings :D | 14:47 |
| TheJulia | yeah | 14:47 |
| dtantsur | I have a lot of second thoughts about our decision for cleaning not to remove software RAID..... | 15:04 |
| JayF | I didn't like the decision when we made it because software raid is something we could stand back up :( | 15:05 |
| dtantsur | So, fun story. Well, "fun". Something has set up software RAID in the openshift CI, Ironic does not clean it, and the jobs fail from time to time. | 15:06 |
| JayF | yep | 15:09 |
| JayF | that's what people wanted | 15:09 |
| TheJulia | ... For reasons, maybe there needs to be a knob?! | 15:09 |
| JayF | I never fully understood why and it all landed when I was not as engaged with the projects | 15:10 |
| JayF | **project | 15:10 |
| * TheJulia hates that idea, but yeah | 15:10 | |
| TheJulia | She who has to write unit tests today | 15:10 |
| dtantsur | JayF: the docs jobs fail on some of your backports, the reason seems unrelated: https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_2db/openstack/2db6b3141d3a442d8b123955165e062b/sphinx-build-pdf.log | 15:11 |
| JayF | I will have an unavoidable meeting in ~30 minutes | 15:11 |
| dtantsur | me too | 15:12 |
| JayF | if someone has time to dig into that and push a separate patch it'd be awesome | 15:12 |
| TheJulia | same in ~45 | 15:12 |
| TheJulia | and... an electritian arriving in ~10 minutes | 15:12 |
| * TheJulia surrendered to the electrical problem and has hired an electritian | 15:12 | |
| * TheJulia is a failure | 15:12 | |
| dtantsur | an exciting thursday, monday-quality | 15:12 |
| TheJulia | wheeeeee! | 15:12 |
| dtantsur | I'm actually quite close to a nuke_software_raid_during_cleaning option in IPA | 15:18 |
| JayF | I'd +2 such a patch | 15:19 |
| dtantsur | Noted. I'll ponder this variant further. If this option is True, do you think we should refuse to create software RAID as a clean (not deploy) step? | 15:20 |
| dtantsur | TheJulia: https://review.opendev.org/c/openstack/ironic/+/949172 is ready for re-approval if you have a minute during the electrician visit | 15:21 |
| JayF | dtantsur: it's an ordering thing; at Rackspace OnMetal, we'd tear down (early priority) and rebuild (later priority) | 15:22 |
| dtantsur | Yeah, I need to think more about it. Maybe I just find a way to prevent software RAID in our hardware manager. | 15:22 |
| dtantsur | Override create_configuration clean step with an error, yeah, should be easy | 15:22 |
| kubajj | dtantsur: so now it can be both? I thought it was just a clean step | 15:23 |
| dtantsur | kubajj: I think it's usable as a deploy step, but I haven't checked this assumption myself | 15:24 |
| JayF | yep | 15:25 |
| opendevreview | Dmitry Tantsur proposed openstack/ironic-python-agent master: PoC: allow deleting software RAID on cleaning https://review.opendev.org/c/openstack/ironic-python-agent/+/949221 | 15:52 |
| dtantsur | input welcome ^^^ | 15:52 |
| dtantsur | Meanwhile, I suspect the docs failure is because of the ironic-lib migration | 16:02 |
| JayF | urgh | 16:28 |
| JayF | https://opendev.org/openstack/ironic/src/branch/master/setup.cfg#L113 It makes me a little sad that it's direct for deploy and agent for inspect/raid/etc | 16:33 |
| JayF | I think I knew this before but didn't internalize until today | 16:33 |
| dtantsur | Next time don't let me do the naming :D | 16:43 |
| TheJulia | Ultimately, agent can have multiple distinct deploys, and actually did for a long time | 16:43 |
| TheJulia | AI, please make me a photo of Caeser on the Ides of March with the label of "iscsi" | 16:44 |
| JayF | lol | 16:46 |
| TheJulia | https://usercontent.irccloud-cdn.com/file/W56jPtLF/iscsi | 16:50 |
| JayF | honestly I'm just more surprised we didn't leave in an alias for 'agent' deploy | 17:06 |
| * JayF just glad iscsi deploy is gone | 17:07 | |
| opendevreview | Merged openstack/ironic master: OSSA-2025-001: Disallow unsafe image file:// paths https://review.opendev.org/c/openstack/ironic/+/949172 | 17:20 |
| opendevreview | Verification of a change to openstack/ironic stable/2025.1 failed: OSSA-2025-001: Disallow unsafe image file:// paths https://review.opendev.org/c/openstack/ironic/+/949173 | 17:24 |
| opendevreview | Jay Faulkner proposed openstack/ironic stable/2024.2: [stable-only] Fix errors building docs https://review.opendev.org/c/openstack/ironic/+/949239 | 18:06 |
| JayF | I think that's what we need to fix doc builds | 18:07 |
| JayF | lets see :) | 18:07 |
| opendevreview | Verification of a change to openstack/ironic stable/2025.1 failed: OSSA-2025-001: Disallow unsafe image file:// paths https://review.opendev.org/c/openstack/ironic/+/949173 | 18:11 |
| JayF | https://review.opendev.org/c/openstack/ironic/+/949239 has already passed docs job in zuul status, if someone wants to +2 and/or early approve | 18:29 |
| *** awb_ is now known as awb | 19:08 | |
| JayF | ^^ needs reviews and approval to continue with the backports, it's v+1 | 19:42 |
| JayF | it's stable proposed by me so I think literally we need one other human | 19:42 |
| * frickler pulls out his stable hat and tries to look human | 19:50 | |
| TheJulia | ... human?!? I'm supposed to look human?! | 19:50 |
| TheJulia | wut?! | 19:50 |
| JayF | I never said "look" | 19:51 |
| JayF | I don't care what you look like if my code merges :D | 19:55 |
| opendevreview | Jay Faulkner proposed openstack/ironic stable/2024.1: [stable-only] Fix errors building docs https://review.opendev.org/c/openstack/ironic/+/949256 | 19:55 |
| opendevreview | Jay Faulkner proposed openstack/ironic unmaintained/2023.1: [stable-only] Fix errors building docs https://review.opendev.org/c/openstack/ironic/+/949257 | 19:56 |
| opendevreview | Jay Faulkner proposed openstack/ironic unmaintained/zed: [stable-only] Fix errors building docs https://review.opendev.org/c/openstack/ironic/+/949258 | 19:56 |
| opendevreview | Jay Faulkner proposed openstack/ironic unmaintained/yoga: [stable-only] Fix errors building docs https://review.opendev.org/c/openstack/ironic/+/949259 | 19:56 |
| opendevreview | Jay Faulkner proposed openstack/ironic unmaintained/xena: [stable-only] Fix errors building docs https://review.opendev.org/c/openstack/ironic/+/949260 | 19:56 |
| okami | Hey folks, I'm currently doing some testing and I very well could be doing something wrong on my end. | 19:59 |
| okami | When I use the cli to create a node and add it's port they get added to dnsmasq hostdir as ignore. | 20:00 |
| JayF | Have you attempted any provisioning actions which would require/enable dhcp? | 20:01 |
| JayF | What you're describing makes sense to me, in some configurations -- especially with inspection and discovery features enabled -- we will block enrolled nodes from getting DHCP from the discovery pool (because they've already been discovered and enrolled) | 20:02 |
| JayF | but when you go to provision (using pxe/ipxe boot interface), we'll replace that block with configuration that has specific dhcp options and pxe for only that node's mac | 20:03 |
| JayF | CI on unmaintained/xena is an absolute mess. | 20:13 |
| okami | Got it, ok let me chase that down. I did just realize there's also a kolla channel so it may be related to my config on the kolla side as well. Currently running the 2024.2 branch. | 20:15 |
| JayF | Yeah, it depends on what level the problem is in who would be more helpful. I'm not super familiar with their default configuration/architecture. | 20:18 |
| okami | Yeah, I'll go ask some questions over there. I can initiate the deployment the node powers on but then because of that dhcp ignore it never gets further. I appreciate the pointers. | 20:23 |
| JayF | good luck! | 20:24 |
| JayF | btw one extra thing | 20:24 |
| JayF | I see you're on webchat | 20:24 |
| JayF | you got *very lucky* to find someone right as you asked the question | 20:24 |
| JayF | for most openstack support, you have to ask and be patient due to the international nature of the project | 20:25 |
| JayF | so you may want a more persistent presence than a webchat -- https://docs.openstack.org/contributors/en_GB/common/irc.html#irc-chatting-with-matrix matrix is a free way to do this, I use irccloud.com (even the free account is decent) | 20:25 |
| okami | Thanks, yeah I appreciate the quick support. I was expecting and totally fine with just posting the question and coming back later to check. I'll check out matrix. | 20:27 |
| JayF | Hey, I'm glad you're using Ironic! BTW, if you wanna share some about your use case it'd be nice to hear | 20:29 |
| opendevreview | Merged openstack/ironic stable/2024.2: [stable-only] Fix errors building docs https://review.opendev.org/c/openstack/ironic/+/949239 | 20:35 |
| shermanm | good tip on the matrix bridge, I hadn't known about it | 20:55 |
| JayF | https://review.opendev.org/c/openstack/ironic/+/949256 is the next docs ci fix patch, needs a +2 so I can get the 2024.1 backport landed as well (eventually) | 21:19 |
| opendevreview | Merged openstack/ironic stable/2025.1: OSSA-2025-001: Disallow unsafe image file:// paths https://review.opendev.org/c/openstack/ironic/+/949173 | 21:27 |
| JayF | \o/ | 21:35 |
| JayF | release for epoxy requested here https://review.opendev.org/c/openstack/releases/+/949278 | 21:36 |
| opendevreview | Jay Faulkner proposed openstack/ironic bugfix/26.0: [stable-only] Fix errors building docs https://review.opendev.org/c/openstack/ironic/+/949281 | 21:39 |
| JayF | bugfix/28.0 bugfix/27.0 self-approved to get them into the game | 21:40 |
| JayF | **gate | 21:40 |
| JayF | 26.0 needs that docs fix too | 21:40 |
| JayF | Right now I'm mildly blocked on getting approvals on the rest of those docs fixes; but at this point the only supported branch in a bad state from that is bugfix/26.0 | 21:40 |
| JayF | and unsupported stuff, quite frankly, is not going to get this level of urgency from me :) | 21:41 |
| JayF | **unmaintained | 21:41 |
| cardoe | Gosh if only hackers would schedule themselves around | 22:16 |
| JayF | I just self-approved https://review.opendev.org/c/openstack/ironic/+/949174 for 2024.2 so it'll go into the gate if things pass | 22:16 |
| cardoe | My birthday. I would have reviewed stuff. | 22:16 |
| JayF | cardoe: please get out your stamp and ink pad | 22:16 |
| JayF | oh, it's your birthday! | 22:16 |
| JayF | happy birthday! | 22:16 |
| JayF | have a CVE | 22:16 |
| JayF | I would've gotten you a better gift but I didn't know until now ;) | 22:16 |
| cardoe | They’re a bit rough in the first bite but once they go down it’s smooth sailing. | 22:19 |
| JayF | so 2024.2 is in the right path; 2024.1 needs https://review.opendev.org/c/openstack/ironic/+/949256 approved then https://review.opendev.org/c/openstack/ironic/+/949175 rechecked/approved | 22:20 |
| opendevreview | Merged openstack/ironic bugfix/28.0: OSSA-2025-001: Disallow unsafe image file:// paths https://review.opendev.org/c/openstack/ironic/+/949184 | 22:20 |
| JayF | once 2024.2 is done we have to release it, too | 22:20 |
| opendevreview | Merged openstack/ironic bugfix/27.0: OSSA-2025-001: Disallow unsafe image file:// paths https://review.opendev.org/c/openstack/ironic/+/949185 | 22:20 |
| JayF | and bugfix/26.0 needs https://review.opendev.org/c/openstack/ironic/+/949281 then https://review.opendev.org/c/openstack/ironic/+/949186 rechecked+approved | 22:21 |
| JayF | everything else is done for supported branches | 22:21 |
| JayF | I'm going to be sliding off here in a little bit, been working since ~6a this morn | 22:21 |
| cardoe | Well tossed reviews out. | 22:22 |
| JayF | very much thank you | 22:26 |
| JayF | I was going to fuss at you for even looking at IRC on your birthday | 22:26 |
| JayF | but then you'll get to fuss at me in like 4 months lol | 22:26 |
| opendevreview | Merged openstack/ironic bugfix/26.0: [stable-only] Fix errors building docs https://review.opendev.org/c/openstack/ironic/+/949281 | 22:35 |
| * JayF put bugfix/26.0 patch into gate | 22:38 | |
| opendevreview | Merged openstack/ironic stable/2024.1: [stable-only] Fix errors building docs https://review.opendev.org/c/openstack/ironic/+/949256 | 23:20 |
| opendevreview | Merged openstack/ironic unmaintained/2023.1: [stable-only] Fix errors building docs https://review.opendev.org/c/openstack/ironic/+/949257 | 23:25 |
| opendevreview | Merged openstack/ironic unmaintained/zed: [stable-only] Fix errors building docs https://review.opendev.org/c/openstack/ironic/+/949258 | 23:38 |
| opendevreview | Merged openstack/ironic unmaintained/yoga: [stable-only] Fix errors building docs https://review.opendev.org/c/openstack/ironic/+/949259 | 23:47 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!