| opendevreview | cid proposed openstack/ironic-python-agent master: WIP: Eventlet Removal- WSGI server https://review.opendev.org/c/openstack/ironic-python-agent/+/946091 | 00:02 |
|---|---|---|
| opendevreview | cid proposed openstack/ironic-python-agent master: WIP: Eventlet Removal- WSGI server https://review.opendev.org/c/openstack/ironic-python-agent/+/946091 | 00:23 |
| opendevreview | cid proposed openstack/ironic-python-agent master: WIP: Eventlet Removal- WSGI server https://review.opendev.org/c/openstack/ironic-python-agent/+/946091 | 00:26 |
| freemanboss[m] | Good morning ironic | 10:58 |
| opendevreview | minwoo seo proposed openstack/ironic master: Add `api-call` action for ironic inspection rule https://review.opendev.org/c/openstack/ironic/+/946741 | 11:11 |
| opendevreview | minwoo seo proposed openstack/ironic master: Add `api-call` action for ironic inspection rule https://review.opendev.org/c/openstack/ironic/+/946741 | 11:13 |
| *** darmach9 is now known as darmach | 11:43 | |
| TheJulia | good morning | 13:17 |
| opendevreview | minwoo seo proposed openstack/ironic master: Add `api-call` action for ironic inspection rule https://review.opendev.org/c/openstack/ironic/+/946741 | 13:56 |
| opendevreview | minwoo seo proposed openstack/ironic master: Add `api-call` action for ironic inspection rule https://review.opendev.org/c/openstack/ironic/+/946741 | 13:57 |
| -opendevstatus- NOTICE: notice Reminder: The Gerrit service on review.opendev.org will be offline for a server replacement maintenance between 16:00-17:00 UTC today per https://lists.opendev.org/archives/list/service-announce@lists.opendev.org/message/D6VGKXHKXCV6TD6MFJY4H4KQBIM3AQYI/ | 14:15 | |
| TheJulia | oh fun | 14:15 |
| opendevreview | Julia Kreger proposed openstack/ironic master: provide host_id to neutron early on https://review.opendev.org/c/openstack/ironic/+/946378 | 14:51 |
| * cid updates Meetings wiki | 14:55 | |
| JayF | Who wants to run the meeting today? | 15:00 |
| opendevreview | Julia Kreger proposed openstack/ironic master: WIP: Patch configdrive metadata https://review.opendev.org/c/openstack/ironic/+/946677 | 15:01 |
| JayF | Are we even going to have a quorum today given it's Easter Monday? | 15:01 |
| JayF | #startmeeting ironic | 15:01 |
| opendevmeet | Meeting started Mon Apr 21 15:01:26 2025 UTC and is due to finish in 60 minutes. The chair is JayF. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:01 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:01 |
| opendevmeet | The meeting name has been set to 'ironic' | 15:01 |
| TheJulia | o/ | 15:01 |
| JayF | Going to see if we have enough folks to actually run this | 15:01 |
| TheJulia | Yeah, I'm assuming everyone EU based is away today | 15:01 |
| JayF | Same; it's likely valuable to hold off on any of the discussion of bugs and work items if it's just us | 15:02 |
| keekz | o/ | 15:02 |
| JayF | going to give until :05 for a quorrum to arrive and if not we cancel the meeting? | 15:02 |
| TheJulia | gerrit is also going down in an hour :( | 15:02 |
| cid | :) | 15:03 |
| JayF | cid: have you tried a version of your eventlet-wsgi-server-gone patch with eventlet + the monkey patch completely removed? | 15:03 |
| cardoe | I'm around | 15:04 |
| cid | JayF: Not yet | 15:04 |
| JayF | I'm so jazzed to see that pass any tests at all :) | 15:05 |
| JayF | okay it's :05, cores here are me, julia, cid, cardoe | 15:05 |
| JayF | I think I'm going to call it no quorum unless there's an objection | 15:05 |
| JayF | #info Most Ironic contributors in Europe are out today on holiday, did not have quorum for meeting. | 15:05 |
| JayF | Last call? | 15:06 |
| TheJulia | uhh | 15:06 |
| TheJulia | It would be good for some wider reviews on https://review.opendev.org/c/openstack/ironic-specs/+/945642 in terms of moving forward integrated network cases | 15:06 |
| JayF | #info Wider reviews needed on https://review.opendev.org/c/openstack/ironic-specs/+/945642 | 15:06 |
| JayF | I've read it multiple times, unsure if I've voted on it | 15:07 |
| JayF | I'll take a full-on review pass today | 15:07 |
| TheJulia | Thanks | 15:07 |
| JayF | TheJulia: no objection to closing the meeting with that note? | 15:07 |
| TheJulia | None | 15:07 |
| JayF | #endmeeting | 15:08 |
| opendevmeet | Meeting ended Mon Apr 21 15:08:00 2025 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:08 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/ironic/2025/ironic.2025-04-21-15.01.html | 15:08 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/ironic/2025/ironic.2025-04-21-15.01.txt | 15:08 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/ironic/2025/ironic.2025-04-21-15.01.log.html | 15:08 |
| JayF | cid: ima put a follow on patch to your eventlet patch ripping the rest out | 15:15 |
| JayF | cid: just as some science as to not derail you from the path of the patch that might actually merge :D | 15:16 |
| cid | ++ :) | 15:18 |
| opendevreview | Jay Faulkner proposed openstack/ironic-python-agent master: SCIENCE: Remove *ALL THE EVENTLET* https://review.opendev.org/c/openstack/ironic-python-agent/+/947744 | 15:19 |
| JayF | pushed so integration tests can run, gonna look at unit tests | 15:19 |
| keekz | i was looking to see 'clean failed' oslo notifications but looking at https://opendev.org/openstack/ironic/src/branch/master/ironic/conductor/utils.py the clean failed notifications only appear to be attached to power state changes. but i think some of the clean failed failure scenarios don't always change power state. i'd like to wedge in sending a clean failed notification when the cleaning actually fails but i'm not sure | 15:19 |
| keekz | sure where/how to do this. i'm thinking in https://opendev.org/openstack/ironic/src/branch/master/ironic/conductor/utils.py#L536 ? | 15:19 |
| JayF | unit tests are passing! | 15:20 |
| JayF | keekz: that seems wrong to me, we emit notifications on provision_state change don't we? | 15:20 |
| keekz | i'm just looking at notify_utils and it seems to be attached to power state changes | 15:22 |
| opendevreview | Julia Kreger proposed openstack/ironic master: WIP: Patch configdrive metadata https://review.opendev.org/c/openstack/ironic/+/946677 | 15:24 |
| JayF | I think some are automatic and some are not but I'm not 100% sure | 15:25 |
| TheJulia | That sounds like current state to me. I suspect there could/should maybe some explicit invocation in the cleaning failure case because the nodes are not actually powered off. Almost like we need an "emit_current_state" as an explicit call from the handler in that case | 15:27 |
| keekz | to give some context, we have automated cleaning enabled and sometimes the cleaning can fail. for example during a deploy of our dev environment where services get restarted a lot which can break interactions with other services. issuing a 're-clean' of the node by doing an `openstack baremetal node manage $node` then `openstack baremetal node provide $node` fixes it. i wrote a little argo workflows script to watch our oslo | 15:27 |
| keekz | notifications queue for clean failed events but that's where i'm having issues. maybe i'm not looking for clean failed events correctly | 15:27 |
| JayF | keekz: look at conductor task manager process_event | 15:27 |
| JayF | keekz: it sends a notification on any state change that doesn't have a callback | 15:27 |
| JayF | keekz: if you wanna change behavior, you may want to start there :) | 15:27 |
| TheJulia | keekz: so, I guess the thing I would be interested issue wise is why does it fail, and should/could that be a bug or opportunity for better error handling | 15:28 |
| keekz | we're using custom neutron plugins and experimenting a lot in our dev environment so things just fail a lot :) | 15:29 |
| TheJulia | Okay, as long as you know that is what the root cause is :) | 15:33 |
| keekz | i made this little script to dump the rabbitmq oslo notifications queue to help me find see/find events: https://github.com/rackerlabs/understack/tree/main/examples/openstack-notifications and i don't see 'clean failed' in the payload for any of the baremetal.node.provision_set.* event types | 15:44 |
| JayF | cid: this is passing CI holy crap | 15:56 |
| JayF | cid: only failure is pep8 and I'm about to push over that, but you may just wanna integrate my changes and see if we can de-eventlet ipa in one show | 15:56 |
| JayF | **shot | 15:56 |
| -opendevstatus- NOTICE: notice The Gerrit service on review.opendev.org is offline for a server replacement maintenance between 16:00-17:00 UTC today per https://lists.opendev.org/archives/list/service-announce@lists.opendev.org/message/D6VGKXHKXCV6TD6MFJY4H4KQBIM3AQYI/ | 16:00 | |
| opendevreview | Verification of a change to openstack/ironic master failed: Add several NV GPU types https://review.opendev.org/c/openstack/ironic/+/947213 | 16:01 |
| JayF | running an errand while gerrit is down, but going to look at logs for https://zuul.opendev.org/t/openstack/build/7d69a82b2c4d4d7da5a660064ead4fb3 to ensure nothing unexpected | 16:03 |
| JayF | I am completely buzzed about the possibility we've finally got IPA off eventlet | 16:03 |
| JayF | I guess I'll also check to make sure we don't need to change any settings to make Oslo libraries use non-eventlet methods | 16:04 |
| TheJulia | That is awesome | 16:07 |
| opendevreview | minwoo seo proposed openstack/ironic master: Add `api-call` action for ironic inspection rule https://review.opendev.org/c/openstack/ironic/+/946741 | 16:26 |
| okami | Hey, has anyone used Ironic with Skyline? Running into a couple of issue with bare metal instances and flavors as well as adding kernel and ramdisk images. | 16:31 |
| TheJulia | okami: Greetings, so none of the developers/maintainers of Ironic has, as far as I'm aware | 16:34 |
| TheJulia | JayF: did we conclusively reach a consensus eventlet was ironic/ipa/networking-baremetal/networking-generic-switch only ? | 16:34 |
| okami | TheJulia: Thanks, I will check in with the Skyline channel. | 16:38 |
| JayF | TheJulia: not 100% sure | 17:13 |
| TheJulia | I suspect at least broad stroke wise, those are the major items | 17:15 |
| opendevreview | Julia Kreger proposed openstack/ironic master: WIP: Patch configdrive metadata https://review.opendev.org/c/openstack/ironic/+/946677 | 18:28 |
| opendevreview | Julia Kreger proposed openstack/ironic master: WIP: Patch configdrive metadata https://review.opendev.org/c/openstack/ironic/+/946677 | 19:00 |
| opendevreview | Jay Faulkner proposed openstack/ironic-python-agent master: SCIENCE: Remove *ALL THE EVENTLET* https://review.opendev.org/c/openstack/ironic-python-agent/+/947744 | 19:29 |
| JayF | just fixed a pep8 issue, only reason it didn't V+1 | 19:29 |
| JayF | obviously we need to manually test the edges but this is exciting | 19:30 |
| TheJulia | very cool | 19:30 |
| opendevreview | Julia Kreger proposed openstack/ironic master: WIP: Patch configdrive metadata https://review.opendev.org/c/openstack/ironic/+/946677 | 19:44 |
| cardoe | For Science! | 20:12 |
| opendevreview | Julia Kreger proposed openstack/ironic master: WIP: Patch configdrive metadata https://review.opendev.org/c/openstack/ironic/+/946677 | 21:08 |
| JayF | I'm going to be making a PTG recap video public on the GR-OSS youtube channel in the next day or two; if anyone wants to (p)review feel free https://www.youtube.com/watch?v=TE5GDkPXJP8 | 21:48 |
| opendevreview | minwoo seo proposed openstack/ironic master: Add `api-call` action for ironic inspection rule https://review.opendev.org/c/openstack/ironic/+/946741 | 22:09 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!