| opendevreview | Adam McArthur proposed openstack/ironic-tempest-plugin master: Microversion Test Generator https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/937206 | 00:35 |
|---|---|---|
| opendevreview | Adam McArthur proposed openstack/ironic-tempest-plugin master: Testing bad microversions on v1/allocations https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/937213 | 00:35 |
| opendevreview | Adam McArthur proposed openstack/ironic-tempest-plugin master: Testing bad microversions on v1/nodes/{uuid}/firmware https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/937214 | 00:35 |
| *** ex_tnode6 is now known as ex_tnode | 00:38 | |
| *** ex_tnode5 is now known as ex_tnode | 03:04 | |
| opendevreview | cid proposed openstack/ironic master: [WIP] Migrates Inspector rules over to Ironic https://review.opendev.org/c/openstack/ironic/+/918303 | 07:58 |
| opendevreview | Michal Nasiadka proposed openstack/ironic-python-agent master: Add LVM based image support to MD scenario https://review.opendev.org/c/openstack/ironic-python-agent/+/816685 | 09:15 |
| opendevreview | Michal Nasiadka proposed openstack/ironic-python-agent master: Add LVM based image support to MD scenario https://review.opendev.org/c/openstack/ironic-python-agent/+/816685 | 09:40 |
| mnasiadka | good morning ironic | 09:46 |
| iurygregory | good morning Ironic | 11:08 |
| opendevreview | Verification of a change to openstack/ironic master failed: Handle Power On/Off for child node cases https://review.opendev.org/c/openstack/ironic/+/896570 | 13:42 |
| masghar | o/ | 14:00 |
| masghar | Should I add the ironic-week-prio hashtag to https://review.opendev.org/c/openstack/ironic/+/933151? | 14:00 |
| iurygregory | masghar, +W =) | 15:05 |
| iurygregory | seems like Actions for VirtualMedia wasn't a thing till 1.10.0 version... | 15:07 |
| iurygregory | and a customer has a machine with newer fw (it seems) that have VirtualMedia 1.0.2 https://redfish.dmtf.org/schemas/v1/VirtualMedia.v1_0_2.json <facepalm> | 15:08 |
| opendevreview | cid proposed openstack/ironic master: [WIP] Migrates Inspector rules over to Ironic https://review.opendev.org/c/openstack/ironic/+/918303 | 15:27 |
| opendevreview | Verification of a change to openstack/ironic master failed: Trivial deprecation fixes. https://review.opendev.org/c/openstack/ironic/+/936411 | 16:29 |
| opendevreview | Verification of a change to openstack/ironic master failed: CI: Detail job removal permission https://review.opendev.org/c/openstack/ironic/+/933151 | 16:39 |
| masghar | Thanks iurygregory! | 16:41 |
| JayF | metal3 did a release today | 16:44 |
| JayF | metal3-integration is broken for a bit as a result | 16:44 |
| JayF | no need to recheck unless you're sure it's fixed | 16:44 |
| JayF | basically there's some kinda brokenness in the release process where the release is created before it's actually uploaded (?) | 16:44 |
| dtantsur | JayF: yeah, I've never dived in depth, but there is a lag before all components (some of which are not even from metal3) snap into places | 16:49 |
| JayF | honestly everytime there's a release I want just a little bit more to make metal3-integration non-voting | 16:55 |
| JayF | because it's kinda crummy how much CI churn it causes us when those releases happen and break us | 16:55 |
| dtantsur | Let's open a discussion on the metal3 slack? Maybe this problem is solvable, the folks just did not realize it hurts us. | 16:58 |
| JayF | I posted a message. | 17:06 |
| dtantsur | Thx! | 17:09 |
| cardoe | So extending lines with a \ is a no no. I assume I can use parens? | 17:15 |
| cardoe | Also JayF that's why I was looking at extra ruff lints/checks. Cause I'll enable that one and the auto-reformatter won't use \ but other oslo/openstack projects don't have that enabled. | 17:15 |
| cardoe | Stupid question... there's no "easy button" boot this box into IPA for me for some troubleshooting? | 17:16 |
| dtantsur | I sometimes use \ but only in one specific patterns, namely after = | 17:16 |
| JayF | cardoe: I don't know what to assume; I am extremely against -1'ing patches for style so I don't know where that impression comes from | 17:16 |
| JayF | cardoe: so I'm actually not thrilled your patch got -1'd for something we don't lint against | 17:16 |
| dtantsur | I do try to avoid -1 for \ | 17:16 |
| JayF | cardoe: so I can't tell you the right thing to do, because my answer is "whatever lint says is ok" | 17:17 |
| dtantsur | unless it looks really, REALLY ugly | 17:17 |
| cardoe | JayF: your comment and rpittau's comment on https://review.opendev.org/c/openstack/ironic/+/937269/ | 17:17 |
| dtantsur | cardoe: re boot IPA: I usually use inspection with fast track for this purpose | 17:17 |
| JayF | cardoe: I explicitly said the same thing there? | 17:17 |
| JayF | cardoe: that I don't like negative reviews for style | 17:17 |
| cardoe | Well you changed your +2 to a +1 | 17:18 |
| cardoe | So I'm trying to figure out how to fix this to get back to a +2 | 17:18 |
| cardoe | The line was over our line length limit, so it broke the line | 17:18 |
| JayF | cardoe: to ensure you saw the negative vote, mainly. Also because I'd rather us come to a consensus than it get merged over someones' objection | 17:20 |
| opendevreview | Merged openstack/ironic master: Handle Power On/Off for child node cases https://review.opendev.org/c/openstack/ironic/+/896570 | 17:21 |
| cardoe | huzzah! that one has been bouncing around for a while. | 17:22 |
| JayF | does that mean metal3-integration is happy now? | 17:23 |
| JayF | or did the metal3 job finish before that release hit | 17:23 |
| cardoe | I agree. I just don't know how to progress that patch forward. What's the acceptable style and I'll fix it up. The default from ruff is to use a \ to break a long line if it's clean. I'll change that default to parens was my idea. | 17:23 |
| JayF | it ran post-metal3-release so I think that's a sign things are happy | 17:23 |
| dtantsur | JayF: Completed at 2024-12-19 16:37:23 | 17:23 |
| JayF | yep, and the release was at ~1300 UTC if slack is to be believed | 17:24 |
| dtantsur | the announcement always comes somewhat after the actual release, so yeah | 17:24 |
| opendevreview | Verification of a change to openstack/ironic master failed: CI: Detail job removal permission https://review.opendev.org/c/openstack/ironic/+/933151 | 18:01 |
| opendevreview | Verification of a change to openstack/ironic master failed: CI: Detail job removal permission https://review.opendev.org/c/openstack/ironic/+/933151 | 18:52 |
| opendevreview | cid proposed openstack/ironic master: [WIP] Migrates Inspector rules over to Ironic https://review.opendev.org/c/openstack/ironic/+/918303 | 20:57 |
| opendevreview | Merged openstack/ironic master: CI: Detail job removal permission https://review.opendev.org/c/openstack/ironic/+/933151 | 21:06 |
| opendevreview | Julia Kreger proposed openstack/ironic master: CI: Remove legacy metalsmith job https://review.opendev.org/c/openstack/ironic/+/933152 | 21:41 |
| opendevreview | cid proposed openstack/ironic master: [WIP] Migrates Inspector rules over to Ironic https://review.opendev.org/c/openstack/ironic/+/918303 | 22:01 |
| opendevreview | cid proposed openstack/ironic master: [WIP] Migrates Inspector rules over to Ironic https://review.opendev.org/c/openstack/ironic/+/918303 | 22:04 |
| opendevreview | cid proposed openstack/ironic master: [WIP] Migrates Inspector rules over to Ironic https://review.opendev.org/c/openstack/ironic/+/918303 | 23:07 |
| opendevreview | Jay Faulkner proposed openstack/ironic master: WIP: Migrate ironic_lib to ironic https://review.opendev.org/c/openstack/ironic/+/937948 | 23:52 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!