| opendevreview | Takashi Kajinami proposed openstack/metalsmith master: Drop reference to removed services https://review.opendev.org/c/openstack/metalsmith/+/935475 | 03:57 |
|---|---|---|
| milad | hello friends I hope everyone is doing well. I've been adding the ironic service to OpenStack for a while now and I've been challenged. Can anyone guide me or provide me with a good document? | 08:13 |
| *** dmellado0755391 is now known as dmellado075539 | 08:34 | |
| ykarel | rpittau, TheJulia if you can check again https://review.opendev.org/c/openstack/ironic/+/934036 | 08:37 |
| dtantsur | JayF: I think the priority list is solid, thank you! | 10:56 |
| dtantsur | JayF: ARM IPA is published under IPA-builder because it's sorta experimental. If we now have a CI where these images are validates, we can talk about promoting them. | 10:57 |
| dtantsur | them/it/y'know | 10:57 |
| dtantsur | (still morning for me) | 10:57 |
| dtantsur | iurygregory: good morning. A quick review needed if you're around: https://review.opendev.org/c/openstack/bifrost/+/928895 | 11:21 |
| iurygregory | dtantsur, sure | 11:26 |
| iurygregory | good morning Ironic | 11:26 |
| opendevreview | Merged openstack/bifrost master: Add support for Ubuntu 24.04 https://review.opendev.org/c/openstack/bifrost/+/928895 | 13:27 |
| TheJulia | good morning | 13:55 |
| opendevreview | Verification of a change to openstack/ironic stable/2023.1 failed: [Stable Only] pin virtualbmc/sushy-tools/ironic-tempest-plugin to last released tag https://review.opendev.org/c/openstack/ironic/+/934036 | 13:59 |
| TheJulia | ykarel: 2024-11-18 13:40:23.182068 | controller | ERROR: Package 'neutron' requires a different Python: 3.8.10 not in '>=3.9' in the job logs <-- given https://github.com/openstack/neutron/blob/stable/2023.1/setup.cfg, I can't help but wonder if something else is going on | 14:27 |
| frickler | stable/2023.1 is gone for neutron and a lot of other repos | 14:34 |
| TheJulia | ugh | 14:35 |
| TheJulia | so there goes stable branch testing | 14:35 |
| frickler | so zuul uses the default branch instead for required_projects, which is master | 14:36 |
| frickler | any reason you didn't change to unmaintained yet? | 14:37 |
| TheJulia | no idea, I didn't realize they changed | 14:38 |
| ykarel | yeap fallback to master triggered these failures, i noticed similar failures in neutron periodics for glance | 14:38 |
| ykarel | there is open patch for ironic to transition to unmaintained https://review.opendev.org/c/openstack/releases/+/934476 | 14:39 |
| ykarel | same for many other projects https://review.opendev.org/q/topic:%22antelope-unmaintained%22+status:open | 14:41 |
| JayF | Jfyi: I will miss the meeting. My wife's car broke down and I have to take her to her job. | 14:50 |
| TheJulia | ack | 14:52 |
| TheJulia | #startmeeting ironic | 15:01 |
| opendevmeet | Meeting started Mon Nov 18 15:01:03 2024 UTC and is due to finish in 60 minutes. The chair is TheJulia. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:01 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:01 |
| opendevmeet | The meeting name has been set to 'ironic' | 15:01 |
| TheJulia | o/ | 15:01 |
| iurygregory | o/ | 15:01 |
| kubajj | o/ | 15:01 |
| cid | o/ | 15:01 |
| cardoe | \o | 15:01 |
| * iurygregory wondering if we will have quorum | 15:02 | |
| TheJulia | Hmm, this is feeling like on critical mass | 15:02 |
| dtantsur | o/ | 15:02 |
| TheJulia | We really don't have much on the agenda | 15:03 |
| TheJulia | ... if the save ever finishes :) | 15:03 |
| TheJulia | #topic Announcements / Reminders | 15:04 |
| TheJulia | Standing reminder to review patches tagged ironic-week-prio and to hashtag any patches ready for review with ironic-week-prio: https://tinyurl.com/ironic-weekly-prio-dash | 15:04 |
| TheJulia | 2025.1 Epoxy Release Schedule https://releases.openstack.org/epoxy/schedule.html | 15:04 |
| TheJulia | And since we're starting to get our way into the beginning of the epoxy schedule, please take a few minutes and review spec changes! | 15:05 |
| TheJulia | #link https://review.opendev.org/q/project:openstack/ironic-specs+and+status:open | 15:05 |
| TheJulia | Since we have no discussion topics listed today, who was the bug deputy for the last week? | 15:06 |
| cid | JayF was. And I can take it for the week. | 15:07 |
| TheJulia | #action cid to be the bug deputy for this week, Thanks cid! | 15:07 |
| TheJulia | Since Jay had to step away, I guess no bug update this week. | 15:08 |
| TheJulia | I guess that means it is time for Open Discussion! | 15:08 |
| TheJulia | #topic Open Discussion | 15:08 |
| TheJulia | Anyone have anything? | 15:08 |
| * TheJulia gets out a giant "review specs" sign | 15:09 | |
| * dtantsur has nothing | 15:09 | |
| TheJulia | Well, if there is nothing else, I'll end the meeting in a minute. | 15:10 |
| TheJulia | Thanks everyone! | 15:11 |
| TheJulia | #endmeeting | 15:11 |
| opendevmeet | Meeting ended Mon Nov 18 15:11:42 2024 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:11 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/ironic/2024/ironic.2024-11-18-15.01.html | 15:11 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/ironic/2024/ironic.2024-11-18-15.01.txt | 15:11 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/ironic/2024/ironic.2024-11-18-15.01.log.html | 15:11 |
| TheJulia | I need to send out the networking meeting and make appropriate changes | 15:12 |
| opendevreview | Merged openstack/ironic master: Add support for Ubuntu 24.04 https://review.opendev.org/c/openstack/ironic/+/934150 | 15:20 |
| cardoe | So only post meeting asking, how would you folks feel about some of the pre-commit changes? How would you feel if I used ruff over pep8 and bandit? What's our line length target? 79? | 15:21 |
| cardoe | oh and using pyupgrade to upgrade to our minimum supported Python | 15:21 |
| cardoe | And we prefer single quotes? | 15:27 |
| cardoe | I'm trying to figure out where we differ from black to create a black config. | 15:27 |
| TheJulia | the existing hacking lint checks enforce line length, afaik | 15:28 |
| cardoe | yeah at 79 | 15:29 |
| cardoe | It's really just running flake8 | 15:29 |
| TheJulia | yeah | 15:29 |
| dtantsur | Black can be really annoying IMO | 15:29 |
| cardoe | Just seeing if I can't make stuff match. | 15:29 |
| dtantsur | I was thinking about periodically running pyupgrade as well, btw | 15:30 |
| cardoe | I'm starting on sushy. | 15:30 |
| TheJulia | Quote wise, there was talk of changing something last year style wise which would have leaned into double quoting, I don't remember what that was anymore | 15:30 |
| dtantsur | I'd not mind settling down on one style | 15:30 |
| dtantsur | Single quotes are easier to type :) | 15:30 |
| dtantsur | Where I don't like black is enforcing the way line breaks are done too aggressively | 15:31 |
| cardoe | So some places we've set a longer line length somehow. | 15:31 |
| dtantsur | (and I think its defaults are not compatible with PEP8) | 15:31 |
| cardoe | And then quotes seem to be mostly single but there's a lot of double. | 15:31 |
| opendevreview | Doug Goldstein proposed openstack/sushy master: enable pyupgrade via ruff to Python 3.9 https://review.opendev.org/c/openstack/sushy/+/934916 | 15:32 |
| JayF | I have zero preference about what to choose. It must be enforced in pre-commit though or else my quality of life will degrade significantly 😂 | 15:32 |
| TheJulia | As long as CI enforces it as well... | 15:32 |
| JayF | Everything pre-commit runs automatically runs in our lint job the way everything is structured now | 15:34 |
| JayF | And it saves me from the embarrassment of pushing a patch with lint failures | 15:34 |
| TheJulia | Really? We are after all, only human. | 15:34 |
| TheJulia | imperfection/flaw/mutation is in our DNA, literally :) | 15:35 |
| cardoe | JayF: So I agree with you with ONE caveat. I want pre-commit to AUTOFIX where possible. Don't make me reformat stupid whitespace manually when a tool can do it. | 15:39 |
| cardoe | dtantsur: https://review.opendev.org/c/openstack/sushy/+/934916 that's doing pyupgrade via ruff. | 15:39 |
| cardoe | So I'm using bandit via ruff. There's some differences. | 15:39 |
| cardoe | With sushy there isn't but with the ironic repo there is. | 15:39 |
| * TheJulia fears increased backport pain in the future | 15:40 | |
| cardoe | TheJulia: I agree with you. I don't wanna regularly drag us up with pyupgrade but there are some things we need to do. | 15:40 |
| cardoe | We've got a bunch of Python 2.x syntax that goes away in 3.14 in sushy. | 15:40 |
| cardoe | So I dragged us up to Python 3.9 in that patch. | 15:41 |
| cardoe | What it's doing now is that if you write some syntax that's older syntax, it'll automatically update you to Python 3.9 | 15:41 |
| cardoe | I would like to drag us up to Python 3.10 and then stay there for a while. So I can add typing across the board. | 15:41 |
| cardoe | After 3.10 all the syntax changes are just ergonomic and not functional. | 15:42 |
| cardoe | CPython changed its parser in 3.9 I think? | 15:44 |
| cardoe | I also had some asks on changes like... https://review.opendev.org/c/openstack/sushy/+/934911/1 | 15:44 |
| cardoe | I don't want the blanket allow those issues so I used "noqa". Currently in the ironic repo we blanket allow that but it seems dangerous. | 15:45 |
| dtantsur | cardoe: are we going to fail CI if somebody uses an old syntax? | 15:45 |
| TheJulia | yeah, I'm just worried about lots of whitespace and quoteation mark changes since that is going to turn backports into patch rewrites past the boundry which will be lots of pain | 15:46 |
| dtantsur | if so, we should be really conservative with the baseline version | 15:46 |
| dtantsur | yeah, backports | 15:46 |
| TheJulia | but, the show must go on | 15:46 |
| cardoe | dtantsur: yeah you would fail CI if someone uses old syntax. | 15:47 |
| dtantsur | cardoe: then master should use the older Python version on *any* branch as the baseline | 15:47 |
| dtantsur | the oldest | 15:47 |
| cardoe | agreed | 15:47 |
| cardoe | I can set it to Python 3.6 syntax if ya want? | 15:48 |
| dtantsur | are there any branches with 3.6 still alive? If yes, then please do | 15:48 |
| cardoe | Just there's been a change in CPython's ast parser in 3.9 I think and it fully landed in 3.10 | 15:48 |
| cardoe | I just checked, Python 3.15 is where some old syntaxes go away. | 15:49 |
| dtantsur | Looking at your patch, f-strings is the newest feature you use, and it was in 3.6 already | 15:49 |
| dtantsur | wow, 81 file, gonna get tired.. | 15:50 |
| dtantsur | if you ever do this for Ironic, please don't do all files at once :D | 15:51 |
| JayF | cardoe: Yes-ish? As long as CI still is angry when it runs and there's things to fix :) | 15:51 |
| cardoe | dtantsur: I'll break it up however you guys wish. That's why I started with this sushy patch set. I'm looking for feedback on how you want me to approach it. | 15:52 |
| JayF | using the oldest-still-supported python version on *any* ironic branch is a nice approach to that | 15:52 |
| JayF | TheJulia: those human flaws is *exactly* why we have to have robots do this stuff :D | 15:53 |
| cardoe | So like https://review.opendev.org/c/openstack/sushy/+/934911/1 is me breaking out the change for the one error and explaining just that one change. | 15:53 |
| cardoe | Similarly here https://review.opendev.org/c/openstack/sushy/+/934912/1 | 15:53 |
| dtantsur | I've spotted one place that I'd personally never do.. if gerrit lets me comment, I'll explain | 15:53 |
| cardoe | And then the next commit https://review.opendev.org/c/openstack/sushy/+/934913/1 enables enforcement since it's now passing. | 15:54 |
| dtantsur | f'"enabled" value.*{list(sushy.BootSourceOverrideEnabled)}' | 15:54 |
| dtantsur | I hope this works, but I'd hate to be forced to write it | 15:54 |
| dtantsur | I wonder if we can ask the f-strings migration (which is good IMO) to limit itself to the simplest cases | 15:54 |
| cardoe | I can hand rewrite it better. | 15:54 |
| cardoe | It tries to infer from the types. | 15:55 |
| JayF | yeah that's some of the trick with black and similar tools | 15:55 |
| dtantsur | not if you enforce it in the CI? | 15:55 |
| JayF | it may pick a crappy way of doing it | 15:55 |
| JayF | but if you do it /manually/ it won't change it back | 15:55 |
| JayF | around those awful edge cases | 15:55 |
| cardoe | Exactly. | 15:55 |
| dtantsur | ah, it won't? | 15:55 |
| cardoe | Nope | 15:55 |
| cardoe | As long as you use a f-string. | 15:55 |
| JayF | basically if it sees a line too long, it'll shorten it, sometimes stupidly | 15:55 |
| JayF | (e.g.) | 15:55 |
| JayF | but you can shorten it sanely and it'll leave it be | 15:55 |
| JayF | I've yet to find a case where it insisted on the bad way after a manual fix; but I would never assume that case doesn't exist :) | 15:56 |
| dtantsur | cardoe: done with comments | 15:56 |
| dtantsur | my personal preference would be do use f-strings for any variables or properties but avoid them when functions are involved | 15:57 |
| cardoe | I'm happy to keep tweaking the config rules. | 16:00 |
| cardoe | So biggest question... everyone okay with using ruff where possible? | 16:00 |
| dtantsur | As long as we expect an average contributor to be able to install it.. | 16:01 |
| cardoe | TheJulia, rpittau, dtantsur, JayF, iurygregory, cid: ^ | 16:01 |
| JayF | that has 100% been my statement the whole time | 16:01 |
| JayF | it's gotta have packages everywhere | 16:02 |
| JayF | Gentoo has an ebuild for it and if it didn't I'd self serve | 16:02 |
| cardoe | It's run and installed via pre-commit | 16:02 |
| cardoe | you can "pip install ruff" | 16:02 |
| cardoe | Only complaint I've gotten from the orney Xen folks have been that "pip install ruff" didn't work on someone's OpenRISC board. | 16:04 |
| dtantsur | :D | 16:04 |
| dtantsur | If it needs Rust, we might want to update our contributor guide. Maybe link to rustup or any official page. | 16:04 |
| cardoe | It doesn't. | 16:04 |
| cardoe | If you're okay with using a binary build. | 16:04 |
| cardoe | It ships binaries via Python wheels. | 16:05 |
| JayF | I agree we should at least update contributor docs to reference this | 16:05 |
| dtantsur | If :) | 16:05 |
| JayF | we have a really good doc on our tox targets and unit tests | 16:05 |
| JayF | (I (re)wrote it last year) | 16:05 |
| cardoe | I'll happily update the docs. | 16:05 |
| JayF | I'd strongly prefer that not bitrot :D | 16:05 |
| dtantsur | I definitely remember some people pissed at cryptography for having rust dependencies because wheels were not installable everywhere | 16:05 |
| JayF | dtantsur: cryptography mainly blazed those trails for everyone else | 16:06 |
| dtantsur | true | 16:06 |
| cardoe | I've been fixing them (the contributor docs) as me and our folks hit stuff. | 16:06 |
| dtantsur | And yet, something like "If it complains about missing rustc or cargo, look here: <link>" | 16:06 |
| cardoe | It's just Jay trying to revert my fixes in his postgres clean ups... ;) | 16:06 |
| dtantsur | That Jay!! | 16:07 |
| JayF | I'm specifically thinking about https://docs.openstack.org/ironic/latest/contributor/dev-quickstart.html#unit-testing-environment | 16:07 |
| JayF | re: docs to update | 16:08 |
| opendevreview | Merged openstack/ironic master: Fix policy checks added with runbooks https://review.opendev.org/c/openstack/ironic/+/935230 | 16:12 |
| opendevreview | Doug Goldstein proposed openstack/ironic stable/2024.2: Fix policy checks added with runbooks https://review.opendev.org/c/openstack/ironic/+/935530 | 16:13 |
| opendevreview | Doug Goldstein proposed openstack/ironic stable/2024.2: Fix policy checks added with runbooks https://review.opendev.org/c/openstack/ironic/+/935530 | 16:13 |
| cardoe | I would super duper appreciate a quick +1 on ^ | 16:15 |
| Pcmalih_ | Hi, In our baremetal machine PXE booting use case, controller and compute seems to exchange following message but no further communication happening. Controller send Discover broadcast message Compute send Request message Controller send Request message Compute send ACK No further TFTP boot communication | 16:39 |
| JayF | Just a slight update: itamar is still looking at SNMP support, and is basically running into eventlet migration bits (since pysnmp is asyncio now, and loading it into Ironic causes pain) | 17:31 |
| JayF | as he put it he's gonna "pop another yak on the stack" and dig into those now | 17:31 |
| dtantsur | eventlet-- | 17:36 |
| opendevreview | Jay Faulkner proposed openstack/ironic stable/2024.2: [stable-only] [ci] Remove metal3 job https://review.opendev.org/c/openstack/ironic/+/935549 | 17:49 |
| JayF | cardoe: ^ your patch to stable ain't going anywhere without that :D | 17:50 |
| opendevreview | Merged openstack/ironic master: trivial: remove libpq from bindep file https://review.opendev.org/c/openstack/ironic/+/935226 | 18:18 |
| opendevreview | Doug Goldstein proposed openstack/ironic master: Task Manager: Log if the lock takes too long https://review.opendev.org/c/openstack/ironic/+/892412 | 19:35 |
| opendevreview | Merged openstack/ironic stable/2024.2: [stable-only] [ci] Remove metal3 job https://review.opendev.org/c/openstack/ironic/+/935549 | 21:02 |
| opendevreview | Doug Goldstein proposed openstack/ironic stable/2024.2: Fix policy checks added with runbooks https://review.opendev.org/c/openstack/ironic/+/935530 | 21:13 |
| TheJulia | jeeze where has the day gone | 21:22 |
| TheJulia | JayF: hopefully not a literal yak. :) | 21:23 |
| JayF | I told him to oil his shears | 21:26 |
| TheJulia | ... eek | 21:27 |
| adamcarthur5 | Hey stephenfin, I was looking at https://review.opendev.org/c/openstack/ironic/+/928920/3, and was wondering if you think we could get it merged just for shard now? You have it marked as WIP, and I see you've written "We do not use any of the new code yet", but for v1/shard, I think it is being used unless I am mistaken? And then your comment on | 21:46 |
| adamcarthur5 | needing a "new mechanism", I am assuming that is the schema you have started writing in /api/schemas + what you do in nova, like https://opendev.org/openstack/nova/src/commit/1acaf899a6964484e5b5be4337618ebbe6ca8dbb/nova/api/openstack/compute/schemas/attach_interfaces.py | 21:46 |
| adamcarthur5 | TLDR, Unless you have objections, I'd like to remove the WIP and get some reviews going on this change specifically. | 21:46 |
| adamcarthur5 | And I think I have a clear idea of how to do further changes, starting with allocations as you have | 21:47 |
| opendevreview | Pierre Riteau proposed openstack/tenks stable/2.0: CI: Use 2024.1 requirements on stable/2.0 branch https://review.opendev.org/c/openstack/tenks/+/935567 | 21:54 |
| TheJulia | A quick review on https://review.opendev.org/c/openstack/networking-baremetal/+/933149 would be appreciated | 22:01 |
| *** dmellado0755393 is now known as dmellado075539 | 22:09 | |
| opendevreview | Verification of a change to openstack/ironic-python-agent bugfix/9.9 failed: Inspect non-raw images for safety https://review.opendev.org/c/openstack/ironic-python-agent/+/927984 | 22:21 |
| opendevreview | Merged openstack/networking-generic-switch master: Add note about requirements lower bounds https://review.opendev.org/c/openstack/networking-generic-switch/+/933528 | 22:22 |
| opendevreview | Verification of a change to openstack/networking-generic-switch stable/2023.2 failed: Do not make actual device changes in bind_port() https://review.opendev.org/c/openstack/networking-generic-switch/+/896112 | 22:22 |
| opendevreview | Merged openstack/ironic-tempest-plugin master: Testing microversions on v1/shards https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/935219 | 22:55 |
| opendevreview | Verification of a change to openstack/ironic stable/2024.2 failed: Gracefully handle bad request exception https://review.opendev.org/c/openstack/ironic/+/933036 | 22:55 |
| opendevreview | Doug Goldstein proposed openstack/ironic master: Task Manager: Log if the lock takes too long https://review.opendev.org/c/openstack/ironic/+/892412 | 23:41 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!