| opendevreview | Jay Faulkner proposed openstack/ironic master: Remove postgresql testing and documentation https://review.opendev.org/c/openstack/ironic/+/931055 | 01:03 |
|---|---|---|
| cardoe | I haven’t gotten in front of a computer yet Jay but I’ll revert it in the morning. | 01:21 |
| rpittau | good morning ironic! o/ | 07:22 |
| opendevreview | Riccardo Pittau proposed openstack/sushy-tools master: Minor docs changes for better readability and consistency https://review.opendev.org/c/openstack/sushy-tools/+/932496 | 09:06 |
| opendevreview | Riccardo Pittau proposed openstack/sushy-tools master: Minor docs changes for better readability and consistency https://review.opendev.org/c/openstack/sushy-tools/+/932496 | 09:07 |
| rpittau | ^ this is just a rebase | 09:13 |
| opendevreview | Merged openstack/sushy master: switch to pre-commit https://review.opendev.org/c/openstack/sushy/+/929704 | 09:58 |
| opendevreview | Merged openstack/python-ironicclient master: Add tests for OSC baremetal chassis create command https://review.opendev.org/c/openstack/python-ironicclient/+/382496 | 10:08 |
| opendevreview | Merged openstack/python-ironicclient master: Remove Functional Tests https://review.opendev.org/c/openstack/python-ironicclient/+/933967 | 10:08 |
| dtantsur | cid, JayF, good morning. Let me know when you want to talk today so that I can make my plans for the afternoon. | 10:33 |
| opendevreview | Dmitry Tantsur proposed openstack/ironic-tempest-plugin master: Use the correct exception when checking for HTTP 406 https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/934650 | 10:38 |
| dtantsur | rpittau: could you fast-track the CI fix ^^ | 10:38 |
| dtantsur | has been approved previously but failed on pep8 (see the diff) | 10:38 |
| rpittau | yep done! :) | 10:38 |
| dtantsur | thx | 10:38 |
| cid | dtantsur, Good ironic. I'm available all the way till 20:00 pm UTC today. We just need to know when JayF will be. | 10:44 |
| opendevreview | Derek Higgins proposed openstack/ironic master: Allow setting of disable_power_off via API https://review.opendev.org/c/openstack/ironic/+/934740 | 11:28 |
| opendevreview | Derek Higgins proposed openstack/python-ironicclient master: Add support to set 'disable_power_off' https://review.opendev.org/c/openstack/python-ironicclient/+/934741 | 11:29 |
| opendevreview | Riccardo Pittau proposed openstack/ironic master: Add support for Ubuntu 24.04 https://review.opendev.org/c/openstack/ironic/+/934150 | 11:39 |
| dtantsur | cid: let's tentatively aim for 1500 UTC and see if JayF makes it? | 12:35 |
| cid | ++ | 12:39 |
| dtantsur | cid: good. Just to check my sanity: we're going to talk about inspection rules, right? | 12:45 |
| cid | Indeed | 13:21 |
| dtantsur | Cool, my sanity is still with me :) | 13:23 |
| dtantsur | Posted some new comments (thank you for addressing the previous ones). Please check before the meeting. | 13:23 |
| cid | I just did. Thanks for the feedback. I'd see if I can push an update before our meet. | 13:56 |
| opendevreview | Merged openstack/ironic-tempest-plugin master: Use the correct exception when checking for HTTP 406 https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/934650 | 14:14 |
| dtantsur | yay, CI! | 14:14 |
| opendevreview | Merged openstack/sushy-tools master: Minor docs changes for better readability and consistency https://review.opendev.org/c/openstack/sushy-tools/+/932496 | 14:18 |
| rpittau | ubuntu noble support looking good, except for some weird fail in the cover test https://review.opendev.org/c/openstack/ironic/+/934150 | 14:24 |
| rpittau | mmm that's actually still on jammy :/ | 14:25 |
| opendevreview | Dmitry Tantsur proposed openstack/ironic master: [WIP] Inspection: account for disable_power_off https://review.opendev.org/c/openstack/ironic/+/934233 | 14:42 |
| cid | dtantsur, according to UTC, our meet is in 7? | 14:54 |
| dtantsur | cid: correct. No JayF in sight yet? | 14:54 |
| cid | Nop. let me ping him on slack | 14:54 |
| cid | Also not active on slack | 14:54 |
| TheJulia | Good morning | 14:56 |
| dtantsur | cid: let's replan to 1600 UTC? (in an hour) | 14:56 |
| dtantsur | morning TheJulia | 14:56 |
| * cid updates calendar | 14:57 | |
| JayF | I'm here-ish | 14:58 |
| dtantsur | up to you guys then | 14:58 |
| JayF | If y'all will start up and Link a video chat, like a meet pad or something, I'll be there in 5 minutes or less | 14:58 |
| JayF | I just need to grab myself a drink and power up the PC | 14:59 |
| dtantsur | cid: your choice ^^ | 14:59 |
| cid | Google meet, if that's fine. | 15:02 |
| dtantsur | Totally, just give us a link | 15:03 |
| cid | Sure thing, one sec | 15:03 |
| cid | https://meet.google.com/zeh-ghnq-wih | 15:04 |
| * dtantsur trying to join, knock-knock | 15:05 | |
| opendevreview | Julia Kreger proposed openstack/ironic-specs master: Move graphical vnc console interface to retired status https://review.opendev.org/c/openstack/ironic-specs/+/933937 | 15:37 |
| TheJulia | Just FYI on ^, got dinged on two typos so should be good to merge now | 15:51 |
| JayF | https://review.opendev.org/c/openstack/ironic-specs/+/934092 can we get this landable? | 16:16 |
| TheJulia | I'm all for lazy-consensusing it | 16:21 |
| cardoe | So what's the best gerrit way to restore a prior patch? | 16:23 |
| cardoe | Also JayF | 16:23 |
| TheJulia | cardoe: what do you mean by restore? | 16:23 |
| TheJulia | cardoe: also, maybe a link might help :) | 16:23 |
| cardoe | Before ya touch specs... https://review.opendev.org/c/openstack/ironic-specs/+/934538 and https://review.opendev.org/c/openstack/ironic-specs/+/934539 | 16:23 |
| JayF | this is about your patch | 16:24 |
| JayF | fwiw | 16:24 |
| JayF | cardoe and I were disagreeing on locking for parent/child node stuff | 16:24 |
| cardoe | https://review.opendev.org/c/openstack/ironic/+/896570 wanna restore that to patch 10. | 16:24 |
| cardoe | I wouldn't say disagreement. I misunderstood. | 16:24 |
| JayF | I think git review -d 123456/1 would work | 16:24 |
| TheJulia | you have to checkout that explicit rev | 16:24 |
| JayF | for patchset 1 of 123456 | 16:24 |
| cardoe | ah perfect. | 16:24 |
| JayF | then you just push it as a new patchset | 16:24 |
| TheJulia | and re-push it as an update | 16:24 |
| TheJulia | typically just a rebase will also work | 16:25 |
| JayF | cardoe: don't assume you misdunderstand because we disagree, fwiw :D | 16:25 |
| rpittau | ubuntu noble support in bifrost and ironic are green \o/ https://review.opendev.org/c/openstack/bifrost/+/928895 https://review.opendev.org/c/openstack/ironic/+/934150 | 16:25 |
| TheJulia | but it will squash the delta between the old version and current versus master | 16:25 |
| JayF | I often ask questions outta ignorance and wanting to make sure we checked all the boxes :) | 16:25 |
| opendevreview | Merged openstack/ironic-specs master: Move graphical vnc console interface to retired status https://review.opendev.org/c/openstack/ironic-specs/+/933937 | 16:26 |
| rpittau | good night! o/ | 16:48 |
| opendevreview | Doug Goldstein proposed openstack/ironic master: Handle Power On/Off for child node cases https://review.opendev.org/c/openstack/ironic/+/896570 | 17:28 |
| cardoe | finally it stopped being moody | 17:28 |
| TheJulia | heh | 18:01 |
| cardoe | https://review.opendev.org/c/openstack/ironic-specs/+/934538 and https://review.opendev.org/c/openstack/ironic-specs/+/934539 before ya typo heathens typo more in the specs! | 18:04 |
| opendevreview | Verification of a change to openstack/ironic master failed: Use patched dnsmasq from PPA https://review.opendev.org/c/openstack/ironic/+/933104 | 18:40 |
| TheJulia | cardoe: maximum typo users, tyvm ;) | 18:52 |
| opendevreview | Merged openstack/ironic-specs master: switch lints to using pre-commit https://review.opendev.org/c/openstack/ironic-specs/+/934538 | 19:21 |
| opendevreview | Merged openstack/ironic-specs master: add codespell to run via pre-commit https://review.opendev.org/c/openstack/ironic-specs/+/934539 | 19:24 |
| TheJulia | hmmm kvmip | 19:34 |
| opendevreview | Verification of a change to openstack/ironic master failed: Use patched dnsmasq from PPA https://review.opendev.org/c/openstack/ironic/+/933104 | 20:53 |
| JayF | we are getting 403s in CI hitting centos for 4k job | 21:27 |
| JayF | https://www.irccloud.com/pastebin/v6K2NLjS/ | 21:27 |
| JayF | fungi and/or clarkb is there some way we could cache that required base image? | 21:28 |
| JayF | I guess I assume (with minimal evidence) we're being rate limited based on not getting a 403 from that URL myself | 21:28 |
| * JayF rechecked the impacted job with a relevant comment | 21:29 | |
| fungi | we do cache some cirros images on our job nodes because they're used by a bunch of devstack jobs | 21:30 |
| fungi | what's the file size? | 21:30 |
| cardoe | JayF: that's your PPA build right? | 21:33 |
| JayF | cardoe: aye | 21:33 |
| cardoe | okay I just dug through the logs and saw the same thing but wasn't wanting to say "there's another one!" if it was the same one. | 21:34 |
| JayF | Length: 1288241152 (1.2G) [application/octet-stream] | 21:34 |
| cardoe | You can see I've been trying to hoax it in all weekend. | 21:34 |
| JayF | yeah honestly it'd be nice if in the future you'd put why it's being rechecked, I'd been able to see at a glance if this is broken everywhere | 21:34 |
| JayF | plus when gate is unhappy the QA folks start pulling "recheck without reasons" numbers and give you a nasty look if your project has big numbers there :D | 21:35 |
| cardoe | sorry. will do. | 21:35 |
| JayF | I appreciate you trying to kick the things through the gate though :D | 21:36 |
| JayF | I just think we have some systemmatic things we need to stomp out; this 1.2G centos image being cached is (potentially) one we can resolve | 21:36 |
| cardoe | I was backpacking this weekend and literally every time I stopped for a break I was looking at a handful of tickets. | 21:36 |
| JayF | just instead next time ... enjoy nature :) | 21:36 |
| JayF | (and if this file is not cachable, we could maybe find a way to implement retries) | 21:36 |
| cardoe | can't I have been in a binary forest? just trying to keep the ones and zeroes happy | 21:37 |
| JayF | not if you had a backpack | 21:37 |
| JayF | instead of a flatpak or tarball | 21:37 |
| JayF | gottem | 21:37 |
| cardoe | Now I'm gonna tell folks when I'm packing that I'm making a tarball so I can flatpak it. | 21:41 |
| JayF | flatpak exists in real life | 21:43 |
| JayF | those space bags you hook your vacuum up to :D | 21:43 |
| opendevreview | Verification of a change to openstack/ironic master failed: Use patched dnsmasq from PPA https://review.opendev.org/c/openstack/ironic/+/933104 | 21:49 |
| JayF | fungi: dunno if you missed the response; but 1.2G | 21:58 |
| fungi | JayF: thanks, yeah i don't have this channel set to highlight on activity alone and have a lot of irons in the fire, so the mention helps ;) | 21:59 |
| JayF | that's on-brand | 22:00 |
| JayF | hiyyyoooooooooooooooooooooooooo | 22:00 |
| cardoe | JayF: I'm gonna baseline to these versions... https://review.opendev.org/c/openstack/ironic/+/934537 if that's okay | 22:00 |
| JayF | why remove [rst] from doc8? | 22:00 |
| fungi | 1.2g seems a bit large to embed in all our images, since that would represent somewhere around a 5-10% increase in image sizes. might be good to consider some alternatives like caching it in our mirror network instead | 22:01 |
| cardoe | Cause that's overriding what's provided in their (doc8's) pre-commit config as to what they support. | 22:01 |
| cardoe | er sorry sphinx-lint | 22:01 |
| cardoe | bandit can get scrubbed too but I'm working on that in a follow on using ruff. | 22:03 |
| cardoe | Which is like 6000x faster but has a lot more rules enabled by default. | 22:03 |
| JayF | fungi: that's what I was asking: mirroring it, I may have not used the right term | 22:05 |
| fungi | no, cache was fine, just vague (we cache things in multiple places) | 22:06 |
| JayF | Basically failing centos image downloads is one of the most common failures I see | 22:07 |
| JayF | and anything we can do to reduce that would be awesome | 22:07 |
| fungi | unfortunately it looks like their cloud images aren't stored in a subset of their package mirrors, like some of their container images are/were, so we'd need a separate mirror config (if we can figure out where to rsync from) | 22:07 |
| fungi | for reference, https://opendev.org/opendev/system-config/src/branch/master/playbooks/roles/mirror-update/files/centos-stream-mirror-update is the script we use to rsync centos packages into our mirror network | 22:09 |
| JayF | How general do you need the mirror script to be? | 22:10 |
| JayF | I don't know how to ask the question I wanna ask | 22:10 |
| JayF | basically if I made a script that only pulled the images we care about | 22:11 |
| JayF | and not like ALL OF THE CENTOS THINGS would that be acceptable | 22:11 |
| JayF | actually I wonder if option #2 is, at least for the Ironic-4k-job, building a 4k IPA image and uploading it alongside our normal ones | 22:12 |
| JayF | that's *probably* the grade A solution for ironic-proper, although caching would help IPA as well, where we have to build on demand | 22:13 |
| fungi | i guess if the iso images are actually buried somewhere in their normal mirror tree and we can grab them by adjusting what we're pulling from rsync.stream.centos.org, that would be the best option | 22:32 |
| JayF | ack, I'll take a look when I can | 22:35 |
| opendevreview | Jay Faulkner proposed openstack/ironic master: Remove postgresql testing and documentation https://review.opendev.org/c/openstack/ironic/+/931055 | 22:41 |
| opendevreview | Jay Faulkner proposed openstack/ironic master: devstack: respect USE_VENV in Ironic https://review.opendev.org/c/openstack/ironic/+/930776 | 23:04 |
| opendevreview | Merged openstack/ironic master: bump some pre-commit hooks and remove default cfg https://review.opendev.org/c/openstack/ironic/+/934537 | 23:26 |
| opendevreview | Doug Goldstein proposed openstack/sushy master: ignore open coded password from flake8-bandit https://review.opendev.org/c/openstack/sushy/+/934911 | 23:47 |
| opendevreview | Doug Goldstein proposed openstack/sushy master: ensure all requests calls have a timeout https://review.opendev.org/c/openstack/sushy/+/934912 | 23:47 |
| opendevreview | Doug Goldstein proposed openstack/sushy master: enable ruff with flake8-bandit rules https://review.opendev.org/c/openstack/sushy/+/934913 | 23:47 |
| opendevreview | Doug Goldstein proposed openstack/sushy master: change ambiguous variable name https://review.opendev.org/c/openstack/sushy/+/934914 | 23:47 |
| opendevreview | Doug Goldstein proposed openstack/sushy master: enable pycodestyle checks in ruff https://review.opendev.org/c/openstack/sushy/+/934915 | 23:47 |
| opendevreview | Doug Goldstein proposed openstack/sushy master: enable pyupgrade via ruff to Python 3.9 https://review.opendev.org/c/openstack/sushy/+/934916 | 23:47 |
| cardoe | shhh stop making me look like a spammer | 23:49 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!