| mnasiadka | JayF: I’ll raise an rfe bug and reno, but first wanted to find some time to support subports add/remove after the instance gets provisioned, which it now does - I’ll try to optimize the code now and write unit tests for the trunk driver. | 05:32 |
|---|---|---|
| opendevreview | Michal Nasiadka proposed openstack/networking-generic-switch master: Add vlan aware VMs support https://review.opendev.org/c/openstack/networking-generic-switch/+/928490 | 07:00 |
| rpittau | good morning ironic! o/ | 08:05 |
| opendevreview | Merged openstack/ironic master: Fix lint issues with documentation https://review.opendev.org/c/openstack/ironic/+/933685 | 08:27 |
| rpittau | something odd with CI | 08:28 |
| rpittau | the error mentioned yesterday by cid seems more frequent and not patch related | 08:28 |
| opendevreview | Riccardo Pittau proposed openstack/bifrost master: Add support for Ubuntu 24.04 https://review.opendev.org/c/openstack/bifrost/+/928895 | 08:38 |
| rpittau | dtantsur: testing your patch against the linux/initrd change in ironic ^ | 08:39 |
| opendevreview | Riccardo Pittau proposed openstack/ironic master: [DNM] test CI https://review.opendev.org/c/openstack/ironic/+/934105 | 08:40 |
| rpittau | JayF: thanks for starting the work items patch! I've created https://bugs.launchpad.net/ironic/+bug/2086672for ironic-lib retirement | 09:05 |
| rpittau | if anyone has a moment we should probably merge https://review.opendev.org/c/openstack/bifrost/+/929753 ASAP | 09:10 |
| masghar | rpittau: cid: If its the same error we're talking about, I noted this last week: https://review.opendev.org/c/openstack/ironic-lib/+/933029/comments/2197663c_9b0a58bb | 09:44 |
| rpittau | masghar: I was looking at a different thing, but that's interesting | 09:45 |
| masghar | oh, alright | 09:47 |
| opendevreview | Merged openstack/networking-baremetal stable/2024.1: avoid attribute error on bad password or config https://review.opendev.org/c/openstack/networking-baremetal/+/934071 | 09:59 |
| opendevreview | Merged openstack/networking-baremetal stable/2024.2: avoid attribute error on bad password or config https://review.opendev.org/c/openstack/networking-baremetal/+/934070 | 10:00 |
| rpittau | masghar: mmm not sure that's the main difference though | 10:00 |
| rpittau | if you look at the jobs, one uses DIB while the others uses tinyipa because of the limitations in the testing environment | 10:02 |
| rpittau | specifically the failing one is using DIB | 10:03 |
| masghar | rpittau. oh, I didnt catch that | 10:03 |
| rpittau | tempest never run because of "Module remote_tmp /home/tempest/.ansible/tmp did not exist and was created with a mode of 0700, this may cause issues when running as another user. To avoid this, create the remote_tmp dir with the correct permissions manually" | 10:05 |
| opendevreview | Merged openstack/tenks master: Preserve assigned MAC on subsequent invocations https://review.opendev.org/c/openstack/tenks/+/931816 | 10:18 |
| rpittau | gmann: sorry to bug you, we're seeing an error when running tempest, the Run Tempest step never starts and it fails with the error above, any clue? | 10:25 |
| opendevreview | Riccardo Pittau proposed openstack/ironic master: Check for AMD virtualization support https://review.opendev.org/c/openstack/ironic/+/934112 | 10:29 |
| opendevreview | Merged openstack/python-ironicclient master: fix port name in Port resource https://review.opendev.org/c/openstack/python-ironicclient/+/933746 | 12:42 |
| opendevreview | Merged openstack/ironic-lib master: Add note about requirements lower bounds https://review.opendev.org/c/openstack/ironic-lib/+/933511 | 12:59 |
| opendevreview | Merged openstack/python-ironicclient stable/2024.2: Replace outdated python job template https://review.opendev.org/c/openstack/python-ironicclient/+/933883 | 13:16 |
| opendevreview | Merged openstack/bifrost master: Fix checksum parsing for Cirros and Rocky Linux https://review.opendev.org/c/openstack/bifrost/+/929753 | 13:28 |
| opendevreview | Merged openstack/bifrost master: Switches to using CentOS Stream latest https://review.opendev.org/c/openstack/bifrost/+/932173 | 13:28 |
| opendevreview | Merged openstack/bifrost master: Remove Python 3.8 support https://review.opendev.org/c/openstack/bifrost/+/933288 | 13:28 |
| cardoe | I'm gonna backport https://review.opendev.org/c/openstack/python-ironicclient/+/933746 if that's okay | 13:53 |
| opendevreview | Doug Goldstein proposed openstack/python-ironicclient stable/2024.2: fix port name in Port resource https://review.opendev.org/c/openstack/python-ironicclient/+/934128 | 13:56 |
| cardoe | I feel like I didn't do that correct since the metadata in gerrit doesn't show cherry-picked | 13:56 |
| opendevreview | Doug Goldstein proposed openstack/python-ironicclient stable/2024.2: fix port name in Port resource https://review.opendev.org/c/openstack/python-ironicclient/+/934128 | 13:58 |
| cardoe | ah gotta do it via gerrit web UI | 13:58 |
| opendevreview | Doug Goldstein proposed openstack/ironic master: add pyproject.toml to support pip 23.1 https://review.opendev.org/c/openstack/ironic/+/927544 | 14:00 |
| opendevreview | Doug Goldstein proposed openstack/ironic master: add pyproject.toml to support pip 23.1 https://review.opendev.org/c/openstack/ironic/+/927544 | 14:00 |
| rpittau | cardoe: JFYI the Depends-On entry in commit message in the same project is not very useful, better a patch chain | 14:01 |
| rpittau | oh whoops that was removed already, ok! :D | 14:02 |
| opendevreview | Dmitry Tantsur proposed openstack/ironic-python-agent master: A hardware manager call for a full sync before shutdown https://review.opendev.org/c/openstack/ironic-python-agent/+/931017 | 14:27 |
| dtantsur | JayF: with a release note ^^ | 14:27 |
| opendevreview | Dmitry Tantsur proposed openstack/ironic master: Actually ignore [inspector]power_off with fast track https://review.opendev.org/c/openstack/ironic/+/932720 | 14:35 |
| opendevreview | Bertrand LALLAU proposed openstack/ironic master: Instance provisioning fails on SQLite https://review.opendev.org/c/openstack/ironic/+/934134 | 14:39 |
| cardoe | Anyone know if there's a power state that's like "wait and hold at POST and don't boot an OS"? | 14:58 |
| opendevreview | Bertrand LALLAU proposed openstack/ironic-python-agent-builder master: Fix vmedia network config drive handling https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/934136 | 14:59 |
| opendevreview | Dmitry Tantsur proposed openstack/ironic master: [WIP] De-duplicate and fix the inspection clean-up logic https://review.opendev.org/c/openstack/ironic/+/932720 | 15:05 |
| opendevreview | Riccardo Pittau proposed openstack/bifrost master: Use cirros 0.6.3 as default cirros version https://review.opendev.org/c/openstack/bifrost/+/932175 | 15:13 |
| opendevreview | yatin proposed openstack/ironic unmaintained/zed: [Stable Only] pin virtualbmc/sushy-tools/ironic-tempest-plugin to last released tag https://review.opendev.org/c/openstack/ironic/+/934140 | 15:16 |
| cardoe | dtantsur: if ya got a few... https://review.opendev.org/c/openstack/ironic/+/933020 | 15:16 |
| opendevreview | Bertrand LALLAU proposed openstack/ironic master: Instance provisioning fails on SQLite https://review.opendev.org/c/openstack/ironic/+/934134 | 15:26 |
| opendevreview | Bertrand LALLAU proposed openstack/ironic master: Instance provisioning fails on SQLite https://review.opendev.org/c/openstack/ironic/+/934134 | 15:27 |
| opendevreview | Merged openstack/python-ironicclient stable/2024.2: fix port name in Port resource https://review.opendev.org/c/openstack/python-ironicclient/+/934128 | 15:28 |
| dtantsur | cardoe: ack | 15:30 |
| shermanm | I wanted to ask, does anyone have a "preferred" way of getting arm64 ipxe binaries? It seems like the x86 versions are available in package repos, but we've been compiling the arm64 ones ourselves | 15:33 |
| dtantsur | shermanm: all I know is that the iPXE project published them | 15:34 |
| dtantsur | https://boot.ipxe.org/arm64-efi/ | 15:35 |
| shermanm | ah, thanks for that! I'll need to check and see what flags those binaries were built with, sometimes they don't include gzip support | 15:40 |
| opendevreview | Dmitry Tantsur proposed openstack/ironic master: Actually ignore [inspector]power_off with fast track https://review.opendev.org/c/openstack/ironic/+/932720 | 15:42 |
| TheJulia | cardoe: so, regarding https://review.opendev.org/c/openstack/ironic-specs/+/933612 I think I have an idea. do something like "skopeo copy host:port/path/container:latest oci:localpath-oci", and then do what you were thinking, just access the file by referencing index.json. | 16:08 |
| TheJulia | we still have to login and all | 16:08 |
| opendevreview | Merged openstack/ironic-python-agent master: Vendor metrics library from Ironic-Lib & deprecate https://review.opendev.org/c/openstack/ironic-python-agent/+/933063 | 16:11 |
| JayF | mnasiadka: I think you were talking about a different patch than the one I linked. I asked for a spec on the bigger, agent patch -- I just need a release note for https://review.opendev.org/c/openstack/networking-generic-switch/+/932541 which is really simple | 16:13 |
| JayF | TheJulia: is there a RFE bug somewhere I can't find re: console support work we discussed at PTG? | 16:15 |
| TheJulia | Haven't created one speicifically, we need to have the further discussions on it, clearly | 16:16 |
| TheJulia | what we discussed with sort of grand design too, maybe not the best for the newer consensus we've started to reach | 16:17 |
| JayF | I'm literally only asking for a link to put in the priorities spec :) | 16:18 |
| JayF | I'll create a shell with small detail to link and track with | 16:18 |
| TheJulia | k | 16:18 |
| JayF | cardoe: are you the right assignee for the "Improve OEM Handling in Sushy" priority? | 16:21 |
| cardoe | TheJulia: yeah I think that would be good. I'm just aiming for us to keep it simple. | 16:22 |
| cardoe | JayF: yes. There's a few items you can toss my name on. | 16:22 |
| JayF | I have you down for, oob inspection hooks too | 16:22 |
| cardoe | yes | 16:22 |
| cardoe | I lost where I was gonna comment on that. | 16:22 |
| JayF | cardoe: did you ever make a bug ticket for that? it was listed as an action outta the ptg | 16:22 |
| cardoe | I'll do it. | 16:23 |
| JayF | ack please link it here when you're done, I'm trying to get the draft of this priorities spec done this morning | 16:25 |
| opendevreview | Riccardo Pittau proposed openstack/ironic master: Use linux instead of linuxefi in grub config https://review.opendev.org/c/openstack/ironic/+/933631 | 16:26 |
| JayF | TheJulia: https://bugs.launchpad.net/ironic/+bug/2086715 is the bug I created for redfish console support; jfyi | 16:30 |
| opendevreview | Riccardo Pittau proposed openstack/ironic master: Use linux instead of linuxefi in grub config https://review.opendev.org/c/openstack/ironic/+/933631 | 16:30 |
| opendevreview | Riccardo Pittau proposed openstack/ironic master: Add support for Ubuntu 24.04 https://review.opendev.org/c/openstack/ironic/+/934150 | 16:39 |
| rpittau | good night! o/ | 16:47 |
| JayF | \o | 16:47 |
| mnasiadka | JayF: ah, you meant the backport - yeah, will update that one, forgot about it completely :) | 16:48 |
| JayF | wait, that's a backport? | 16:49 |
| JayF | hold on lemme look | 16:49 |
| JayF | technically we shouldn't backport something that didn't land with a relnote | 16:49 |
| JayF | but if it didn't have one in master we shouldn't add one now | 16:49 |
| JayF | looking | 16:49 |
| JayF | https://review.opendev.org/c/openstack/networking-generic-switch/+/931572 should not have been approved without a release note | 16:49 |
| JayF | but that was 20 days ago and I don't have a time machine | 16:49 |
| JayF | I'm going to 🙈 and +2 the backport as-is | 16:50 |
| JayF | mnasiadka: ty for the pointer, I missed the branch on that | 16:51 |
| JayF | mnasiadka: I've +2A'd that patch; but please be aware in the future that it's super important to put a release note on changes; especially bugfixes we may want to backport | 16:51 |
| JayF | Now operators will have no idea that bug was fixed in the next patch release of NGS unless they go commit digging | 16:52 |
| mnasiadka | I'm fine with following up with a reno on master if that makes you happier ;-) | 16:52 |
| JayF | I don't think it really works that way? | 16:52 |
| JayF | There's some magic tying a release note to the code | 16:52 |
| * JayF hand waves | 16:52 | |
| JayF | it'd probably just work if we made a relnote patch and backported it through, but meh? Lets just use it as an opportunity to be better next time | 16:52 |
| mnasiadka | ok then, I'll make sure to have a reno on every NGS patch I push ;-) | 16:53 |
| JayF | heh, we don't need them for all of them | 16:53 |
| JayF | the rule of thumb I use is: if I was an operator, would I be able to tell this change happened and/or is it a change I'd wanna know about | 16:53 |
| JayF | I suspect my line is ... more leaning towards adding a relnote than some other cores though :) | 16:53 |
| dtantsur | Having renos for everything user-visible is good | 16:55 |
| dtantsur | it becomes contentious for things that not-exactly-user-visible-but-maybe-who-knows :) | 16:55 |
| dtantsur | We also don't want to pollute our notes every time we refactor something | 16:55 |
| JayF | yeah, when I say "would an operator notice" I am basically saying "API changes" but having some awareness that e.g. hardwaremanager class is a form of operator-facing api too | 16:56 |
| dtantsur | true | 16:57 |
| JayF | I also think there's a little bit of an unspoken impact on what repo, too | 16:57 |
| JayF | like I assume, for instance, IPA release notes are read an order of magnitude less often than Ironic-service relnotes :) | 16:57 |
| JayF | (NGS is probably somewhere in between those two, I'd guess) | 16:58 |
| cardoe | does conductor listen on a port and serve up oslo healthcheck or no? | 17:01 |
| JayF | Conductor only does RPC | 17:17 |
| JayF | I believe the canonical way to test conductor liveness is /v1/conductors | 17:18 |
| opendevreview | Jay Faulkner proposed openstack/ironic-specs master: 2025.1 Ironic priorities / PTG Summary https://review.opendev.org/c/openstack/ironic-specs/+/934092 | 17:41 |
| opendevreview | Jay Faulkner proposed openstack/ironic-specs master: 2025.1 Ironic priorities / PTG Summary https://review.opendev.org/c/openstack/ironic-specs/+/934092 | 17:44 |
| JayF | that is ready for review, only thing missing is that sushy oem stuff ticket | 17:44 |
| cardoe | controversial add... inspection shouldn't create ports... it should move into a hook. | 17:48 |
| cardoe | https://bugs.launchpad.net/ironic/+bug/2086723 JayF | 17:54 |
| opendevreview | Jay Faulkner proposed openstack/ironic-specs master: 2025.1 Ironic priorities / PTG Summary https://review.opendev.org/c/openstack/ironic-specs/+/934092 | 17:56 |
| cardoe | https://bugs.launchpad.net/ironic/+bug/2086725 there's the sushy OEM one | 18:02 |
| JayF | oh, I think I mixed em up in my update | 18:07 |
| JayF | no, I didn't | 18:07 |
| JayF | updated, push coming | 18:08 |
| opendevreview | Jay Faulkner proposed openstack/ironic-specs master: 2025.1 Ironic priorities / PTG Summary https://review.opendev.org/c/openstack/ironic-specs/+/934092 | 18:08 |
| JayF | cardoe: when you make rfes, please self-triage them (tag: rfe; priority: wishlist, status: triaged) | 18:09 |
| * JayF doing it for this one | 18:09 | |
| cardoe | I can. | 18:09 |
| JayF | I already did :-) | 18:09 |
| cardoe | well teach a man to fish | 18:09 |
| JayF | cardoe: wait, cardoe@gentoo.org ?! | 18:09 |
| cardoe | I don't wanna give ya extra work | 18:09 |
| JayF | cardoe: you're a gentoo developer? | 18:09 |
| JayF | or is there another cardoe in lp | 18:10 |
| cardoe | I was. I thought I told ya that. | 18:10 |
| JayF | Just because you tell me something doesn't mean I know ;) | 18:10 |
| JayF | my mind is a sieve sometimes | 18:10 |
| cardoe | https://www.gentoo.org/inside-gentoo/developers/retired-developers.html | 18:10 |
| JayF | cardoe: https://bugs.gentoo.org/941247 | 18:11 |
| opendevreview | Julia Kreger proposed openstack/ironic-specs master: OCI Container Registry Image Source https://review.opendev.org/c/openstack/ironic-specs/+/933612 | 18:12 |
| cardoe | https://bugs.gentoo.org/58120 | 18:12 |
| TheJulia | so! for everyone involved, I've revised ^ to be a bit more specific around the interactions. I've also put tags in to the oci dsitribution spec which if you skim provides a bit more clarity | 18:13 |
| JayF | they are faster at removing people than adding :P | 18:13 |
| TheJulia | and I think I might have sorted the url issues by saying we're just going to strip it off and hand it to $userspacetool | 18:13 |
| opendevreview | Jay Faulkner proposed openstack/ironic master: devstack: respect USE_VENV in Ironic https://review.opendev.org/c/openstack/ironic/+/930776 | 18:22 |
| opendevreview | Julia Kreger proposed openstack/ironic-specs master: Support for bootable containers https://review.opendev.org/c/openstack/ironic-specs/+/933620 | 18:37 |
| opendevreview | Julia Kreger proposed openstack/ironic master: Instance provisioning fails on SQLite https://review.opendev.org/c/openstack/ironic/+/934134 | 18:54 |
| JayF | TheJulia: do we know why any of our various CIs didn't catch that? I thought we had a job on sqlite (metal3?) | 18:55 |
| JayF | or is sqlite just completely out of ci coverage now | 18:55 |
| TheJulia | it is in, I think there is code which assigns it anyway but it might be racey | 18:56 |
| TheJulia | I wasn't able to find it | 18:56 |
| TheJulia | at least, at a quick glance | 18:56 |
| opendevreview | Pierre Riteau proposed openstack/bifrost master: Add support for Ubuntu 24.04 image download https://review.opendev.org/c/openstack/bifrost/+/934177 | 19:04 |
| opendevreview | Merged openstack/networking-generic-switch stable/2024.2: cumulus_nvue: Don't call enable() and set enter_config_mode = False https://review.opendev.org/c/openstack/networking-generic-switch/+/932541 | 19:04 |
| opendevreview | Pierre Riteau proposed openstack/bifrost stable/2024.2: Fix checksum parsing for Cirros and Rocky Linux https://review.opendev.org/c/openstack/bifrost/+/934178 | 19:06 |
| cardoe | bleh. How can I nicely have a branch with someone else's patch in it and just submit my change? | 19:19 |
| cardoe | Cause I just stomped over someone else's by using git review -X <their-change> and then rebasing mine on top | 19:19 |
| TheJulia | so, sort of depends on your starting point | 19:33 |
| TheJulia | generally what I do is I pull down the other change or set them up as a series of cherry picks, and then download my change, and rebase on top of the branch representing the series of changes | 19:33 |
| JayF | honestly my answer to that problem is "really try to avoid this problem by moving around my work" | 19:34 |
| JayF | which may or may not be a helpful answer for you :) | 19:34 |
| JayF | or offer to take over the patch(es) I want to combo with | 19:34 |
| JayF | last time I did this I screwed over dtantsur though :-X | 19:34 |
| cardoe | Well when I ran "git review" it said I was submitting multiple changes. And I said yes. | 19:35 |
| TheJulia | I mean, you *can* do that, but sort of depends on what you did in your history to get to that point | 19:35 |
| TheJulia | git-review is going to try and reconcile everything that differs back to the state of master branch | 19:41 |
| JayF | if you have ZERO CHANGES in the other patches, it shouldn't push them | 19:43 |
| JayF | but in practice that's still painful because if the person you're stacked on updates, you have to rebase manually before it'll run CI | 19:44 |
| TheJulia | bbingo | 19:44 |
| JayF | this is why my answer -- which might have sounded like a joke but wasn't -- was to just rearrange your work to avoid this | 19:45 |
| JayF | I know not everyone has that luxury, but I do | 19:45 |
| opendevreview | Adam McArthur proposed openstack/ironic-tempest-plugin master: WIP: Microversion handling test https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/933970 | 20:37 |
| opendevreview | Adam McArthur proposed openstack/python-ironicclient master: Remove Functional Tests https://review.opendev.org/c/openstack/python-ironicclient/+/933967 | 20:40 |
| opendevreview | Adam McArthur proposed openstack/ironic master: api: Introduce new mechanism for API versioning https://review.opendev.org/c/openstack/ironic/+/928919 | 21:56 |
| opendevreview | Merged openstack/ironic master: Check for AMD virtualization support https://review.opendev.org/c/openstack/ironic/+/934112 | 21:57 |
| opendevreview | Jay Faulkner proposed openstack/python-ironicclient master: Support /v1/shards https://review.opendev.org/c/openstack/python-ironicclient/+/933894 | 22:04 |
| opendevreview | Merged openstack/ironic-lib master: Drop the unused capabilities module https://review.opendev.org/c/openstack/ironic-lib/+/933029 | 23:27 |
| cardoe | So I swear the policy permissions changed to 2024.2, like I can't run clean operations anymore as the admin on the project where my nodes are. I can only do so as OS_SYSTEM_SCOPE=all | 23:37 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!