| TheJulia | mnasiadka: .. likely the switch but that is a super good question | 00:01 |
|---|---|---|
| opendevreview | cid proposed openstack/ironic master: [WIP] Save ``configdrive`` in an auxiliary table https://review.opendev.org/c/openstack/ironic/+/933622 | 00:52 |
| rpittau | good morning ironic! o/ | 07:01 |
| opendevreview | Riccardo Pittau proposed openstack/ironic master: [WIP] Use linux instead of deprecated linuxefi https://review.opendev.org/c/openstack/ironic/+/933631 | 08:08 |
| mnasiadka | TheJulia: it was the switch, Cumulus since 5.7.0 is enabling LLDP MED - would it be maybe a good idea to just ignore unknown TLV 127 entries instead of failing on them? | 08:16 |
| opendevreview | Riccardo Pittau proposed openstack/ironic master: [WIP] Use linux instead of deprecated linuxefi https://review.opendev.org/c/openstack/ironic/+/933631 | 08:27 |
| opendevreview | Riccardo Pittau proposed openstack/ironic master: [WIP] Use linux instead of deprecated linuxefi https://review.opendev.org/c/openstack/ironic/+/933631 | 09:18 |
| milad | hi every body | 10:40 |
| masghar | Hello! | 10:50 |
| mnasiadka | TheJulia: actually it is, inspection failed from another reason, I was just blind | 10:50 |
| iurygregory | morning ironic | 11:11 |
| TheJulia | good morning | 12:35 |
| cid | rpittau, ```<rpittau> Riccardo Pittau | 12:47 |
| cid | masghar: for the permissions change I honestly don't remember, but I think we recently changed that for cid, maybe he remembers how to do that```, the group I was recently added to, for bug triaging is the 'Ironic Drivers', but I doubt my hammer is big enough to make such changes (assuming that's what this message suggested). Sorry I missed this yesterday | 12:47 |
| TheJulia | cid: I think that is the only group, so by all means give it a try :) | 12:56 |
| rpittau | cid: ironic drivers? weird, but let me check, unless you're on it already | 13:00 |
| cid | TheJulia, rpittau, this is what I see on the team's page: https://usercontent.irccloud-cdn.com/file/MH3dNCPi/image.png | 13:02 |
| rpittau | cid: I think it's a different group | 13:03 |
| rpittau | ah no, it was just changed | 13:04 |
| cid | rpittau, ... on account of the Core reviewers shuffle? | 13:05 |
| rpittau | nah, I was just looking at an old one :) | 13:05 |
| rpittau | very old | 13:05 |
| TheJulia | try now! | 13:06 |
| TheJulia | you might have to log out and log back into launchpad | 13:06 |
| cid | I just refreshed, and now I see option to 'add member' :) | 13:07 |
| TheJulia | it occurs to me that https://launchpad.net/~ironic-bugs might need some editing | 13:07 |
| TheJulia | I'll email Aeva to see if she can login and click admin for me | 13:08 |
| cid | rpittau, TheJulia, thanks. | 13:09 |
| cid | masghar, I just added you to the team. | 13:09 |
| rpittau | thanks to you cid | 13:09 |
| rpittau | ahhh team add spam! | 13:10 |
| masghar | thanks cid, TheJulia, rpittau | 13:10 |
| rpittau | oh wow CI super green here https://review.opendev.org/c/openstack/ironic/+/933631 | 13:11 |
| rpittau | going to clean the patch up | 13:12 |
| rpittau | we can migrate to ubuntu noble after that I think | 13:12 |
| TheJulia | I added to specs to ironic-week-prio based upon ptg discussions | 13:13 |
| rpittau | thanks TheJulia! | 13:13 |
| dtantsur | rpittau: wasn't linuxefi required for secure boot? | 13:19 |
| rpittau | dtantsur: I don't think it's the case anymore | 13:22 |
| dtantsur | ack | 13:22 |
| TheJulia | email to aeva sent regarding the ironic-bugs group | 13:30 |
| opendevreview | Riccardo Pittau proposed openstack/bifrost master: [DNM] test linux efi https://review.opendev.org/c/openstack/bifrost/+/933650 | 13:58 |
| rpittau | I know we have integration with bifrost, but I'm quite paranoid with the linuxefi change | 13:59 |
| TheJulia | we do secure booting of grub with grub.cfg, so if the in repo template is changed then we should have some level of coverage | 15:50 |
| TheJulia | and test wise that is a good test | 15:50 |
| TheJulia | I'm not sure it secure boots, but the parameters are the same afaik since it is, afaik, just an alias | 15:50 |
| JayF | Wasn't/Isn't there someone at vexxhost running Ironic and/or in the Ironic community? | 15:51 |
| rpittau | it is indeed, but I'm wondering now if CS9/RHEL9 actually use a kernel recent enough | 15:51 |
| * JayF is looking for an engineering or OSPO contact over there | 15:51 | |
| rpittau | this was re TheJulia ^^ | 15:51 |
| JayF | the kernel matters for the linux vs linuxefi change? | 15:51 |
| rpittau | yep | 15:51 |
| TheJulia | JayF: mnaser is your best point of contact for routing questions w/r/t vexxhost | 15:52 |
| JayF | THAT'S RIGHT | 15:52 |
| JayF | I knew it was someone obvious and I was blanking | 15:52 |
| TheJulia | heh | 15:52 |
| rpittau | kernel 6.x is 100% sure to work as it deprecated the EFI handover protocol optional | 15:52 |
| rpittau | s/optional/option | 15:52 |
| TheJulia | so my machine is using linux | 15:53 |
| TheJulia | fwiw | 15:53 |
| JayF | 6.6 is the current stable | 15:54 |
| JayF | but I know that kernel versions to features mapping gets tricky with distro kenrels | 15:54 |
| rpittau | CS9 has 5.14 IIRC | 15:55 |
| rpittau | bye everyone, see you next Monday o/ | 17:12 |
| JayF | \o | 17:13 |
| opendevreview | Julia Kreger proposed openstack/ironic-specs master: OCI Container Registry Image Source https://review.opendev.org/c/openstack/ironic-specs/+/933612 | 18:15 |
| opendevreview | Julia Kreger proposed openstack/ironic-specs master: Support for bootable containers https://review.opendev.org/c/openstack/ironic-specs/+/933620 | 18:17 |
| TheJulia | The latter is just a rebase since they are chained together | 18:20 |
| shermanm | hey, I had kind of an oddball question: | 18:31 |
| shermanm | is it possible to force ironic-agent to skip "get_bmc_address" and "get_bmc_v6address"? I've got some servers that take a minute or so for each wrapped ipmitool call to time out | 18:32 |
| JayF | I have a better answer than you expect | 18:32 |
| JayF | https://opendev.org/openstack/ironic-python-agent/commit/2d79eae382503568c9adaddee02d7ef0041ea8b4 which was in Dalmation | 18:33 |
| JayF | should make your life much better | 18:33 |
| JayF | you could build a custom hardware manager to implement those as noops instead, but if you're building your own ramdisk pulling in that commit is likely the best route | 18:33 |
| shermanm | unfortunately it does support ipmi, just an extremely limited subset of ipmi | 18:34 |
| JayF | okay, then lets go to option 2 | 18:37 |
| JayF | urgh this is a bug https://opendev.org/openstack/ironic-python-agent/src/branch/master/ironic_python_agent/hardware.py#L1086 | 18:39 |
| JayF | that should be dispatching those out to managers | 18:39 |
| JayF | so shermanm, basically, you'll wanna, using one of these as an example https://opendev.org/openstack/ironic-python-agent/src/branch/master/examples/business-logic | 18:40 |
| JayF | subclass the HardwareManager class from hardware.py | 18:40 |
| JayF | implement get_bmc_address + get_bmc_v6address as "pass" or "return None" or whatever is appropriate | 18:40 |
| JayF | and set it up to return a higher value for evaluate_hardware_support | 18:41 |
| shermanm | that last line is I think what I was missing for getting custom managers working. Generic's returning a value of 1, so I'd need to return 2+ to use that result instead? | 18:43 |
| JayF | yes | 18:45 |
| JayF | and really IMO it's wrong we aren't calling dispatch_to_managers in that list_hardware_info default implementation | 18:45 |
| JayF | because if we were, you could just override those two methods | 18:45 |
| shermanm | gotcha. The other half, what's the recommend approach for making the overides apply to server type X, but not type Y? | 18:47 |
| shermanm | e.g. I wasn't sure if I could assume evaluate_hardware_support was called prior to list_hardware_info | 18:49 |
| JayF | It should be | 18:50 |
| JayF | that's how it's supposed to work | 18:50 |
| JayF | collect hardware managers -> get hardware support -> sort by hardware support -> anytime we need to do something with hardware, dispatch to managers in priority order, skipping ones that don't have a method implemented | 18:51 |
| shermanm | perfect, I think that's my "mental map" identified then. thanks for the help! | 18:51 |
| JayF | good luck! | 18:51 |
| JayF | dtantsur: either clarify or lift your -1 please https://review.opendev.org/c/openstack/ironic-python-agent/+/928466/6#message-a59e9c755c86e0e78e89c49d9df4c3af29bcd784 | 19:39 |
| opendevreview | Jay Faulkner proposed openstack/ironic master: Make all API samples valid JSON https://review.opendev.org/c/openstack/ironic/+/933678 | 20:25 |
| JayF | I'm going to have a handful of these coming down | 20:25 |
| JayF | basically instead of dropping a giant commit w/CI config and lint fixes in it | 20:25 |
| JayF | going to sprinkle the lint fixes in separately so it's actually readable | 20:25 |
| opendevreview | Jay Faulkner proposed openstack/ironic master: Correct duplicated names/entries in unit tests https://review.opendev.org/c/openstack/ironic/+/933679 | 20:54 |
| opendevreview | Merged openstack/ironic-python-agent master: Capture and log sector sizes https://review.opendev.org/c/openstack/ironic-python-agent/+/933200 | 21:29 |
| opendevreview | Jay Faulkner proposed openstack/ironic master: Make all API samples valid JSON https://review.opendev.org/c/openstack/ironic/+/933678 | 22:00 |
| opendevreview | Jay Faulkner proposed openstack/ironic master: Correct duplicated names/entries in unit tests https://review.opendev.org/c/openstack/ironic/+/933679 | 22:00 |
| opendevreview | Jay Faulkner proposed openstack/ironic master: Remove trailing whitespace https://review.opendev.org/c/openstack/ironic/+/933684 | 22:00 |
| opendevreview | Jay Faulkner proposed openstack/ironic master: Fix lint issues with documentation https://review.opendev.org/c/openstack/ironic/+/933685 | 22:00 |
| opendevreview | Jay Faulkner proposed openstack/ironic master: Migrate lint to pre-commit https://review.opendev.org/c/openstack/ironic/+/933686 | 22:00 |
| JayF | That should be the migration to pre-commit | 22:01 |
| cardoe | How are the jobs being called in the last one? | 22:04 |
| JayF | If you look at the pre-commit config file, you'll see that bandit and codespell are now being run as part of the basic linter job that pep8 runs | 22:16 |
| JayF | Which means as a bonus, will get notified at commit time if any of those are invalid instead of after CI runs. At least for people who have the pre-commit hook installed | 22:17 |
| opendevreview | Doug Goldstein proposed openstack/sushy master: Add Port resource https://review.opendev.org/c/openstack/sushy/+/932096 | 22:38 |
| cardoe | JayF: I guess I missed that. That's what I expected but didn't see it. | 22:40 |
| cardoe | JayF: Is that sushy change less concerning? | 22:40 |
| JayF | that's on my list for tomorrow, don't have nearly enough brain left for that one | 22:46 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!
