| rpittau | good morning ironic! o/ | 07:26 |
|---|---|---|
| rpittau | cardoe: re wsgi module: I left a comment in https://review.opendev.org/c/openstack/ironic/+/927635, essentially the error is due to the fact that you have executable code running directly at the top level | 07:33 |
| rpittau | if we want to use sphinx we need to change that as I suggested in the comment, or in a different way | 07:33 |
| opendevreview | Derek Higgins proposed openstack/ironic master: Eject vmedia if fast track is enabled https://review.opendev.org/c/openstack/ironic/+/933326 | 10:06 |
| masghar | Good afternoon Ironic! I am looking at untriaged bugs for this month, and we have quite a few | 10:13 |
| masghar | (10 in ironic) | 10:14 |
| cid | masghar, :D, that's a new high (since I learned how bug triaging works). Maybe as it's the beginning of a new release. | 11:00 |
| masghar | cid: Yep, lots going on at the moment I guess | 12:04 |
| masghar | I've got a doc with suggestions for triaging them. I haven't done it already because I am not too sure, and also because I don't have the permissions yet. Shall I go ahead and share it here? | 12:20 |
| rpittau | masghar: sure, that works, we can also discuss that during the next meeting to have more concentrated audience | 12:33 |
| opendevreview | Derek Higgins proposed openstack/ironic master: Don't eject vmedia if fast track is enabled https://review.opendev.org/c/openstack/ironic/+/933326 | 12:49 |
| cardoe | rpittau: https://opendev.org/openstack/nova/src/branch/master/nova/wsgi/osapi_compute.py was the example that JayF originally followed. Which now that i moved stuff into the wsgi directory it should match. | 13:44 |
| rpittau | cardoe: it does match, the problem is that sphinx is reading our code, analyzing it, and it doesn't like that :) | 14:23 |
| rpittau | nova is building their docs in a different way, that's why all's good in their jobs | 14:23 |
| cardoe | Jay tried to add that to be ignored but sphinx didn't listen | 14:24 |
| JayF | rpittau: they have autodoc in nova, yeah? | 14:24 |
| rpittau | JayF: they do | 14:25 |
| JayF | then what does 'nova is building their docs in a different way' mean | 14:25 |
| rpittau | it means that if you look at their job and especially their conf.py, they're quite different from ours | 14:26 |
| rpittau | so either we change how we generate our docs, or we don't have executable code at the top level of that module | 14:27 |
| cardoe | So wsgi stuff can use a function as an entry point, but that's not how the rest of OpenStack projects are doing it. | 14:28 |
| cardoe | It's not just nova that's doing that pattern. | 14:28 |
| JayF | We should get sean mooney to look at that | 14:29 |
| JayF | he was working on the wsgi stuff in nova | 14:29 |
| JayF | might have some nugget of info we don't? | 14:29 |
| rpittau | I'm not saying the problem is how that is written, I'm saying that sphinx does not like it, and that nova does not include that module in their docs AFAICS | 14:29 |
| JayF | Yeah, but I don't see any evidence in their conf.py that they're skipping | 14:35 |
| JayF | I do think skipping the wsgi module is the a++ solution | 14:35 |
| JayF | Really we should revert back to original where I tried to skip it and I can try again to skip it lol | 14:35 |
| JayF | I need to write up something for the OpenInfra Days NA @ SCALE this morning but I can try to find time later | 14:36 |
| rpittau | JayF: FYI autodoc explicitly says that for scripts they should be protected by an if __name__ == '__main__' condition | 14:36 |
| JayF | Yep, but I've got no idea if that makes sense for wsgi | 14:36 |
| JayF | I don't think a wsgi server doing an import is going to have it be __main__ | 14:36 |
| opendevreview | Merged openstack/sushy master: Provide vmedia username and password if required https://review.opendev.org/c/openstack/sushy/+/923524 | 14:40 |
| JayF | dtantsur: https://review.opendev.org/c/openstack/ironic-python-agent/+/928466/6#message-a59e9c755c86e0e78e89c49d9df4c3af29bcd784 I left my comment back on draft, if you can help me understand what to do here I'm happy to do it | 14:44 |
| * JayF will brb in an 60-90mins | 14:44 | |
| opendevreview | Merged openstack/virtualbmc master: Drop unnecessary 'x' bit from doc config file https://review.opendev.org/c/openstack/virtualbmc/+/933269 | 14:48 |
| opendevreview | Merged openstack/sushy-tools master: Drop unnecessary 'x' bit from doc config file https://review.opendev.org/c/openstack/sushy-tools/+/933315 | 14:52 |
| rpittau | cardoe, JayF: a solution could be not treating all warnings as errors for pdf builds only, and using mock autosummary, do you want me to update the patch? | 14:53 |
| cardoe | I'm all for it cause I'm out of ideas. | 14:54 |
| rpittau | ok, gimme a sec to clean the patch | 14:55 |
| opendevreview | Riccardo Pittau proposed openstack/ironic master: Enable WSGI module entrypoint for Ironic https://review.opendev.org/c/openstack/ironic/+/927635 | 14:57 |
| rpittau | we don't treat warnings as errors in docs, don't see why we should do that in pdf-docs | 14:58 |
| opendevreview | Merged openstack/ironic-python-agent-builder master: Drop unnecessary 'x' bit from doc config file https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/932864 | 15:00 |
| rpittau | bye everyone, have a great weekend! o/ | 15:11 |
| opendevreview | Merged openstack/ironic master: docs: adds link to oslo_messaging_notifications documentation https://review.opendev.org/c/openstack/ironic/+/933119 | 15:15 |
| masghar | rpittau: Sorry, I missed your reply earlier. Here it is: https://docs.google.com/document/d/1fGGfg3OP69rOYvvn17zZ2ve_muVZKreMbrS_UVrs3IA/edit?tab=t.0 | 15:48 |
| opendevreview | Merged openstack/ironic master: Expand detected strings in check_cipher_suite_errors https://review.opendev.org/c/openstack/ironic/+/932915 | 16:14 |
| JayF | rpittau: we specifically enabled that because it acts as a linter for Sphinx. It's okay that you removed it though, because when I action the pre-commit stuff from the ptg, I can tie in a docs linter to the lint job then | 16:56 |
| JayF | And I don't think that linter is going to go so far as to run autodoc | 16:57 |
| JayF | oh, the change you made is way better than it sounded | 18:30 |
| JayF | that's awesome | 18:30 |
| JayF | thank you | 18:30 |
| JayF | jfyi as promised, itamarst has started on his quest to fix virtualpdu; no real schedule but if someone else picks up fixing virtualpdu, you might wanna reach out (I can proxy if you don't share a channel with him) | 19:04 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!