Friday, 2024-09-06

opendevreviewMerged openstack/ironic stable/2023.2: CI: Remove grenade jobs for 2023.2  https://review.opendev.org/c/openstack/ironic/+/92829400:24
opendevreviewVerification of a change to openstack/ironic stable/2023.1 failed: CI: stable/2023.1 - remove partition and older non-voting jobs  https://review.opendev.org/c/openstack/ironic/+/92829001:36
*** dtantsur_ is now known as dtantsur01:57
opendevreviewVerification of a change to openstack/ironic stable/2023.1 failed: CVE-2024-44982: Harden all image handling and conversion code  https://review.opendev.org/c/openstack/ironic/+/92797202:48
*** ex_tnode8 is now known as ex_tnode04:31
dtantsurTheJulia, JayF, a very late question, but does any of you maintain a list of things we disabled/removed/changed temporary to push the changes through?10:50
opendevreviewVerification of a change to openstack/ironic stable/2023.1 failed: CI: stable/2023.1 - remove partition and older non-voting jobs  https://review.opendev.org/c/openstack/ironic/+/92829011:13
opendevreviewVerification of a change to openstack/ironic stable/2023.1 failed: CVE-2024-44982: Harden all image handling and conversion code  https://review.opendev.org/c/openstack/ironic/+/92797211:22
cardoeOne that we likely will want to land before the release is https://review.opendev.org/c/openstack/ironic/+/926961 I was doing a review on the release notes and for Ironic this functionality is mentioned but that's the docs for the functionality.12:55
TheJuliadtantsur: Only thing I removed was long broken bit rotted jobs on unmaintained branches. The grenade removal was not necessary yet, but once 2023.1 goes unmaintained, it was going to break anyway12:58
TheJuliathatw as grenade on 2023.212:58
opendevreviewOpenStack Release Bot proposed openstack/ironic-lib stable/2024.2: Update .gitreview for stable/2024.2  https://review.opendev.org/c/openstack/ironic-lib/+/92835413:08
opendevreviewOpenStack Release Bot proposed openstack/ironic-lib stable/2024.2: Update TOX_CONSTRAINTS_FILE for stable/2024.2  https://review.opendev.org/c/openstack/ironic-lib/+/92835713:08
opendevreviewOpenStack Release Bot proposed openstack/metalsmith stable/2024.2: Update .gitreview for stable/2024.2  https://review.opendev.org/c/openstack/metalsmith/+/92836113:08
opendevreviewOpenStack Release Bot proposed openstack/metalsmith stable/2024.2: Update TOX_CONSTRAINTS_FILE for stable/2024.2  https://review.opendev.org/c/openstack/metalsmith/+/92836213:08
opendevreviewOpenStack Release Bot proposed openstack/metalsmith master: Update master for stable/2024.2  https://review.opendev.org/c/openstack/metalsmith/+/92836513:08
opendevreviewOpenStack Release Bot proposed openstack/python-ironic-inspector-client stable/2024.2: Update .gitreview for stable/2024.2  https://review.opendev.org/c/openstack/python-ironic-inspector-client/+/92836713:08
opendevreviewOpenStack Release Bot proposed openstack/python-ironic-inspector-client stable/2024.2: Update TOX_CONSTRAINTS_FILE for stable/2024.2  https://review.opendev.org/c/openstack/python-ironic-inspector-client/+/92836813:08
opendevreviewOpenStack Release Bot proposed openstack/python-ironic-inspector-client master: Update master for stable/2024.2  https://review.opendev.org/c/openstack/python-ironic-inspector-client/+/92836913:09
opendevreviewOpenStack Release Bot proposed openstack/python-ironicclient stable/2024.2: Update .gitreview for stable/2024.2  https://review.opendev.org/c/openstack/python-ironicclient/+/92837013:09
opendevreviewOpenStack Release Bot proposed openstack/python-ironicclient stable/2024.2: Update TOX_CONSTRAINTS_FILE for stable/2024.2  https://review.opendev.org/c/openstack/python-ironicclient/+/92837113:09
opendevreviewOpenStack Release Bot proposed openstack/python-ironicclient master: Update master for stable/2024.2  https://review.opendev.org/c/openstack/python-ironicclient/+/92837213:09
opendevreviewOpenStack Release Bot proposed openstack/sushy stable/2024.2: Update .gitreview for stable/2024.2  https://review.opendev.org/c/openstack/sushy/+/92837313:09
opendevreviewOpenStack Release Bot proposed openstack/sushy stable/2024.2: Update TOX_CONSTRAINTS_FILE for stable/2024.2  https://review.opendev.org/c/openstack/sushy/+/92837413:09
opendevreviewOpenStack Release Bot proposed openstack/sushy master: Update master for stable/2024.2  https://review.opendev.org/c/openstack/sushy/+/92837513:09
opendevreviewMerged openstack/ironic stable/2023.1: CI: stable/2023.1 - remove partition and older non-voting jobs  https://review.opendev.org/c/openstack/ironic/+/92829013:24
TheJulia\o/13:25
cardoesuccess!13:41
TheJuliaindeed!14:13
TheJuliaugh, why is grenade still on zed14:27
* TheJulia sighs14:27
opendevreviewMerged openstack/ironic stable/2023.1: CVE-2024-44982: Harden all image handling and conversion code  https://review.opendev.org/c/openstack/ironic/+/92797214:41
dtantsuryay!14:50
* dtantsur adds ironic-lib future to the PTG topics14:52
opendevreviewMerged openstack/sushy master: Update master for stable/2024.2  https://review.opendev.org/c/openstack/sushy/+/92837514:56
opendevreviewMerged openstack/sushy stable/2024.2: Update .gitreview for stable/2024.2  https://review.opendev.org/c/openstack/sushy/+/92837314:56
opendevreviewMerged openstack/sushy stable/2024.2: Update TOX_CONSTRAINTS_FILE for stable/2024.2  https://review.opendev.org/c/openstack/sushy/+/92837414:59
TheJuliayeouch 2024-09-06 14:51:32.607500 | controller | {0} ironic_tempest_plugin.tests.scenario.test_baremetal_basic_ops.BaremetalBasicOpsAndRescue.test_baremetal_server_ops_wholedisk_image [2162.904526s] ... ok15:00
dtantsurthat took a while15:00
opendevreviewMerged openstack/python-ironicclient master: Update master for stable/2024.2  https://review.opendev.org/c/openstack/python-ironicclient/+/92837215:02
opendevreviewMerged openstack/python-ironicclient stable/2024.2: Update .gitreview for stable/2024.2  https://review.opendev.org/c/openstack/python-ironicclient/+/92837015:02
opendevreviewMerged openstack/ironic-lib stable/2024.2: Update .gitreview for stable/2024.2  https://review.opendev.org/c/openstack/ironic-lib/+/92835415:03
opendevreviewMerged openstack/ironic-lib stable/2024.2: Update TOX_CONSTRAINTS_FILE for stable/2024.2  https://review.opendev.org/c/openstack/ironic-lib/+/92835715:03
opendevreviewMerged openstack/python-ironicclient stable/2024.2: Update TOX_CONSTRAINTS_FILE for stable/2024.2  https://review.opendev.org/c/openstack/python-ironicclient/+/92837115:03
opendevreviewMerged openstack/python-ironic-inspector-client master: Update master for stable/2024.2  https://review.opendev.org/c/openstack/python-ironic-inspector-client/+/92836915:05
opendevreviewMerged openstack/python-ironic-inspector-client stable/2024.2: Update .gitreview for stable/2024.2  https://review.opendev.org/c/openstack/python-ironic-inspector-client/+/92836715:05
opendevreviewMerged openstack/python-ironic-inspector-client stable/2024.2: Update TOX_CONSTRAINTS_FILE for stable/2024.2  https://review.opendev.org/c/openstack/python-ironic-inspector-client/+/92836815:05
* dtantsur is backporting CVE patches to OCP and already wants to scream15:05
cardoedtantsur: is there a wiki to add stuff to PTG topics? there was something recently I think JayF told me to bring up.15:15
dtantsurcardoe: https://etherpad.opendev.org/p/ironic-ptg-october-202415:15
opendevreviewJulia Kreger proposed openstack/ironic-python-agent stable/2023.1: CI: Dial back CI jobs for 2023.1  https://review.opendev.org/c/openstack/ironic-python-agent/+/92845315:35
TheJuliaJayF: when your on, lets chat about butfix/9.915:37
dtantsuras a data point: in metal3 we want to eventually use bugfix (or really any) branches for IPA. but we currently do not.15:38
TheJuliaI think that is unreasonable unless there is help to maintain CI on those branches. We can't simply swallow that and further spread limited resources15:40
TheJuliatoday, they bitrot15:40
dtantsurisn't 9.9 past the mark where we said we would maintain branches?15:41
TheJuliaYou guys said it needed to be kept longer...15:42
* TheJulia shrugs15:42
dtantsurit could have been about Ironic, we're not using IPA yet15:42
TheJuliaI highly doubt that15:42
dtantsurWell, the current state of things is. Metal3 relies on Ironic branches for some time. The oldest we use now is 24.0. Metal3 does not use IPA branches.15:43
TheJuliaWhy don't we just turn off all testing, merge the fix, the branch will be gone soon15:43
dtantsurFrom the OCP perspective, bugfix branches are helpful but nothing more. We have our own forks.15:43
dtantsurTheJulia: where I'm aiming at is: the branch should have been deleted already, and we don't really need to fix it.15:44
TheJuliaWell, we committed to merging it on the basis we were told not to delete it15:44
TheJuliabecause it was apparently needed15:44
TheJuliaSo, there is a middle ground neither of us are on15:44
TheJuliaso we have to find it15:44
dtantsurI cannot speak for all consumers15:44
TheJuliaexactly15:45
dtantsurAll I wanted to do is to give you the Metal3 perspective on bugfix/9.9 in IPA15:45
JayFI'm on board to kill all jobs on bugfix 9.9 to get it landed15:46
JayFThere's still an issue with IPA stable 2023.1. I'm going to continue looking at it today but I would suggest we consider disabling tempest on that temporarily too since it keeps failing on downloading centos15:46
TheJuliaJayF: I just pushed a patch up for that15:47
JayFBut I'm going to take one more swing at looking to see if there's a fix from ironic I can cherry pick over to IPA15:47
JayFAwesome thank you very much15:47
JayFThat patch doesn't appear to be disabling more than mine did?15:47
JayFEven that one job you still have enabled was failing on that patch that still labeled disable the examples job15:47
TheJuliaI didn't see another patch on ipa 2023.115:48
JayFIt's listed as a merge conflict against your patch right now if you want to quick link I'll grab it for you too15:48
JayFhttps://review.opendev.org/c/openstack/ironic-python-agent/+/92801415:48
TheJuliaI commented out the dib build job15:49
TheJuliain mine15:50
TheJuliabecause the URL has changed and at this point we're going to spend way more time trying to get that working than makes sense15:50
JayFOkay, at first glance I thought you had disabled the same job I did15:50
JayFI'm a little frustrated because I've thrown a lot of different things at that and it's perplexing to me why it's broken on IPA but not ironic15:50
opendevreviewJulia Kreger proposed openstack/ironic-python-agent bugfix/9.9: CI: Disable bugfix/9.9 testing  https://review.opendev.org/c/openstack/ironic-python-agent/+/92845515:51
TheJuliaI *suspect* we forced the generic jobs over to tinycore a while back on the ironic jobs15:52
JayFYeah that was the kind of patch I was going to look for to cherry pick over15:52
JayFHonestly I don't feel that bad if we have to bypass CI on that Branch given that I know it was tested manually15:52
JayFAnd I think it gets unmaintained in what, 3 months?15:53
dtantsurif you mean 9.9, 1 month ago?15:53
JayFI mean stable/2023.1 IPA15:54
dtantsurestimated 2024-10-3015:54
dtantsur 15:54
JayFTo be clear, I did not test any of the bugfix IPA patches in Dev stack15:54
JayFYeah, that's what I figured, about a month or so after our next release15:54
opendevreviewJulia Kreger proposed openstack/ironic-python-agent bugfix/9.9: CI: Disable bugfix/9.9 testing  https://review.opendev.org/c/openstack/ironic-python-agent/+/92845515:57
TheJuliaI think I need to have *something* in the list15:58
clarkbat the very least you'll need noop jobs in check and gate so that things can be merged15:58
TheJuliaclarkb: do you have an example job name?15:59
dtantsurIMO if you don't even run unit tests, it's worse than removing the branch15:59
TheJuliaor is it literal "noop" ?15:59
dtantsurit's a disservice to whoever is trying to consume it 15:59
TheJuliafor bugfix/9.9, there is no way15:59
clarkbTheJulia: it is literally `noop` it is a built in zuul return success immediately function for these situations16:00
dtantsurthen close it and move on16:00
TheJuliarequirements are toast, we could spend days on this16:00
clarkbjust use that as the job name in both check and gate and I think you'll be good16:00
JayFthanks :)16:00
TheJuliathanks16:01
JayFcardoe: fwiw things like our PTG etherpad are usually indexed on the Ironic whiteboard, linked from /topic16:01
JayFcardoe: don't assume all info in there is up to date, but it usually has links out to useful stuff16:01
opendevreviewJulia Kreger proposed openstack/ironic-python-agent bugfix/9.9: CI: Disable bugfix/9.9 testing  https://review.opendev.org/c/openstack/ironic-python-agent/+/92845516:02
TheJuliaokay, lets see how zuul likes this16:02
TheJuliawelp... templates didn't apply16:04
JayFhonestly maybe just add pep8?16:15
JayFwe know that passes and it might be the easiest solution16:16
* JayF would do it but doesn't want to cross streams16:16
dtantsurand gives you at least protection against things like missing imports16:16
opendevreviewJulia Kreger proposed openstack/ironic-python-agent bugfix/9.9: CI: Disable bugfix/9.9 testing  https://review.opendev.org/c/openstack/ironic-python-agent/+/92845516:19
TheJuliaThe template did apply16:19
TheJuliafwiw16:19
TheJuliaso the vmeida job, I think worked in a past run. I'm guessing we're just getting different resonses from mirrors?16:22
TheJulia*shrug*16:22
opendevreviewJulia Kreger proposed openstack/ironic-python-agent stable/2023.1: CI: Dial back CI jobs for 2023.1  https://review.opendev.org/c/openstack/ironic-python-agent/+/92845316:25
JayFTheJulia: https://github.com/openstack/ironic/commit/86358c89e80cb2d078d1aef705cb1609e22da5bb do we maybe need this?16:27
JayF(in ipa)16:27
JayFI am +1 to that recent patch anyway16:27
TheJuliathoughts on just disabling the unit test: https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_376/927975/4/check/openstack-tox-py36/37664f0/testr_results.html ?16:28
JayFyes16:28
JayFif you remmeber we almost considered not even putting the test module in the backports16:29
TheJuliaJayF: we're getting a 404, so it might mask it, dunno16:29
JayFdisable with prejudice16:29
JayFTheJulia: yeah, your more aggro patch to just stop the broken tempest jobs I think is better16:29
JayFTheJulia: although I guess we should consider if that means the new IPA ramdisks will fail in post...16:29
TheJuliayeah, it is expected for us to dial stuff back as time goes on16:29
TheJuliaand we're bad at that :)16:30
JayFyeah as long as ironic-python-agent-check-image-dib-centos9 https://zuul.opendev.org/t/openstack/build/a966dbf3e4cc4b8fa5f3934a966235d8 : FAILURE in 4m 13s (non-voting) fails16:30
JayFwe are not going to release a new fixed IPA16:30
JayFso merging the patch until we fix that seems useless? IDK16:30
JayF> Task  Build a DIB image failed running on host  ubuntu-focal16:31
JayFfocal seems bad16:31
JayFand the failure there is what that ironic commit fixes16:31
JayFgood16:31
* JayF applies that ironic commit16:32
JayFwait, we should have that, shouldn't we? 16:32
JayFhmmm16:32
JayFoh, it's not a devstack job I bet16:32
TheJuliayeah, focal is bad16:33
JayFwe should also check and verify we built new ramdisks for other IPA branches16:33
JayFI'll do that after I get down this 2023.1 rabbithole16:33
JayFI can nearly guarantee they aren't since this bug needed fixing in IPA-B to fix those jobs :( 16:35
TheJuliaugh16:35
JayFand it's all in ansible :( 16:36
JayFooh, I wonder if getting off focal fixes this entirely16:37
JayFsince it might punt that XML problem16:38
TheJuliamy revised ironic job dialback for yoga https://review.opendev.org/c/openstack/ironic/+/92829616:40
opendevreviewJay Faulkner proposed openstack/ironic-python-agent stable/2023.1: DNM: Science  https://review.opendev.org/c/openstack/ironic-python-agent/+/92845716:41
opendevreviewJay Faulkner proposed openstack/ironic-python-agent stable/2023.1: DNM: Science  https://review.opendev.org/c/openstack/ironic-python-agent/+/92845716:42
opendevreviewJay Faulkner proposed openstack/ironic-python-agent stable/2023.1: DNM: Science  https://review.opendev.org/c/openstack/ironic-python-agent/+/92845716:44
* JayF wishes we never split out ipa-b :( 16:52
JayFI think my science is working though16:52
JayFhttps://zuul.opendev.org/t/openstack/stream/10682d7872cd419b9092db35631977e5?logfile=console.log16:52
JayFjust changing the nodeset in IPA is enough16:52
JayFand all other IPA stable branches got ramdisks posted16:56
JayFhooray16:56
JayFI'm going to stack a change on top of your dial back CI jobs change to do the removal of the examples job and fix the build16:56
JayFthen we might be in business16:56
opendevreviewJay Faulkner proposed openstack/ironic-python-agent stable/2023.1: [stable-only] Multiple job fixes  https://review.opendev.org/c/openstack/ironic-python-agent/+/92801417:02
opendevreviewJay Faulkner proposed openstack/ironic-python-agent stable/2023.1: Inspect non-raw images for safety  https://review.opendev.org/c/openstack/ironic-python-agent/+/92797917:02
* JayF crosses fingers17:02
opendevreviewJay Faulkner proposed openstack/ironic-python-agent stable/2023.1: [stable-only] Multiple job fixes  https://review.opendev.org/c/openstack/ironic-python-agent/+/92801417:05
opendevreviewJay Faulkner proposed openstack/ironic-python-agent stable/2023.1: Inspect non-raw images for safety  https://review.opendev.org/c/openstack/ironic-python-agent/+/92797917:05
opendevreviewJay Faulkner proposed openstack/ironic-python-agent master: Migrate to oslo.utils-based format_inspector  https://review.opendev.org/c/openstack/ironic-python-agent/+/92846317:33
JayFThe changes to how format_inspector in oslo utils work is minimal, thankfully :) 17:34
TheJuliathat is good17:45
* TheJulia is ready for weekend()17:45
JayFcan you re-vote on the other two IPA stable/2023.1 patches attached to yours (^^^ those)? 17:47
JayFI think they'll all land at this point if approved17:47
TheJuliahttps://review.opendev.org/c/openstack/ironic/+/927975 could use a review vote, the CI fix patch is not stacked with it and also running now17:49
JayF+2 and I'll explicitly say here I'm very OK with you workflowing it once the CI is happy17:52
opendevreviewJay Faulkner proposed openstack/ironic-python-agent master: Cleanup usage of imported-from-ironic-lib disk_utils  https://review.opendev.org/c/openstack/ironic-python-agent/+/92846518:09
opendevreviewJay Faulkner proposed openstack/ironic-python-agent master: Use populate_image for all calls to write images  https://review.opendev.org/c/openstack/ironic-python-agent/+/92846618:09
opendevreviewJay Faulkner proposed openstack/ironic-python-agent master: Cleanup usage of imported-from-ironic-lib disk_utils  https://review.opendev.org/c/openstack/ironic-python-agent/+/92846618:10
TheJuliaJayF: looks like the only thing blocking us on https://review.opendev.org/q/I7fac5c64f89aec39e9755f0930ee47ff8f7aed47 is just yoga right now. Looks like we're going to have to recheck it once it fails19:02
JayFdo you need me to +A anything r/n?19:03
TheJulianah, just +2 stuff if you could unless we just don't care about merge ordering :)19:03
JayF+2A and recheck on yoga19:04
TheJuliaerrrr19:04
TheJuliathe fix for yoga ci hasn't merged yet19:04
JayFOH19:04
TheJuliayeah19:04
TheJuliano worries19:04
JayFif only you had said that like, an hour ago <.< >.> (you did lolsob)19:04
TheJulialol19:04
TheJuliait happens19:05
JayFI anticipate I'm going to ride off into the sunset in the next hour-90m and make up the time this weekend, so if there's anything I need to keep an eye on other than approving those as they pop in, lmk19:10
TheJuliaI'm pretty much in the darkness of sthe sunset now19:10
* TheJulia rechecks the yoga ci change19:11
JayFyeah, I think I'm going to go walk over to my desktop and record my "Ironic security alert" vid then head in that direction :)19:13
JayFI also have a deck about it, you all are welcome to use it if you need to explain what's up to anyone management-y https://docs.google.com/presentation/d/1dW8ShIgcE5GPP9rk4EBh8VxPHOFSCV_zusRRY_1SIqQ/edit?usp=sharing19:14
opendevreviewMerged openstack/ironic-python-agent stable/2023.1: CI: Dial back CI jobs for 2023.1  https://review.opendev.org/c/openstack/ironic-python-agent/+/92845319:17
opendevreviewMerged openstack/ironic-python-agent stable/2023.1: [stable-only] Multiple job fixes  https://review.opendev.org/c/openstack/ironic-python-agent/+/92801419:47
opendevreviewMerged openstack/ironic-python-agent stable/2023.1: Inspect non-raw images for safety  https://review.opendev.org/c/openstack/ironic-python-agent/+/92797919:47
JayFhoorah19:47
cardoemnaser: why is OSH so weird sometimes!?20:22
JayFhttps://review.opendev.org/c/openstack/ironic-python-agent/+/927985 and it's cherry-picked friends have been updated. We should land 'em but it's not extremely urgent given we've put in every notice these aren't getting patched and I'm skeptical anyone reads README files ;) 21:39
TheJuliahttps://review.opendev.org/q/I7fac5c64f89aec39e9755f0930ee47ff8f7aed47 yoga is on it's way22:44

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!