| opendevreview | Merged openstack/ironic master: Rework the navigation in the contributor guide https://review.opendev.org/c/openstack/ironic/+/922612 | 02:42 |
|---|---|---|
| opendevreview | Merged openstack/ironic master: Reorganize the documentation front page https://review.opendev.org/c/openstack/ironic/+/922484 | 02:42 |
| rpittau | good morning ironic! happy friday! o/ | 06:22 |
| janders | hey rpittau o/ Happy Friday | 06:35 |
| opendevreview | Derek Higgins proposed openstack/sushy master: Provide vmedia username and password if required https://review.opendev.org/c/openstack/sushy/+/923524 | 08:02 |
| opendevreview | Merged openstack/ironic master: Deprecated field in Redfish Driver https://review.opendev.org/c/openstack/ironic/+/922951 | 09:01 |
| iurygregory | good morning Ironic | 11:04 |
| dtantsur | JayF, Reverbverbverb, btw I did not simply ignore your comments on https://review.opendev.org/c/openstack/ironic/+/922484, I just had to delay this discussion until I clean up certain priorities downstream. Sorry for that, I'll get back to them soon and follow-up with whatever I have time and spoons for. | 11:30 |
| dtantsur | cid, please see my comment on https://review.opendev.org/c/openstack/ironic/+/922951 | 11:46 |
| dtantsur | this change breaks RAID, I believe | 11:47 |
| cid | ok, checking... | 12:00 |
| cid | oh, okay, on it now... | 12:07 |
| opendevreview | cid proposed openstack/ironic master: Follow-up to change that breaks RAID #922951 https://review.opendev.org/c/openstack/ironic/+/923570 | 12:19 |
| cid | dtantsur: this looks ugly a little; is it in order ^^ | 12:20 |
| opendevreview | cid proposed openstack/ironic master: Follow-up to change that breaks RAID #922951 https://review.opendev.org/c/openstack/ironic/+/923570 | 12:24 |
| dtantsur | cid: I don't think it's even possible for storage_controllers to ever raise AttributeError: https://opendev.org/openstack/sushy/src/branch/master/sushy/resources/system/storage/storage.py#L136-L137 | 13:09 |
| dtantsur | but if you want to handle it just in case, you can do something like `if getattr(storage, 'storage_controllers', None):`, which will cover both AttributeError and an empty value. | 13:10 |
| dtantsur | which makes me realize: storage_controllers is not a simple list | 13:11 |
| dtantsur | even worse, sushy attributes can raise MissingAttributeError which does not inherit AttributeError (a serious mistake on our side if you ask me) | 13:13 |
| cid | Hmm | 13:18 |
| cid | I was thinking both attributes are almost guaranteed to exist but there values could be None | 13:18 |
| cid | From your review comment | 13:18 |
| dtantsur | my comment could have been misleading, sorry for that | 13:19 |
| dtantsur | I'll try to leave a more precise comment now | 13:19 |
| cid | ack, I will update the patch as soon as I know the right direction :D | 13:20 |
| dtantsur | cid: okay, I've left 3 comments which I believe should fix the situation. Once you're done, I'll see if I can find a real machine to test this function on it (I cannot test the whole RAID unfortunately). | 13:25 |
| cid | ++ | 13:26 |
| mnaser | good morning ironic -- appreciate eyes on https://bugs.launchpad.net/ironic/+bug/2071972 -- pretty big caracal regression that hit us hard and dont want it to slip through cracks :< | 13:40 |
| dtantsur | I wonder how many of our Nova people are on the US holidays.. | 13:40 |
| mnaser | if I was to guess anything based on us canadians | 13:43 |
| mnaser | people usually grab the day to round up a long weekend :p | 13:43 |
| dtantsur | exactly, we do the same thing here (it even has a name: Brückentag - bridge day) | 13:47 |
| opendevreview | Dmitry Tantsur proposed openstack/ironic-inspector master: Deprecate the project https://review.opendev.org/c/openstack/ironic-inspector/+/923170 | 13:48 |
| dtantsur | rpittau: fixed the typo ^^ ptal | 13:48 |
| TheJulia | good morning | 14:15 |
| opendevreview | Kaifeng Wang proposed openstack/ironic master: Require hashed passwords for rescue by default https://review.opendev.org/c/openstack/ironic/+/923452 | 14:19 |
| opendevreview | Verification of a change to openstack/python-ironic-inspector-client master failed: Deprecate the project https://review.opendev.org/c/openstack/python-ironic-inspector-client/+/923176 | 14:24 |
| JayF | mnaser: Nova cores are still back porting security fixes. I will more aggressively pursue getting that merged and back ported once that is not their primary focus. | 14:26 |
| opendevreview | Merged openstack/ironic-inspector master: Deprecate the project https://review.opendev.org/c/openstack/ironic-inspector/+/923170 | 14:33 |
| opendevreview | Julia Kreger proposed openstack/ironic master: Require hashed passwords for rescue by default https://review.opendev.org/c/openstack/ironic/+/923452 | 14:43 |
| opendevreview | Dmitry Tantsur proposed openstack/python-ironic-inspector-client master: Deprecate the project https://review.opendev.org/c/openstack/python-ironic-inspector-client/+/923176 | 14:45 |
| opendevreview | Merged openstack/python-ironic-inspector-client master: Deprecate the project https://review.opendev.org/c/openstack/python-ironic-inspector-client/+/923176 | 15:08 |
| opendevreview | Julia Kreger proposed openstack/ironic-tempest-plugin master: Add http-iso to the standalone tests https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/923071 | 15:24 |
| TheJulia | oddness in the tempest tests == negative fun | 15:24 |
| opendevreview | Merged openstack/sushy master: Log the response when unable to parse JSON https://review.opendev.org/c/openstack/sushy/+/923210 | 15:25 |
| JayF | I am about to write a quick script to import all the docs audit work items into launchpad as bugs. If you object to this please speak now :) | 15:53 |
| dtantsur | Have a nice weekend folks o/ | 16:09 |
| TheJulia | o/ | 16:10 |
| JayF | o/ | 16:11 |
| * TheJulia is starting to feel much more human today | 16:12 | |
| * dtantsur is suspicious of humans! | 16:17 | |
| JayF | humans blowing things up kept my house awake through late last night lol | 16:20 |
| TheJulia | dtantsur: truly, I'm much more a vulcan than anything else | 16:22 |
| TheJulia | I just lack the ears | 16:22 |
| TheJulia | and the green blood | 16:22 |
| TheJulia | JayF: that is unfortunate. A plus side of being someplace where fireworks are strictly prohibited. It was nice and quiet. :) | 16:22 |
| TheJulia | ... now, in the desert, people were doing stupid stuff | 16:23 |
| JayF | it's strictly prohibited here, too, which is why people go to the parking lot/field at the school near me (to the left) or the elks lodge near me (to the right), set them off, and loudly speed away | 16:24 |
| TheJulia | That seems like a problem a nightvision scope and a .50 can solve... | 16:24 |
| * TheJulia has zero tolerance for people doing crap like that | 16:25 | |
| JayF | You know I'm a pacifist :D definition of all bark no bite right here | 16:25 |
| TheJulia | :) | 16:29 |
| JayF | https://bugs.launchpad.net/ironic/+bugs?field.tag=docs-audit-2024 I'm going to go through and triage them all to low | 16:50 |
| opendevreview | Julia Kreger proposed openstack/ironic-tempest-plugin master: Add http-iso to the standalone tests https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/923071 | 16:55 |
| JayF | cardoe: okay, looking at your stable question now. This is the openstack stable policy: https://docs.openstack.org/project-team-guide/stable-branches.html ... the tl;dr in practice is: 1) You gotta go newest->oldest, in order (you can't patch 2023.1 until 2023.2 is patched until 2024.1 is patched) -- basically we never want someone to upgrade into a bug. 2) Cherry-pick the patch from the next-oldest branch (e.g. master -> | 16:56 |
| JayF | 2024.1, then 2024.1 patch -> 2023.2, etc) noting any conflicts in the commit message. It's ideal, and some projects require that you have the chain of "Cherry picked from ..." messages on the commit. .... the easiest way to do this is basically `cd ironic; git checkout gerrit/stable/2024.1; git review -X 123456` where 123456 is the master branch patch that landed you want to put in 2024.1 (you'd use the number from 2024.1 for | 16:56 |
| JayF | 2023.2) | 16:56 |
| opendevreview | cid proposed openstack/ironic master: Follow-up to change; #922951 breaks RAID https://review.opendev.org/c/openstack/ironic/+/923570 | 17:28 |
| opendevreview | cid proposed openstack/ironic master: Follow-up to change; #922951 breaks RAID https://review.opendev.org/c/openstack/ironic/+/923570 | 17:36 |
| cid | dtantsur: Updated ^^ | 17:37 |
| opendevreview | cid proposed openstack/ironic master: Follow-up to change; #922951 breaks RAID https://review.opendev.org/c/openstack/ironic/+/923570 | 17:45 |
| TheJulia | looks like the anaconda job is running a bit long right now :( | 19:02 |
| opendevreview | Julia Kreger proposed openstack/ironic master: CI: Allow standalone-redfish to leverage vmedia https://review.opendev.org/c/openstack/ironic/+/923589 | 19:25 |
| cid | o// | 19:45 |
| opendevreview | Julia Kreger proposed openstack/ironic master: CI: set tftp folder permission https://review.opendev.org/c/openstack/ironic/+/923590 | 20:02 |
| opendevreview | Julia Kreger proposed openstack/ironic-tempest-plugin master: Add http-iso to the standalone tests https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/923071 | 20:03 |
| opendevreview | Julia Kreger proposed openstack/ironic-tempest-plugin master: Permit boot_interface to be updated :( https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/923591 | 20:03 |
| TheJulia | wheeeeeeeeeeee | 20:09 |
| iurygregory | weeeeee | 20:17 |
| opendevreview | Julia Kreger proposed openstack/ironic master: CI: set tftp folder permission https://review.opendev.org/c/openstack/ironic/+/923590 | 21:06 |
| opendevreview | Julia Kreger proposed openstack/ironic master: CI: set tftp folder permission https://review.opendev.org/c/openstack/ironic/+/923590 | 23:42 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!