opendevreview | Julia Kreger proposed openstack/ironic-python-agent stable/2023.1: Unmount config drives https://review.opendev.org/c/openstack/ironic-python-agent/+/917852 | 02:56 |
---|---|---|
cid | TheJulia: I saw the new patch and rebase 👍, time to touch the skipping logic. | 05:18 |
cid | By the way, I haven't been fully active so far this week on my pending changes, and I assume the same for the next as well. | 05:26 |
cid | Some personal stuff. | 05:26 |
rpittau | good morning ironic! o/ | 07:25 |
opendevreview | Jacob Anders proposed openstack/bifrost master: Make boot_interface customisable https://review.opendev.org/c/openstack/bifrost/+/917927 | 08:07 |
opendevreview | Jacob Anders proposed openstack/bifrost master: Make boot_interface customisable https://review.opendev.org/c/openstack/bifrost/+/917927 | 08:26 |
opendevreview | Tudor Domnescu proposed openstack/ironic-lib master: destroy_disk_metadata: support 4096 sector size https://review.opendev.org/c/openstack/ironic-lib/+/917937 | 09:34 |
rpittau | hi all, I'm giving another chance to review the work items for 2024.2 https://review.opendev.org/c/openstack/ironic-specs/+/916295 it has already 2 +2, would like to merge it tomorrow | 09:44 |
iurygregory | good morning Ironic | 11:28 |
iurygregory | TheJulia, tks for the answer yesterday (I only saw now) | 11:29 |
* iurygregory adds service_step field and /history to the list | 11:31 | |
TheJulia | cid: no worries, life is that way some times for all of us :) | 12:59 |
TheJulia | cid: so, I don't think the skip logic needs to be adjusted, I changed the test to one which is valid. I also put in another patch to remove the old tests from the ironic-tempest-plugin as well | 12:59 |
opendevreview | Tudor Domnescu proposed openstack/ironic-lib master: destroy_disk_metadata: support 4096 sector size https://review.opendev.org/c/openstack/ironic-lib/+/917937 | 13:33 |
cid | TheJulia: Ermm, okay, I will take a look later. The last time, it was skipping tests. | 14:00 |
TheJulia | oh, :( | 14:03 |
TheJulia | yup, still skipping | 14:03 |
TheJulia | weird | 14:03 |
TheJulia | cid: I guess look at the test state and look at the actual state in ironic because it did skip ironic_tempest_plugin.tests.scenario.ironic_standalone.test_basic_ops.BaremetalDriverDirectWholedisk | 14:04 |
TheJulia | which realistically should have just worked if the node was present | 14:04 |
TheJulia | Interesting, yeah | 14:05 |
TheJulia | It loaded the plugin and immediately skipped without anything else being logged | 14:06 |
TheJulia | https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_b3e/915441/19/check/ironic-standalone-aarch64/b3e54a3/controller/logs/tempest_log.txt | 14:06 |
cid | Yeah. Same thing I saw earlier. | 14:08 |
cid | I will definitely take a closer look | 14:09 |
rpittau | good night! o/ | 16:03 |
JayF | cid: Take care of yourself+family, it's important o/ | 17:20 |
opendevreview | Julia Kreger proposed openstack/ironic-tempest-plugin master: Additional test state fixes https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/918001 | 17:47 |
TheJulia | If I've learned anything with tempest this past month, it is to pay close attention to inputs when folks do anything with the state machine in a test | 17:53 |
TheJulia | hmm... I'm cursed on 2023.1 | 17:59 |
JayF | So I was thinking about self-serve templates last night | 18:04 |
JayF | And I kinda wanna call them runbooks? | 18:05 |
JayF | instead of overloading "template" since we'll still have deploy templates | 18:05 |
JayF | and that, at least to my US-centric self seems to be the perfect word for it; I'm unsure how common use of that term is internationally / outside of bigger companies | 18:05 |
TheJulia | I feel like runbooks sort of haralds back to IBM of ages past | 18:10 |
TheJulia | and playbooks sort of (also over used and now sort of name conflicts) draws from the same sphere | 18:11 |
* TheJulia feels like there is deja vu somewhere here | 18:11 | |
JayF | playbook/cookbook/recipe were all in this category for me | 18:11 |
JayF | I was trying to think of the collective noun for "a set of steps" and those 4 words were mostly all I could come up with | 18:12 |
JayF | assuming we don't want /v1/furniture_assembly_pamplet | 18:12 |
TheJulia | if we have such an endpoint | 18:13 |
TheJulia | we will need generic figures of humanoids with tools | 18:13 |
TheJulia | and it will need to render html pages | 18:13 |
JayF | I can provide my perplexed face beside a badly assembled piece of European furniture for content :) | 18:14 |
TheJulia | And then, heh | 18:15 |
TheJulia | err | 18:15 |
TheJulia | heh | 18:15 |
TheJulia | I guess I like templates, I just wish there was a way to combine everything together and I think that is sort of why we got so confused early on as well | 18:20 |
TheJulia | we *want* that simplicity of commonality | 18:21 |
JayF | well, split this hair with me here | 18:25 |
JayF | a template is "we have a thing you can inject stuff into" | 18:25 |
JayF | Deploy templates are this: you create a list of steps, we hydrate that template with the required steps, and keep going (I could see fitting automated clean into this model if we ever wanted it to be more declarative) | 18:26 |
JayF | Step Runbooks are not templates in this way -- they are recipes or runbooks created to do *exactly the thing it does* not anything else | 18:27 |
JayF | You could potentially even argue that using the word template for this feature is even more confusing for this | 18:27 |
* JayF just realized that a collection of steps is a dance or coreography | 18:28 | |
JayF | oh snap, it's a script!!!! | 18:28 |
JayF | thank you thesaurus | 18:28 |
JayF | eh, maybe not, I hate all these for different reasons | 18:29 |
TheJulia | So, when do we start making IMDB entries?! | 18:29 |
TheJulia | since we're talking about scripts and all!? | 18:29 |
JayF | I will say, I'm fairly convinced reusing the word templates is wrong | 18:30 |
JayF | two kinds of templates in Ironic is us being very inexact with naming things and more time to think of a better word will payoff in less decoder rings later (I hope?) | 18:30 |
TheJulia | (and potentially, "i just want to upload this bash script to the script endpoint!?") | 18:33 |
TheJulia | ((but, your making sense to me)) | 18:34 |
JayF | this is why I love runbook | 18:34 |
JayF | because that models the real world thing it's replacing | 18:34 |
JayF | and hydrates the use cases immediately | 18:34 |
TheJulia | .... | 18:43 |
TheJulia | At some point we should restore the coffee pot driver and also include a "bread machine" driver | 18:44 |
TheJulia | well, the coffee pot driver was never in tree | 18:44 |
JayF | TheJulia: after an informal poll in a couple of IRC channels I'm in, I think I'm going for "runbook" unless you have an objection | 19:06 |
TheJulia | none from here | 19:14 |
opendevreview | Jay Faulkner proposed openstack/ironic-specs master: Self-Service via Runbooks https://review.opendev.org/c/openstack/ironic-specs/+/890164 | 21:57 |
JayF | holy cow, I learned a cool thing just now: ❯ cat /proc/sys/kernel/random/uuid => 15aae853-b670-4c2a-9cd9-618d7320402a | 21:59 |
opendevreview | Jay Faulkner proposed openstack/ironic-specs master: Self-Service via Runbooks https://review.opendev.org/c/openstack/ironic-specs/+/890164 | 22:15 |
opendevreview | Jay Faulkner proposed openstack/ironic-specs master: Set basepython for docs builds https://review.opendev.org/c/openstack/ironic-specs/+/918013 | 22:18 |
JayF | rpittau: dtantsur: iurygregory: I'd appreciate your feedback on https://review.opendev.org/c/openstack/ironic-specs/+/890164 -- especially around the use of the word "runbook" to describe the object now | 22:19 |
iurygregory | JayF, ack I will add to my list to look at it | 22:21 |
JayF | iurygregory: you have a seat-of-the-pants feeling about the name right now? | 22:21 |
iurygregory | regarding runbook? | 22:23 |
JayF | yeah | 22:23 |
JayF | callin' em runbooks instead of "step templates" or something similarly awkward | 22:23 |
iurygregory | sounds interesting | 22:23 |
JayF | uh oh | 22:23 |
iurygregory | I liked when I saw the title :D | 22:23 |
JayF | interesting usually I take as a negative connotation | 22:24 |
JayF | e.g. the ancient curse of "may you live in interesting times" | 22:24 |
iurygregory | ohhhh | 22:24 |
iurygregory | ok, let me find a better word to express myself :D | 22:25 |
JayF | hehehee | 22:25 |
JayF | I liked it when I saw the title was all I wanted | 22:25 |
JayF | :P | 22:25 |
iurygregory | fascinating lol :D | 22:25 |
iurygregory | better? | 22:25 |
iurygregory | I'm without energy since I just got back from the gym, need more coffee :D | 22:26 |
JayF | https://www.thesaurus.com/browse/amazing any one of these will work /s | 22:26 |
iurygregory | marvelous - because I like the way it sound :D | 22:27 |
JayF | Everyone loves themselves some GPT. The only large language model I need is a nice thick roget's thesaurus /s | 22:28 |
JayF | Does anyone have an email for dking? If so can you drop it to me in a DM or do an email into so I have his address. | 22:38 |
JayF | use git jay, duh | 22:38 |
iurygregory | I was going to say to check the email in the patches :D | 22:40 |
JayF | it does look like a git-specific-spambox but it's more than what I have, I'll take it lol | 22:41 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!