| opendevreview | Jacob Anders proposed openstack/sushy-tools master: [WIP] Replace hardcoded BiosVersion with an updatable field https://review.opendev.org/c/openstack/sushy-tools/+/909487 | 01:11 |
|---|---|---|
| opendevreview | ZhouHao proposed openstack/ironic-specs master: Add field to accept the default verify_ca path https://review.opendev.org/c/openstack/ironic-specs/+/912050 | 01:15 |
| opendevreview | ZhouHao proposed openstack/ironic-specs master: Add field to accept the default verify_ca path https://review.opendev.org/c/openstack/ironic-specs/+/912050 | 01:19 |
| opendevreview | ZhouHao proposed openstack/ironic-specs master: Add field to accept the default verify_ca path https://review.opendev.org/c/openstack/ironic-specs/+/912050 | 01:20 |
| opendevreview | Julia Kreger proposed openstack/ironic stable/zed: stable only/ci: pin CI to dnsmasq 2.85/pin proliantutils/scciclient https://review.opendev.org/c/openstack/ironic/+/911158 | 01:27 |
| opendevreview | ZhouHao proposed openstack/ironic-specs master: Add field to accept the default verify_ca path https://review.opendev.org/c/openstack/ironic-specs/+/912050 | 01:50 |
| opendevreview | Youngjun Yoo proposed openstack/sushy master: refectoring: code modification to distinguish indents https://review.opendev.org/c/openstack/sushy/+/912690 | 02:03 |
| opendevreview | Youngjun Yoo proposed openstack/sushy master: refectoring: Fix parameter and annotation mismatch https://review.opendev.org/c/openstack/sushy/+/912691 | 02:06 |
| opendevreview | Youngjun Yoo proposed openstack/sushy master: refectoring: code modification to distinguish indents https://review.opendev.org/c/openstack/sushy/+/912690 | 02:07 |
| opendevreview | Youngjun Yoo proposed openstack/sushy master: refectoring: remove unnecessary function https://review.opendev.org/c/openstack/sushy/+/912692 | 02:15 |
| opendevreview | Youngjun Yoo proposed openstack/sushy master: refectoring: replace code to function https://review.opendev.org/c/openstack/sushy/+/912693 | 02:20 |
| opendevreview | Youngjun Yoo proposed openstack/sushy master: refectoring: replace code to function https://review.opendev.org/c/openstack/sushy/+/912693 | 02:22 |
| opendevreview | Youngjun Yoo proposed openstack/sushy master: refectoring: replace code to function https://review.opendev.org/c/openstack/sushy/+/912693 | 02:24 |
| opendevreview | Youngjun Yoo proposed openstack/sushy master: refectoring: remove unnecessary function https://review.opendev.org/c/openstack/sushy/+/912692 | 02:26 |
| opendevreview | Youngjun Yoo proposed openstack/sushy master: refectoring: replace code to function https://review.opendev.org/c/openstack/sushy/+/912693 | 02:27 |
| opendevreview | Jacob Anders proposed openstack/sushy-tools master: [WIP] Add support for BIOS update emulation https://review.opendev.org/c/openstack/sushy-tools/+/909500 | 05:42 |
| opendevreview | Youngjun Yoo proposed openstack/sushy master: refectoring: remove unnecessary function https://review.opendev.org/c/openstack/sushy/+/912692 | 05:50 |
| opendevreview | Youngjun Yoo proposed openstack/sushy master: refectoring: replace code to function https://review.opendev.org/c/openstack/sushy/+/912693 | 06:00 |
| opendevreview | Jacob Anders proposed openstack/sushy-tools master: [WIP] Replace hardcoded BiosVersion with an updatable field https://review.opendev.org/c/openstack/sushy-tools/+/909487 | 06:16 |
| opendevreview | Jacob Anders proposed openstack/sushy-tools master: [WIP] Add support for BIOS update emulation https://review.opendev.org/c/openstack/sushy-tools/+/909500 | 06:24 |
| opendevreview | Youngjun Yoo proposed openstack/sushy master: refectoring: remove unnecessary function https://review.opendev.org/c/openstack/sushy/+/912692 | 06:30 |
| rpittau | good morning ironic! o/ | 07:55 |
| masghar | good morning! | 08:15 |
| opendevreview | Merged openstack/ironic-python-agent master: Force constraints when installing a package during tox test https://review.opendev.org/c/openstack/ironic-python-agent/+/908787 | 08:23 |
| zigo | Hi there! A question, if there's some NGS people around. I see that in the NGS sources, there's a tempest_plugin folder. Where is it supposed to be installed? Maybe in /usr/lib/python3/dist-packages/tempest_plugin ? If so, then it's going to conflict with other plugins, no? | 08:24 |
| zigo | Also, is there an agent for NGS ? I haven't seen one in setup.cfg. | 08:38 |
| dtantsur | zigo: I don't think it was supposed to be installed, I think we named it like that to discourage installation. | 08:54 |
| zigo | dtantsur: Why doing this? In my packaged environment, I'm legitimate to install it, no? | 09:23 |
| zigo | FYI, I do run tempest to validate each release... | 09:23 |
| dtantsur | You're welcome to, assuming you know what you're doing. I.e. that's it not a a real tempest plugin and will mess with your local networking. | 09:23 |
| zigo | And I packaged all tempest plugins. | 09:23 |
| zigo | Oh ... | 09:23 |
| dtantsur | Normal tempest plugins only check the API though | 09:23 |
| dtantsur | they don't rely on the way the local stuff is set up | 09:24 |
| zigo | dtantsur: So, you're suggesting I don't package this part, and never use it? | 09:24 |
| dtantsur | Yep. FWIW I told RDO people the same. | 09:24 |
| zigo | Ok. | 09:24 |
| zigo | dtantsur: And about my other question: there's no agent for NGS, right? | 09:24 |
| dtantsur | I'm not sure what you mean under 'agent' there. Maybe hjensas knows. | 09:25 |
| zigo | I mean a daemon that would run for NGS. | 09:25 |
| zigo | What does the ssh in the switches? | 09:25 |
| zigo | neutron-rpc-server itself? | 09:25 |
| zigo | Or neutron-api, maybe? | 09:25 |
| opendevreview | Merged openstack/sushy master: refectoring: Fix parameter and annotation mismatch https://review.opendev.org/c/openstack/sushy/+/912691 | 09:27 |
| opendevreview | Takashi Kajinami proposed openstack/ironic master: Update regex to detect closed branch https://review.opendev.org/c/openstack/ironic/+/912730 | 10:31 |
| opendevreview | Takashi Kajinami proposed openstack/ironic master: Ignore generated config/policy file https://review.opendev.org/c/openstack/ironic/+/907556 | 10:32 |
| opendevreview | Adam Rozman proposed openstack/sushy-tools master: improve volume boot mode support https://review.opendev.org/c/openstack/sushy-tools/+/912113 | 10:34 |
| opendevreview | Takashi Kajinami proposed openstack/ironic master: Guide users/developers to launchpad https://review.opendev.org/c/openstack/ironic/+/912732 | 10:35 |
| opendevreview | Takashi Kajinami proposed openstack/ironic-inspector master: Update bug tracker url https://review.opendev.org/c/openstack/ironic-inspector/+/912733 | 10:37 |
| opendevreview | Takashi Kajinami proposed openstack/ironic-inspector master: Update regex to detect closed branch https://review.opendev.org/c/openstack/ironic-inspector/+/912735 | 10:39 |
| opendevreview | Takashi Kajinami proposed openstack/ironic-python-agent master: Update regex to detect closed branch https://review.opendev.org/c/openstack/ironic-python-agent/+/912736 | 10:41 |
| rpittau | aaand metalsmith legacy is broken on ironic CI too \o/ | 11:05 |
| opendevreview | Adam Rozman proposed openstack/sushy-tools master: improve volume boot mode support https://review.opendev.org/c/openstack/sushy-tools/+/912113 | 11:08 |
| opendevreview | Riccardo Pittau proposed openstack/ironic master: Implement generic redfish vmedia attach detach https://review.opendev.org/c/openstack/ironic/+/912516 | 11:10 |
| iurygregory | good morning Ironic | 11:19 |
| Nisha_Agarwal | rpittau, hi | 12:06 |
| Sandzwerg[m] | Morning ironic. Can someone tell me how I could enumerate "ironic.hardware.interfaces.rescue"? I'm looking for the value for the Redfish driver but I don't see the possible values mentioned in the docs | 12:30 |
| iurygregory | Sandzwerg[m], if I'm not mistaken, you can run openstack baremetal driver show redfish, this will output the interfaces you can use also | 12:35 |
| iurygregory | but the only available rescue interfaces are agent, fake and no-rescue | 12:36 |
| iurygregory | https://opendev.org/openstack/ironic/src/branch/master/setup.cfg#L166 | 12:36 |
| Sandzwerg[m] | Isn't that what I have currently configured? Because I did run that but only see no-rescue but Redfish should support rescue afaik | 12:37 |
| iurygregory | I think you can configure to use agent | 12:38 |
| Sandzwerg[m] | Yeah that is probably correct but it's never mentioned anywhere, not in the Redfish driver page and not on the rescue page as well | 12:39 |
| Sandzwerg[m] | I found third party documentation by redhat that mentioned agent as possible value | 12:39 |
| rpittau | Nisha_Agarwal: hi :) | 13:27 |
| rpittau | Nisha_Agarwal: I replied to your comment | 13:34 |
| TheJulia | I guess a lack of clarity around rescue would make sense, it was... the second interface merged if memory serves | 13:49 |
| TheJulia | easy enough to fix, though | 13:49 |
| TheJulia | ci fixes for zed: https://review.opendev.org/c/openstack/ironic/+/911158 and yoga: https://review.opendev.org/c/openstack/ironic/+/911156 | 13:51 |
| iurygregory | looking now | 13:53 |
| opendevreview | Merged openstack/ironic master: Guide users/developers to launchpad https://review.opendev.org/c/openstack/ironic/+/912732 | 14:06 |
| TheJulia | a relatively simple docs only change https://review.opendev.org/c/openstack/ironic/+/909953 | 14:15 |
| dtantsur | +W | 14:48 |
| TheJulia | added ironic-week-prio to the prelude patch (https://review.opendev.org/c/openstack/ironic/+/912679) | 14:52 |
| opendevreview | Riccardo Pittau proposed openstack/ironic master: Temporary move metalsmith legacy CI job to non-voting https://review.opendev.org/c/openstack/ironic/+/912785 | 15:11 |
| opendevreview | Julia Kreger proposed openstack/ironic stable/xena: stable only/ci: pin CI to dnsmasq 2.85/pin proliantutils https://review.opendev.org/c/openstack/ironic/+/911159 | 15:11 |
| TheJulia | rpittau: i found an older branch pulling master tinycore based images in yesterday | 15:12 |
| TheJulia | and it was definitely breaking those jobs as well | 15:12 |
| TheJulia | fix is included in the general fix patch for yoga | 15:12 |
| rpittau | TheJulia: it's breaking on legacy only though, right? I mean it seems to work on UEFI | 15:12 |
| rpittau | TheJulia: sorry, which fix? | 15:13 |
| TheJulia | https://github.com/openstack/ironic/blob/stable/2023.2/devstack/lib/ironic#L316 | 15:13 |
| TheJulia | that is the problem | 15:13 |
| dtantsur | \o/ | 15:14 |
| dtantsur | We really need to start respecting ZUUL_BRANCH | 15:14 |
| dtantsur | (same for bifrost) | 15:14 |
| iurygregory | "master" ouch >.< | 15:14 |
| TheJulia | okay, I thought i fixed it | 15:15 |
| rpittau | it may be my neckpain+headache talking but shouldn't that be ok for master branch? | 15:15 |
| TheJulia | https://github.com/openstack/ironic/blob/stable/2023.2/devstack/lib/ironic#L316 <-- there we go | 15:15 |
| TheJulia | rpittau: look at the branch name I'm linking from | 15:15 |
| TheJulia | same in 2023.1 as well | 15:16 |
| rpittau | TheJulia: yes, that's clear, we need to point to 2023.2 there | 15:16 |
| TheJulia | its not a huge deal, really | 15:16 |
| rpittau | but in master should be ok | 15:16 |
| TheJulia | oh yeah, in master it is fine but dtantsur's suggestion is actually the right path | 15:16 |
| TheJulia | for master branch specifically | 15:16 |
| rpittau | ok | 15:16 |
| rpittau | yeah, of course | 15:17 |
| rpittau | TheJulia: can we use IRONIC_PYTHON_AGENT_BRANCH or TARGET_BRANCH as default maybe ? | 15:19 |
| TheJulia | I would just set an intermediate variable if not already set, say ZUUL_BRANCH, or perhaps target branch (which will need to respect zuul_branch | 15:19 |
| TheJulia | ) | 15:19 |
| TheJulia | and then set that if not otherwise overridden on the single parameter level | 15:20 |
| opendevreview | Merged openstack/ironic stable/zed: stable only/ci: pin CI to dnsmasq 2.85/pin proliantutils/scciclient https://review.opendev.org/c/openstack/ironic/+/911158 | 15:25 |
| Nisha_Agarwal | rpittau, i have replied to ur comment on the patch and i see the proliantutils change is must for 2024.1 else proliantutils installation will fail on the system and ilo drivers cannot work without proliantutils. | 15:31 |
| Nisha_Agarwal | rpittau, i will raise the ironic patch for driver-requirements for proliantutils to be correct. | 15:32 |
| dking | Is there a docker container or some special environment in which you would run your IPA unit tests? I'm running from a python:3.9 docker container with tox installed. The unit tests pass but the functional tests fail because it can't find a real /dev/disk/by-path directory. What other things need to exist? | 15:36 |
| dking | I'm speaking about local testing, of course. I know that there's a lot that goes into the upstream testing. | 15:36 |
| JayF | I'm not sure I've ever run IPA functional tests locally. | 15:36 |
| dking | JayF: How do you know they'll pass before you pass the changes up? | 15:37 |
| JayF | I've not made a change to IPA that would impact the functional tests in a long, long time. Most of my work in IPA was very early on :) | 15:37 |
| JayF | I do think it's OK if you have unit tests and flake8 passing, if you don't think functional tests will be impacted, to push it up and see what upstream tests say | 15:38 |
| dking | Mine don't affect the functional tests. It's just that if I run the standard tox env, that's what I get. I suppose that I could do py3 and pep8 separately, but I figured that it might be good to test functional if possible because it's good practice to make sure that you don't break something functional as well. | 15:39 |
| dking | Okay, that's probably fair. | 15:39 |
| JayF | ah yeah, I do `tox -epep8` `tox -epy3` separately | 15:39 |
| JayF | I only run more if it's a sizable change I expect could break things, which hasn't happened in ages | 15:40 |
| JayF | in fact it's possible I haven't made a meaty change to IPA since I had real-hardware to test it on :/ | 15:40 |
| dking | I've noticed that when I work with other people's code, I tend to find things that bug me. Obviously, when in Rome... But still, I have so much trouble getting over visual indentation for method parameters. If you modify the starting line, you have to modify all of the following lines also. | 15:47 |
| dking | That and no fakers makes me sad. | 15:47 |
| rpittau | dking: I usually use a CentOS Stream 9 based container for unit tests | 15:47 |
| JayF | dking: I get the reverse. Look at a non-openstack style python change, and all the sudden I'm like "is this wrong or just different?" all over the place | 15:48 |
| dking | rpittau: I might try that. It's probably not a bad idea as that's the base image I use for my PXE images. | 15:48 |
| clarkb | I'm just happy if people bother to write commit messages | 15:48 |
| JayF | git commit -m 'fix' -a && git-review | 15:48 |
| rpittau | dking: that's the same reason I use that, compatibility with our ironic containers :) | 15:48 |
| dking | clarkb: +1 | 15:48 |
| dking | rpittau: What is the image and tag exactly? I use the disk image, but I don't know that I've used the docker image since they went to stream. | 15:52 |
| rpittau | dking: quay.io/centos/centos:stream9 | 15:53 |
| dking | Ah, makes sense. Thank you. | 15:53 |
| rpittau | np! | 15:53 |
| dking | As a side note, Taskfiles make my life so much better. | 15:55 |
| dking | Well, it looks like I get the same errors with a CentOS image. And I'm not planning to run the thing with special privileges just for the functional tests. | 16:01 |
| opendevreview | Merged openstack/ironic master: Modify ESP configuring script of redfish document https://review.opendev.org/c/openstack/ironic/+/909953 | 16:29 |
| TheJulia | sigh, I guess the branch renames went through | 16:48 |
| TheJulia | what a cluster... | 16:49 |
| rpittau | good night! o/ | 17:22 |
| opendevreview | Mohammed Boukhalfa proposed openstack/sushy-tools master: Add fake_ipa inspection, lookup and heartbeater to fake system https://review.opendev.org/c/openstack/sushy-tools/+/875366 | 17:41 |
| NobodyCam | Good morning Openstack Folks, Happy hump day | 18:38 |
| NobodyCam | crazy question, Any known issues when manually creating a neutron port and using "server create with --port" to deploy on SMC hardware? | 18:40 |
| NobodyCam | works fine if I do not supply --port and allow it dynamically pick a ip | 18:41 |
| TheJulia | none that I'm aware of, in that case the only difference is nova creates a port | 19:00 |
| NobodyCam | +++ | 19:37 |
| opendevreview | Jay Faulkner proposed openstack/ironic master: [DNM/Science] 𝆕 Green is the color of my DNS 𝆕 https://review.opendev.org/c/openstack/ironic/+/910657 | 21:11 |
| opendevreview | Jay Faulkner proposed openstack/ironic master: Release notes prelude for 2024.1/24.1 https://review.opendev.org/c/openstack/ironic/+/912679 | 21:13 |
| * TheJulia fires up blender to render "PURPLE!" | 21:13 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!