| opendevreview | Adam McArthur proposed openstack/ironic-python-agent master: Adding support for viewing individual cpu process info https://review.opendev.org/c/openstack/ironic-python-agent/+/909346 | 02:27 |
|---|---|---|
| opendevreview | Adam McArthur proposed openstack/ironic-python-agent master: WIP Adding support for viewing individual cpu process info https://review.opendev.org/c/openstack/ironic-python-agent/+/909346 | 02:31 |
| adamcarthur5 | Thanks for the rebases TheJulia :)) | 02:34 |
| *** tkajinam is now known as Guest213 | 08:56 | |
| opendevreview | cid proposed openstack/ironic master: Remove unsupported rpc methods https://review.opendev.org/c/openstack/ironic/+/909263 | 13:36 |
| opendevreview | Damien RANNOU proposed openstack/ironic-python-agent master: USB device discovery https://review.opendev.org/c/openstack/ironic-python-agent/+/902769 | 13:50 |
| opendevreview | Kamil Gustab proposed openstack/sushy master: WIP for adding Ethernet Interfaces for manager. https://review.opendev.org/c/openstack/sushy/+/909451 | 13:50 |
| TheJulia | good morning | 13:52 |
| TheJulia | cid: o/ https://github.com/openstack/ironic/blob/master/ironic/conductor/manager.py#L939 and https://github.com/openstack/ironic/blob/master/ironic/conductor/manager.py#L1208 perhaps as a next patch :) | 14:02 |
| masghar | Good morning! | 14:04 |
| dtantsur | Folks, could I get some reviews on this relatively easy patch https://review.opendev.org/c/openstack/bifrost/+/906635 please? It's blocking the further inspection work in bifrost. | 14:12 |
| cid | TheJulia: thanks. I think I needed that pointer ¯_(ツ)_/¯ | 14:18 |
| JayF | I'll kick off the meeting in a couple minutes. | 15:00 |
| JayF | #startmeeting Ironic | 15:03 |
| opendevmeet | Meeting started Mon Feb 19 15:03:14 2024 UTC and is due to finish in 60 minutes. The chair is JayF. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:03 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:03 |
| opendevmeet | The meeting name has been set to 'ironic' | 15:03 |
| JayF | Welcome to the Ironic meeting o/ | 15:03 |
| JayF | #topic Announcements/Reminder | 15:03 |
| TheJulia | o/ | 15:03 |
| masghar | o/ | 15:03 |
| JayF | #info Standing reminder to review patches tagged ironic-week-prio and to hashtag any patches ready for review with ironic-week-prio: https://tinyurl.com/ironic-weekly-prio-dash | 15:03 |
| dtantsur | o/ | 15:03 |
| JayF | #info Next PTG Monday April 8 - Fri April 12. Make sure you register at https://openinfra.dev/ptg/ and review the etherpad at https://etherpad.opendev.org/p/ironic-ptg-april-2024 | 15:04 |
| JayF | #topic Review action items | 15:05 |
| JayF | Only one action, and I can confirm it's done -- rpittau reached out to PTG folks and got us signed up. Thanks! | 15:05 |
| JayF | #topic Caracal Release Schedule | 15:05 |
| dtantsur | rpittau++ | 15:06 |
| JayF | Release is closing up quickly, please get your changes in and reviewed. I'll be working on a couple of nova changes which need to be code complete by C-3. | 15:06 |
| JayF | I'm skipping the next topic ;re CERN meetup, I think it's leftover from previous meetings. | 15:06 |
| JayF | #topic Review Ironic CI Status | 15:06 |
| JayF | How is CI? | 15:06 |
| JayF | I think TheJulia might have knocked out the last stragglers from the scope default change? | 15:06 |
| TheJulia | I think so, we appear to have an snmp library break to contend with | 15:07 |
| JayF | Well, we should rein in the constraint to get things fixed for now unless it's a trivial fixup | 15:08 |
| TheJulia | I've not looked yet | 15:09 |
| JayF | ack; we'll fix it I'm sure, we always do | 15:09 |
| JayF | going to move on if there's no details to discuss | 15:09 |
| JayF | #topic Bug Deputy | 15:09 |
| JayF | TheJulia is listed, but I suspect that is a week old | 15:09 |
| JayF | Anyone want to bug deputy this week? | 15:10 |
| JayF | I'll take it week after this | 15:10 |
| TheJulia | Yeah, it was Iury last week, I believe | 15:10 |
| TheJulia | we did do a group triage session mid-week before he went on PTO | 15:10 |
| JayF | Safe to say it seems to be working, even if we don't have a volunteer every week | 15:10 |
| JayF | We've done a good job of keeping focus on bugs and trying to fix some | 15:11 |
| TheJulia | I can take it this week | 15:11 |
| JayF | Ack; sgtm and I'll get it next | 15:11 |
| JayF | #action TheJulia volunteers to bug deputy | 15:11 |
| JayF | There are no RFEs to review, skipping item. | 15:11 |
| JayF | #topic Open Discussion | 15:11 |
| JayF | anything for open discussion? | 15:11 |
| JayF | Going to call it there then, thanks all o/ | 15:12 |
| JayF | #endmeeting | 15:12 |
| opendevmeet | Meeting ended Mon Feb 19 15:12:59 2024 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:12 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/ironic/2024/ironic.2024-02-19-15.03.html | 15:12 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/ironic/2024/ironic.2024-02-19-15.03.txt | 15:12 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/ironic/2024/ironic.2024-02-19-15.03.log.html | 15:12 |
| JayF | dtantsur: do you want me/others to land stuff in ironic-bug-dashboard? Will you get a chance to review cid's proposed patches soon? | 15:13 |
| JayF | It's a pretty good improvement | 15:13 |
| dtantsur | I will, yes, I was on PTO the whole last week | 15:13 |
| JayF | oh, nice! I hope you enjoyed the rest | 15:14 |
| dtantsur | well... kinda | 15:14 |
| dtantsur | anyway, I'm back and slowly getting into business | 15:14 |
| dtantsur | please stay tuned | 15:15 |
| JayF | well I'm glad you're back and in business :D | 15:15 |
| * TheJulia watches her desktop OOM | 15:15 | |
| dtantsur | compiling something in Go? :) | 15:15 |
| TheJulia | No, the build of chrome on debian has a fun memory leak I've not been able to get a good feeling for | 15:16 |
| TheJulia | normally it just kills the browser and the world moves on | 15:17 |
| TheJulia | it hasn't done it yet this morning | 15:17 |
| TheJulia | *boom* | 15:18 |
| TheJulia | it just killed it | 15:18 |
| dtantsur | yeah, compiling openshift-installer works faster, usually within a minute | 15:18 |
| opendevreview | Merged openstack/bifrost master: Switch to snponly and stop copying the unused ipxe.pxe https://review.opendev.org/c/openstack/bifrost/+/905844 | 15:42 |
| opendevreview | Kamil Gustab proposed openstack/sushy master: WIP for adding Ethernet Interfaces for manager. https://review.opendev.org/c/openstack/sushy/+/909451 | 15:53 |
| TheJulia | Question for the contributors here, as a contributor microcosm, how do folks feel if PTG sessions were recorded? | 16:32 |
| JayF | As long as the recordings were supplemental to notes taken; I think it'd be a great idea. | 16:36 |
| dtantsur | Probably fewer silly jokes from me, so generally a net positive? | 16:36 |
| dtantsur | (as a data point, all metal3 meetings are recorded, both weekly and larger ones) | 16:37 |
| TheJulia | From what I can see, it is common in other communities. | 16:39 |
| TheJulia | Silly jokes are always encouraged as long as we don't violate the code of conduct :) | 16:40 |
| JayF | I think an environment where people feel safe to make silly jokes and have camraderie is what we want, recording or not. | 16:43 |
| TheJulia | +1,000,000 | 16:45 |
| dtantsur | I said "fewer", I didn't promise to become a serious person ;) | 16:45 |
| JayF | lol good | 16:46 |
| JayF | joking around is serious business :P | 16:46 |
| TheJulia | Indeed! | 16:46 |
| TheJulia | Which is next to the priority for "taking over the world" | 16:47 |
| JayF | I'm assuming community will be OK with merging any changes needed to make Ironic tests pass on WSL? cid is looking into getting tests running there now and I suspect we'll find some hiccups like we did for IPA | 16:47 |
| JayF | WSL running our flake/unit tests are a big help for smaller contributors who don't have stacks of linux VMs at hand :D | 16:47 |
| TheJulia | WSL? | 16:49 |
| dtantsur | Heresy! (yes, I'm okay in general) | 16:49 |
| dtantsur | TheJulia: Windows Subsystem for Linux or whatever | 16:49 |
| TheJulia | Oh, heh | 16:49 |
| TheJulia | yeah, I'm good with that | 16:49 |
| masghar | (A bit late to reply but I wouldn't mind if PTGs were recorded, also jokes are good dtantsur :D) | 16:50 |
| dtantsur | :D | 16:50 |
| clarkb | JayF: any idea of what sorts of things fail in unittests between a ubuntu test node an wsl (which is based on ubuntu aiui)? | 16:52 |
| JayF | In our case, it was usually stuff that assumed certain /dev nodes would exist | 16:52 |
| clarkb | makes me curious to know if there is something that might be improved upon in the CI system or if this is just the nature of emulating linux on windows | 16:52 |
| clarkb | ah ok that makesense | 16:52 |
| JayF | relying on reads from the OS to succeed | 16:52 |
| JayF | that sorta thing | 16:52 |
| JayF | For specific example; IPA has a big utils.execute interception mock to blow up tests if you actually shell out | 16:53 |
| JayF | but someone changed the interface to not execute a command but didn't fix the read mocks properly | 16:53 |
| JayF | on 99.99% of linux machines: it'd read the correct data and pass; on other machines (WSL being the first example I hit), it'd blow up expecting /dev/sda to exist and be a device node or something like that | 16:54 |
| TheJulia | os stuffs in general is likely going to be the big area of headaches anyway | 16:57 |
| TheJulia | Unless WSL enables most of the Linux os code compatability, but even then there are likely substate flavor differences | 16:58 |
| TheJulia | "Hi, filesystem always does x, not y" | 16:58 |
| * TheJulia twitches having flashbacks of cygwin | 16:58 | |
| JayF | WSL2 is basically a hyperv VM with some bonus magic | 17:00 |
| TheJulia | Yeah, that should keep things mostly compatible with minimal mods, but still there migth be some odd-stuffs | 17:01 |
| JayF | yeah | 17:01 |
| JayF | I'd be surprised if we ever had to make a change for WSL which wasn't a net-positive change | 17:02 |
| opendevreview | Kamil Gustab proposed openstack/sushy master: WIP for adding Ethernet Interfaces for manager. https://review.opendev.org/c/openstack/sushy/+/909451 | 17:02 |
| JayF | (e.g. just generally improved mocking) | 17:02 |
| JayF | now, getting tests running *natively* on windows is a whole different ball of wax I want no part of LOL | 17:02 |
| TheJulia | lol | 17:03 |
| TheJulia | So nobody screaming at the suggestion of recording the PTG. Awesome! | 17:05 |
| cid | Currently trying to spin up a dev environment that can support running `tox -epep8 && tox -epy3`. | 19:33 |
| cid | TheJulia: can you help confirm that/if a change to https://github.com/openstack/ironic/blob/master/ironic/conductor/manager.py will also affect https://github.com/openstack/ironic/blob/master/ironic/tests/unit/conductor/test_manager.py | 19:33 |
| cid | And if those will be the only remaining affected files. | 19:33 |
| TheJulia | brraaaaaaain lag | 19:33 |
| TheJulia | give me a few minutes to switch context, I'm sending an important email right now | 19:33 |
| cid | do your thing | 19:34 |
| TheJulia | okay, email sent | 19:40 |
| TheJulia | cid: yes, it would force you to remove specific tests from https://github.com/openstack/ironic/blob/master/ironic/tests/unit/conductor/test_manager.py | 19:40 |
| TheJulia | tests which are directly invoking are likely safe to remove, if other tests start failing, then that might require further investigation/action | 19:41 |
| cid | Okay. thanks a lot. I just feel bad with all the removals :D | 19:41 |
| TheJulia | eh, as pointed out in another channel this morning, sometimes deletion should be taken as catharsis | 19:42 |
| TheJulia | You were definitely not the one who wrote the tests, but the lessened weight likely can be felt and appreciated | 19:43 |
| cid | good point. now I feel better :D | 19:44 |
| TheJulia | Excellent! | 19:46 |
| TheJulia | https://www.youtube.com/watch?v=YKUOB8MN4Kc | 19:46 |
| frickler | missed to mention that in the meeting, repeating my comment from yesterday, library version bump needs fixes in ironic https://review.opendev.org/c/openstack/ironic/+/909315 | 19:49 |
| TheJulia | I saw, I haven't gotten a chance to take a look at it yet today | 19:50 |
| frickler | ah, ok, great, I just wanted to make sure it doesn't get lost and from looking at the error I didn't have the impression I could make much progess on it myself | 19:52 |
| TheJulia | it, unfortunately, is also a niche use case at this point, but an important one as folks with hardware labs tend to use it more than full modern servers with baseboard management controllers | 19:54 |
| JayF | cid: See, from the other perspective, we all feel a little bad because you're cleaning up all the code we left around :| | 19:58 |
| JayF | You don't blame a janitor for how dirty the mopwater is, you blame all of us who haven't been cleaning up the floor after we walk on it :D | 20:01 |
| TheJulia | Well, https://github.com/lextudio/pysnmp/commit/a72e913f0773e0bad4e16e5a68c16e9329f5ea1f is what broke us with pysnmp-lextudio | 21:59 |
| JayF | uh, does that mean we're essentially SOL? | 22:20 |
| TheJulia | not sure | 22:27 |
| TheJulia | I'm like half of the way to fixing the unit tests, but I'm sort of worried more extensive refactoring may be needed | 22:28 |
| JayF | I am confused in that | 22:28 |
| JayF | if it's a minor release, did they *mean* to break the API as bad as they did? | 22:28 |
| JayF | e.g. are we sure this isn't just their bug? | 22:28 |
| JayF | I assumed we're likely in pain because of eventlet/ | 22:28 |
| TheJulia | truthfully, it likely should have been a major bump | 22:29 |
| TheJulia | but the issue could be style differences, I'm just not sure given the level at which it was chagned | 22:30 |
| opendevreview | Julia Kreger proposed openstack/ironic master: WIP/DNM: Wrap coroutines for snmp https://review.opendev.org/c/openstack/ironic/+/909483 | 23:02 |
| JayF | TheJulia: I *think* that's only going to work on exceedingly modern eventlet | 23:10 |
| TheJulia | Likely | 23:15 |
| TheJulia | I've filed https://github.com/lextudio/pysnmp/issues/49 | 23:15 |
| * TheJulia watches the work laptop crash | 23:16 | |
| JayF | ++ I call it their bug for sure | 23:20 |
| TheJulia | Oh yeah... | 23:20 |
| opendevreview | Steve Baker proposed openstack/sushy-tools master: Add virtual-media-boot to openstack driver https://review.opendev.org/c/openstack/sushy-tools/+/906768 | 23:40 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!