| NobodyCam | I should have picked up on the service token thing :( | 00:02 |
|---|---|---|
| NobodyCam | Thank you TheJulia | 00:02 |
| NobodyCam | I'm setting up for the next test | 00:02 |
| NobodyCam | will let you know how we do | 00:03 |
| NobodyCam | :) | 00:03 |
| NobodyCam | same error on the volume detach | 00:24 |
| TheJulia | that seems like states don't line up | 00:35 |
| TheJulia | dunno | 00:35 |
| NobodyCam | I'll dig in | 00:40 |
| NobodyCam | thank you for the help! | 00:40 |
| NobodyCam | the states do look good.. volume status shows in-use and attachments show (a lot) but has attached_at with a date | 01:18 |
| TheJulia | dunno :( | 01:31 |
| rpittau | good morning ironic! happy friday! o/ | 08:27 |
| masghar | Happy Friday :D | 10:05 |
| opendevreview | Afonne-CID Paul Onyedikachi proposed openstack/ironic master: Improve clarity of exception message https://review.opendev.org/c/openstack/ironic/+/909123 | 14:12 |
| opendevreview | Afonne-CID Paul Onyedikachi proposed openstack/ironic master: Improve clarity of exception message https://review.opendev.org/c/openstack/ironic/+/909123 | 14:14 |
| TheJulia | good morning | 14:24 |
| jamesdenton | hello hello | 14:29 |
| opendevreview | Julia Kreger proposed openstack/ironic master: ci: support overriding the service project name https://review.opendev.org/c/openstack/ironic/+/909221 | 15:25 |
| TheJulia | More coffee required | 15:25 |
| JayF | we should land https://review.opendev.org/c/openstack/ironic/+/909120 and it's attached change (909221 above) to fix some CI issues | 16:12 |
| JayF | I'm going AFK for a couple hours; but if it's not landed or -1'd by the time I get back landing as a single core to fix ci | 16:12 |
| rpittau | I have approved both | 16:13 |
| TheJulia | \o/ | 16:14 |
| cid | good evening o/. | 16:25 |
| cid | Working on https://bugs.launchpad.net/ironic/+bug/2031457, wondering if I need to indicate the changes in the "API version history" docstring (and how). | 16:25 |
| opendevreview | Julia Kreger proposed openstack/ironic master: Special case lenovo UEFI boot setup https://review.opendev.org/c/openstack/ironic/+/908946 | 16:34 |
| TheJulia | o/ cid | 16:38 |
| TheJulia | so, it wouldn't be REST api, but it would be an RPC version increment | 16:39 |
| TheJulia | and in that I'd just note the method's removals in the release notes | 16:39 |
| cid | "I'd" as in me (CID)? | 16:40 |
| TheJulia | yes, if I was doing so, I would just do it as a note. I suspect we might need a version check someplace.. I'm also trying to think if we've ever removed an rpc method before | 16:41 |
| TheJulia | we're quite obviously outside of the upgrade support window for those methods | 16:42 |
| cid | ok thanks. | 16:46 |
| rpittau | bye everyone, have a great weekend! o/ | 16:58 |
| TheJulia | Any chance I can get some reviews on https://review.opendev.org/c/openstack/ironic/+/907610 ? | 17:25 |
| opendevreview | Julia Kreger proposed openstack/ironic master: docs: add additional content for host clock skew https://review.opendev.org/c/openstack/ironic/+/908511 | 17:42 |
| NobodyCam | :head desk: service account roles not setup | 17:43 |
| JayF | good stuff cid, thanks! | 17:46 |
| JayF | looking Julia | 17:46 |
| JayF | +2 on 907610; but not landing immediately as a single core since it's removing a CI job | 17:47 |
| JayF | if you have urgency let me know and I can forgo the waiting period :P | 17:47 |
| TheJulia | I'd just like to get the stable branch happy again | 17:47 |
| TheJulia | doesn't have to be today | 17:48 |
| JayF | sgtm; my thought on CI for those older branches is removing a job == "if you -1 this, you volunteer to fix it" | 17:49 |
| JayF | so I doubt we'll have any interest in -1'ing it :D | 17:49 |
| TheJulia | Yeah, with older branches, it is normal to start shedding jobs | 17:50 |
| TheJulia | of course, if you want to add a job https://review.opendev.org/c/openstack/ironic/+/901090?usp=search :) | 17:51 |
| JayF | sure; lgtm | 17:51 |
| opendevreview | Merged openstack/ironic master: ci: allow service role CI account usage to have elevated access https://review.opendev.org/c/openstack/ironic/+/909120 | 18:06 |
| TheJulia | https://review.opendev.org/c/openstack/networking-baremetal/+/906788 wants a review :) | 19:41 |
| TheJulia | Actually, previously had dmitry, and I only touched the commit message | 19:42 |
| * TheJulia fixes | 19:42 | |
| opendevreview | cid proposed openstack/ironic master: Remove unsupported rpc methods https://review.opendev.org/c/openstack/ironic/+/909263 | 19:59 |
| JayF | https://review.opendev.org/c/openstack/ironic/+/909263/1#message-a1b2fbebcda5e96755f64cb52e22f808c22b3efb Is this rightheaded? I'm saying we should pull any release_mappings referencing RPC versions we could no longer service with the change | 20:16 |
| TheJulia | ... without looking at the change, and only what you put in irc, likely correct | 20:26 |
| JayF | Then it's likely correct :) | 20:26 |
| TheJulia | that should likely only co-incide with where they are removed at | 20:27 |
| JayF | ++ | 20:27 |
| TheJulia | say 1.43 had and used by default the methods, but we've since has 1.44-1.65, then only mapping references for 1.43 and before should be dropped | 20:28 |
| TheJulia | And those are just example numbers | 20:28 |
| JayF | ++ | 20:37 |
| TheJulia | so also | 20:41 |
| TheJulia | so unit tests likely need to be removed | 20:41 |
| TheJulia | cid: tox -epep8 && tox -epy3 are your friends :) | 20:41 |
| jamesdenton | @JayF thanks again for the help yesterday. Turns out I needed to use [inspector] extra_kernel_params in ironic.conf, since Ironic was driving inspection | 20:43 |
| jamesdenton | --ipa-collect-lldp=1 was the way to go | 20:44 |
| JayF | nice! | 20:44 |
| cid | TheJulia: noted :D | 20:50 |
| cid | Thanks a million JayF | 20:50 |
| cid | Happy weekend o/ | 20:50 |
| TheJulia | have a wonderful weekend | 20:51 |
| * TheJulia steps away for brain sanity | 20:51 | |
| opendevreview | Merged openstack/ironic stable/wallaby: [stable-only] Fix tempest checkout/grenade run https://review.opendev.org/c/openstack/ironic/+/907610 | 21:59 |
| opendevreview | Merged openstack/networking-baremetal master: [codespell] Fixing Spelling Mistakes https://review.opendev.org/c/openstack/networking-baremetal/+/906788 | 22:05 |
| opendevreview | Adam McArthur proposed openstack/networking-baremetal master: [codespell] Adding Tox Target for Codespell https://review.opendev.org/c/openstack/networking-baremetal/+/906789 | 23:55 |
| opendevreview | Adam McArthur proposed openstack/networking-baremetal master: [codespell] Adding CI target for Tox Codespell https://review.opendev.org/c/openstack/networking-baremetal/+/906790 | 23:56 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!