| tkajinam | it seems unit tests of sushy-tools are broken because of recent change in Werkzeug https://github.com/pallets/werkzeug/commit/eef696b15c5e9fc20ed718f6685a3f21f2fbc3b8#diff-ff3c479edefad986d2fe6fe7ead575a46b086e3bbcf0ccc86d85efc4a4c63c79R22 | 01:33 |
|---|---|---|
| tkajinam | wondering if we can just update unit tests to expect 415, or we should fix the logic so that it returns 400, if the different code breaks something | 01:34 |
| opendevreview | Takashi Kajinami proposed openstack/sushy-tools master: Fix broken unit tests with Werkzeug>=2.3.0 https://review.opendev.org/c/openstack/sushy-tools/+/906230 | 01:40 |
| tkajinam | probably this is the correct approach | 01:41 |
| opendevreview | Takashi Kajinami proposed openstack/sushy-tools master: Fix broken unit tests with Werkzeug>=2.3.0 https://review.opendev.org/c/openstack/sushy-tools/+/906230 | 07:35 |
| opendevreview | Takashi Kajinami proposed openstack/sushy-tools master: Fix broken unit tests with Werkzeug>=2.3.0 https://review.opendev.org/c/openstack/sushy-tools/+/906230 | 07:36 |
| opendevreview | Takashi Kajinami proposed openstack/sushy-tools master: Remove translation sections from setup.cfg https://review.opendev.org/c/openstack/sushy-tools/+/906217 | 07:36 |
| opendevreview | Takashi Kajinami proposed openstack/sushy-tools master: Add Python 3.10 and 3.11 to supported versions https://review.opendev.org/c/openstack/sushy-tools/+/906216 | 07:36 |
| opendevreview | Takashi Kajinami proposed openstack/sushy-tools master: Improving nova search filter https://review.opendev.org/c/openstack/sushy-tools/+/896130 | 07:38 |
| rpittau | good morning ironic! o/ | 07:48 |
| opendevreview | Dmitry Tantsur proposed openstack/ironic stable/2023.2: Don't create a hardlink to a symlink when handling file:// URLs https://review.opendev.org/c/openstack/ironic/+/906132 | 08:32 |
| opendevreview | Dmitry Tantsur proposed openstack/ironic stable/2023.1: Don't create a hardlink to a symlink when handling file:// URLs https://review.opendev.org/c/openstack/ironic/+/906133 | 08:32 |
| iurygregory | good morning Ironic | 10:37 |
| dtantsur | tkajinam: I wonder if the sushy library is affected (i.e. it does not send content-type) | 10:46 |
| tkajinam | dtantsur, the failure in sushy-tempest-uefi-redfish-vmedia is unrelated and seems the job is trying to reach a broken node in infra. I'm discussing it in #opendev now | 10:48 |
| dtantsur | k thanks for looking into it | 10:48 |
| tkajinam | or is there any failures I've not yet noticed ? | 10:48 |
| opendevreview | Takashi Kajinami proposed openstack/ironic master: Stop using a specific mirror in infra https://review.opendev.org/c/openstack/ironic/+/906256 | 10:57 |
| opendevreview | Takashi Kajinami proposed openstack/ironic master: wip: Attempt to use CI mirror https://review.opendev.org/c/openstack/ironic/+/906257 | 11:03 |
| tkajinam | dtantsur, seems like ^^^ | 11:05 |
| tkajinam | I'll check if I can complete that shell hack to use infra mirror after dinner | 11:05 |
| opendevreview | Merged openstack/sushy-tools master: Fix broken unit tests with Werkzeug>=2.3.0 https://review.opendev.org/c/openstack/sushy-tools/+/906230 | 11:07 |
| opendevreview | Riccardo Pittau proposed openstack/bifrost master: Collect lshw output in json format https://review.opendev.org/c/openstack/bifrost/+/890408 | 11:42 |
| opendevreview | Merged openstack/ironic-python-agent master: Add support for reporting CPU socket number https://review.opendev.org/c/openstack/ironic-python-agent/+/900642 | 11:52 |
| iurygregory | dtantsur, looking at your comments from https://review.opendev.org/c/openstack/ironic/+/903379/, I've moved from e.message to e (https://review.opendev.org/c/openstack/ironic/+/903379/5/ironic/drivers/modules/redfish/utils.py) but I'm puzzled why the log is showing the error as MissingAttributeError('The attribute UpdateService is missing from the resource redfish/v1') instead of just 'The attribute UpdateService is missing from the | 12:08 |
| iurygregory | resource redfish/v1' | 12:08 |
| dtantsur | iurygregory: because you're checking it before the logging engine has applied str() on it. This is fine. | 12:09 |
| iurygregory | aha! | 12:09 |
| iurygregory | I was going crazy here | 12:09 |
| dtantsur | FYI https://bugs.launchpad.net/ironic/+bug/2050054 (the linuxefi problem) | 12:09 |
| * iurygregory needs more coffee | 12:09 | |
| iurygregory | a new bug and I need to update my statistics from the last week lol | 12:10 |
| iurygregory | dtantsur, second question https://review.opendev.org/c/openstack/ironic/+/903379/5/ironic/drivers/modules/redfish/firmware_utils.py if I understood correct you said we have something like redfish/common.py, but I couldn't find any in `ironic/common/` or `ironic/drivers/modules/redfish/` , it's ok to just create one under driver or in common? | 12:16 |
| opendevreview | Merged openstack/ironic-inspector stable/2023.1: Fix RBAC access for service/admin user access https://review.opendev.org/c/openstack/ironic-inspector/+/906123 | 12:20 |
| opendevreview | Verification of a change to openstack/sushy stable/2023.2 failed: Handle a different related properties for missing TransferProtocolType https://review.opendev.org/c/openstack/sushy/+/905740 | 12:40 |
| opendevreview | Merged openstack/ironic-python-agent-builder stable/wallaby: CI: specify Debian version explicitly https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/906121 | 12:50 |
| opendevreview | Merged openstack/ironic-python-agent-builder stable/wallaby: Drop TripleO job https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/905835 | 12:50 |
| tkajinam | fyi.. docs job in master is broken because of https://bugs.launchpad.net/nova/+bug/2050090 ... I'm trying to downgrade pillow as a short term fix | 12:51 |
| tkajinam | so do not recheck | 12:51 |
| iurygregory | tks for the heads-up tkajinam ! | 12:55 |
| tkajinam | fun moment after mass u-c bump :-) | 12:58 |
| opendevreview | Takashi Kajinami proposed openstack/ironic master: Stop using a specific mirror in infra https://review.opendev.org/c/openstack/ironic/+/906256 | 13:12 |
| rpittau | tkajinam: consider that we have in the plan to drop blockdiag | 13:13 |
| rpittau | the issue with pillow is already known | 13:15 |
| rpittau | tkajinam: at the moment we're looking at plantuml | 13:15 |
| rpittau | I actually wonder why the version was updated | 13:16 |
| rpittau | tkajinam: https://bugs.launchpad.net/ironic/+bug/2026345 | 13:17 |
| rpittau | going to pin again to 9.5.0 | 13:17 |
| tkajinam | rpittau, ahh, ok so there is a bug already. I'll mark mine as duplicate | 13:24 |
| rpittau | tkajinam: it's ok | 13:24 |
| rpittau | I marked mine as you were faster | 13:24 |
| tkajinam | ah, yes | 13:25 |
| tkajinam | but I was talking about the bug I reported today... let me mark it as duplicate | 13:25 |
| tkajinam | closed https://bugs.launchpad.net/nova/+bug/2050090 ( which I created today) as duplicate of https://bugs.launchpad.net/nova/+bug/2026345 | 13:28 |
| rpittau | right, thanks | 13:32 |
| tkajinam | rpittau, thank you, too | 13:33 |
| tkajinam | rpittau, looks like designate decided to use graphviz . I have no good view to tell which one is better, but I hope we don't pull too many tools | 13:34 |
| tkajinam | https://review.opendev.org/c/openstack/designate/+/889369 | 13:35 |
| rpittau | tkajinam: yeah plantuml is based on graphviz, problem is for us graphviz is not enough | 13:36 |
| rpittau | because we also make use of seqdiag | 13:37 |
| rpittau | let's say that plantuml is more user-friendly :) | 13:37 |
| tkajinam | ah, ok | 13:38 |
| tkajinam | thanks for the clarification and it sounds very reasonable to me | 13:38 |
| rpittau | no problem! | 13:38 |
| rpittau | hopefully I'l get to it soon :/ | 13:38 |
| tkajinam | if we get an establish pattern, it may help the other projects. I see octavia has seqdiag and they had to disable it but can utilize the same approach, I hope | 13:44 |
| rpittau | well I did some testing some months ago with plantuml, that's why I proposed that | 13:45 |
| rpittau | I need to retrieve the patch and propose it, just need to find the time for that! | 13:45 |
| TheJulia | good morning | 13:46 |
| iurygregory | good morning TheJulia =) | 14:08 |
| dtantsur | iurygregory: my bad, it's called utils https://opendev.org/openstack/ironic/src/branch/master/ironic/drivers/modules/redfish/utils.py | 14:39 |
| iurygregory | dtantsur, ack, tks! | 14:40 |
| k_romanenko | Hi! | 14:56 |
| TheJulia | greetomgs! | 14:57 |
| k_romanenko | Long time no see | 14:57 |
| dtantsur | o/ | 14:58 |
| TheJulia | well, that should be greetings, but apparently I cannot type, still. | 14:59 |
| rpittau | I took that as a mix between "greetings" and "oh my goodness" | 15:00 |
| iurygregory | you need more coffee TheJulia =) | 15:00 |
| JayF | #startmeeting ironic | 15:01 |
| opendevmeet | Meeting started Mon Jan 22 15:01:25 2024 UTC and is due to finish in 60 minutes. The chair is JayF. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:01 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:01 |
| opendevmeet | The meeting name has been set to 'ironic' | 15:01 |
| JayF | Good morning everyone o/ | 15:01 |
| iurygregory | o/ | 15:01 |
| dtantsur | o/ | 15:01 |
| TheJulia | o/ | 15:01 |
| masghar | o/ | 15:01 |
| JayF | #topic Announcement/Reminder | 15:01 |
| JayF | #info Standing reminder to review patches tagged ironic-week-prio and to hashtag any patches ready for review with ironic-week-prio: https://tinyurl.com/ironic-weekly-prio-dash | 15:01 |
| JayF | No action items from previous meeting; skipping that agenda item. | 15:02 |
| JayF | #topic Caracal Release Schedule | 15:02 |
| rpittau | o/ | 15:02 |
| JayF | It is R-10, no notable deadlines, but 10 weeks left :) | 15:02 |
| JayF | #link https://releases.openstack.org/caracal/schedule.html | 15:02 |
| JayF | #topic Potential BM SIG/Ironic meetup at CERN around June 6, 2024 | 15:03 |
| JayF | I will be at OpenInfra Days at CERN on June 6. | 15:03 |
| dtantsur | Is there a nice link with the info for ^^^? | 15:03 |
| JayF | So will a handful of other Ironic contributors | 15:03 |
| JayF | We are looking to see if there is enough interest to schedule a thing, likely on the 5th | 15:03 |
| JayF | If so, it'll become official likely this week or next (I just got my travel approved on Friday) | 15:03 |
| dtantsur | I'm interested in theory, but cannot commit until I figure out.. many things | 15:04 |
| TheJulia | I went looking last week, and it seems like not much has been published yet | 15:04 |
| JayF | There is almost zero details published about the OIF Days, and the BM SIG meetup is in the "Jay and others think it's a cool idea" stage | 15:04 |
| rpittau | very interested too, it's quite close for me to get to Geneve | 15:04 |
| dtantsur | Once official, I can ask for budget (and consider if I can self-sponsor if I get a no (likely)) | 15:05 |
| JayF | but Arne asked me to check w/the community for general interest before we put too much effort into an Ironic meetup, specifically | 15:05 |
| rpittau | likewise | 15:05 |
| iurygregory | I'm not even considering based on the prices I saw =( | 15:05 |
| rpittau | :/ | 15:05 |
| JayF | So it sounds like "general interest but major logistical concerns" | 15:06 |
| JayF | I'll pass on the strong desire for more documentation about the OIF Days :) | 15:06 |
| TheJulia | I'm unsure I'll be able to, trying to bring some clarity to my schedule for the year but it is going slow | 15:07 |
| JayF | 90% of my orgs travel planning is done a the top of the year, which makes it good for events with this timing, but less good if something pops up in late 2024 :) | 15:07 |
| JayF | Either way, I think this topic is exhausted? | 15:07 |
| JayF | #topic Review Ironic CI Status | 15:08 |
| JayF | I had a separate topic for this, but will bring it up now instead since it's mostly-resolved | 15:08 |
| JayF | Inspector docs jobs are broken on latest eventlet | 15:09 |
| rpittau | is that for eventlet or because of the uc update? | 15:09 |
| JayF | it was removed from upper-constraints in requirements project due to minor breakages across openstack and it being late in the cycle | 15:09 |
| JayF | I am talking specifically about eventlet, other breakages (I assume someone tried pillow again based on backlog?) I don't know details about | 15:09 |
| JayF | but we will have to find some kind of solution in eventlet or sphinx autodoc to make things happy if we want to continue to be able to autodoc once we get new eventlet | 15:10 |
| rpittau | ack | 15:10 |
| JayF | as of now, I'm working w/infra to get us experimental queue CI tempest/unit test/doc jobs that run against master eventlet so we can easily test | 15:10 |
| JayF | Comments about this or other things to note? | 15:10 |
| JayF | Moving on. | 15:12 |
| JayF | #topic Bug Deputy | 15:12 |
| JayF | Thanks to iurygregory for volunteering to be the bug deputy. | 15:12 |
| JayF | #info Summary: -11 bugs, -2 wishlist items, -2 new, -9 in progress, -1 critical, -2 high. | 15:12 |
| JayF | Any comments iurygregory? Anyone want to volunteer to pick it up for this week? | 15:12 |
| iurygregory | yw =) | 15:12 |
| iurygregory | I forgot to update today, seems like we got a new bug =) | 15:13 |
| JayF | zarro boogs found :D | 15:13 |
| rpittau | I think I can handle this week considering the great job done by iurygregory :) | 15:13 |
| JayF | #action rpittau is the bug deputy for this week | 15:13 |
| iurygregory | tks rpittau =) | 15:14 |
| rpittau | :) | 15:14 |
| JayF | #topic RFE Review | 15:14 |
| JayF | #link https://bugs.launchpad.net/ironic/+bug/2049913 | 15:14 |
| JayF | dtantsur proposed this on Decomposing out-of-band inspection | 15:15 |
| dtantsur | Yeah. It's honestly somewhat less scary than it sounds :) | 15:15 |
| dtantsur | The tl;dr is that I want to move oob (!) inspection to the default path | 15:16 |
| dtantsur | so that we virtually always have access to MAC addresses or CPU architecture (at least as far as Redfish is concerned) | 15:16 |
| JayF | I think my biggest issue with the RFE is that the top line of what it's accomplishing is not super clear (in the bug ticket itself). Right now, we can only do IB or OOB inspection, not both or a combination(?) | 15:17 |
| * JayF suspects that this issue is based in his lack of inspection knowledge | 15:17 | |
| TheJulia | I think part of it is filling in some of the information gaps to create a easier user experience | 15:18 |
| JayF | Well, an easier user experience *for redfish users* | 15:19 |
| TheJulia | some paramters we have logic built around is just no longer required | 15:19 |
| TheJulia | I think oob is already prior art in some other interfaces, fwiw, and IPMI is expected to have rough edges for those who continue to use it | 15:19 |
| * JayF notes there's almost no way he's a "no" to this RFE, but is just talking through it to understand more | 15:19 | |
| dtantsur | my view is a bit biased because IPMI is going extinct in my world :) | 15:20 |
| JayF | Well that's part of why I'm asking the questions this way | 15:21 |
| dtantsur | JayF: we cannot officially do a combination of ib and oob | 15:21 |
| JayF | I know the Metal3 lens is redfish tinted :D | 15:21 |
| dtantsur | BUT | 15:21 |
| dtantsur | the inspector/agent interface actually is a hybrid interface - see my explanation in the RFE | 15:21 |
| TheJulia | somewhat similar, only the most die-hard IPMI fans seem to continue to do new deployments with it | 15:21 |
| dtantsur | we also need to keep in mind that for many consumers ironic today is what they deploy in a year | 15:22 |
| TheJulia | or two, so yeah | 15:22 |
| dtantsur | (does not apply to metal3, but we're indeed wearing fishy glasses) | 15:22 |
| JayF | Should we have an end goal (that this would be a step towards) of in-band inspection becoming "baked in" in a sense, too? | 15:23 |
| TheJulia | I'm not sure there is truly value to forcing it in process wise, but if we can get the data as part of other processes its not a big deal | 15:23 |
| dtantsur | I'm pondering that.. I guess there may be some sense into re-running oob inspection in some cases? Like, installing a new NIC? | 15:24 |
| JayF | Inspection has always been shaped a little differently than other things in-band, is all I'm thinking. If it could look more like other step-based flows, that'd be neat, but I suspect there are reasons I'm not thinking of that wouldn't be possible/desirable (even beyond the "not enough hours in the day). | 15:24 |
| dtantsur | Inspection is kinda step-based - the hooks are very similar - but only in terms of processing data | 15:26 |
| dtantsur | "not enough hours" is always a critical problem tbh | 15:26 |
| JayF | yeah | 15:27 |
| JayF | Either way, I think I'm OK with this. I'm a little skeptical about doing it without a spec, but I suspect the diff is smaller than I realize and my skepticism is just ... lack of knowledge about inspection moreso than any meaningful concern. | 15:27 |
| dtantsur | heh, I even wrote the RFE in rst format in case you ask for a spec :D | 15:28 |
| dtantsur | it won't match very well into the template though | 15:28 |
| JayF | Let me put it this way, if I'm an Ironic operator, I'm not sure I understand what that RFE is doing. | 15:29 |
| JayF | And maybe in a world where we primarily communicate about new features via docs and release notes that is OK? | 15:30 |
| dtantsur | I can write a spec. In this case, I agree that the proposal is not exactly obvious unless you (like me) have spent months pondering it | 15:30 |
| JayF | I am saying ^ that is the problem I would like solved, I don't care if it's a fresh para at the top of an RFE, a spec, or interpretive dance :D | 15:31 |
| JayF | *paragraph | 15:31 |
| JayF | but unless there are objections I am A-OK with approving it since I trust you to do that :D | 15:32 |
| dtantsur | So folks, to spec or not to spec? :) | 15:32 |
| TheJulia | spec might be good, tbh | 15:33 |
| JayF | Alright, spec it is. | 15:33 |
| rpittau | either way honestly | 15:33 |
| TheJulia | I kind of understand what your going after though, so I'm a bit easier to convince | 15:33 |
| dtantsur | Okay, I'll do it. The RFE text is half of the spec already. | 15:33 |
| JayF | I'd say like, a thin spec :) | 15:33 |
| TheJulia | Many None or N/A lines :) | 15:33 |
| dtantsur | oh yeah :D | 15:33 |
| JayF | #agreed https://bugs.launchpad.net/ironic/+bug/2049913 needs to have a spec | 15:33 |
| JayF | #topic Open Discussion | 15:34 |
| JayF | I have one thing for here to start | 15:34 |
| JayF | blockdiag! | 15:34 |
| JayF | Bauzas made a suggestion in #openstack-nova I think we should execute on: https://bugs.launchpad.net/tacker/+bug/2026345/comments/11 | 15:34 |
| rpittau | yeah, we need to burn it down with seqdiag | 15:34 |
| JayF | unless there are moving parts I'm not aware of | 15:35 |
| TheJulia | One item in my mind is the priorities for the cycle, I suspect some of the items we put on there haven't made progress, or might be a review away. Others just haven't been started. We should likely revisit/discuss explicitly | 15:35 |
| rpittau | that suggestion may work for blockdiag, but not sure about seqdiag | 15:35 |
| rpittau | I mean we could svg too for sequence diagrams | 15:35 |
| rpittau | I can put something together with plantuml in the next week, but we can even remove entirely the dependencies and just use pure images | 15:36 |
| TheJulia | Some of the sequenec diagrams seem overkill at this point for our documentation | 15:36 |
| TheJulia | *or* haven't changed/updated/evolved in *ages* | 15:36 |
| TheJulia | which makes me wonder "is it really needed" and "does it continue to bring value" | 15:37 |
| JayF | And/or are less useful. | 15:37 |
| rpittau | the other solution would be remove the sequence diagrams and convert blockdiag to graphviz | 15:37 |
| rpittau | which is what other projects are doing | 15:37 |
| JayF | The seqdiag is my favorite, but I know many other folks don't like them and it's outta date | 15:37 |
| JayF | so I don't object if we wanna pull them | 15:37 |
| TheJulia | I'm thinking the ilo docs used to have tons of them, and it *really* wasn't needed in the end because it was painting a picture beyond the driver interface | 15:38 |
| rpittau | most of the seq diags are in the ilo docs indeed | 15:38 |
| JayF | we have a good one for agent deploy flow | 15:38 |
| JayF | that's outdated but can be useful | 15:38 |
| JayF | I still use that when onboarding folks to how IPA works; but that's the only diagram in our docs I've used in years outside of the state machine | 15:39 |
| JayF | and like I said, it's significantly bitrotted and so I'm still +1 to dumping it | 15:39 |
| masghar | If any diagrams can still help newcomers, can we try to update them instead of removing them? | 15:40 |
| TheJulia | I think this is a thing we need to look at on a case by case basis | 15:41 |
| JayF | I'd rephrase that to a question pointed at you; you have recently been a newcomer: what diagrams have helped you? | 15:41 |
| TheJulia | and discussing it to a conclusion during a meeting might not be viable | 15:41 |
| JayF | And that can be a good input to the discussion. | 15:41 |
| masghar | The state machine so far :D I havent looked at the IPA diagram you mentioned though | 15:41 |
| masghar | Perhaps all the diagrams cant be discussed in the meeting alone, like Julia said | 15:42 |
| TheJulia | https://docs.openstack.org/ironic/latest/admin/drivers/ilo.html#id6 :) | 15:42 |
| JayF | ++ I agree, but we will need to take action at some point | 15:42 |
| dtantsur | yeah, losing the state machine will be undesirable | 15:42 |
| rpittau | masghar: that's not seqdiag though, it's a png | 15:43 |
| rpittau | or I'm confusing the file :) | 15:43 |
| TheJulia | state machine has to be regenerated when we make changes (which is *often* also forgotten) | 15:43 |
| masghar | Ah, so only the seqdiag ones are in consideration? | 15:43 |
| rpittau | for the migration yes | 15:44 |
| masghar | rpittau: okay | 15:44 |
| JayF | TheJulia: is that code for "nobody check it for SERVICING" | 15:44 |
| TheJulia | JayF: that had a python2 only dependency for SVG generation, yes | 15:44 |
| rpittau | masghar: but your point makes total sense, if there is anything useful we should definitely migrate and update it | 15:45 |
| TheJulia | which is why it is now a PNG | 15:45 |
| JayF | egad | 15:45 |
| * TheJulia gets some glue and applies it to jamesdenton__'s irc client | 15:45 | |
| JayF | and makes a strong argument against "just punt it to offline" because that is an end state that's unpleasant for that | 15:45 |
| jamesdenton__ | :| | 15:45 |
| TheJulia | jamesdenton__: sorry, your not allowed to leave us ;) | 15:45 |
| jamesdenton__ | am i bouncing? | 15:45 |
| TheJulia | jamesdenton__: It seems that way | 15:46 |
| TheJulia | jamesdenton__ meet jamesdenton_ | 15:46 |
| JayF | about every 5-10 minutes :D | 15:46 |
| jamesdenton__ | had a pretty major storm overnight and some power outages... things settling down | 15:46 |
| jamesdenton__ | yeah, i think znc is going nuts | 15:46 |
| JayF | So sounds like the summary is: the state of generated diagrams in our docs is generally bad, not just the parts that are blocking u-c bumps, and should probably be a larger topic which involves retiring a large number of them. | 15:47 |
| JayF | I might try to nerd-snipe some of my friends in other communities to find us a replacement library ;) | 15:47 |
| rpittau | ispers plantuml | 15:47 |
| rpittau | argh | 15:47 |
| * rpittau whispers plantuml | 15:47 | |
| TheJulia | going back to the sequence diagrams, I think it might make sense to make sure some lower level details are covered elsewhere in our docs in terms of mechanics, but I think the diagrams in the ilo driver can be dropped | 15:48 |
| JayF | ++ | 15:48 |
| rpittau | sounds good | 15:49 |
| TheJulia | masghar: as one of our newer members, would you like to take a look at that? I can, but I may make some assumptions on what actually is documented clearly | 15:49 |
| rpittau | I can prepare an example patch to show plantuml | 15:49 |
| JayF | that sounds great | 15:49 |
| masghar | I can! I will ask many many questions though :D | 15:50 |
| TheJulia | masghar: that is fine :) | 15:50 |
| masghar | Thanks rpittau! | 15:50 |
| opendevreview | Iury Gregory Melo Ferreira proposed openstack/ironic master: RedfishFirmwareInterface - Unit Tests & More logs https://review.opendev.org/c/openstack/ironic/+/903379 | 15:50 |
| rpittau | masghar: questions welcome :) | 15:50 |
| TheJulia | rpittau: is this in regards to the sequence diagrams? | 15:50 |
| rpittau | yes | 15:50 |
| TheJulia | okay | 15:50 |
| masghar | Alright then, I will start with the ilo diagrams | 15:50 |
| TheJulia | perfect | 15:51 |
| JayF | Anything else we need to chat about in Open Discussion? :) | 15:51 |
| TheJulia | I brought up our published priorities | 15:51 |
| k_romanenko | I have some little questions | 15:52 |
| TheJulia | k_romanenko: for our open discussion section of our meeting? | 15:52 |
| k_romanenko | I guess so. Since I left Mirantis I have a batch of incomplete Ironic-related changes on review. | 15:53 |
| k_romanenko | Over last years I completed two of them. So far there are some changes pending. Here are questions related: | 15:53 |
| JayF | TheJulia: I suggest we encourage, here and on ML, people review that and take a dedicated agenda item next meeting to go over priorities, is that good for you? | 15:53 |
| JayF | TheJulia: that way we don't spend time here looking over it sync in meeting? | 15:53 |
| TheJulia | JayF: fair, in the past I would have just told folks "update the whiteboard" | 15:54 |
| TheJulia | k_romanenko: okay | 15:54 |
| JayF | In this case, the whiteboard is the attached bugs, which has the same effect here | 15:54 |
| JayF | but I think a zoomed out view is valuable | 15:54 |
| k_romanenko | 1. Is ML2 Neutron Events Fail Fast feature still actual? 2. Are Ironic_tempest_plugin tests still necessary? 3. Are the functional tests for ironicclient OSC plugin still needed? | 15:54 |
| k_romanenko | If yes all three, then I will continue on those topic. I just have some time. | 15:55 |
| JayF | If you have links to the reviews those questions are contextually related to that'd be useful too :D | 15:55 |
| TheJulia | 1) Neutron events processing work stalled, basically the issue was "how to pause/resume" where we need to in way that is non-breaking | 15:55 |
| k_romanenko | ML2 Fail Fast: https://review.opendev.org/c/openstack/ironic/+/370016 | 15:55 |
| TheJulia | 2) Depends, for api contract stuffs yes, if you have specific questions happy to look/discuss after the meeting. | 15:56 |
| TheJulia | 3) I have no idea :) | 15:56 |
| k_romanenko | Tempest plugin, here I renewed the patch already https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/906078 | 15:56 |
| JayF | I hashtagged 906078 for you with ironic-week-prio | 15:57 |
| TheJulia | so I think the original stance was not to do negative testing in tempest, because largely those items should already be covered in overall unit tests. That being said, at a glance I suspect your additional tests make sense | 15:57 |
| k_romanenko | ironicclient OSC plugin tests like this: https://review.opendev.org/c/openstack/python-ironicclient/+/382496 | 15:57 |
| TheJulia | I just approved that one | 15:59 |
| k_romanenko | Thank you | 15:59 |
| k_romanenko | Ok, then I will put aside the ML2 stuff and continue updating points 2 and 3. | 16:00 |
| JayF | And just in time; because we're at time for the meeting. | 16:00 |
| JayF | Thank you so much everyone | 16:00 |
| JayF | and welcome back k_romanenko o/ | 16:00 |
| JayF | #endmeeting | 16:00 |
| opendevmeet | Meeting ended Mon Jan 22 16:00:56 2024 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 16:00 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/ironic/2024/ironic.2024-01-22-15.01.html | 16:00 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/ironic/2024/ironic.2024-01-22-15.01.txt | 16:00 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/ironic/2024/ironic.2024-01-22-15.01.log.html | 16:00 |
| k_romanenko | It was nice to see all the same people after so long time. | 16:05 |
| JayF | It's nice in some ways :) Wish there were more new people to see, too | 16:05 |
| TheJulia | Wow, it feels weird that it is overcast and raining here.... | 16:10 |
| JayF | TheJulia: *laughs in PNW* https://usercontent.irccloud-cdn.com/file/BxVIlqK6/rain-rain-rain-rain-rain.png | 16:11 |
| TheJulia | I was like "why is it still dark in the office" | 16:12 |
| TheJulia | we're really not equipped for tons of rain here | 16:12 |
| JayF | TheJulia: literally yesterday we went to the hockey game, left around 3pm, it was grey and miserable from the rain and it just being ... here ... we come home around 8-ish and it's almost *brighter* because even though it's darker, the grey is lifted | 16:12 |
| JayF | yeah, I know it's not directly comparable in terms of like, life-impact, but I hate the constant grey :/ | 16:12 |
| TheJulia | :( | 16:13 |
| TheJulia | Yeah, it can get old | 16:13 |
| JayF | yeah but the flip side is we get beautiful, clear, mild summers | 16:13 |
| clarkb | I've found the most important thing is to not let the rain win. Its raining? we're still walking to school, or going on that hike, or fishing, etc | 16:15 |
| clarkb | the last week has been bad bceause its actually been unsafe to be outside more than the cold/wet | 16:15 |
| rpittau | good night! o/ | 16:58 |
| JayF | o/ | 16:59 |
| masghar | I need rain-repellant glasses tbh | 17:10 |
| TheJulia | I'll just stay in doors when it is raining, then again living in a desert, flooding is the other concern when it is raining like it is right now. | 17:15 |
| masghar | Hopefully there's no flooding | 17:16 |
| TheJulia | it is almost guaranteed with nearby mountains. | 17:17 |
| masghar | Oh dear | 17:17 |
| masghar | Stay safe Julia! | 17:18 |
| opendevreview | Dmitry Tantsur proposed openstack/ironic master: Account for nodes with the same BMC hostname in inspection lookup https://review.opendev.org/c/openstack/ironic/+/906308 | 17:26 |
| TheJulia | masghar: eh, so far okay, just one of the nearby roads appears to be flooding out for now | 18:37 |
| TheJulia | JayF: I replied on https://review.opendev.org/c/openstack/ironic/+/902009 | 18:37 |
| TheJulia | I'm not sure the concern you have is the item to go into depth in there, given what you cited are not cases where the policy in ironic comes into play. Now, if other services changed default enforcement and ironic's config was out of date with the wrong role, then that would be problematic, but it is also something we're largely blind to | 18:39 |
| JayF | I think some nonzero amount of this is operator FUD that I've been fielding around this when billboarding Ironic's automatic_lessee support | 18:39 |
| JayF | there's a lot of fear around running mixed setups which I thought was justified to some level, but it sounds like it's potentially not | 18:40 |
| TheJulia | FUD how so? | 18:40 |
| TheJulia | like, normal "it is different, everything is going to break" or specific concerns? | 18:40 |
| JayF | or the "all cloud operator supplied by by config" in your comment is hiding complexity | 18:41 |
| JayF | TheJulia: I have had professional openstack deploy-y type of people say they can't enable new-style RBAC on any openstack services until *all* openstack services in a deployment supports them | 18:41 |
| TheJulia | ... that is so wrong it is not even funny | 18:41 |
| * TheJulia gets out a sad panda | 18:41 | |
| JayF | TheJulia: I do not personally hold this opinion, but my comment there was meant to reflect that we might have FUD to fight against here | 18:41 |
| * TheJulia ponders re-framing | 18:42 | |
| JayF | it's not exactly (well, not ONLY) our job to do so, but it impacts us greatly so it seems prudent of us to frame this as best as we can | 18:42 |
| TheJulia | Yeah, I think with that in mind, I can reframe it a little to help with the FUD type concerns | 18:43 |
| TheJulia | Would it be awful to explicitly call out "concerns over need for other services to support RBAC..." ? | 18:46 |
| JayF | Why not just say it directly that: "It's our belief that this should be safe to enable even if you may be using openstack services which do not yet support RBAC scope (whatever the right glossary term is here)" and ask people to file bugs / let us know if it's not true? | 18:47 |
| TheJulia | something in the middle maybe | 18:48 |
| * TheJulia looks out window, sees dark sky, goes and makes more coffee | 18:48 | |
| opendevreview | Dmitry Tantsur proposed openstack/ironic master: Flip require_managed_boot to True for the new agent inspection https://review.opendev.org/c/openstack/ironic/+/906314 | 18:54 |
| opendevreview | Julia Kreger proposed openstack/ironic master: Disable legacy RBAC policy by default. https://review.opendev.org/c/openstack/ironic/+/902009 | 19:11 |
| TheJulia | JayF: take a look at ^ and lmk | 19:12 |
| JayF | Basically exactly what I wanted, a strong statement with specific caveats or no strong statement | 19:13 |
| JayF | A++ would converse again | 19:13 |
| TheJulia | sigh: 'ImageDraw' object has no attribute 'textsize' | 19:15 |
| TheJulia | masghar: our docs builds are broken now too :( | 19:16 |
| TheJulia | do we want to block on the docs job for now? | 19:39 |
| JayF | what is the change that broke it? | 19:42 |
| JayF | the charting stuff is a "fix it now" thing or something else? | 19:43 |
| TheJulia | well, you liked to the bug filed against another project during the meeting :) | 19:49 |
| TheJulia | I figured it was a "we should", but didn't realize we were broken | 19:49 |
| JayF | tbh I got the impression from backlog (read at like, t+15m from waking up, so maybe it was a misread) that u-c was going to be reverted for that | 19:50 |
| JayF | which is why I'm asking | 19:50 |
| opendevreview | Julia Kreger proposed openstack/ironic-inspector master: Change policy to enforce only new policy https://review.opendev.org/c/openstack/ironic-inspector/+/905119 | 20:00 |
| TheJulia | JayF: ahh, okay, no idea | 20:06 |
| JayF | https://review.opendev.org/c/openstack/requirements/+/906262 | 20:07 |
| JayF | although I'll note, nova has fixed their build | 20:07 |
| dking | dtantsur: M3 folks: I was wanting to get thoughts on adding some useful endpoints for the Ironic liveness probe for the BMO deployment. Is there any reason why that would be a bad thing? | 20:13 |
| JayF | Can you be explicit about what you mean by that? | 20:15 |
| dking | JayF: Currently, the liveness probe for Ironic just calls 'http://127.0.0.1:6385'. That makes sure that the container is running, but too often I find that works while something useful, like 'http://127.0.0.1:6385/v1/nodes/' would fail, for instance if there is a problem connecting to the db. | 20:17 |
| JayF | ah, so you're talking specifically about stuff in the operator, understood | 20:18 |
| JayF | thanks for the clarification | 20:18 |
| JayF | I wasn't sure if you were saying Ironic should add e.g. a /v1/healthcheck endpoint | 20:18 |
| JayF | like used to be popular a few years back | 20:18 |
| dking | yeah, really just the k8s deployment file for BMO. | 20:18 |
| TheJulia | well, technically the healthcheck is there, the problem is it doesn't trigger anything in the backend | 20:18 |
| dking | That might be useful, but personally, I think just hitting /v1/nodes/ should be fine since that catches the issues. | 20:19 |
| TheJulia | so if the db is roasting over a nice fire, only a node list will really give a clue to that | 20:19 |
| TheJulia | it still won't poll the backend, fwiw | 20:19 |
| dking | Oh, if there is a healthcheck, I think it really should include a backend request. | 20:19 |
| JayF | hitting /v1/nodes is also punishing your database for no good reason, really :) | 20:20 |
| dking | In my experience, I've had issues where the db itself is fine but for various reasons Ironic needs to restart to be able to connect to it. I don't think it's the same issue each time. | 20:20 |
| dking | Fair. But if it can't handle one extra hit, it's probably too fragile anyway. | 20:21 |
| JayF | Depends on what your value of limit= is, how aggro your healthchecking is, and a few other things.... but the point is, there are lower-cost ways to validate :D | 20:21 |
| TheJulia | Your not loading 100k nodes into your deployment... right? | 20:21 |
| dking | I suppose that over time that really adds up, but maybe it's worth it to catch Ironic not being able to work. | 20:22 |
| JayF | yeah, exactly ^ :D | 20:22 |
| dking | Okay. So, what's a better way to do that? | 20:22 |
| dking | I suppose the client could report when there's a timeout. | 20:23 |
| JayF | If you're looking for a single config for a single environment, and not a universal solution | 20:23 |
| JayF | I would be tempted to say "get a specific node" but that gets HILARIOUS when that node goes EOL | 20:23 |
| JayF | probably GET /v1/conductors | 20:23 |
| JayF | I think that's the endpoint? | 20:23 |
| dking | Yeah, I wouldn't rely on any specific node. | 20:24 |
| JayF | because you could then actually check to see if conductors are happy if you wanted to go a step further from that | 20:24 |
| JayF | that is going to pull from the DB, confirm, with latency, that rabbit is happy | 20:24 |
| JayF | and not make your DB server work too hard in the process | 20:24 |
| dking | Currently, we already are checking state fairly regularly. I think it's BMO doing it. I don't know why something didn't yell from that. | 20:24 |
| dking | Okay, that might work. | 20:25 |
| dking | I don't see/v1/conductors | 20:26 |
| JayF | https://docs.openstack.org/api-ref/baremetal/#conductors-conductors | 20:26 |
| TheJulia | JayF: well, no rabbit in metal3 | 20:26 |
| JayF | ah, valid | 20:26 |
| JayF | but BMO is not only metal3, I think? | 20:27 |
| JayF | depending on which BMO(?) I think dmitry has one that's not only for metal3 now | 20:27 |
| JayF | but tbh I still haven't sorted all the glossary terms from that side of the community | 20:27 |
| dking | Oh, right, I needed to add the X-OpenStack-Ironic-API-Version header. But that means that if we added that to the probe, we would need to add the header as well. | 20:28 |
| TheJulia | well, Bare Metal Operator for driving interactions with ironic != other operators doing just software setup at a high level, but the latter seems to be much more "problem/case" specific | 20:28 |
| dking | Even if the results are empty, they still have to hit the DB, right, and maybe any other resources? | 20:29 |
| TheJulia | it does a select against the conductors table | 20:29 |
| JayF | in the RMQ case, that table would be updated with metadata if the conductor wasn't checking in | 20:30 |
| JayF | I don't think that happens in the json-rpc case | 20:30 |
| TheJulia | it still occurs, but it journals it to the db | 20:31 |
| TheJulia | I'm not sure if we actually bother to keep it up to date in metal3's single process context | 20:31 |
| dking | So, currently, changing the liveness probe to something like `curl -sSf -H "X-OpenStack-Ironic-API-Version: 1.49" 'http://127.0.0.1:6385/v1/conductors/'` would seem to be a useful improvement? | 20:34 |
| JayF | I do not have enough context on metal3 as a whole to say that; but I would say it is a better test of "is Ironic likely to do a thing" than a query on `/` | 20:34 |
| dking | Okay. I think that helps. | 20:36 |
| dking | So, what's up with /v1/heartbeat/? | 20:36 |
| dking | As in, if it doesn't check db connections, etc., why not? | 20:36 |
| JayF | That is an internal endpoint used for the *ironic-python-agent* to heartbeat (report in, we would NOT call it heartbeat today I suspect) to Ironic. | 20:36 |
| JayF | > A /heartbeat method is exposed at the root of the REST API. This is used as a callback from within the ironic-python-agent ramdisk, so that an active ramdisk may periodically contact the Bare Metal service and provide the current URL at which to contact the agent. | 20:37 |
| JayF | from https://docs.openstack.org/api-ref/baremetal/#utility | 20:37 |
| dking | OH, right. I got my head into the containers and forgot about the real stuff. | 20:38 |
| JayF | No problem Neo, we all get distracted by the red dress sometimes :D | 20:38 |
| dking | Is there a similar endpoint on Inspector that would be good? I suppose that `/v1/rules` is still best as `/v1/introspection` could be much larger. | 20:41 |
| JayF | I don't know for inspector. | 20:41 |
| iurygregory | seems like vmedia job is broken becuase it can't connect to the mirror https://zuul.opendev.org/t/openstack/build/68b9f6721c024cdc8b5e50c75af3853f | 20:46 |
| JayF | they were talking about that in #opendev | 20:47 |
| JayF | just being weirded out that it was hitting the mirror directly I think | 20:47 |
| iurygregory | yeah, we have an attempt to fix it via https://review.opendev.org/c/openstack/ironic/+/906256 | 20:47 |
| TheJulia | we can temp disable and re-enable | 20:48 |
| JayF | https://review.opendev.org/c/openstack/ironic/+/906256 | 20:48 |
| JayF | is the fix | 20:48 |
| iurygregory | yeah | 20:48 |
| JayF | it looks good to me except for the docs being broken | 20:48 |
| JayF | which has a u-c revert that is pending a second core review | 20:48 |
| iurygregory | standalone failed | 20:48 |
| iurygregory | https://zuul.opendev.org/t/openstack/build/de9d82545d0d44c69b4135f6a290ac69 | 20:48 |
| JayF | you should dig into that separately I suspect, as the changed code does not impact standalone, right? | 20:49 |
| iurygregory | maybe just a random failure =) | 20:49 |
| JayF | well not random anymore, an Ironic expert just looked at it | 20:49 |
| iurygregory | I don't think it does based on what I saw | 20:49 |
| JayF | sounds like it'll get identified and figured out ;) | 20:49 |
| iurygregory | :D hopefully! | 20:49 |
| JayF | (you know I'm talking about you, right :P) | 20:49 |
| JayF | lol | 20:50 |
| iurygregory | I had this feeling lol | 20:50 |
| iurygregory | =D | 20:50 |
| dtantsur | dking: keep in mind that both conductors and nodes endpoints are authenticated. This is a potential problem for healthchecks. | 21:33 |
| TheJulia | brraaaaiiinsss | 21:47 |
| JayF | pillow downgrade is in the gate | 22:21 |
| iurygregory | \o/ | 22:30 |
| TheJulia | Awesome | 22:34 |
| JayF | https://review.opendev.org/c/openstack/ironic/+/906256 is almost certinly going to need another recheck | 23:01 |
| JayF | b/c it got rechecked while pillow was still upgraded | 23:02 |
| JayF | so if you see it's failed, please bump it and remember only one core approval needed to fix the gate | 23:02 |
| iurygregory | JayF, the change got +1 from zuul =) | 23:54 |
| iurygregory | +2W | 23:54 |
| opendevreview | Julia Kreger proposed openstack/ironic-specs master: WIP/DNM: Document to discuss vmedia issue/fix options https://review.opendev.org/c/openstack/ironic-specs/+/906324 | 23:54 |
| JayF | started at > 2024-01-22 21:59:57 | 23:54 |
| JayF | Thank you queue? | 23:55 |
| JayF | lol | 23:55 |
| JayF | oh, other landed at 1:18(?) | 23:55 |
| JayF | that must have hit my inbox late | 23:55 |
| JayF | interesting | 23:55 |
| iurygregory | magic | 23:59 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!
