| iurygregory | tks for sharing JayF o/ | 11:35 |
|---|---|---|
| iurygregory | good morning Ironic, happy last workday of the year lol | 11:36 |
| samcat116 | It looks like enabling send_sensor_data enables it for drivers that don't support it. Is this something that can be configured per node? | 18:32 |
| samcat116 | I have mostly snmp based nodes and so my conductor logs have a lot of errors in them | 18:32 |
| JayF | samcat116: I'd consider that a bug if it's throwing errors, can you put the information into one and link it? | 18:44 |
| JayF | samcat116: if there's already a solution I can point you to it there with the info inside, but I suspect we might have overlooked a thing | 18:44 |
| samcat116 | Here ya go | 18:46 |
| samcat116 | https://bugs.launchpad.net/ironic/+bug/2047709 | 18:46 |
| JayF | okay yeah that is a bug | 18:47 |
| JayF | one I might be able to patch real quick | 18:47 |
| JayF | will you get the last piece of productive work out of me in 2023?!? | 18:47 |
| samcat116 | 🤞 | 18:50 |
| JayF | Yeah it's just a noisy log message | 18:56 |
| JayF | I looked at it, there are other routes to maybe take | 19:02 |
| JayF | but I just s/warning/debug/ in my proposed patch | 19:02 |
| JayF | I think it's likely the best solution in this case and easily backportable if needed | 19:02 |
| JayF | samcat116: what version you need this in? | 19:02 |
| samcat116 | this is bobcat | 19:03 |
| JayF | aight, it'll probably take a bit to get in b/c I think we're not at core-quorum this week | 19:03 |
| JayF | but as long as it lands, should be a trivial backport | 19:03 |
| samcat116 | sweet! | 19:03 |
| samcat116 | thanks for the fast response 🥳 | 19:04 |
| opendevreview | Jay Faulkner proposed openstack/ironic master: Do not log lack of metrics support at WARNING lvl https://review.opendev.org/c/openstack/ironic/+/904455 | 19:04 |
| JayF | timing is everything, I just sat down after a break, opened IRC, your message is the first thing I saw :) | 19:04 |
| JayF | happy to help especially when it doesn't even really cost an interrupt :) | 19:04 |
| JayF | samcat116: ^ your review is appreciated if you're familiar w/gererit | 19:05 |
| samcat116 | That looks like it'll remove the warning log, but that other exception seems like its something different? | 19:08 |
| samcat116 | Yeah I'll do that | 19:08 |
| JayF | So that second piece I *think* is a local config error for you | 19:10 |
| JayF | checking tho | 19:10 |
| JayF | samcat116: I think that means you don't have a metrics backend configured | 19:12 |
| JayF | and also that our check for that is not in the right place as well, potentially (?) | 19:12 |
| JayF | samcat116: can you share [metrics] section of your conf? | 19:12 |
| JayF | redact hostnames, ofc | 19:12 |
| JayF | samcat116: my belief is you have the default set here: https://github.com/openstack/ironic-lib/blob/master/ironic_lib/metrics_utils.py#L28 (noop) which leads you to this codepath when we call to send metrics: https://github.com/openstack/ironic-lib/blob/master/ironic_lib/metrics.py#L295 (NoopMetricLogger doesn't implement that method, so it bails to there) | 19:14 |
| samcat116 | well there isn't one, so that would be the problem I guess | 19:14 |
| JayF | samcat116: If you're using prometheus, I think that gets set to collector | 19:14 |
| JayF | samcat116: if you're using statsd, there are great docs, IDK where the docs are for the prometheus stuff they are not in the same place | 19:14 |
| samcat116 | I've got that under [oslo_messaging_notifications] | 19:15 |
| samcat116 | driver = prometheus_exporter | 19:15 |
| samcat116 | location = /var/lib/ironic/metrics | 19:15 |
| JayF | those are different things | 19:15 |
| JayF | even if both can output to prometheus | 19:15 |
| samcat116 | Yeah so then I have no metrics section setup | 19:16 |
| JayF | samcat116: https://docs.openstack.org/ironic/latest/admin/metrics.html#transmission-to-the-message-bus-notifier | 19:16 |
| JayF | there we go :D | 19:16 |
| JayF | samcat116: literally looks like you just need to set it to collector, which is going to plug it into the notifications backend w/prom exporter | 19:16 |
| samcat116 | yep that did it | 19:18 |
| samcat116 | I guess thats a bug for the kolla folks | 19:18 |
| samcat116 | (I say that did it, the error is gone but I haven't started scraping here to check the actual metrics) | 19:19 |
| JayF | samcat116: I have a bonus patch coming in, too | 19:21 |
| JayF | basically: _msg_fmt = _("Metrics action is not supported. You may need to adjust the [metrics] section in ironic.conf.") | 19:21 |
| opendevreview | Jay Faulkner proposed openstack/ironic-lib master: Improve error message for wrong metrics backend https://review.opendev.org/c/openstack/ironic-lib/+/904457 | 19:22 |
| JayF | samcat116: any more of these low hanging fruit for me? | 19:22 |
| JayF | delicious juicy code pears | 19:22 |
| JayF | lol | 19:22 |
| JayF | that one will not likely be backported, fwiw, but you'll help out the next person in line :D | 19:22 |
| samcat116 | Hah, nothing right now but thank you | 19:23 |
| JayF | no problem :) these quality of life fixes are my favorite kind of thing | 19:23 |
| samcat116 | I'm sure the new year will bring high hanging fruit from me though | 19:23 |
| JayF | leave those for taller people | 19:23 |
| JayF | I'm in a lounge chair over here, peel me another bug ticket will you /s | 19:23 |
| JayF | lol | 19:24 |
| JayF | Reminder: I'm out through Thursday of next week; I'll be in email if anyone needs me urgently. | 22:05 |
| opendevreview | Merged openstack/ironic-python-agent master: Reformat and update the section on injecting root credentials https://review.opendev.org/c/openstack/ironic-python-agent/+/903750 | 22:20 |
| opendevreview | Merged openstack/ironic-specs master: Boot configuration API https://review.opendev.org/c/openstack/ironic-specs/+/902574 | 22:21 |
| opendevreview | Merged openstack/ironic master: CI: use Swift for configdrive when available https://review.opendev.org/c/openstack/ironic/+/903642 | 23:31 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!