| opendevreview | Verification of a change to openstack/ironic master failed: Revert "Move BFV job to non-voting" https://review.opendev.org/c/openstack/ironic/+/903460 | 00:20 |
|---|---|---|
| opendevreview | Merged openstack/ironic master: Fix two severe errors in the firmware caching code https://review.opendev.org/c/openstack/ironic/+/903185 | 00:55 |
| JayF | not bfv; a post failure | 01:06 |
| opendevreview | Verification of a change to openstack/ironic master failed: Revert "Move BFV job to non-voting" https://review.opendev.org/c/openstack/ironic/+/903460 | 01:28 |
| opendevreview | Merged openstack/ironic master: Revert "Move BFV job to non-voting" https://review.opendev.org/c/openstack/ironic/+/903460 | 04:46 |
| rpittau | good morning ironic! o/ | 07:58 |
| *** jph5 is now known as jph1 | 08:19 | |
| *** jph1 is now known as jph | 08:20 | |
| opendevreview | Dmitry Tantsur proposed openstack/ironic-python-agent stable/2023.2: Fix referencing to the raid_device var which is not set https://review.opendev.org/c/openstack/ironic-python-agent/+/903547 | 10:28 |
| opendevreview | Riccardo Pittau proposed openstack/ironic-python-agent bugfix/9.8: Fix referencing to the raid_device var which is not set https://review.opendev.org/c/openstack/ironic-python-agent/+/903549 | 10:49 |
| opendevreview | Dmitry Tantsur proposed openstack/ironic master: [DNM] Test with reduced sushy-tools feature set https://review.opendev.org/c/openstack/ironic/+/903361 | 11:25 |
| dtantsur | Could I get https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/903175 approved please? Neither debian versions work now. | 11:26 |
| iurygregory | good morning Ironic | 11:27 |
| iurygregory | dtantsur, done | 11:28 |
| dtantsur | thx! | 11:28 |
| iurygregory | yw | 11:28 |
| opendevreview | Dmitry Tantsur proposed openstack/ironic master: [DNM] Test redfish with reduced sushy-tools feature set https://review.opendev.org/c/openstack/ironic/+/903361 | 12:42 |
| opendevreview | Dmitry Tantsur proposed openstack/ironic master: [WIP] Test redfish with reduced sushy-tools feature set https://review.opendev.org/c/openstack/ironic/+/903361 | 12:44 |
| opendevreview | Dmitry Tantsur proposed openstack/ironic master: [DNM] Break redfish baseline https://review.opendev.org/c/openstack/ironic/+/903588 | 12:44 |
| opendevreview | Merged openstack/ironic-python-agent-builder master: Fix building images for Bullseye and Bookworm https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/903175 | 13:22 |
| opendevreview | Iury Gregory Melo Ferreira proposed openstack/ironic master: [WIP] RedfishFirmwareInterface - Unit Tests & More logs https://review.opendev.org/c/openstack/ironic/+/903379 | 14:16 |
| opendevreview | Merged openstack/ironic-python-agent-builder master: Always generate checksum files on image builds https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/878297 | 14:31 |
| opendevreview | Dmitry Tantsur proposed openstack/ironic-python-agent-builder stable/2023.2: Fix building images for Bullseye and Bookworm https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/903550 | 14:34 |
| opendevreview | Dmitry Tantsur proposed openstack/ironic-python-agent master: Add a jitter to heartbeat retries https://review.opendev.org/c/openstack/ironic-python-agent/+/897055 | 14:36 |
| dtantsur | TheJulia, JayF, this ^^^ is a "fun" one, I'd appreciate a careful look at the math | 14:36 |
| TheJulia | dtantsur: overall, a few things I could nit, but they really aren't worth it. I *think* it looks good and you've also articulated why. The one question I do wonder, if we *really* want to have such a error path on a conflict given the conflict is (if my memory is serving me today) a lock | 15:22 |
| dtantsur | TheJulia: thanks! a lock can be released quickly, so 5-10 seconds is not too bad. Or what do you mean? | 15:22 |
| TheJulia | oh, I just re-looked at that section, nvmd | 15:23 |
| TheJulia | I thought you cast it in with the long delay, but you didn't | 15:23 |
| TheJulia | its all good | 15:23 |
| dtantsur | I've toyed with various ideas in the previous changesets, but settled down on this one | 15:23 |
| TheJulia | That is what I get for getting distrated between opening it first and looking at it | 15:23 |
| dtantsur | :D | 15:24 |
| TheJulia | Yeah, I think 5-10 is reasonable retry. Since we also added the logic conductor side to prevent the locks from stacking | 15:24 |
| TheJulia | so it short circuits the heartbeat super quickly | 15:24 |
| dtantsur | yep | 15:24 |
| TheJulia | iurygregory: replied to your mpath cache patch as to why you likely want all of the mappings | 15:41 |
| TheJulia | and maybe just advocated keeping an age on the data in the cache | 15:42 |
| TheJulia | maybe. | 15:42 |
| iurygregory | TheJulia, thanks! | 15:43 |
| TheJulia | dtantsur: replied to https://review.opendev.org/c/openstack/ironic/+/900964/10/doc/source/admin/drivers/redfish.rst | 15:55 |
| TheJulia | take a quick look and let me know if you have any thoughts/questions | 15:55 |
| dtantsur | TheJulia: mm, thanks. Nothing there was blocking really, I just didn't expect to see an ISO. | 16:02 |
| TheJulia | Yeah, it is admittedly a little mind bending | 16:04 |
| TheJulia | hjensas: a thought, if we can detect ipv6 stateful use in the code base and actually block folks from attempting flat in a neutron integrated case, since it needs to be "neutron" for the extra config data to be sent. | 16:11 |
| * TheJulia has the ?5th? customer hitting that issue for the year | 16:11 | |
| JayF | TheJulia: we can detect that | 16:22 |
| JayF | TheJulia: I've been in that code helping Boushra w/the ovn vtep switch support | 16:22 |
| JayF | (I think, at least) | 16:22 |
| TheJulia | We would need to look at the neutron network data to determine type | 16:23 |
| JayF | TheJulia: we already do that in a couple places | 16:27 |
| TheJulia | yeah | 16:27 |
| JayF | TheJulia: er, I guess I mean, we look at the *binding profile* e.g. port.local_link_connection | 16:27 |
| JayF | which I guess isn't the same thing | 16:27 |
| TheJulia | no, it is not | 16:27 |
| JayF | but I bet we have all the info | 16:27 |
| JayF | we have a lot of info in there | 16:27 |
| TheJulia | we can easily get it | 16:28 |
| JayF | dtantsur: +2 on that IPA change; I didn't +W in case you wanted another review from someone more math-y :D | 16:28 |
| TheJulia | it just seems like if we know a case will never work, we should detect and error to stop the attempt hard with a slightly insightful error message | 16:28 |
| JayF | We do that in some places already | 16:28 |
| JayF | e.g. if port.is_smartnic=true and the binding profile isn't one for a smartnic | 16:28 |
| dtantsur | JayF: I don't know if we have someone more mathy :D | 16:29 |
| JayF | or node.has_smartnic, whatever that value is | 16:29 |
| JayF | dtantsur: have I mentioned recently we need more brains :) | 16:29 |
| JayF | dtantsur: lol | 16:29 |
| JayF | +a | 16:29 |
| TheJulia | JayF: more to the point, it woudl require taking a look at the contents of the neutron network as configured in neutron, which is fine really | 16:30 |
| JayF | ugh actually dtantsur can you follow up with a release node? | 16:30 |
| JayF | s/node/note/ | 16:30 |
| JayF | I guess people don't read them much for IPA, and there's a bug, but we shouldn't neglect them :/ | 16:31 |
| JayF | I keep missing those in review | 16:31 |
| dtantsur | JayF: I can add one now if you re-approach the patch right away | 16:32 |
| JayF | yup | 16:32 |
| * dtantsur not sure why he forgot | 16:32 | |
| JayF | I am pretty sure if we measured it, I might win for best review latency :) | 16:32 |
| JayF | I had a *nova* bugfix up for days asking for review and didn't realize until last night I missed the reno | 16:32 |
| opendevreview | Dmitry Tantsur proposed openstack/ironic-python-agent master: Add a jitter to heartbeat retries https://review.opendev.org/c/openstack/ironic-python-agent/+/897055 | 16:34 |
| dtantsur | JayF: could you check the text now before I go for dinner? | 16:34 |
| JayF | reapproved | 16:35 |
| JayF | lgtm | 16:35 |
| JayF | go dinner | 16:35 |
| dtantsur | thx! | 16:35 |
| dtantsur | o/ | 16:35 |
| rpittau | good night! o/ | 17:17 |
| opendevreview | Merged openstack/bifrost master: Support for Debian Bookworm https://review.opendev.org/c/openstack/bifrost/+/903177 | 17:51 |
| opendevreview | Merged openstack/bifrost master: Fix disable-dhcp option in playbook https://review.opendev.org/c/openstack/bifrost/+/903135 | 18:03 |
| opendevreview | Merged openstack/ironic-python-agent master: Add a jitter to heartbeat retries https://review.opendev.org/c/openstack/ironic-python-agent/+/897055 | 19:31 |
| opendevreview | Merged openstack/ironic master: Fix GET for conductors with a port or IPv6 address https://review.opendev.org/c/openstack/ironic/+/902790 | 20:11 |
| opendevreview | Merged openstack/ironic master: First pass at the new in-band inspection docs https://review.opendev.org/c/openstack/ironic/+/898237 | 20:11 |
| opendevreview | Merged openstack/bifrost master: Enable IPMI debugging in the testing mode https://review.opendev.org/c/openstack/bifrost/+/903182 | 20:24 |
| opendevreview | Merged openstack/bifrost master: Switch IPA building to Debian Bookworm https://review.opendev.org/c/openstack/bifrost/+/903162 | 20:41 |
| opendevreview | Merged openstack/bifrost master: Use sha256 instead of md5 by default https://review.opendev.org/c/openstack/bifrost/+/902656 | 20:41 |
| opendevreview | Merged openstack/ironic-python-agent stable/zed: preserve/handle config drives on 4k block devices https://review.opendev.org/c/openstack/ironic-python-agent/+/893558 | 20:43 |
| opendevreview | Julia Kreger proposed openstack/ironic master: Revise ramdisk boot interface for clarity https://review.opendev.org/c/openstack/ironic/+/903621 | 20:52 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!