opendevreview | Merged openstack/ironic-python-agent bugfix/9.6: Retry on checksum failures https://review.opendev.org/c/openstack/ironic-python-agent/+/897968 | 03:20 |
---|---|---|
opendevreview | Merged openstack/ironic master: CI: Fix our internal MTU settings https://review.opendev.org/c/openstack/ironic/+/893112 | 06:43 |
*** jroll5 is now known as jroll | 06:54 | |
rpittau | good morning ironic! o/ | 07:48 |
*** dking is now known as Guest3800 | 07:51 | |
Nisha_Agarwal | rpittau, GM | 08:58 |
rpittau | hey Nisha_Agarwal good morning :) | 08:58 |
Nisha_Agarwal | rpittau, i was reading the PTG notes on etherpad ....u have mentioned about some vmedia bug on ilo6 | 08:59 |
Nisha_Agarwal | do u have the link or details to it? | 08:59 |
Nisha_Agarwal | i searched story borad but couldnt find it | 09:00 |
Nisha_Agarwal | board* | 09:00 |
opendevreview | Damien RANNOU proposed openstack/ironic-python-agent-builder master: Moving from networking to systemd-networkd for debian Original networking is not capable to natively manage down/up on interfaces that is necessary for rescue https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/898723 | 09:01 |
rpittau | Nisha_Agarwal: no link at the moment, we haven't raised any bug, that specific issue comes from an internal discussion I had months ago | 09:04 |
Nisha_Agarwal | rpittau, can u give some details...have no clue... | 09:04 |
dtantsur | is it the FIPS issue or something else? | 09:06 |
rpittau | dtantsur: it's something else, related to vmedia image | 09:06 |
rpittau | Nisha_Agarwal: it's related to the size of the vmedia image in case floppy is used as device, if bigger than 1.4 MB then it does not report an error but tries to load the image forever | 09:07 |
dtantsur | floppy omg | 09:08 |
rpittau | unfortuantely I don't have logs | 09:08 |
Nisha_Agarwal | dtantsur, bug related to FIPs i have seen...but there the enhancement request goes to ilo firmware team bucket | 09:08 |
dtantsur | Nisha_Agarwal: yeah, I know you folks are aware of that. Would be great to have something soon - we keep getting pinged about it, and the only thing we can suggest is to stop using HTTPS... | 09:08 |
rpittau | anything FIPS related is definitely much more important and sensitive | 09:09 |
rpittau | my note is just to raise attention on ilo6 and potential known issues | 09:09 |
Nisha_Agarwal | rpittau, generally we attach the vfat image with necessary details of the instance(like ip address, IPA call back etc) to the floppy drive...Are you saying the size for it is bigger than 1.4 MB? | 09:10 |
Nisha_Agarwal | rpittau, i know...that u have just mentioned a note there | 09:10 |
rpittau | Nisha_Agarwal: I'm saying that if the size of the floppy image is bigger than 1.4 MB I would expect an error, not an infinite loop :) | 09:10 |
Nisha_Agarwal | i was just trying to see the details | 09:10 |
Nisha_Agarwal | rpittau, yes thats true | 09:11 |
Nisha_Agarwal | That infinite loop is happening from ilo firmware side? | 09:11 |
rpittau | that's my understanding, yes | 09:11 |
Nisha_Agarwal | not from driver side, right? | 09:11 |
rpittau | correct | 09:11 |
Nisha_Agarwal | If you hit the issue and raise it, probably that can be easily forwarded to ilo firmware team to fix it | 09:12 |
Nisha_Agarwal | because that would be regression for them | 09:12 |
Nisha_Agarwal | dtantsur, hmm | 09:13 |
Nisha_Agarwal | I can suggest for FIPS enhancement in ilo5 to ilo firmware team.... | 09:14 |
Nisha_Agarwal | but whether they will take any enhancements in ilo5 or not is something which we cannot say... | 09:15 |
rpittau | Nisha_Agarwal: alright, we'll do :) | 09:15 |
Nisha_Agarwal | rpittau, thanks | 09:15 |
Nisha_Agarwal | :) | 09:15 |
dtantsur | Nisha_Agarwal: all we can do is make them understand the consequences.. | 10:59 |
iurygregory | good morning Ironic | 11:19 |
masghar | Good morning! | 11:27 |
*** mmalchuk is now known as dimentor | 11:53 | |
*** dimentor is now known as mmalchuk | 11:59 | |
drannou | Hello | 12:11 |
drannou | TheJulia JayF : as requested, I tried to make the RFE for SED: https://bugs.launchpad.net/ironic/+bug/2039676 | 12:12 |
drannou | It's my first one :) so don't hesitate if you think that it's not enough, need to do it differently, etc | 12:12 |
drannou | I also have two bugs fix open, if you have time to review https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/898723 and https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/898322 (JayF already make a +1 on this one) | 12:13 |
opendevreview | Damien RANNOU proposed openstack/ironic-python-agent-builder master: 'sudo' group different between RH and Debian https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/898322 | 13:56 |
opendevreview | Julia Kreger proposed openstack/ironic-tempest-plugin master: WIP: Add test for dhcp-less vmedia based deployment https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/898006 | 13:56 |
JayF | I'll note I can put a +2 on it, so a +1 is a vote that does indicate I think improvements can be made (and I indicated one; if the group name can change; we should make it settable from the DIB caller IMO) | 13:57 |
TheJulia | good morning | 13:57 |
opendevreview | Damien RANNOU proposed openstack/ironic-python-agent-builder master: Use systemd-networkd for debian https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/898723 | 13:58 |
drannou | JayF: not sure I follow you, you are speaking about your comment on my #898322 ? | 14:44 |
JayF | I'm saying please don't ignore my comment here: https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/898322/3#message-f5979764c246210f7289ab6371a95c90444f781f | 14:45 |
JayF | putting a +1 instead of a -1 with a comment is considered courteous in this project when it's not a blocking comment | 14:45 |
JayF | but it's still something to consider :D | 14:45 |
drannou | yes ok, got it | 14:45 |
drannou | so, putting this as a variable that can be given in a bash argument would be better ? | 14:46 |
JayF | I honestly am not sure, that's why I put it in as an advisory comment | 14:47 |
JayF | just wanted to make sure it got seen/considered | 14:47 |
JayF | if you think it's not something that should be in a DIB_[blah] variable, and say so, I'd probably upgrade my vote to a +2 | 14:47 |
drannou | Well I would say that, as long as it's an 'hardcoded group name in distribution spirit', I don't know if it's a necessity to add complexity | 14:49 |
TheJulia | dib wise generally the hardcoded defaults are fine to encode into elements as long as they are generally known static defaults | 14:50 |
TheJulia | like... who is going to change wheel on an upgrade | 14:50 |
opendevreview | Julia Kreger proposed openstack/ironic master: WIP/DNM: Advanced vmedia deployment test ops https://review.opendev.org/c/openstack/ironic/+/898010 | 14:50 |
* TheJulia crosses her fingers and hopes that works | 14:50 | |
JayF | alright | 14:51 |
JayF | drannou: from TheJulia's comment it sounds like I'm wrong; I'm going to change my vote | 14:51 |
TheJulia | JayF: sorry dude! | 14:51 |
JayF | hey, I don't mind being wrong | 14:52 |
JayF | I just wanna know :D | 14:52 |
TheJulia | is that related at all to https://www.abposters.com/marketplace/i-want-to-believe-x-files-v113999 ? | 14:53 |
JayF | i believe in fermi :P | 14:53 |
drannou | Thx ! | 14:54 |
drannou | JayF: I get your point, that's why I put networkd as a variable in #898723, so it was not a waste of time :) | 14:55 |
JayF | nice | 14:55 |
JayF | yeah I often will ask questions in reviews | 14:55 |
JayF | my default is to lean into making things configurable, but OpenStack is large and complex and that can often be the incorrect route to go (because we have so many knobs already) | 14:56 |
TheJulia | and sometimes need even more knobs because of past decisions | 14:57 |
* TheJulia added a new knob and feels bad about it | 14:57 | |
TheJulia | Well, more like a valve | 14:57 |
JayF | I only wish clouds were as steampunk as we make them sound :D | 14:57 |
TheJulia | Well, when we apply steam to the valve, wholedisk images will now be stamped out | 14:58 |
TheJulia | via the dib-steam-stampinator | 14:58 |
TheJulia | lol | 14:58 |
TheJulia | I guess it was only funny to me | 15:01 |
JayF | not in much of a humorous mood, not feeling great this morning trying to work thru it but might sick out | 15:01 |
TheJulia | :( | 15:01 |
TheJulia | I'm *still* dealing with sinus issues from my last covid infection | 15:01 |
TheJulia | I was up for several hours last night, I guess exhaustion is just winning over in the form of mania | 15:02 |
JayF | Vanessa had a head cold this weekend, I think I avoided it mostly but might have just enough to make me feel crap | 15:02 |
TheJulia | ugh, that stinks :( | 15:02 |
TheJulia | dtantsur: you around ? | 15:30 |
TheJulia | dtantsur: specifically w/r/t https://review.opendev.org/c/openstack/openstacksdk/+/895224/4/openstack/baremetal/v1/node.py , line 443-444 handle what you seek, please advise. | 15:31 |
dtantsur | TheJulia: hmm, yeah, it probably does in this case since the step and the argument are from the same version | 15:32 |
TheJulia | I can add it anyway, but if I do that, then I'd add a note, and it would get confusing for anyone to go modify that code path since we already assert the version is on the request | 15:32 |
dtantsur | not necessary, +2 | 15:33 |
TheJulia | okay, thanks! | 15:34 |
dtantsur | do you agree with https://review.opendev.org/c/openstack/openstacksdk/+/895225/ ? | 15:34 |
TheJulia | Uhh, not really since it is a settable 3 state field | 15:34 |
TheJulia | unless your thinking something different or I'm not entirely groking what your thinking | 15:34 |
TheJulia | which *is* entirely possible | 15:35 |
dtantsur | TheJulia: well, then you need to go through deprecation and so on | 15:35 |
dtantsur | also, we have similar 3-state fields like is_secure_boot already | 15:35 |
TheJulia | I mean.. I guess it could be fine. Is the intent on the sdk just for the field to only be read from and not set? | 15:35 |
dtantsur | TheJulia: why not set? | 15:36 |
TheJulia | just thinking about name mapping then, but if the convention for those fields is "is_something_something" that might be fine, it just seems weird to me | 15:37 |
JayF | it also means our docs based on the raw API are completely invalid | 15:37 |
TheJulia | my brain lines orderly duplication :) | 15:37 |
dtantsur | TheJulia: that's the SDK's convention, yes | 15:37 |
TheJulia | s/lines/likes/ | 15:37 |
TheJulia | JayF: it is a translation issue inside of openstacksdk, not our docs | 15:37 |
dtantsur | I'm not really fond of it, but it was before me (probably blame mordred) | 15:37 |
JayF | someone using the SDK now needs a decoder ring to know we mean "baremetal set node is_enabled_automated_clean true" when we say "set node.automated_clean to true" in our docs | 15:38 |
TheJulia | Where did we put the wet cat cannon at?! | 15:38 |
JayF | yikes yikes yikes yikes | 15:38 |
JayF | I don't blame anyone in particular | 15:38 |
dtantsur | JayF: it's not about CLI, but yeah | 15:38 |
TheJulia | JayF: that would be cli, this is programatic python api interface | 15:38 |
dtantsur | they can use the SDK's Python docs | 15:38 |
JayF | oh, sdk is sdk, not cli | 15:38 |
JayF | that makes it slightly less awful in some ways and more in others | 15:38 |
JayF | but is reflective of why I don't use SDKs | 15:39 |
dtantsur | for CLI, they only need to figure out --automated-clean vs --no-automated-clean :) | 15:39 |
JayF | (in python, at least) | 15:39 |
TheJulia | dtantsur: steve has volunteered to take care of some other fields, he did a deep dive compare and found some other aspects | 15:39 |
TheJulia | so I would expect a few other fields inbound in the next few weeks | 15:39 |
TheJulia | stevebaker[m]: ^^^ | 15:39 |
dtantsur | ++ | 15:39 |
TheJulia | I'll go revise that one, so we can just unblock him | 15:40 |
TheJulia | And then I have to put on a serious business at with my "if moopsy not friend why friend shaped?" coffee mug | 15:40 |
TheJulia | s/at/hat/ | 15:40 |
* TheJulia glares at the keyboard | 15:40 | |
dtantsur | +++ | 15:40 |
* dtantsur needs to invent a dinner in the meantime | 15:40 | |
TheJulia | dtantsur: spawn() or read spell from book? | 15:41 |
TheJulia | :) | 15:41 |
* TheJulia feels like we need an ironic cookbook | 15:41 | |
dtantsur | a very ironic cookbook! | 15:41 |
TheJulia | We would have a whole chapter on Pizza Dough... in accordance with the rules and regulations | 15:42 |
TheJulia | heh, is_automated_clean_enabled is also not tested | 15:47 |
opendevreview | Julia Kreger proposed openstack/ironic master: WIP/DNM: Advanced vmedia deployment test ops https://review.opendev.org/c/openstack/ironic/+/898010 | 15:54 |
rpittau | good night! o/ | 16:17 |
Nisha_Agarwal | dtantsur, Hi | 17:11 |
Nisha_Agarwal | dtantsur, I had written to ilo fw team today and they say that it is already in plan and ilo% with TLS1.3 is already in plan and iLO5 with TLS1.3 is expected to be released early next year. | 17:15 |
Nisha_Agarwal | This is just a FYI... | 17:15 |
ashinclouds[m] | Awesome! | 17:27 |
opendevreview | Julia Kreger proposed openstack/ironic master: WIP/DNM: Advanced vmedia deployment test ops https://review.opendev.org/c/openstack/ironic/+/898010 | 17:53 |
opendevreview | Merged openstack/ironic-python-agent-builder master: 'sudo' group different between RH and Debian https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/898322 | 17:59 |
opendevreview | Julia Kreger proposed openstack/ironic master: WIP/DNM: Advanced vmedia deployment test ops https://review.opendev.org/c/openstack/ironic/+/898010 | 19:32 |
opendevreview | Julia Kreger proposed openstack/ironic master: WIP/DNM: Advanced vmedia deployment test ops https://review.opendev.org/c/openstack/ironic/+/898010 | 21:18 |
opendevreview | Verification of a change to openstack/ironic-python-agent master failed: Add mlnx deploy_step entry to enable deploy time firmware https://review.opendev.org/c/openstack/ironic-python-agent/+/893371 | 21:38 |
opendevreview | Maksim Malchuk proposed openstack/bifrost stable/2023.2: Fix Keystone default log location typo https://review.opendev.org/c/openstack/bifrost/+/898760 | 22:07 |
JayF | mmalchuk: you sending that all the way back? | 22:09 |
JayF | mmalchuk: needs to go to zed afaict | 22:10 |
JayF | mmalchuk: I can do it if you don't want to; but if you do it I can still ladn them :D | 22:10 |
* JayF JFDI | 22:13 | |
JayF | ah, it doesn't need it in stable/2023.1, it's right there | 22:14 |
opendevreview | Merged openstack/ironic master: Reset parent_node values to uuids instead of names https://review.opendev.org/c/openstack/ironic/+/889750 | 22:29 |
opendevreview | Julia Kreger proposed openstack/ironic-tempest-plugin master: WIP: Add test for dhcp-less vmedia based deployment https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/898006 | 23:23 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!