| *** shadower8 is now known as shadower | 00:18 | |
| vanou | good morning ironic | 00:38 |
|---|---|---|
| vanou | JayF: Thanks for review on rough draft | 00:40 |
| vanou | TheJulia JayF: I modified backport patch to make it more backportable https://review.opendev.org/c/openstack/ironic/+/870880 . If possible please give a look on this. | 00:40 |
| iurygregory | JayF, nope only the etherpad, did you request the team slot for the PTG? if not I can do that | 01:12 |
| JayF | iurygregory: I did that today | 01:13 |
| iurygregory | ack | 01:14 |
| opendevreview | Steve Baker proposed openstack/ironic master: Refresh updated_at in unregister_conductor https://review.opendev.org/c/openstack/ironic/+/872833 | 03:47 |
| opendevreview | Steve Baker proposed openstack/ironic master: On rpc service stop, wait for node reservation release https://review.opendev.org/c/openstack/ironic/+/872834 | 03:47 |
| rpittau | good morning ironic! o/ | 07:58 |
| kubajj | Morning everyone | 08:06 |
| opendevreview | Riccardo Pittau proposed openstack/metalsmith master: [WIP] Add centos9 based job https://review.opendev.org/c/openstack/metalsmith/+/869374 | 08:38 |
| opendevreview | Mark Goddard proposed openstack/bifrost stable/zed: Use curl to download deploy image if get_url fails https://review.opendev.org/c/openstack/bifrost/+/872873 | 09:07 |
| opendevreview | Mark Goddard proposed openstack/bifrost stable/yoga: Use curl to download deploy image if get_url fails https://review.opendev.org/c/openstack/bifrost/+/872874 | 09:07 |
| opendevreview | Mark Goddard proposed openstack/bifrost stable/xena: Use curl to download deploy image if get_url fails https://review.opendev.org/c/openstack/bifrost/+/872875 | 09:07 |
| kubajj | dtantsur: What should be the error handling when an exception is raise during get_introspection_data_from_swift? (This could happen even when the object simply does not exist) | 10:11 |
| kubajj | Do we have any wiki on what conductor is doing/how it works? | 11:32 |
| opendevreview | Verification of a change to openstack/bifrost master failed: Fix jinja ansible lint error https://review.opendev.org/c/openstack/bifrost/+/866137 | 11:51 |
| iurygregory | good morning Ironic | 12:07 |
| dtantsur | kubajj: we need to propagate the exception and turn it into HTTP 404, I think | 12:44 |
| kubajj | So should I just raise the NotFound in the ..._from_swift and then propagate it up to the API? | 12:47 |
| dtantsur | I think so | 12:48 |
| kubajj | dtantsur: should I try to find plugin_data before raising it if inventory is not found or just raise it with the first one? | 12:50 |
| dtantsur | kubajj: I cannot see a reasonable scenario where we end up with plugin data but not inventory | 12:51 |
| dtantsur | (we do account for it in the clean up because it's clean up) | 12:51 |
| kubajj | Yeah, makes sense | 12:51 |
| kubajj | dtantsur: should I create a new exception SwiftObjectNotFound or is the HTTPNotFound enough? | 13:21 |
| dtantsur | kubajj: we should probably add a standard InventoryNotFound derived from the base not found | 13:24 |
| kubajj | dtantsur: sounds reasonable | 13:25 |
| kubajj | dtantsur: I just found out that there is already SwiftObjectNotFoundError, should I raise this from the private function and then raise the InventoryNotFound from the get_inventory_data? | 13:27 |
| dtantsur | sounds reasonable (we should then give the database and no-op path the same treatment) | 13:27 |
| kubajj | dtantsur: will do | 13:28 |
| Sandzwerg[m] | <ftarasenko> "Gm Ironic! Team, did someone..." <- We have issues with cleaning on some HPE nodes, but on the OS disks not on the NVMes. Would need to check what exactly we have in use | 13:46 |
| kubajj | dtantsur: So I figured out that I have created NodeInventoryNotFound exception for Node Object in the first change. But I will keep this and InventoryNotFound separate as I would like to pass a reason (different one for nostore, db and swift) to it. | 13:50 |
| opendevreview | Riccardo Pittau proposed openstack/metalsmith master: [WIP] Add centos9 based job https://review.opendev.org/c/openstack/metalsmith/+/869374 | 13:55 |
| opendevreview | Harald Jensås proposed openstack/metalsmith master: Use a network cache in Instance https://review.opendev.org/c/openstack/metalsmith/+/872963 | 14:17 |
| opendevreview | Harald Jensås proposed openstack/metalsmith master: Get all instance vifs in one call https://review.opendev.org/c/openstack/metalsmith/+/872966 | 14:32 |
| mgoddard | Hi, anyone able to give a second +2 on these backports? https://review.opendev.org/q/I5946e8a864b164c019f6febe35cb70337c06fff2 | 14:43 |
| TheJulia | mgoddard: looking | 14:47 |
| TheJulia | mgoddard: approved | 14:55 |
| mgoddard | thanks TheJulia :) | 15:00 |
| mgoddard | TheJulia: there's also this one, if you have time: https://review.opendev.org/q/I8861c4c5932529a8b99b057b4d33bc14de60420c | 15:01 |
| TheJulia | mgoddard: done | 15:04 |
| mgoddard | thank you | 15:04 |
| TheJulia | no problem :) | 15:04 |
| opendevreview | Merged openstack/bifrost stable/zed: Create /run/ironic runtime directory when service starts https://review.opendev.org/c/openstack/bifrost/+/871030 | 16:09 |
| opendevreview | Verification of a change to openstack/bifrost stable/yoga failed: Create /run/ironic runtime directory when service starts https://review.opendev.org/c/openstack/bifrost/+/871031 | 16:09 |
| JayF | TheJulia: IT'S ME. I'm login.launchpad.net_154 | 16:13 |
| JayF | I just did a password reset on pypi and it's like "that's your username" | 16:13 |
| TheJulia | Lolz | 16:14 |
| TheJulia | Out of curiosity, the last login date/time? | 16:22 |
| dtantsur | JayF: now we know your superhero identity! | 16:28 |
| JayF | I have no idea, I reset the password on that account | 16:28 |
| JayF | and will drop the creds as soon as I get screenshots for the doc | 16:28 |
| TheJulia | I was hoping it would have told you when the last login was | 16:29 |
| JayF | I have to have logged into it somewhat more recently | 16:33 |
| JayF | because it had my current email address | 16:33 |
| JayF | but the password wasn't in lastpass either | 16:33 |
| JayF | so I have no idea when I made this, how it's been used, etc, but it's in my pw manager now and password changed | 16:33 |
| JayF | if I can't change the username, I'll probably delete the account once I get it to let go of IPA | 16:33 |
| TheJulia | Interesting… | 16:36 |
| TheJulia | I’m sure an IPA was involved someplace.. otherwise the OPA… | 16:42 |
| * TheJulia feels sad nobody laughed, hangs her head, and dreams of having a ship like the roci… | 16:51 | |
| Sandzwerg[m] | The OPA? Didn't know you were a belter | 16:52 |
| * TheJulia has an MCR flag… | 16:53 | |
| TheJulia | None of me neighbors have said a word… | 16:54 |
| Sandzwerg[m] | All better than a Laconian one :P | 16:55 |
| TheJulia | Indeed! | 16:55 |
| rpittau | good night! o/ | 17:09 |
| opendevreview | Merged openstack/bifrost stable/zed: Use curl to download deploy image if get_url fails https://review.opendev.org/c/openstack/bifrost/+/872873 | 17:59 |
| opendevreview | Merged openstack/bifrost stable/yoga: Use curl to download deploy image if get_url fails https://review.opendev.org/c/openstack/bifrost/+/872874 | 17:59 |
| opendevreview | Merged openstack/bifrost stable/xena: Use curl to download deploy image if get_url fails https://review.opendev.org/c/openstack/bifrost/+/872875 | 17:59 |
| opendevreview | Merged openstack/bifrost stable/yoga: Create /run/ironic runtime directory when service starts https://review.opendev.org/c/openstack/bifrost/+/871031 | 18:47 |
| opendevreview | Jakub Jelinek proposed openstack/ironic master: Erase swift inventory entry on node deletion https://review.opendev.org/c/openstack/ironic/+/871394 | 19:30 |
| kubajj | TheJulia: can I have a question? I've been staring at this for last two hours. In ^ I have a problem. I created a test case https://review.opendev.org/c/openstack/ironic/+/871394/11/ironic/tests/unit/api/controllers/v1/test_node.py#7960 and I try to catch HTTPNotFound, but the test fails and says "Bad response: 404 Not Found". What am I missing? | 19:33 |
| opendevreview | Harald Jensås proposed openstack/metalsmith master: Get ports by 'binding:host_id' query filter https://review.opendev.org/c/openstack/metalsmith/+/872966 | 21:23 |
| opendevreview | Steve Baker proposed openstack/metalsmith master: test_provision: don't assert provision_node call order https://review.opendev.org/c/openstack/metalsmith/+/873035 | 21:36 |
| opendevreview | Harald Jensås proposed openstack/metalsmith master: Get ports by 'binding:host_id' query filter https://review.opendev.org/c/openstack/metalsmith/+/872966 | 21:59 |
| TheJulia | kubajj: so... your getting an http response payload, not a raw exception so you need to just check the status_code on the response body | 22:41 |
| TheJulia | it is an attribute field on the result of self.get_json, if memory serves | 22:42 |
| JayF | kubajj: TheJulia: the tests in my sharding PR (which you should review, kubajj) are a good, simple example here | 23:23 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!