| opendevreview | Vanou Ishii proposed openstack/ironic stable/zed: [iRMC] identify BMC firmware version https://review.opendev.org/c/openstack/ironic/+/870880 | 05:05 |
|---|---|---|
| opendevreview | Vanou Ishii proposed openstack/ironic stable/zed: [iRMC] Handle IPMI incompatibility in iRMC S6 2.x https://review.opendev.org/c/openstack/ironic/+/870881 | 05:05 |
| opendevreview | Vanou Ishii proposed openstack/ironic stable/zed: [iRMC] Handle IPMI incompatibility in iRMC S6 2.x https://review.opendev.org/c/openstack/ironic/+/870881 | 07:20 |
| rpittau | happy Friday ironic! o/ | 08:04 |
| rpittau | looking for a quick approval to fix unit tests in CI for 3 bugfix branches if anyone has a moment https://review.opendev.org/q/topic:pin-tox-bugfix-ironic thanks! | 08:14 |
| opendevreview | Samuel Kunkel proposed openstack/sushy master: bugfix: fix requests verify handling if env is set https://review.opendev.org/c/openstack/sushy/+/870888 | 08:58 |
| samuelkunkel[m] | rpittau: have added releasenotes, not sure how granular they need to be. | 08:59 |
| kubajj | Good morning everyone! | 09:03 |
| rpittau | samuelkunkel[m]: left a note, thanks | 09:05 |
| rpittau | hey kubajj :) | 09:05 |
| opendevreview | Samuel Kunkel proposed openstack/sushy master: workaround: requests verify handling if env is set https://review.opendev.org/c/openstack/sushy/+/870888 | 09:19 |
| opendevreview | Samuel Kunkel proposed openstack/sushy master: workaround: requests verify handling if env is set https://review.opendev.org/c/openstack/sushy/+/870888 | 09:44 |
| samuelkunkel[m] | rpittau: do I btw need to do anything about the HPE Proliant Pipeline? | 09:46 |
| rpittau | samuelkunkel[m]: not really, that's third party CI and we don't control that | 10:32 |
| iurygregory | good morning Ironic | 11:40 |
| kubajj | could I get some reviews of https://review.opendev.org/c/openstack/ironic/+/870470 please? | 13:04 |
| dtantsur | +2 | 13:17 |
| kubajj | dtantsur: thanks | 13:19 |
| kubajj | dtantsur: have you managed to look at https://review.opendev.org/c/openstack/ironic/+/870799 ? What should be the next step after it? I can do some reading on redfish if you think that would be useful | 13:20 |
| dtantsur | I haven't looked yet. Re the next step, have you put any thoughts into swift clean up on node deletion? | 13:22 |
| rpittau | kubajj: +W | 13:24 |
| dtantsur | kubajj: I'm a bit puzzled why get requires a context, while store does not.. | 13:25 |
| kubajj | dtantsur: I am not sure. I just implemented it like this in the main api change. | 13:26 |
| dtantsur | yeah, I'm trying to understand for myself | 13:27 |
| kubajj | It is just for the DB if I recall | 13:28 |
| dtantsur | kubajj: I see that e.g. objects.Node is created in the API with 'context' as the first argument | 13:28 |
| dtantsur | not sure why though - I'm not strong in this area | 13:28 |
| kubajj | dtantsur: about the next step. I knew I forgot about something. I'll work on that next. | 13:32 |
| dtantsur | meanwhile, new comments incoming | 13:39 |
| opendevreview | Julia Kreger proposed openstack/ironic master: Docs: Troubleshooting: how to exit clean failed https://review.opendev.org/c/openstack/ironic/+/871129 | 14:23 |
| opendevreview | Verification of a change to openstack/ironic master failed: Create [inventory] https://review.opendev.org/c/openstack/ironic/+/870470 | 14:44 |
| rpittau | bye everyone, have a great weekend! o/ | 14:53 |
| kubajj | dtantsur: I am safe to recheck this, right? https://zuul.opendev.org/t/openstack/build/223d22f9d62340e8b65c1392c433a2af Is it 3 host trying to access one volume? | 14:53 |
| kubajj | bye rpittau! | 14:53 |
| dtantsur | kubajj: this is concerning, but unlikely your fault | 14:54 |
| * TheJulia tries to wake up | 15:04 | |
| opendevreview | Verification of a change to openstack/ironic master failed: Create [inventory] https://review.opendev.org/c/openstack/ironic/+/870470 | 15:21 |
| kubajj | What is a post_failure in zuul? Can I do something with it? | 16:03 |
| TheJulia | it sometimes helps to look at the logs, it may be recheckable | 16:03 |
| TheJulia | but we generally want to know why it failed, if at all possible | 16:04 |
| TheJulia | sometimes that just means logs failed to upload and the job was considered failed as a result. | 16:04 |
| kubajj | TheJulia: I think that might be the case, cause there aren't any logs https://zuul.opendev.org/t/openstack/build/a71369108ae645cc9508422ca08cfbb6 | 16:04 |
| TheJulia | \o/ | 16:04 |
| kubajj | TheJulia: Should I recheck now or wait until it finishes the rest of the tests? | 16:06 |
| TheJulia | you have to wait unfortuantely | 16:08 |
| opendevreview | Julia Kreger proposed openstack/ironic-tempest-plugin master: Prevent protected node tests from orphaning test nodes https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/871301 | 16:09 |
| kubajj | TheJulia: Ok, thanks for help. | 16:10 |
| opendevreview | Julia Kreger proposed openstack/ironic-tempest-plugin master: Prevent protected node tests from orphaning test nodes https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/871301 | 16:41 |
| TheJulia | okay, this is bizzar | 17:24 |
| JayF | how bizarre? | 17:42 |
| TheJulia | well, tempest hates me | 17:43 |
| TheJulia | the patch seems to work intent wise, doesn't *seem* to error in ci. errors on a local machine I have of course, at least getting close | 17:44 |
| TheJulia | apparently I've been editing the wrong files for an hour | 17:55 |
| JayF | at least you discovered it before hour 2 :/ | 17:58 |
| opendevreview | Julia Kreger proposed openstack/ironic-tempest-plugin master: Prevent protected node tests from orphaning test nodes https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/871301 | 18:04 |
| TheJulia | true | 18:09 |
| TheJulia | On a plus side, that should be good to go, and verified that the node is deleted properly | 18:09 |
| TheJulia | \o/ | 18:09 |
| TheJulia | I do <3 that we have unit tests where we didn't mock out the memory check and so it actually lets me know when I ought to clean up my browser tabs.... | 18:40 |
| opendevreview | Julia Kreger proposed openstack/ironic master: API support for CRUD node.shard https://review.opendev.org/c/openstack/ironic/+/866235 | 18:41 |
| TheJulia | JayF: minor fix based upon comment | 18:42 |
| JayF | I saw, ty | 18:53 |
| JayF | TheJulia: one question: you think the /v1/ports querying stuff needs to be in that same change? | 19:10 |
| JayF | I'm about to start on that; so trying to determine if I should stuff it in there or a follow on | 19:10 |
| TheJulia | I'm fine with afterwards, but it realistically means a second api version increment | 19:10 |
| TheJulia | so... either? | 19:11 |
| JayF | I'll probably try to get it code complete before pushing it then | 19:11 |
| JayF | so if I have a second +2 in time; awesome, I'll take it | 19:11 |
| JayF | otherwise; I'll append it to the existing PR so we don't have to bump an extra API version | 19:11 |
| JayF | .o(what happens when we run out of two-digit API version numbers) | 19:11 |
| JayF | 1.100 is going to break a client, you know it, I know it lol | 19:11 |
| TheJulia | we split on the period I believe... | 19:13 |
| TheJulia | but... hmm | 19:13 |
| JayF | I'm not talking about our clients, either. | 19:13 |
| TheJulia | oh, yeah | 19:13 |
| TheJulia | eww | 19:13 |
| TheJulia | yeah | 19:13 |
| JayF | I'm talking about any shottily written script in the last decade | 19:13 |
| JayF | new plan: use the same PR no matter what | 19:13 |
| TheJulia | okay | 19:13 |
| JayF | and hope this problem doesn't happen until after the only ironic I care about is a 90s song? /s | 19:14 |
| TheJulia | heh | 19:14 |
| * TheJulia is worried the association proxy change breaks some tempest tests | 19:14 | |
| JayF | has that landed? | 19:16 |
| NobodyCam | Good morning and ... | 19:17 |
| NobodyCam | TGIF! | 19:17 |
| TheJulia | JayF: no | 19:23 |
| TheJulia | JayF: rechecked in ci to see since I think my other fix merged | 19:24 |
| JayF | if it does break tempest tests; it's sad for the change (and I'm sure will be brutal to debug) ... but in a way I'd feel more validated about all the work we put in keeping those running | 19:24 |
| TheJulia | but.. only on one job, which makes it *super* suspect too | 19:25 |
| * TheJulia ponders a nap | 19:28 | |
| TheJulia | ugh a gray area driver backport patch https://review.opendev.org/c/openstack/networking-generic-switch/+/870896 which... err | 19:29 |
| JayF | how is it a grey area? | 19:29 |
| JayF | it's a clear unbackportable change | 19:29 |
| TheJulia | technically driver enablement is a permittable backport | 19:30 |
| TheJulia | technically | 19:31 |
| TheJulia | but would need some solid justification | 19:31 |
| JayF | I mean, they're adding entrypoints in setup.cfg | 19:32 |
| TheJulia | yeah | 19:32 |
| JayF | I put a comment on the change and a -1, I'm like 95% "don't merge this" but could move if they come back with a really good justification | 19:32 |
| TheJulia | agreed | 19:32 |
| JayF | if the driver already existed, and they were fixing support for say, firmware version 6.10; that's permissable | 19:32 |
| TheJulia | ++ | 19:32 |
| JayF | or even if they were fixing an "ABC model switch" driver to support model "ABCD" as well, sure | 19:32 |
| TheJulia | hjensas: so, the chassis_uuid lookup appears to break node access. I'll try to look some over the weekend, my cold is kind of winning at the moment | 19:33 |
| opendevreview | Merged openstack/bifrost master: Feature: Enable user_data's file generation https://review.opendev.org/c/openstack/bifrost/+/870017 | 20:18 |
| opendevreview | Merged openstack/ironic master: Create [inventory] https://review.opendev.org/c/openstack/ironic/+/870470 | 20:34 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!