Thursday, 2022-12-15

opendevreviewMerged openstack/ironic-python-agent stable/ussuri: WIP Drop python2 from bindep.txt  https://review.opendev.org/c/openstack/ironic-python-agent/+/86265800:02
TheJuliaJayF: awesome! Now to prep dinner00:28
iurygregoryJayF, let me sync with dtantsur and rpittau we can answer this tomorrow I would say, wdyt?01:36
JayFI have no desire to cut bugfix releases unless we have contributors explicitly invested in them01:44
kamleshChauvhanGood morning Ironic !06:51
kamleshChauvhanNeed help to review https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/865803 & https://review.opendev.org/c/openstack/sushy/+/86484506:52
codecapHi Guys,08:16
codecapstill need help with ironic setup by kolla-ansible. Ironic Inspector does not find the node, when being contacted during deployment. Hier the error message08:16
codecapLook up error: Could not find a node for attributes {'bmc_address': ['10.40.11.68'], 'mac': ['4c:52:62:42:de:97', '4c:52:62:42:de:95', '4c:52:62:52:ae:2a', '4c:52:62:42:de:98', '4c:52:62:42:de:96', '4c:52:62:52:ae:2b']}08:16
codecapCan somebody help ?08:16
rpittaugood morning ironic! o/08:46
rpittauJayF: if I'm reading it right antelope is due out in March, with FF in February. If we don't cut a bugfix branch now (or before mid january at the latest) it probably does not make sense to cut one at all at this point considering that ironic final antelope release will be between mid february and beginning of march (I'm thinking with my downstream mind for this)08:56
rpittauJayF: sorry, actually ironic, ipa and inspector needs to be out by Feb 10, so even more we need a bugfix branch now or never08:59
rpittaudtantsur, TheJulia ^09:00
rpittauI don't mind skipping bugfix, but for the sake of consistency we should at least cut one, even if it won't be consumed that much09:02
opendevreviewAija Jauntēva proposed openstack/ironic master: Fix "'NoneType' object is not iterable" in RAID  https://review.opendev.org/c/openstack/ironic/+/86711709:21
dtantsurrpittau, TheJulia, JayF, I think we should not diverge from our release plans without a good reason09:41
dtantsur"middle of the holidays" is a good reason, "we forgot" - not so much :)09:41
dtantsurremember, we hope that not only OpenShift consumers Ironic releases09:41
dtantsurI think we only skipped releases for inspector when there were literally 0 functional changes09:44
dtantsurJayF, TheJulia, not sure what you mean by "nothing about the release cadence in the spec", this spec is very clear on it: https://specs.openstack.org/openstack/ironic-specs/specs/approved/new-release-model.html#releasing09:45
dtantsuror do you mean some other spec?09:45
rpittaudtantsur: before being in the middle of holidays and forget again, I'll cut bugfix branches for ironic, ipa and inspector :)10:02
dtantsurthanks!10:03
opendevreviewRiccardo Pittau proposed openstack/ironic-python-agent master: Fix create configuration unit tests  https://review.opendev.org/c/openstack/ironic-python-agent/+/86778010:52
opendevreviewRiccardo Pittau proposed openstack/ironic-python-agent master: Use pbr for versioning  https://review.opendev.org/c/openstack/ironic-python-agent/+/86778110:54
opendevreviewRiccardo Pittau proposed openstack/ironic-python-agent master: Update tox.ini for tox 4  https://review.opendev.org/c/openstack/ironic-python-agent/+/86778210:54
kubajjgood morning everybody11:20
opendevreviewRiccardo Pittau proposed openstack/ironic-python-agent master: Update tox.ini for tox 4  https://review.opendev.org/c/openstack/ironic-python-agent/+/86778211:21
opendevreviewkamlesh chauvhan proposed openstack/sushy stable/zed: Retry on iDRAC SYS518 errors for all requests  https://review.opendev.org/c/openstack/sushy/+/86763911:36
kamleshChauvhanrpittau : Hi 11:51
kamleshChauvhanrpittau : I see patch https://review.opendev.org/c/openstack/sushy/+/864102 hasn't been backported.  11:53
kamleshChauvhanrpiitau : backporting of https://review.opendev.org/c/openstack/sushy/+/864911 is dependent on the same.12:04
opendevreviewJakub Jelinek proposed openstack/ironic master: API for node inventory  https://review.opendev.org/c/openstack/ironic/+/86687612:49
kubajjdtantsur: that's a draft of the release note and api-ref ^12:51
rpittaukamleshChauvhan: that has not been backproted because it's a feature, and we usually don't backports features12:59
kamleshChauvhanrpittau : okay, Thanks.13:00
TheJuliaBrraaaaiiins. Also, good morning14:33
TheJuliadtantsur: I'm fairly sure we skipped an ironic release once as well, but after years it has all become a blur14:36
TheJuliaand I think it was a few weeks into january with minimal changes outside of bug fixes since like a date in november14:37
TheJuliaor something like that14:37
TheJuliamy point was more "is there quantity/reason"14:38
TheJuliaI'm indifferent otherwise14:38
dtantsurmorning TheJulia14:39
opendevreviewRiccardo Pittau proposed openstack/ironic master: [WIP] [PoC] A metal3 CI job  https://review.opendev.org/c/openstack/ironic/+/86387314:43
TheJuliawoot, nova side of shard key spec has 2x+214:51
dtantsur\o/14:57
TheJuliaHas anyone heard anything on service role implementation?14:58
JayFdtantsur: I'm glad you found the release cadence stuff in a document. I thought I was going insane yesterday remembering having read it but being unable to find it15:00
opendevreviewVanou Ishii proposed openstack/ironic master: [iRMC] Handle IPMI incompatibility in iRMC S6 2.x  https://review.opendev.org/c/openstack/ironic/+/86507515:04
opendevreviewVanou Ishii proposed openstack/ironic master: Add argument to explicitly specify IPMI retry  https://review.opendev.org/c/openstack/ironic/+/86780815:04
rpittaubye everyone see you tomorrow! o/15:21
TheJuliao/15:21
TheJuliaJayF: a couple things on the shard api change, nothing super major aside from some rbac testing stuffs15:25
TheJuliaand api-ref build fails15:25
TheJulia:)15:25
JayFNice. After that, it's filter ports by node.shard then write some docs, right?15:25
opendevreviewOpenStack Release Bot proposed openstack/ironic-python-agent bugfix/9.2: Update .gitreview for bugfix/9.2  https://review.opendev.org/c/openstack/ironic-python-agent/+/86781615:27
TheJuliabasically yeah15:27
TheJuliathere is a thing on get /v1/nodes?shard=foo,bar15:27
TheJuliabut that can be in the next patch from my pov15:27
TheJuliait may also just work, I don't remember how the filters get evaluated on just one cup of coffee15:27
TheJuliahjensas: I just noticed there is one thing missing with the changes to use association proxy to speed node_uuid/chassis_uuid/allocation_uuid resolution. We don't have any release notes15:29
opendevreviewJakub Jelinek proposed openstack/ironic master: API for node inventory  https://review.opendev.org/c/openstack/ironic/+/86687615:31
dtantsurkubajj: 5 minutes from patch posted to a review is nearing my personal record ^^ :)15:37
JayFdtantsur: would you be in opposition to changing the release policy to be every two months "as long as there is a sponsor to ensure the branch is maintained" or something similar15:40
JayFdtantsur: basically, I want to change the policy such that we only cut bugfix releases if we know someone is packaging it15:40
dtantsurJayF: I think I will, yes. I need to run now, happy to chat next week, but I don't want bugfix branches to end up something done only for Red Hat OpenShift15:40
JayFotherwise it's just maintenance churn15:40
JayFthey mostly already are? 15:41
dtantsurmaybe?15:41
dtantsurwe don't actually know how many people consume them. as always.15:41
JayFI've never found a single user in the wild. I did take pypi stats and found a few thousand downloads; but a lot of people mirror all of openstack from pypi15:41
JayFbut I also know it's manual work, and unless we're going to make the releases tooling fix it, I am not a fan of just throwing time into a black hole15:41
JayFs/fix it/support it/15:42
dtantsurJayF: if we think that nobody other than OCP is using bugfix branches we should stop doing them15:42
dtantsurrpittau is making provisions to ensure we can live without old branches; we'll be able to use the same for new releases too15:42
kubajjdtantsur: if swift is used, is it not covered by ironic object? I thought that Ironic objects were some kind of abstraction, but are they just for db?15:42
JayFI mean, that's an even better answer to the problem as I present it.15:43
dtantsurkubajj: I think they're only around DB15:43
dtantsur(yes, my take on bugfix branches existence is completely different from my take on their extended maintenance)15:43
dtantsurJayF: sorry, I need to run now, will be happy to elaborate further on Monday, but I think you got an idea15:44
JayFdtantsur: you going to be @ Monday meeting? Can make it a topic there?15:44
dtantsurmost likely yes. ++15:44
dtantsurprobably an ML topic as well since it may affect operators15:45
dtantsurtalk to you then o/15:45
kubajjdtantsur: could I get workflow for the alternative storage for inventory ( https://review.opendev.org/c/openstack/ironic/+/866056 ) then? I need to lead in the config option defined there to this change.15:48
JayFdtantsur: yeah, my thought was, get an idea of a direction folks are OK with, then gather info. I don't wanna send something to the ML being like "what if we didn't bugfix branch anymore" without more than two cores weighing in on it :D 15:49
kubajjor TheJulia or JayF (about the workflow)15:50
JayFI don't know off the top of my head; I know very little about inspector generally15:51
JayFbut if you haven't gotten help in ~an hour I have some free time15:51
* TheJulia sess a race for API version 1.81 brewing :)15:51
JayFit's not that bad of a rebase if you lose it15:52
kubajjTheJulia: it's mine 😈15:52
JayFkubajj: better hurry; node sharding is coming after you :)15:52
TheJuliawell, you both have a few minor things to fix :)15:52
TheJuliaand some rbac tests to add :)15:52
JayFlike, for instance, breakfast15:52
kubajjJayF: the change for the alternative storage is ready and has 2x +2, I just need to merge it15:52
TheJuliammmmmm breakfast15:53
JayFI'm not fixing it; just going to go pick it up ;) 15:53
kubajjTheJulia: what is rbac? JayF you might win then :D15:53
TheJuliaRole Based Access Control15:53
TheJuliawe have tests that enumerate through a yaml file and run as a data driven test15:53
kubajjTheJulia: ok, I'll have a look at them15:54
TheJuliathey basically run scenarios against the API to validate that access is granted, or denied based upon the policy15:54
TheJuliathink of it as an extra layer of security so we're validating the API behaves as we expect15:54
TheJuliaalso, RBAC testing in the traditional python test model is super complex/painful, hence why it is a yaml file15:54
kubajjTheJulia: is workflow automated or does somebody need to trigger it? I am unsure now15:56
TheJuliasomeone needs to push a button15:56
TheJuliafor newer features/multi-change items, often we workflow stuff together15:56
TheJuliaor in relatively rapid sucession15:56
kubajjTheJulia: and can I somehow tell my change that the config option exists, but just in another change?15:57
kubajjfor the swift support ^16:01
TheJuliawell, we generally don't want to change config file parameters once we've merged16:02
TheJuliaso if you want to modify your original change, there is still time16:02
kubajjTheJulia: I don't want to modify it. I need to use the config file parameter from the change enabling Swift (and NoStore) in the API one.16:04
TheJuliaOH!16:04
TheJuliaas long as the api change is after the base change with the config, your good16:04
kubajjTheJulia: ok16:05
opendevreviewOpenStack Release Bot proposed openstack/ironic-inspector bugfix/11.2: Update .gitreview for bugfix/11.2  https://review.opendev.org/c/openstack/ironic-inspector/+/86782516:05
opendevreviewOpenStack Release Bot proposed openstack/ironic bugfix/21.2: Update .gitreview for bugfix/21.2  https://review.opendev.org/c/openstack/ironic/+/86782616:11
kubajjTheJulia: should I raise a special NotFound if a user tries to access inventory of a node when the config is on NoStore?16:13
TheJuliaLikely NotFound with an error message16:17
TheJuliaI'm not sure there is a need to make another exception there16:18
TheJuliabut I'd convert the existing patterns first16:18
* TheJulia cries at the cover tests for ironic-inspector16:18
JayFyeah I saw that :(16:21
kubajjI just realised that I probably need to implement a function to get the inventory from Swift 😮‍💨16:25
kubajjJayF: you're definitely winning this race16:26
JayFit's not a race, fwiw16:26
JayFand of course I was going to win16:26
JayF;) 16:26
TheJuliaheh16:53
opendevreviewJulia Kreger proposed openstack/ironic-inspector master: SQLAlchemy 2.0 Support  https://review.opendev.org/c/openstack/ironic-inspector/+/86073117:06
JayFI'm going to be testing all ironic projects against tox 4.0 today17:07
JayFis anyone going to be around 12/22 when they un-pin tox 4.0 in case our gate explodes?17:08
TheJuliaif worst comes to worst, I can be pinged17:12
TheJuliaI'll be replacing a few appliances, redoing some baseboard17:12
JayFI'm planning similar; where like I'll probably be off but not away17:14
TheJuliayeah17:14
TheJuliasigh, still not there with cover17:14
TheJuliait is odd, version wise between CI and locally I get different counts17:16
TheJuliaand some different line numbers :( le sigh17:16
JayFmake sure you're rebased on master?17:21
JayFit's going to do that before it runs tests in ci17:21
opendevreviewJulia Kreger proposed openstack/ironic-inspector master: SQLAlchemy 2.0 Support  https://review.opendev.org/c/openstack/ironic-inspector/+/86073117:29
TheJuliayeah, rebased to upload17:29
opendevreviewJay Faulkner proposed openstack/ironic master: Fixes for tox 4.0  https://review.opendev.org/c/openstack/ironic/+/86783017:31
JayFCan we land that ^^^ asap? We apparently have to fix stable branches too17:32
JayFit's a formatting fix in the tox.ini, probably OK to land as a single core17:32
TheJuliaso they are no longer going to keep the stable branches pinned?17:32
TheJuliaseriously we have to now line separate?17:33
TheJuliagah17:33
JayFWe're talking about it in -tc17:34
JayFbasically, even if it's pinned for stable we should backport it17:34
JayFunless you want to keep tox <4 installed to run tests locally when pushing a stable change17:34
TheJuliayeah, it is unpinned otherwise, which makes sense17:35
TheJuliablarg17:35
TheJuliathat is a log of backporting17:35
JayFthis is tox's fault17:35
TheJuliaand a TON of gate overhead17:35
JayFbreaking changes are one thing17:35
JayFstupid breaking changes are another17:35
TheJuliaworkflowed that change as a single core approval, since it is non-code17:36
JayFack17:36
JayFgoing to test inspector and the rest too17:36
TheJuliak17:36
JayFinspector (master) is happy \o/17:36
TheJuliaokay, looks like cover test fixes work17:37
TheJulia\o/17:37
JayFwallaby is not OK17:37
JayFso I'll walk inspector and fix the first broken stable and we can backport from there17:37
JayFTheJulia: \o/17:37
JayFit's only broken in inspector zed and earlier :| 17:38
JayFwow inspector zed local tests are hella broken17:39
JayFjsonschema kaboom all over the place17:39
opendevreviewJay Faulkner proposed openstack/ironic-inspector stable/zed: [stable-only] Fixes for tox 4.0 compatability  https://review.opendev.org/c/openstack/ironic-inspector/+/86783317:40
JayFseeing if it happens in gate too17:40
opendevreviewJay Faulkner proposed openstack/metalsmith master: Fixes for tox 4.0  https://review.opendev.org/c/openstack/metalsmith/+/86783417:43
stuartgr_Hi. I'm trying to deploy Ubuntu 20.04 image with UEFI to a baremetal node using software RAID. The image has an ESP partition of exactly 550MiB but when IPA creates /dev/md0 to hold a copy of the ESP, it gets a capacity of (550MiB minus 64KiB). As a result, the command "cp /dev/md127p1 /dev/md0" fails with 'No space left on device' and the deployment fails. Any ideas how to fix this?17:44
TheJuliaJayF: joy :(17:48
TheJuliastuartgr_: ugh, so... the default partition size was determiend as a reasonable maximum, considering all that *needs* to be in the ESP is grub, it sounds like it is just oversized and that would require a code change to handle17:49
JayFironic-lib is good \o/17:50
JayFipe looks good \o/17:51
stuartgr_My Ubuntu image came out of diskimage-builder so I'd expect a standard sized ESP17:54
opendevreviewJay Faulkner proposed openstack/ironic-python-agent master: Fixes for tox 4.0  https://review.opendev.org/c/openstack/ironic-python-agent/+/86783517:56
opendevreviewJay Faulkner proposed openstack/ironic stable/zed: Fixes for tox 4.0  https://review.opendev.org/c/openstack/ironic/+/86764417:56
JayFhttps://review.opendev.org/c/openstack/ironic-inspector/+/867833 and https://review.opendev.org/c/openstack/metalsmith/+/867834 have passed tests now if we want to land 'em I can start backporting them :D17:58
opendevreviewMerged openstack/ironic master: Fixes for tox 4.0  https://review.opendev.org/c/openstack/ironic/+/86783018:02
opendevreviewJay Faulkner proposed openstack/bifrost master: Fixes for tox 4.0  https://review.opendev.org/c/openstack/bifrost/+/86783818:03
jrosserstuartgr_: did you find where the 550MiB in dib comes from, it doesnt appear as directly defined there as it is in ironic https://github.com/openstack/diskimage-builder/blob/master/diskimage_builder/lib/disk-image-create#L470-L48018:06
opendevreviewJay Faulkner proposed openstack/networking-baremetal master: Fixes for tox 4.0  https://review.opendev.org/c/openstack/networking-baremetal/+/86784018:08
opendevreviewJay Faulkner proposed openstack/networking-generic-switch master: Fixes for tox 4.0  https://review.opendev.org/c/openstack/networking-generic-switch/+/86784118:11
jrosserstuartgr_: my search skills were insufficient, it is here https://opendev.org/openstack/diskimage-builder/src/branch/master/diskimage_builder/elements/block-device-efi/block-device-default.yaml#L1018:13
JayFpython-ironicclient is good \o/18:13
opendevreviewJay Faulkner proposed openstack/python-ironic-inspector-client master: Fixes for tox 4.0  https://review.opendev.org/c/openstack/python-ironic-inspector-client/+/86784218:14
JayFsushy is good \o/18:15
JayFsushy-tools is good18:16
JayFtenks is okay18:17
opendevreviewJay Faulkner proposed openstack/virtualbmc master: Fixes for tox 4.0  https://review.opendev.org/c/openstack/virtualbmc/+/86784318:18
opendevreviewJay Faulkner proposed openstack/ironic-python-agent master: Fixes for tox 4.0  https://review.opendev.org/c/openstack/ironic-python-agent/+/86783518:20
opendevreviewJay Faulkner proposed openstack/metalsmith stable/zed: Fixes for tox 4.0  https://review.opendev.org/c/openstack/metalsmith/+/86764518:21
opendevreviewJay Faulkner proposed openstack/metalsmith stable/yoga: Fixes for tox 4.0  https://review.opendev.org/c/openstack/metalsmith/+/86764618:21
opendevreviewJay Faulkner proposed openstack/metalsmith stable/xena: Fixes for tox 4.0  https://review.opendev.org/c/openstack/metalsmith/+/86764718:22
opendevreviewJay Faulkner proposed openstack/metalsmith stable/wallaby: Fixes for tox 4.0  https://review.opendev.org/c/openstack/metalsmith/+/86764818:22
opendevreviewJay Faulkner proposed openstack/metalsmith stable/victoria: Fixes for tox 4.0  https://review.opendev.org/c/openstack/metalsmith/+/86764918:23
opendevreviewJay Faulkner proposed openstack/metalsmith stable/ussuri: Fixes for tox 4.0  https://review.opendev.org/c/openstack/metalsmith/+/86785018:24
opendevreviewJay Faulkner proposed openstack/metalsmith stable/train: Fixes for tox 4.0  https://review.opendev.org/c/openstack/metalsmith/+/86785118:24
TheJuliajrosser: I'm wondering if it is a stock image they are trying to deploy18:24
opendevreviewJay Faulkner proposed openstack/metalsmith stable/stein: Fixes for tox 4.0  https://review.opendev.org/c/openstack/metalsmith/+/86785218:24
TheJuliathank you JayF 18:24
JayFI am no longer human18:25
JayFI am a gerrit button mashing robot18:25
JayFbeep boop18:25
opendevreviewJay Faulkner proposed openstack/ironic-inspector bugfix/11.0: [stable-only] Fixes for tox 4.0 compatability  https://review.opendev.org/c/openstack/ironic-inspector/+/86785318:26
opendevreviewJay Faulkner proposed openstack/ironic-inspector bugfix/10.12: [stable-only] Fixes for tox 4.0 compatability  https://review.opendev.org/c/openstack/ironic-inspector/+/86785418:26
opendevreviewJay Faulkner proposed openstack/ironic-inspector stable/yoga: [stable-only] Fixes for tox 4.0 compatability  https://review.opendev.org/c/openstack/ironic-inspector/+/86785518:26
opendevreviewJay Faulkner proposed openstack/ironic-inspector bugfix/10.9: [stable-only] Fixes for tox 4.0 compatability  https://review.opendev.org/c/openstack/ironic-inspector/+/86785618:27
opendevreviewJay Faulkner proposed openstack/ironic-inspector stable/xena: [stable-only] Fixes for tox 4.0 compatability  https://review.opendev.org/c/openstack/ironic-inspector/+/86785718:28
opendevreviewJay Faulkner proposed openstack/ironic-inspector bugfix/10.7: [stable-only] Fixes for tox 4.0 compatability  https://review.opendev.org/c/openstack/ironic-inspector/+/86785818:28
opendevreviewJay Faulkner proposed openstack/ironic-inspector stable/wallaby: [stable-only] Fixes for tox 4.0 compatability  https://review.opendev.org/c/openstack/ironic-inspector/+/86785918:30
opendevreviewJay Faulkner proposed openstack/ironic-inspector stable/victoria: [stable-only] Fixes for tox 4.0 compatability  https://review.opendev.org/c/openstack/ironic-inspector/+/86786018:31
opendevreviewJay Faulkner proposed openstack/ironic-inspector stable/ussuri: [stable-only] Fixes for tox 4.0 compatability  https://review.opendev.org/c/openstack/ironic-inspector/+/86786118:31
opendevreviewJay Faulkner proposed openstack/ironic-inspector stable/train: [stable-only] Fixes for tox 4.0 compatability  https://review.opendev.org/c/openstack/ironic-inspector/+/86786218:31
opendevreviewJay Faulkner proposed openstack/ironic bugfix/21.0: Fixes for tox 4.0  https://review.opendev.org/c/openstack/ironic/+/86786318:35
JayFTheJulia: fwiw I am tagging all these as prio so if you feel like landing some, that should make it easy18:35
opendevreviewJay Faulkner proposed openstack/ironic bugfix/20.2: Fixes for tox 4.0  https://review.opendev.org/c/openstack/ironic/+/86786418:35
opendevreviewJay Faulkner proposed openstack/ironic stable/yoga: Fixes for tox 4.0  https://review.opendev.org/c/openstack/ironic/+/86786518:36
opendevreviewJay Faulkner proposed openstack/ironic bugfix/19.0: Fixes for tox 4.0  https://review.opendev.org/c/openstack/ironic/+/86786618:36
opendevreviewJay Faulkner proposed openstack/ironic stable/xena: Fixes for tox 4.0  https://review.opendev.org/c/openstack/ironic/+/86786718:36
opendevreviewJay Faulkner proposed openstack/ironic bugfix/18.1: Fixes for tox 4.0  https://review.opendev.org/c/openstack/ironic/+/86786818:37
opendevreviewJay Faulkner proposed openstack/ironic stable/wallaby: Fixes for tox 4.0  https://review.opendev.org/c/openstack/ironic/+/86786918:38
opendevreviewJay Faulkner proposed openstack/ironic stable/victoria: Fixes for tox 4.0  https://review.opendev.org/c/openstack/ironic/+/86787018:38
opendevreviewJay Faulkner proposed openstack/ironic stable/victoria: Fixes for tox 4.0  https://review.opendev.org/c/openstack/ironic/+/86787018:39
opendevreviewJay Faulkner proposed openstack/ironic stable/ussuri: Fixes for tox 4.0  https://review.opendev.org/c/openstack/ironic/+/86787118:39
opendevreviewJay Faulkner proposed openstack/ironic stable/train: Fixes for tox 4.0  https://review.opendev.org/c/openstack/ironic/+/86787218:40
jrosserTheJulia: stuartgr_ is working with me on this18:43
jrosserits an image built with dib18:44
JayFTheJulia: python-ironic-inspector-client is dying in CI functional tests with "Database is locked" errors from sqlite :| 18:47
JayFsee https://review.opendev.org/c/openstack/python-ironic-inspector-client/+/867842 :| 18:48
opendevreviewJay Faulkner proposed openstack/networking-generic-switch stable/zed: Fixes for tox 4.0  https://review.opendev.org/c/openstack/networking-generic-switch/+/86787318:49
opendevreviewJay Faulkner proposed openstack/networking-generic-switch stable/yoga: Fixes for tox 4.0  https://review.opendev.org/c/openstack/networking-generic-switch/+/86787418:49
opendevreviewJay Faulkner proposed openstack/networking-generic-switch stable/yoga: Fixes for tox 4.0  https://review.opendev.org/c/openstack/networking-generic-switch/+/86787418:49
opendevreviewJay Faulkner proposed openstack/networking-generic-switch stable/yoga: Fixes for tox 4.0  https://review.opendev.org/c/openstack/networking-generic-switch/+/86787418:50
opendevreviewJay Faulkner proposed openstack/networking-generic-switch stable/xena: Fixes for tox 4.0  https://review.opendev.org/c/openstack/networking-generic-switch/+/86787518:50
opendevreviewJay Faulkner proposed openstack/networking-generic-switch stable/wallaby: Fixes for tox 4.0  https://review.opendev.org/c/openstack/networking-generic-switch/+/86787618:51
opendevreviewJay Faulkner proposed openstack/networking-generic-switch stable/victoria: Fixes for tox 4.0  https://review.opendev.org/c/openstack/networking-generic-switch/+/86787718:51
opendevreviewJay Faulkner proposed openstack/networking-generic-switch stable/ussuri: Fixes for tox 4.0  https://review.opendev.org/c/openstack/networking-generic-switch/+/86787818:52
opendevreviewJay Faulkner proposed openstack/networking-generic-switch stable/train: Fixes for tox 4.0  https://review.opendev.org/c/openstack/networking-generic-switch/+/86787918:52
JayFjrosser: feel free to re-ping on that ansible change if it gets lost in the [gestures generally at gerrit and tox 4.0]18:55
jrossersure18:56
jrosseri did totally fail to be able to use the ansible collection to configure anything to do with my ironic nodes though18:56
jrossertoken scope arrrrgh somehow makes them all not work for me where the rest of the modules seem ok18:57
iurygregoryJayF, can a go with single core approval in the tox patches or we should wait?18:59
JayFiurygregory: land them with impunity 18:59
JayFiurygregory: if tests pass; it's fine18:59
iurygregoryJayF, ack o/18:59
JayFbecause I tested with tox 4.0 locally and tox 3.x is in the gate18:59
JayFwell, tested == `tox --showconfig` doesn't complain :) 18:59
iurygregoryok o/19:01
opendevreviewMerged openstack/metalsmith stable/zed: Fixes for tox 4.0  https://review.opendev.org/c/openstack/metalsmith/+/86764519:07
opendevreviewMerged openstack/metalsmith master: Fixes for tox 4.0  https://review.opendev.org/c/openstack/metalsmith/+/86783419:09
JayFFYI as part of  this; I realized we missed stable/stein metalsmith when EOL'ing old branches up thru stein19:09
JayFso I've pushed that change to releases repo19:09
JayF\19:11
opendevreviewMerged openstack/metalsmith stable/yoga: Fixes for tox 4.0  https://review.opendev.org/c/openstack/metalsmith/+/86764619:12
opendevreviewMerged openstack/metalsmith stable/xena: Fixes for tox 4.0  https://review.opendev.org/c/openstack/metalsmith/+/86764719:12
opendevreviewMerged openstack/metalsmith stable/ussuri: Fixes for tox 4.0  https://review.opendev.org/c/openstack/metalsmith/+/86785019:12
opendevreviewMerged openstack/metalsmith stable/wallaby: Fixes for tox 4.0  https://review.opendev.org/c/openstack/metalsmith/+/86764819:12
opendevreviewMerged openstack/metalsmith stable/victoria: Fixes for tox 4.0  https://review.opendev.org/c/openstack/metalsmith/+/86764919:13
opendevreviewMerged openstack/metalsmith stable/train: Fixes for tox 4.0  https://review.opendev.org/c/openstack/metalsmith/+/86785119:14
opendevreviewMerged openstack/ironic stable/zed: Fixes for tox 4.0  https://review.opendev.org/c/openstack/ironic/+/86764419:19
opendevreviewMerged openstack/ironic bugfix/20.2: Fixes for tox 4.0  https://review.opendev.org/c/openstack/ironic/+/86786419:22
opendevreviewMerged openstack/ironic stable/xena: Fixes for tox 4.0  https://review.opendev.org/c/openstack/ironic/+/86786719:22
opendevreviewMerged openstack/ironic stable/victoria: Fixes for tox 4.0  https://review.opendev.org/c/openstack/ironic/+/86787019:23
opendevreviewMerged openstack/networking-generic-switch master: Fixes for tox 4.0  https://review.opendev.org/c/openstack/networking-generic-switch/+/86784119:26
opendevreviewMerged openstack/networking-generic-switch stable/zed: Fixes for tox 4.0  https://review.opendev.org/c/openstack/networking-generic-switch/+/86787319:27
opendevreviewMerged openstack/ironic stable/yoga: Fixes for tox 4.0  https://review.opendev.org/c/openstack/ironic/+/86786519:28
opendevreviewMerged openstack/ironic stable/wallaby: Fixes for tox 4.0  https://review.opendev.org/c/openstack/ironic/+/86786919:28
opendevreviewMerged openstack/ironic stable/train: Fixes for tox 4.0  https://review.opendev.org/c/openstack/ironic/+/86787219:28
stuartgr_jrosser: Thanks for finding the definition of ESP size in elements/block-device-efi/block-device-default.yaml. I reduced that to 525MiB and the image now successfully fits onto /dev/md0 :)19:29
jrosserstuartgr_: were you able to do that via a dib parameter or did you have to do in and edit it?19:30
jrosser*go in19:30
TheJulia\o/19:30
stuartgr_GRUB failed to find the correct partition after a reboot, but at least it's getting further than before19:30
jrosseri wonder if this is because the 550M value in the ironi side doesnt account for some potential md superblock (?)19:31
JayFjrosser: ++ that sounds really, really close to the right answer19:31
jrosserand it exactly matches the value in dib so theres no room for anything else at all19:31
JayFcan one of you please put these details into a storyboard bug?19:31
JayFso they aren't lost?19:31
stuartgr_I adjusted the value in the file, it wasn't clear how to change that from the commandline or env vars19:31
opendevreviewMerged openstack/ironic stable/ussuri: Fixes for tox 4.0  https://review.opendev.org/c/openstack/ironic/+/86787119:32
opendevreviewMerged openstack/ironic-inspector stable/zed: [stable-only] Fixes for tox 4.0 compatability  https://review.opendev.org/c/openstack/ironic-inspector/+/86783319:32
opendevreviewMerged openstack/ironic-inspector bugfix/10.9: [stable-only] Fixes for tox 4.0 compatability  https://review.opendev.org/c/openstack/ironic-inspector/+/86785619:32
opendevreviewMerged openstack/ironic-inspector bugfix/11.0: [stable-only] Fixes for tox 4.0 compatability  https://review.opendev.org/c/openstack/ironic-inspector/+/86785319:32
opendevreviewMerged openstack/ironic-inspector stable/yoga: [stable-only] Fixes for tox 4.0 compatability  https://review.opendev.org/c/openstack/ironic-inspector/+/86785519:32
opendevreviewMerged openstack/ironic-inspector stable/xena: [stable-only] Fixes for tox 4.0 compatability  https://review.opendev.org/c/openstack/ironic-inspector/+/86785719:32
stuartgr_I'll create a bug about this tomorrow - going home now19:34
opendevreviewMerged openstack/ironic-inspector stable/ussuri: [stable-only] Fixes for tox 4.0 compatability  https://review.opendev.org/c/openstack/ironic-inspector/+/86786119:34
opendevreviewMerged openstack/ironic-inspector stable/victoria: [stable-only] Fixes for tox 4.0 compatability  https://review.opendev.org/c/openstack/ironic-inspector/+/86786019:34
opendevreviewMerged openstack/ironic-inspector stable/wallaby: [stable-only] Fixes for tox 4.0 compatability  https://review.opendev.org/c/openstack/ironic-inspector/+/86785919:34
opendevreviewMerged openstack/ironic-inspector stable/train: [stable-only] Fixes for tox 4.0 compatability  https://review.opendev.org/c/openstack/ironic-inspector/+/86786219:34
opendevreviewJay Faulkner proposed openstack/ironic-python-agent stable/zed: Fixes for tox 4.0  https://review.opendev.org/c/openstack/ironic-python-agent/+/86788119:38
opendevreviewJay Faulkner proposed openstack/ironic-python-agent bugfix/9.0: Fixes for tox 4.0  https://review.opendev.org/c/openstack/ironic-python-agent/+/86788219:38
opendevreviewJay Faulkner proposed openstack/ironic-python-agent bugfix/8.6: Fixes for tox 4.0  https://review.opendev.org/c/openstack/ironic-python-agent/+/86788319:38
opendevreviewJay Faulkner proposed openstack/ironic-python-agent stable/yoga: Fixes for tox 4.0  https://review.opendev.org/c/openstack/ironic-python-agent/+/86788419:39
opendevreviewJay Faulkner proposed openstack/ironic-python-agent bugfix/8.3: Fixes for tox 4.0  https://review.opendev.org/c/openstack/ironic-python-agent/+/86788519:39
opendevreviewJay Faulkner proposed openstack/ironic-python-agent stable/xena: Fixes for tox 4.0  https://review.opendev.org/c/openstack/ironic-python-agent/+/86788619:39
opendevreviewJay Faulkner proposed openstack/ironic-python-agent bugfix/8.1: Fixes for tox 4.0  https://review.opendev.org/c/openstack/ironic-python-agent/+/86788719:40
jrosserstuartgr_: could you add anything you think i've missed to https://storyboard.openstack.org/#!/story/201047319:40
opendevreviewJay Faulkner proposed openstack/ironic-python-agent bugfix/8.1: Fixes for tox 4.0  https://review.opendev.org/c/openstack/ironic-python-agent/+/86788719:40
opendevreviewJay Faulkner proposed openstack/ironic-python-agent stable/wallaby: Fixes for tox 4.0  https://review.opendev.org/c/openstack/ironic-python-agent/+/86788819:41
opendevreviewJay Faulkner proposed openstack/ironic-python-agent stable/wallaby: Fixes for tox 4.0  https://review.opendev.org/c/openstack/ironic-python-agent/+/86788819:41
opendevreviewJay Faulkner proposed openstack/ironic-python-agent stable/victoria: Fixes for tox 4.0  https://review.opendev.org/c/openstack/ironic-python-agent/+/86788919:41
opendevreviewJay Faulkner proposed openstack/ironic-python-agent stable/victoria: Fixes for tox 4.0  https://review.opendev.org/c/openstack/ironic-python-agent/+/86788919:42
opendevreviewJay Faulkner proposed openstack/ironic-python-agent stable/ussuri: Fixes for tox 4.0  https://review.opendev.org/c/openstack/ironic-python-agent/+/86791019:43
opendevreviewJay Faulkner proposed openstack/ironic-python-agent stable/train: Fixes for tox 4.0  https://review.opendev.org/c/openstack/ironic-python-agent/+/86791119:43
opendevreviewJay Faulkner proposed openstack/ironic-python-agent stable/train: Fixes for tox 4.0  https://review.opendev.org/c/openstack/ironic-python-agent/+/86791119:44
JayFiurygregory: TheJulia: be a little more review-y when looking at the IPA fixes; there were conflicts at almost every step of the backport19:45
TheJuliaack, joy19:45
JayFI think they're all fine?19:45
JayFWorst case will be I missed a random usedevelop= and the behavior will be funky in tox 4.0 (but not broken, just like, that will be ignored as a command)19:45
JayFI think every one I posted has been backported thru; except the virtualbmc and inspector client changes which are failing CI19:47
JayFvirtualbmc looks like a breakage from the ubuntu version change, probably just needs a fix->bindep.txt or something19:47
JayFinspector client is much, much more ominous given recent changes we landed (deadlocks in sqlite db in integration tests)19:47
JayFafter my noon meeting and a short break I'll ensure there are no others to backport then probably get in on trying to get virtualbmc gate happy19:48
iurygregoryJayF, ack19:53
JayFwell, ipa ussuri just failed so I'll have to followup on that19:54
JayFI think I may be setting a personal record for most patches posted+landed in one day19:54
JayFlol19:54
iurygregorylol19:54
JayFtox changes not needing to go thru devstack-based jobs is very helpful19:54
opendevreviewMerged openstack/ironic-python-agent master: Fixes for tox 4.0  https://review.opendev.org/c/openstack/ironic-python-agent/+/86783519:56
opendevreviewMerged openstack/ironic-python-agent stable/yoga: Fixes for tox 4.0  https://review.opendev.org/c/openstack/ironic-python-agent/+/86788419:56
opendevreviewMerged openstack/ironic-python-agent bugfix/9.0: Fixes for tox 4.0  https://review.opendev.org/c/openstack/ironic-python-agent/+/86788219:58
opendevreviewMerged openstack/ironic-python-agent stable/zed: Fixes for tox 4.0  https://review.opendev.org/c/openstack/ironic-python-agent/+/86788119:58
opendevreviewMerged openstack/ironic-python-agent stable/xena: Fixes for tox 4.0  https://review.opendev.org/c/openstack/ironic-python-agent/+/86788619:58
opendevreviewMerged openstack/ironic bugfix/19.0: Fixes for tox 4.0  https://review.opendev.org/c/openstack/ironic/+/86786620:05
opendevreviewMerged openstack/ironic-python-agent stable/wallaby: Fixes for tox 4.0  https://review.opendev.org/c/openstack/ironic-python-agent/+/86788820:06
opendevreviewMerged openstack/ironic bugfix/18.1: Fixes for tox 4.0  https://review.opendev.org/c/openstack/ironic/+/86786820:08
opendevreviewMerged openstack/ironic bugfix/21.0: Fixes for tox 4.0  https://review.opendev.org/c/openstack/ironic/+/86786320:11
opendevreviewMerged openstack/ironic-inspector bugfix/11.2: Update .gitreview for bugfix/11.2  https://review.opendev.org/c/openstack/ironic-inspector/+/86782520:11
*** dking is now known as Guest227021:08
Guest2270Does anybody know the best way to find a list of commits that one has contributed to OpenStack?21:18
JayFGuest2270: Hey, I think you lost your nickname friend :D 21:21
JayFGuest2270: there are a few ways; stackalytics.io used to be the preferred suggestion, but it hasn't been updated in a while21:21
JayFthere's a new foundation-sponsored git stats site (or just use github.com/openstack/ironic or whatever repos you care about and use the github tooling)21:21
JayFBut generally speaking; upstream strongly discourages number of commits or lines of code as a KPI21:22
JayFinstead we prefer patchsets or reviews which can reflect engagement in the project without tying that contribution to a net-new patch21:22
Guest2270yeah, my nick seems to still keep slipping off on this network. I need to get that fixed, but I've been lazy.21:23
JayFlikely you, or someone else, registered it21:24
JayFand you keep getting kicked off it for not identifying21:24
JayFyou can do `/nick dking_` or similar if you want a temp one that won't go away :)21:24
Guest2270Yeah, I tried stackalytics, but as you said, it's out of date. I was just wanting to look at some of the updates for my own benefit. It's been a while since I've been able to push upstream.21:25
JayFYeah; I've been struggling with that with my PTL hat on21:25
*** Guest2270 is now known as dking_tmp21:25
JayFbecause I am supposed to review review stats21:25
JayFbut there's no real working place to get it until/unless I want to write a whole gerrit stats API client on my own :| 21:25
JayFhttps://openstack.biterg.io/app/kibana#/dashboard/Overview is the new, actually-supported stats place21:26
JayFbut it only gets data currently, I think, from git/mailing lists21:26
JayFso it doesn't contain reviews which is why I don't use it frequently21:26
dking_tmpI got spoiled by stackalytics. It never felt official, but it was nice, and I assumed it would always just be there.21:26
JayFIt was good and bad. 21:27
dking_tmpThat's pretty neat. That looks a bit like Kibana?21:27
JayFBack in the heyday of openstack, too many people were relying on metrics from stackalytics to manage employees at some places21:27
JayFwhich led to weird stuff e.g. people "reviewing" using a spell checker just so they could get stats up21:28
dking_tmpCrazy.21:31
dking_tmpI really like that site. I'm a fan of Kibana.21:36
TheJuliasoooo many people using spell checkers21:42
TheJuliamy favorite was different dialect spellings21:42
JayFSo I recently had a blogpost published on my employers' blog (https://www.gresearch.co.uk/news) and it tripped me out the first time I read it21:48
JayFbecause it was editing into british spelling21:48
JayFNobodyCam: I miss your morning hellos in here, fwiw21:51
TheJulia+100000000021:52
NobodyCamHumm I may be able to encouraged to pick that back up ;)22:54
NobodyCamWe’ll give it a shot tomorrow and see how it goes22:54
JayFI'm about to go live on my office hours in ~3 minutes at https://youtube.com/jayofdoom22:58
JayFwill probably be taking inventory of how many of those tox patches are left lol22:58
NobodyCamOh22:58
JayFyou should come by in the mornings and say hi again anyway :) 22:58
JayFit's nice to have more folks chatting in the channel22:58
JayFwe love you even if you don't have time to contribute, lol22:58
NobodyCamLoL22:59
opendevreviewJay Faulkner proposed openstack/virtualbmc master: Fixes for tox 4.0  https://review.opendev.org/c/openstack/virtualbmc/+/86784323:12
JayFTheJulia: IDR if I showed you this; https://zuul.opendev.org/t/openstack/build/5beeaacf1161489e84a489b45f31bc6c23:32
JayFTheJulia: during python-ironic-inspector-client functional tests > sqlalchemy.exc.OperationalError: (sqlite3.OperationalError) database is locked23:32
JayFWhich implies to me our inspector sqla2.0 fixes are not complete23:32
opendevreviewJay Faulkner proposed openstack/ironic-python-agent bugfix/8.6: Drop python2 from bindep.txt  https://review.opendev.org/c/openstack/ironic-python-agent/+/86791523:44
opendevreviewJay Faulkner proposed openstack/ironic-python-agent bugfix/8.6: Fixes for tox 4.0  https://review.opendev.org/c/openstack/ironic-python-agent/+/86788323:44
opendevreviewJay Faulkner proposed openstack/ironic-python-agent bugfix/8.3: Drop python2 from bindep.txt  https://review.opendev.org/c/openstack/ironic-python-agent/+/86791623:45
opendevreviewJay Faulkner proposed openstack/ironic-python-agent bugfix/8.3: Fixes for tox 4.0  https://review.opendev.org/c/openstack/ironic-python-agent/+/86788523:45
* JayF puts https://review.opendev.org/c/openstack/ironic-inspector/+/860731 as a depends-on for that client test23:50
opendevreviewJay Faulkner proposed openstack/python-ironic-inspector-client master: Fixes for tox 4.0  https://review.opendev.org/c/openstack/python-ironic-inspector-client/+/86784223:51
NobodyCamNice office hours JayF23:58
JayFlurking is not allowed, you gotta say hi in yt chat too :P 23:59
JayFseriously, I'll take any feedback if you have it, I've done maybe a dozen of those at this point23:59
NobodyCamLoL that means I would have to sign in23:59

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!