| rpittau | good morning ironic! o/ | 08:36 |
|---|---|---|
| kubajj | Good morning rpittau | 09:40 |
| rpittau | hey kubajj :) | 10:15 |
| opendevreview | Riccardo Pittau proposed openstack/bifrost master: Fix deprecated module ansible lint error https://review.opendev.org/c/openstack/bifrost/+/866040 | 10:22 |
| opendevreview | Riccardo Pittau proposed openstack/bifrost master: Fix jinja ansible lint error https://review.opendev.org/c/openstack/bifrost/+/866137 | 10:55 |
| iurygregory | good morning Ironic o/ | 13:50 |
| kubajj | Good morning iurygregory | 13:50 |
| iurygregory | kubajj, o/ | 13:51 |
| kubajj | Does anybody know why there wasn't a get_object method in ironic/common/swift? Is there a reason for this? I am currently writing a unit test for a method storing data in swift and I don't know if I should check that everything went right. | 13:52 |
| iurygregory | I think we would use openstacksdk directlly or the swiftclient to retrive the data | 13:53 |
| iurygregory | maybe there is another method not "get_object" that would do this for you | 13:53 |
| kubajj | I see, thanks iurygregory. I will look into it | 13:54 |
| iurygregory | I will try to look at the code in a few | 13:54 |
| TheJulia | good morning | 14:00 |
| TheJulia | Yeah, I would just wire in the sdk | 14:01 |
| arne_wiebalck | hey kubajj iurygregory TheJulia rpittau o/ | 14:01 |
| * arne_wiebalck comes in late, gets to greet everyone :-D | 14:01 | |
| TheJulia | good morning arne_wiebalck | 14:01 |
| kubajj | good morning TheJulia and arne_wiebalck o/ | 14:02 |
| iurygregory | arne_wiebalck, TheJulia o/ | 14:02 |
| kubajj | TheJulia: do you think I should let users specify the container for the inventory if they use Swift? | 14:03 |
| opendevreview | Jakub Jelinek proposed openstack/ironic master: WIP: Enable alternative storage for inventory https://review.opendev.org/c/openstack/ironic/+/866056 | 14:12 |
| TheJulia | kubajj: which user? end user? api consumer? administrator via config? | 14:13 |
| kubajj | TheJulia: I still need to add the test that checks that the data stored in swift are matching, but if you had a minute and could give me some early feedback it would be nice | 14:13 |
| kubajj | TheJulia: I think the administrator via config | 14:14 |
| TheJulia | oh, I would expect that :) | 14:14 |
| kubajj | TheJulia: ok, I will change that too | 14:14 |
| JayF | Got Ironic's recent OSSN featured in the corp GR blog, if anyone wants to read. https://www.gresearch.co.uk/blog/article/invisible-work-of-openstack-security-bugs/ | 15:13 |
| opendevreview | Julia Kreger proposed openstack/ironic-inspector master: SQLAlchemy 2.0 prep https://review.opendev.org/c/openstack/ironic-inspector/+/860731 | 15:37 |
| TheJulia | hopefully that is happier for the coverage test | 15:37 |
| opendevreview | Aija Jauntēva proposed openstack/ironic master: Follow-up to Redfish Interop Profile https://review.opendev.org/c/openstack/ironic/+/866190 | 17:08 |
| rpittau | good night! o/ | 17:15 |
| TheJulia | Hey folks, I have to fly to Atlanta tomorrow for a family thing. If you need me, feel free to reach out, but I wont have my work laptop | 18:58 |
| TheJulia | I'll be back Monday | 18:58 |
| JayF | o/ have a nice trip | 19:00 |
| TheJulia | I'll try :( | 19:26 |
| JayF | Hmm. For new fields on a node object, do I need to ensure it's only exposed on newer API microversions? yes, right? | 21:53 |
| JayF | looks like no | 22:01 |
| JayF | Anyone with familiarity with our node API tests? | 22:28 |
| JayF | I think I'm getting sqlite deadlocks on disk trying to make nodes | 22:28 |
| TheJulia | JayF: if you do it correctly, it should be hidden by the code, but you’ll need to have a test | 22:35 |
| JayF | It is 100% not hidden by the code | 22:35 |
| JayF | and I don't see many examples of us explicitly hiding new fields on node behind microversions | 22:35 |
| JayF | when looking in versions.py | 22:35 |
| JayF | so I'm clearly doing something wrong | 22:38 |
| TheJulia | Uhhh hmmm | 22:40 |
| TheJulia | I think the filtering is just before we transmit… but you have to list the field with the version it was added in… I think api tips | 22:41 |
| JayF | Yeah, I think you're right-ish that it's being blocked | 22:42 |
| JayF | and node.lessee is behind a microversion | 22:43 |
| JayF | I'm clearly missing something | 22:43 |
| TheJulia | Unfortunately in a car hunting down formal outfit | 22:47 |
| JayF | yeah I found some breadcrumbs | 22:47 |
| JayF | just been a long, long time since I wrote API code of any kind | 22:47 |
| JayF | heh; I def fixed that because I forgot to bump my microversion in the test after fixing it and all hell broke loose lol | 22:59 |
| * JayF massively underestimated how unfamiliar he was with this API code | 22:59 | |
| opendevreview | Jay Faulkner proposed openstack/ironic master: WIP: API support for shards https://review.opendev.org/c/openstack/ironic/+/866235 | 23:28 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!