| opendevreview | Merged openstack/sushy stable/zed: Increase server side retries https://review.opendev.org/c/openstack/sushy/+/864037 | 00:06 |
|---|---|---|
| opendevreview | Merged openstack/sushy master: Make server connection retries configurable https://review.opendev.org/c/openstack/sushy/+/864102 | 00:06 |
| opendevreview | Merged openstack/ironic stable/yoga: Add SNMPv3 authentication functionality https://review.opendev.org/c/openstack/ironic/+/850553 | 00:36 |
| opendevreview | Merged openstack/ironic bugfix/20.2: Add support auth protocols for iRMC https://review.opendev.org/c/openstack/ironic/+/863573 | 00:49 |
| vanou | good morning ironic | 02:11 |
| vanou | And thanks JayF for backport review | 02:12 |
| opendevreview | SONG SHUKUN proposed openstack/ironic bugfix/19.0: Add SNMPv3 authentication functionality https://review.opendev.org/c/openstack/ironic/+/864465 | 03:06 |
| opendevreview | SONG SHUKUN proposed openstack/ironic stable/xena: Add SNMPv3 authentication functionality https://review.opendev.org/c/openstack/ironic/+/850554 | 03:07 |
| opendevreview | SONG SHUKUN proposed openstack/ironic bugfix/18.1: Add SNMPv3 authentication functionality https://review.opendev.org/c/openstack/ironic/+/864466 | 03:07 |
| opendevreview | SONG SHUKUN proposed openstack/ironic stable/wallaby: Add SNMPv3 authentication functionality https://review.opendev.org/c/openstack/ironic/+/850707 | 03:08 |
| opendevreview | SONG SHUKUN proposed openstack/ironic stable/yoga: Add support auth protocols for iRMC https://review.opendev.org/c/openstack/ironic/+/864467 | 03:16 |
| arne_wiebalck | Good morning vanou and Ironic! | 07:31 |
| rpittau | good morning ironic! o/ | 08:15 |
| arne_wiebalck | hey rpittau o/ | 08:16 |
| rpittau | hey arne_wiebalck :) | 08:18 |
| janders | hey vanou arne_wiebalck rpittau and Ironic o/ | 08:29 |
| rpittau | hey janders :) | 08:29 |
| vanou | Hi arne_wiebalck janders and rpittau o/ | 08:35 |
| rpittau | hey vanou :) | 08:35 |
| opendevreview | SONG SHUKUN proposed openstack/ironic bugfix/19.0: Add SNMPv3 authentication functionality https://review.opendev.org/c/openstack/ironic/+/864465 | 09:13 |
| opendevreview | SONG SHUKUN proposed openstack/ironic bugfix/18.1: Add SNMPv3 authentication functionality https://review.opendev.org/c/openstack/ironic/+/864466 | 09:15 |
| opendevreview | SONG SHUKUN proposed openstack/ironic stable/xena: Add SNMPv3 authentication functionality https://review.opendev.org/c/openstack/ironic/+/850554 | 09:18 |
| opendevreview | SONG SHUKUN proposed openstack/ironic stable/wallaby: Add SNMPv3 authentication functionality https://review.opendev.org/c/openstack/ironic/+/850707 | 09:19 |
| *** akahat|ruck is now known as akahat|ruck|afk | 09:53 | |
| opendevreview | Dmitry Tantsur proposed openstack/ironic master: [WIP] [PoC] A metal3 CI job https://review.opendev.org/c/openstack/ironic/+/863873 | 10:36 |
| *** akahat|ruck|afk is now known as akahat|ruck | 11:32 | |
| opendevreview | Merged openstack/sushy stable/yoga: Increase server side retries https://review.opendev.org/c/openstack/sushy/+/864038 | 11:33 |
| opendevreview | Merged openstack/sushy stable/xena: Increase server side retries https://review.opendev.org/c/openstack/sushy/+/864040 | 11:33 |
| opendevreview | Merged openstack/sushy stable/wallaby: Increase server side retries https://review.opendev.org/c/openstack/sushy/+/864039 | 11:47 |
| opendevreview | Dmitry Tantsur proposed openstack/ironic master: [WIP] [PoC] A metal3 CI job https://review.opendev.org/c/openstack/ironic/+/863873 | 12:51 |
| opendevreview | Arne Wiebalck proposed openstack/ironic master: [doc] Add documentation on SMART test after disk burn-in https://review.opendev.org/c/openstack/ironic/+/864550 | 13:58 |
| *** akahat|ruck is now known as akahat|ruck|dinner | 15:31 | |
| opendevreview | Dmitry Tantsur proposed openstack/ironic master: [WIP] [PoC] A metal3 CI job https://review.opendev.org/c/openstack/ironic/+/863873 | 15:53 |
| JayF | Heads up, I'm going to be doing my office hours in ~12 minutes at youtube.com/jayofdoom -- going to be working on shard_key stuff more, unless someone stops by with questions :) | 16:48 |
| opendevreview | Jakub Jelinek proposed openstack/ironic master: Implements node inventory: database https://review.opendev.org/c/openstack/ironic/+/862569 | 17:00 |
| opendevreview | Jakub Jelinek proposed openstack/ironic master: WIP: Get inventory from Inspector https://review.opendev.org/c/openstack/ironic/+/864057 | 17:00 |
| rpittau | good night! o/ | 17:06 |
| JayF | TheJulia: you around, perhaps? | 17:55 |
| JayF | TheJulia: I'm implementing shard key DB/object layer stuff | 17:55 |
| JayF | and I'm at a crossroads and could use some directioneering | 17:55 |
| TheJulia | JayF: I am mostly around, acan it wait like 10 minutes so I can finish a cfp? | 17:56 |
| JayF | TheJulia: yeah, ima step away for 10ish now myself | 17:59 |
| JayF | TheJulia: you can watch the last 5-10 minutes of my office hours if you want a sneak preview: basically I'm 75% thru the object layer/db code for shards | 17:59 |
| JayF | and unsure about how to approach/do something and there's no other examples | 18:00 |
| TheJulia | uhh, okay | 18:05 |
| JayF | I suspect this is trivialish and just my unfamiliarity with the object layer is making it seem harder than it is | 18:06 |
| kubajj | TheJulia: could you please have a look at https://review.opendev.org/c/openstack/ironic/+/864057/ I just want to make sure that this makes sense before I start writing tests for it. | 18:08 |
| *** akahat|ruck|dinner is now known as akahat|ruck | 18:31 | |
| TheJulia | kubajj: ack, I should be reviewing code later today | 18:33 |
| kubajj | TheJulia: should I add you as a reviewer? | 18:34 |
| stevebaker[m] | good morning | 19:18 |
| JayF | o/ | 19:24 |
| TheJulia | kubajj: please | 19:30 |
| TheJulia | kubajj: makes it a little easier for me | 19:30 |
| TheJulia | good morning stevebaker[m] | 19:30 |
| *** rcastillo|rover is now known as rcastillo | 21:55 | |
| JayF | I'm having some trouble getting my new shard_key test to pass | 22:10 |
| JayF | it keeps complaining about sort_key being invalid | 22:11 |
| JayF | I'm going to push up what I have now, it's close, I just can't get my test to pass (which implies maybe I'm not close? lol) | 22:12 |
| opendevreview | Jay Faulkner proposed openstack/ironic master: WIP: DB implementation of shards / shard_key https://review.opendev.org/c/openstack/ironic/+/864236 | 22:13 |
| JayF | https://gist.github.com/jayofdoom/9171223f236759c2d0a9cf589f70d6e6 | 22:13 |
| JayF | I put a comment about that failure on the review if someone wants to try and help async | 22:14 |
| JayF | kubajj: ^ you might have unique insight into that | 22:15 |
| * TheJulia wonders if there can even really be a sort key on a shard table | 22:29 | |
| JayF | I'm thinking it's probably a bad idea to not-paginate, because the second I do that we get a bug about performance with 10k shards /s | 22:30 |
| JayF | and if we paginate, we need to sort | 22:30 |
| JayF | and if we sort, shard_key or count is the most sensible thing to sort on | 22:30 |
| JayF | but even if I pull the sorting logic out, I'm curious WTAF is going on there | 22:30 |
| TheJulia | hmm kind of yeah | 22:30 |
| JayF | let me put it this way: there's no harm in sort/pagination support | 22:31 |
| JayF | other than me not knowing wtf is going on | 22:31 |
| JayF | and I need to know that in either event lol | 22:31 |
| JayF | TheJulia: apparently _paginate_query assumes you have a field called 'id' | 22:41 |
| * TheJulia orders some lumber to make a table to flip | 22:41 | |
| JayF | TheJulia: YAGNI pagination/sorting? | 22:42 |
| JayF | I'm not sure if that's the right decision or the fact I'm running outta time and wanted this done today lol | 22:42 |
| TheJulia | maybe just add an id, and put a note in to say that the ID is unstable and you shouldn't query on it | 22:43 |
| TheJulia | but to have pagination, it is needed | 22:43 |
| TheJulia | because you need the object.id to serve as the marker position | 22:43 |
| TheJulia | and the pagination coul duse the name | 22:43 |
| TheJulia | so maybe we don't need it in practicality?! | 22:44 |
| JayF | as long as the sort is stable; you should be able to use any primary key | 22:44 |
| JayF | but changing that /in practice/ will be a bigger pain than that | 22:44 |
| JayF | because I'd have to be very careful to preserve existing behavior | 22:45 |
| TheJulia | well, the db pagination code likely expects it as you've learned | 22:45 |
| TheJulia | but if we're just going to do a single transaction truncate/repopulate, we don't need to do row level updates | 22:45 |
| TheJulia | downside is row id values wouldn't be stable in general | 22:45 |
| TheJulia | unless you do some sort of matci to do the reconcile and yeah | 22:46 |
| TheJulia | and all for pagination as a hidden detail?! | 22:46 |
| TheJulia | :\ | 22:46 |
| JayF | YAGNI | 22:47 |
| JayF | You Ain't Gonna Need It | 22:47 |
| * JayF kicks it outta his patch | 22:47 | |
| TheJulia | heh | 22:48 |
| JayF | actually, I will kick it out after walking the dog | 22:48 |
| JayF | I've been in this chair too long | 22:48 |
| JayF | o/ | 22:48 |
| TheJulia | o/ | 22:48 |
| TheJulia | JayF: I think we should go ahead and merge https://review.opendev.org/c/openstack/ironic-specs/+/841061/ just under the "better late than never" approach. It did represent what was focused on.... | 23:21 |
| JayF | sure | 23:22 |
| JayF | **please** people go review https://review.opendev.org/c/openstack/ironic-specs/+/862538 | 23:22 |
| JayF | I'm going to land that patch this week if it still has 2x+2 and no negative feedback | 23:22 |
| opendevreview | Merged openstack/ironic-specs master: Zed Themes https://review.opendev.org/c/openstack/ironic-specs/+/841061 | 23:31 |
| opendevreview | Julia Kreger proposed openstack/ironic-specs master: Add a shard key https://review.opendev.org/c/openstack/ironic-specs/+/861803 | 23:35 |
| opendevreview | Julia Kreger proposed openstack/ironic-specs master: Add a shard key https://review.opendev.org/c/openstack/ironic-specs/+/861803 | 23:39 |
| TheJulia | JayF: web-edited it | 23:39 |
| opendevreview | Jay Faulkner proposed openstack/ironic master: WIP: DB implementation of shards / shard_key https://review.opendev.org/c/openstack/ironic/+/864236 | 23:39 |
| JayF | /win 11 | 23:42 |
| JayF | whoops | 23:42 |
| JayF | I'll take a look | 23:42 |
| JayF | TheJulia: you still neglected to add me as an assignee :P | 23:44 |
| JayF | not a big deal tho lol | 23:45 |
| TheJulia | uhhhh | 23:45 |
| TheJulia | I thought I did | 23:45 |
| JayF | hmm | 23:48 |
| TheJulia | oh wow | 23:48 |
| TheJulia | so.... apparently you can edit an intermediate state | 23:49 |
| TheJulia | not good gerrit | 23:49 |
| opendevreview | Julia Kreger proposed openstack/ironic-specs master: Add a shard key https://review.opendev.org/c/openstack/ironic-specs/+/861803 | 23:51 |
| TheJulia | Okay, that should be better | 23:51 |
| JayF | restored my +2; I think that's close enough to be landable now | 23:52 |
| JayF | I would suggest ironic-week-prio on it unless you think johnthetubaguy will have more feedback | 23:52 |
| TheJulia | nah, lets do it | 23:54 |
| TheJulia | done | 23:55 |
| TheJulia | I'm going to take the corgi for an outing and then... dunno | 23:55 |
| JayF | I'm EOD in about 5 minutes :) | 23:55 |
| JayF | you should take the corgi and be done too, I suspect | 23:55 |
| JayF | take the corgi to eveningtown lol | 23:55 |
| TheJulia | lol | 23:56 |
| TheJulia | heh, yeah, I should have wrapped at least an hour ago | 23:56 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!