| opendevreview | Jacob Anders proposed openstack/sushy master: Only use SettingsURI for BootSourceOverride if the attribute is present in GET response https://review.opendev.org/c/openstack/sushy/+/856597 | 01:55 |
|---|---|---|
| janders | ajya I finally got to refactoring the patch along the lines of what we discussed in the past weeks. When you're online please let me know what you think about this approach to assessing whether SettingsURI could be used. I responded to your latest comment with a small question as well. TY! (CC dtantsur). | 02:10 |
| opendevreview | test proposed openstack/ironic master: Modify the definition of owner https://review.opendev.org/c/openstack/ironic/+/807302 | 02:22 |
| opendevreview | test proposed openstack/ironic master: Modify the definition of owner https://review.opendev.org/c/openstack/ironic/+/807302 | 02:23 |
| opendevreview | test proposed openstack/ironic master: Modify the definition of owner in parameter.yaml https://review.opendev.org/c/openstack/ironic/+/807332 | 02:26 |
| opendevreview | test proposed openstack/ironic master: Modify the definition of owner https://review.opendev.org/c/openstack/ironic/+/807302 | 02:29 |
| opendevreview | test proposed openstack/ironic master: Modify the definition of owner in parameter.yaml https://review.opendev.org/c/openstack/ironic/+/807332 | 02:59 |
| opendevreview | Ebbex proposed openstack/bifrost master: Install git in prep-for-install https://review.opendev.org/c/openstack/bifrost/+/861535 | 06:42 |
| arne_wiebalck | Good morning, Ironic! | 07:36 |
| rpittau | good morning ironic! o/ | 08:04 |
| ajya | Morning, janders , arne_wiebalck , rpittau & Ironic | 08:49 |
| ajya | janders: looking at the patch introducing the test, https://opendev.org/openstack/sushy/commit/97cee86a2fb35dd3e12f152ee6c214dca895dbde, it seems it is there as all params are optional and "new method will only include those items into the JSON document, that are explicitly passed by the user" | 08:50 |
| ajya | it would make sense in that case to not call PATCH at all; this has happened with your change - no PATCH is called | 08:50 |
| ajya | the test could be adjusted to assert that no PATCH was called instead of removing it, though I'm not sure if there is any caller that calls this method with no parameter, in that case could avoid calling the method | 08:51 |
| Nisha_Agarwal | JayF, hi...i saw the comment today on https://review.opendev.org/c/openstack/ironic/+/859397/3 and responded there...have a look at the patch when u have time | 09:00 |
| janders | Thank you ajya. Otherwise, does the patch look good to you? | 10:01 |
| ajya | janders: on high level it looked ok, I'll take closer look at it later and try out on iDRAC | 10:51 |
| janders | TY ajya. I will fix the test once I'm done requesting some sushy releases | 10:57 |
| iurygregory | good morning Ironic | 11:29 |
| janders | hey iurygregory | 11:51 |
| opendevreview | Jacob Anders proposed openstack/sushy master: Only use SettingsURI for BootSourceOverride if the attribute is present in GET response https://review.opendev.org/c/openstack/sushy/+/856597 | 12:00 |
| janders | ajya ^ fixed test_set_system_boot_options_nothing_specified() test | 12:00 |
| janders | thanks in advance for looking at my patch - much appreciated :) | 12:01 |
| opendevreview | test proposed openstack/ironic master: Modify the definition of owner in parameter.yaml https://review.opendev.org/c/openstack/ironic/+/807332 | 12:23 |
| opendevreview | test proposed openstack/ironic master: Modify the definition of owner in parameter.yaml https://review.opendev.org/c/openstack/ironic/+/807332 | 12:41 |
| opendevreview | test proposed openstack/ironic master: Modify the definition of owner in parameter.yaml https://review.opendev.org/c/openstack/ironic/+/807332 | 12:55 |
| TheJulia | good morning | 13:25 |
| iurygregory | good morning TheJulia =) | 13:30 |
| opendevreview | Merged openstack/ironic master: Fix the anaconda deploy for the ISO mounted https://review.opendev.org/c/openstack/ironic/+/859397 | 16:09 |
| dtantsur | ajya: hi! if you're by chance still around, have you seen the behavior in https://bugzilla.redhat.com/show_bug.cgi?id=2093511#c17 ? | 16:40 |
| dtantsur | I wonder if it has always been like that or is a new behavior | 16:41 |
| opendevreview | Julia Kreger proposed openstack/ironic-specs master: Add a shard key https://review.opendev.org/c/openstack/ironic-specs/+/861803 | 17:07 |
| TheJulia | i hope that passes the linter | 17:07 |
| opendevreview | Julia Kreger proposed openstack/ironic-specs master: Add a shard key https://review.opendev.org/c/openstack/ironic-specs/+/861803 | 17:15 |
| opendevreview | Julia Kreger proposed openstack/ironic-specs master: Add a shard key https://review.opendev.org/c/openstack/ironic-specs/+/861803 | 17:49 |
| TheJulia | \o/ it is green | 18:13 |
| opendevreview | Merged openstack/tenks master: Skip more ansible-lint style checks https://review.opendev.org/c/openstack/tenks/+/862557 | 21:37 |
| opendevreview | Merged openstack/tenks master: Follow ups to venv https://review.opendev.org/c/openstack/tenks/+/857008 | 21:37 |
| opendevreview | Merged openstack/bifrost master: Install git in prep-for-install https://review.opendev.org/c/openstack/bifrost/+/861535 | 22:56 |
| opendevreview | Merged openstack/bifrost master: Move kpartx to dib_host_required_packages https://review.opendev.org/c/openstack/bifrost/+/861539 | 23:03 |
| opendevreview | Ebbex proposed openstack/bifrost master: Remove unused iniparse python system dependency https://review.opendev.org/c/openstack/bifrost/+/862391 | 23:20 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!