| *** tkajinam is now known as Guest3966 | 00:09 | |
| stevebaker[m] | TheJulia: victoria and earlier likely | 00:11 |
|---|---|---|
| TheJulia | stevebaker[m]: I'm looking at a bls issue, got time for a consult? | 00:13 |
| stevebaker[m] | TheJulia: yup | 00:20 |
| TheJulia | stevebaker[m]: https://meet.google.com/qrz-utze-oco | 00:21 |
| *** tkajinam is now known as Guest3972 | 01:47 | |
| opendevreview | Steve Baker proposed openstack/ironic-python-agent stable/train: WIP Drop python2 from bindep.txt https://review.opendev.org/c/openstack/ironic-python-agent/+/862659 | 03:19 |
| opendevreview | Jacob Anders proposed openstack/sushy master: Retry BootSourceOverride request when SettingsURI is read-only https://review.opendev.org/c/openstack/sushy/+/856597 | 05:14 |
| opendevreview | Jacob Anders proposed openstack/sushy master: Retry BootSourceOverride request when SettingsURI is read-only https://review.opendev.org/c/openstack/sushy/+/856597 | 05:26 |
| opendevreview | Jacob Anders proposed openstack/sushy master: Only use SettingsURI for BootSourceOverride if the attribute is present in GET response https://review.opendev.org/c/openstack/sushy/+/856597 | 05:27 |
| *** tkajinam is now known as Guest3986 | 05:43 | |
| opendevreview | Jacob Anders proposed openstack/sushy master: Improve resiliency of eTag handling https://review.opendev.org/c/openstack/sushy/+/856123 | 05:49 |
| *** tkajinam is now known as Guest3988 | 06:53 | |
| opendevreview | Harald Jensås proposed openstack/ironic master: Add port/portgroup list conductor groups filter https://review.opendev.org/c/openstack/ironic/+/862292 | 08:11 |
| arozman | Hello Ironic! | 08:17 |
| kubajj | Good morning Ironic! | 08:22 |
| opendevreview | Jakub Jelinek proposed openstack/ironic master: WIP: Implements node inventory: database https://review.opendev.org/c/openstack/ironic/+/862569 | 08:58 |
| opendevreview | Jakub Jelinek proposed openstack/ironic master: WIP: Implements node inventory: database https://review.opendev.org/c/openstack/ironic/+/862569 | 09:32 |
| kubajj | dtantsur: How do I update the checkouts in /opt/stack to update bifrost? If I did that, could I test the migration locally? | 10:00 |
| janders | dtantsur @ajya I re-wrote the Lenovo /Pending/ URL fix: https://review.opendev.org/c/openstack/sushy/+/856597. If you have time I'd appreciate your comments and reviews, in particular around this area: https://review.opendev.org/c/openstack/sushy/+/856597/14/sushy/resources/system/system.py#288: 1) is this simple check sufficient to tell if we can | 10:06 |
| janders | use SettingsURI for boot override or 2) do we need an all-to-all boot parameter comparison? | 10:06 |
| shukun | JayF: could you please also +1 workflow to this patch (https://review.opendev.org/c/openstack/ironic/+/850553)? | 10:14 |
| dtantsur | janders: the etag one looks good, left some optional comments for your consideration | 11:10 |
| dtantsur | janders: and one comment on the /Pending/ thing | 11:13 |
| dtantsur | kubajj: you can edit the code or use git fetch/checkout - up to you. | 11:14 |
| dtantsur | kubajj: once you add a migration, $ ironic-dbsync --config-file /etc/ironic/ironic.conf upgrade | 11:14 |
| dtantsur | (keep in mind that downgrading is not possible!) | 11:14 |
| kubajj | dtantsur: But once I upgrade, I can re-run it to fix it, right? | 11:15 |
| kubajj | dtantsur: if I just edited the code in /opt/stack, I can just run it, right? | 11:17 |
| kubajj | Also, any idea why my bifrost's /etc/ironic/ironic.conf is empty? | 11:25 |
| dtantsur | it shouldn't be empty Oo | 11:25 |
| kubajj | I fixed that. | 11:37 |
| kubajj | Can I somehow run the test_migrations? Is it not in tox? | 11:37 |
| dtantsur | it requires setting up a real database, I'm not sure if we document it.. (on a meeting now) | 11:41 |
| kubajj | dtantsur: Okay, no worries | 11:41 |
| dtantsur | kubajj: this is a part of it, I think: https://opendev.org/openstack/ironic/src/branch/master/tools/test-setup.sh | 11:42 |
| janders | dtantsur thank you for your reviews. Working on revisions. W/r/t https://review.opendev.org/c/openstack/sushy/+/856597, do you agree checking for presence of just BootSourceOverrideTarget in SettingsURI is sufficient? | 12:23 |
| dtantsur | janders: it's not long-term, but it's a step forward | 12:25 |
| janders | dtantsur ACK, TY | 12:26 |
| dtantsur | folks, looking for a 2nd +2 on https://review.opendev.org/c/openstack/ironic/+/862506 please | 12:32 |
| janders | dtantsur w/r/t https://review.opendev.org/c/openstack/sushy/+/856123/comments/9e59cfa2_15e0f233 did you mean moving the log message to after L302 or L348? | 12:54 |
| dtantsur | janders: after 302, just to exclude other response codes | 13:05 |
| opendevreview | Jacob Anders proposed openstack/sushy master: Only use SettingsURI for BootSourceOverride if the attribute is present in GET response https://review.opendev.org/c/openstack/sushy/+/856597 | 13:08 |
| janders | dtantsur TY, fixing https://review.opendev.org/c/openstack/sushy/+/856123 now | 13:09 |
| janders | dtantsur actually I think it's already fixed | 13:09 |
| janders | :D I forgot where I moved that LOG to in the end | 13:10 |
| dtantsur | nice :) | 13:15 |
| opendevreview | Verification of a change to openstack/ironic-python-agent stable/victoria failed: Use utf-16-le if BOM not present https://review.opendev.org/c/openstack/ironic-python-agent/+/861064 | 13:22 |
| ajya | janders: hypothetically if there is one property in Settings and another not, then it's 2 PATCHes - one for Settings, and another for active resource. Realistically, BootSourceOverrideTarget and BootSourceOverrideEnabled will be together, it's BootSourceOverrideMode that will stand out. All I'm suggesting is not to make such assumption, only read Settings properties and generalize on that. It's more lines to change now, but don't see | 13:25 |
| ajya | that complicated. | 13:25 |
| TheJulia | Good morning | 13:25 |
| janders | hey TheJulia o/ | 13:40 |
| janders | ajya agreed. So - instead of going through this block https://opendev.org/openstack/sushy/src/branch/master/sushy/resources/system/system.py#L232-L277 and then trying to set all three properties in one go, we would do it in two steps, one for BootSourceOverrideTarget&BootSourceOverrideEnabled and one for BootSourceOverrideMode right? | 13:45 |
| frickler | not sure if everyone is subscribed, discussion about the storyboard issue is now happening here https://lists.opendev.org/pipermail/service-discuss/2022-October/000370.html | 13:46 |
| TheJulia | frickler: not subscribed right now, but I think I will be soon! | 13:50 |
| TheJulia | frickler: thanks for the heads up! | 13:51 |
| janders | ajya if we do it this way I am tempted to also check for presence of both BootSourceOverrideTarget and BootSourceOverrideEnabled in resp.json() and fallback to System if any is missing (and this fallback should fail out if System doesn't have both either). Just so that brokenness is easier to spot. | 13:52 |
| janders | ajya let me know your thoughts and I will tweak the code tomorrow | 13:53 |
| janders | see you tomorrow Ironic o/ | 13:53 |
| iurygregory | good morning Ironic | 14:03 |
| ajya | janders: that was what I had in mind - check for all of them and fall back to System (active resource) for those not in Settings. And, yes, I think this way it will be easier to see issues if something goes wrong. | 14:06 |
| dtantsur | frickler: oh, I wasn't even aware of that list | 14:14 |
| dtantsur | melwitt raises a good point about "target to series", I forgot about it completely | 14:16 |
| JayF | yeah, and multi-project bugs | 15:17 |
| JayF | launchpad isn't as bad as we like to think it is :) | 15:17 |
| JayF | I think we dislike it in the way you dislike any tool you used for that long; you know all the bad pieces of it | 15:17 |
| opendevreview | Jay Faulkner proposed openstack/virtualbmc master: Document VirtualBMC is not for production use https://review.opendev.org/c/openstack/virtualbmc/+/862709 | 15:27 |
| JayF | If someone wants to help me land this quickly ^ I'd appreciate it | 15:42 |
| TheJulia | LGTM | 15:56 |
| TheJulia | the very last sentence of that makes me think it is worthwhile to maybe be a little more explicit on the sushy-tools repo | 15:56 |
| JayF | I'll have a look, I'm writing up the OSSN right now. Everything is fixed and opened up, fungi suggested waiting to hit the list until the CVE number is assigned though | 15:56 |
| fungi | yeah, unless it's really urgent to send to the mailing lists straight away, in which case you can say a cve number has been requested and not yet assigned, the possibly follow up with a subsequent errata post once it has been | 15:58 |
| JayF | Yeah; I don't mind waiting :) | 15:58 |
| fungi | yeah, better to save yourself the hassle if you can | 15:58 |
| opendevreview | Merged openstack/virtualbmc master: Document VirtualBMC is not for production use https://review.opendev.org/c/openstack/virtualbmc/+/862709 | 16:04 |
| TheJulia | Ack, thanks | 16:08 |
| opendevreview | Jay Faulkner proposed openstack/sushy-tools master: Explictily document not for production use https://review.opendev.org/c/openstack/sushy-tools/+/862736 | 16:30 |
| TheJulia | JayF: Thanks! | 16:36 |
| JayF | just doin' my job, maam :P | 16:36 |
| JayF | I'm going to be heading out early today (probably in 3ish hours), if you need anything from me explicitly say so :D | 16:36 |
| TheJulia | likewise :) | 16:40 |
| TheJulia | I have to run down to the desert for a vaccine shot | 16:41 |
| JayF | My wife got off early, and the weather is changing here so I have a headache, just a couple of good excuses to walk away and give my eyes a break | 16:41 |
| TheJulia | Good plan, have a wonderful afternoon! | 16:46 |
| JayF | https://review.opendev.org/c/openstack/ironic-specs/+/862538 is not done; but is far enough to get some feedback | 17:15 |
| JayF | for documenting our work items for this (2023.1) cycle | 17:15 |
| TheJulia | Does anyone need me to look at or review anything today? | 17:24 |
| * TheJulia is reaching spoon depleation | 17:24 | |
| JayF | TheJulia: comments on that streams doc would be appreciated | 17:26 |
| opendevreview | Merged openstack/sushy-tools master: Explictily document not for production use https://review.opendev.org/c/openstack/sushy-tools/+/862736 | 18:25 |
| JayF | https://review.opendev.org/c/openstack/ironic/+/861956 is a ironic-week-prio hashtagged patch that needs another core vote | 18:37 |
| TheJulia | JayF: I'm not sure we should actually track completed status in the spec repo | 19:32 |
| opendevreview | Merged openstack/ironic stable/victoria: Suppress Bandit B509 in snmp.py https://review.opendev.org/c/openstack/ironic/+/860848 | 20:12 |
| opendevreview | Merged openstack/ironic master: Fix double mock call in glance_service test https://review.opendev.org/c/openstack/ironic/+/861956 | 20:12 |
| *** dmellado_ is now known as dmellado | 22:49 | |
| JayF | TheJulia: I went back and forth on that | 22:52 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!