Wednesday, 2022-09-14

opendevreviewJacob Anders proposed openstack/sushy master: [WIP] Improve resiliency of eTag handling  https://review.opendev.org/c/openstack/sushy/+/85612300:00
opendevreviewKOBAYASHI DAISUKE proposed openstack/ironic stable/xena: Check Fujitsu backport CI  https://review.opendev.org/c/openstack/ironic/+/85730908:10
opendevreviewMerged openstack/tenks master: Use Yoga branch of Kayobe for gating CI job  https://review.opendev.org/c/openstack/tenks/+/85727308:41
opendevreviewGhanshyam proposed openstack/python-ironic-inspector-client master: Switch to 2023.1 Python3 unit tests and generic template name  https://review.opendev.org/c/openstack/python-ironic-inspector-client/+/85642209:14
opendevreviewAija Jauntēva proposed openstack/ironic master: Fix idrac-redfish RAID controller mode conversion  https://review.opendev.org/c/openstack/ironic/+/85587209:20
opendevreviewAija Jauntēva proposed openstack/ironic master: Update sushy-oem-idrac version  https://review.opendev.org/c/openstack/ironic/+/85759709:20
opendevreviewVerification of a change to openstack/tenks master failed: Follow ups to venv  https://review.opendev.org/c/openstack/tenks/+/85700811:08
opendevreviewRadosław Piliszek proposed openstack/tenks master: Use Yoga branch of Kayobe for gating CI job (p2)  https://review.opendev.org/c/openstack/tenks/+/85764811:40
iurygregorygood morning Ironic11:44
opendevreviewAija Jauntēva proposed openstack/ironic master: Update sushy-oem-idrac version  https://review.opendev.org/c/openstack/ironic/+/85759712:17
opendevreviewAija Jauntēva proposed openstack/ironic master: Fix idrac-redfish RAID controller mode conversion  https://review.opendev.org/c/openstack/ironic/+/85587212:27
opendevreviewEbbex proposed openstack/bifrost master: Use a more traditional ansible approach to include_vars  https://review.opendev.org/c/openstack/bifrost/+/85580612:44
opendevreviewEbbex proposed openstack/bifrost master: Refactor use of include_vars  https://review.opendev.org/c/openstack/bifrost/+/85580712:44
TheJuliagood morning12:53
arne_wiebalckGood morning, Ironic!13:04
TheJuliaJayF: replied to some of your questions on the sqlalchemy phase 1 patch. btw... 1535.6 nodes/second is what it came back with, which is better than I would expect (in ci)... on a rax VM. 2145.9 on a previous job but that machine was paravirt so we can't really compare the runs. 13:26
TheJulianeed to run them on the same machine at some point13:29
JayFTheJulia: if you tell me how to run them, I can probably find time to do that test today13:34
TheJuliawe've got two dirty awful scripts under tools/benchmark, one to create mock db records in mysql with some consistency of chaos (indexing chaos that is, intentionally because index/cache poisoning is a thing...). We run them as part of a bifrost job against ironic since it needs a working ironic codebase/config, and it exercises api/object models for nodes which helped us improve performance last year. 13:40
TheJuliaJayF: ^13:40
TheJuliacode welcome there, btw13:40
TheJuliaThe query counts are explicitly the same query structure nova asks for when doing the sync with ironic, just as an fyi13:40
JayFAll right. I have some ideas that might involve automating that...13:41
TheJuliawe do have it on a zuul job now, but again, we don't save the numbers aside from an etherpad when we need to do stuff like this13:43
JayFYeah I was talking about something more for my personal use where I could point it at 2 equivalent VMs or similar13:45
TheJuliahttps://etherpad.opendev.org/p/ironic-performance13:45
TheJuliaold historical numbers ^13:45
JayFBluntly, I don't trust the worker nodes that zuul uses to be sufficiently similar for this purpose13:45
TheJulia... we lost the link to that etherpad someplace :(13:45
TheJuliaoh, god, don't trust htem at all13:45
TheJuliathe performance is highly variable13:45
JayFSo I'll probably try to set up something that like is push button receive numbers from a more stable platform13:46
TheJuliahmm... that etherpad feels truncated :(13:46
TheJuliasounds good, I was just running the latter script locally on my desktop13:46
TheJuliaand yes, streaming netflix versus amazon video was also measurable on the results :)13:47
TheJuliaAnyway, email()13:47
smachiHi Julia13:58
smachiif there are no further changes required with the patch https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/84870913:59
smachican you please vote against it so it can get merged 14:02
TheJulia*sigh*14:20
opendevreviewMerged openstack/tenks master: Use Yoga branch of Kayobe for gating CI job (p2)  https://review.opendev.org/c/openstack/tenks/+/85764814:21
rlooyeah. i thought about voting cuz i wasn't sure who the redhat folks would vote for.14:22
TheJuliaptl election?14:22
rlooyeah. i messed up with the cordocet whatever thingy. i think. no worries.14:23
TheJuliaI wouldn't guess on others, just vote the way you feel14:23
TheJuliaeveryone! VOTE!14:23
opendevreviewMerged openstack/networking-baremetal master: Update master for stable/zed  https://review.opendev.org/c/openstack/networking-baremetal/+/85731314:29
opendevreviewMerged openstack/ironic-prometheus-exporter master: Update master for stable/zed  https://review.opendev.org/c/openstack/ironic-prometheus-exporter/+/85731814:29
opendevreviewMerged openstack/ironic-prometheus-exporter master: Switch to 2023.1 Python3 unit tests and generic template name  https://review.opendev.org/c/openstack/ironic-prometheus-exporter/+/85731915:10
JayFhttps://review.opendev.org/c/openstack/ironic/+/857238 should be safe to review/merge, and needs to get in before zed is cut15:43
opendevreviewKaifeng Wang proposed openstack/ironic master: Fix nodes stuck at cleaning when Network Service is unavailable  https://review.opendev.org/c/openstack/ironic/+/85761515:56
opendevreviewKaifeng Wang proposed openstack/ironic master: Fix nodes stuck at cleaning on Network Service issues  https://review.opendev.org/c/openstack/ironic/+/85761515:59
opendevreviewMerged openstack/ironic master: Zed Ironic requires Sushy >4  https://review.opendev.org/c/openstack/ironic/+/85723817:12
iurygregorykaifeng =O19:03
TheJuliait is a good find, just needs a release note I think19:05
JayFGot a couple of stable patches that still need love: https://review.opendev.org/c/openstack/ironic/+/856191 https://review.opendev.org/c/openstack/ironic-python-agent/+/85706420:32
JayFclean backports, both passing tests20:32
JayFWe should also probably get this reviewed before zed is cut -> https://review.opendev.org/c/openstack/ironic-python-agent/+/852999/21:30
JayF(I have +2 on it now, needs one more -- but it's a beefy thing to review, as IPA stuff goes)21:31
JayFand https://review.opendev.org/c/openstack/ironic/+/849587 has been waiting almost a week21:37
opendevreviewJay Faulkner proposed openstack/ironic bugfix/20.2: Redfish: Consider password part of the session cache  https://review.opendev.org/c/openstack/ironic/+/85777121:40
opendevreviewJay Faulkner proposed openstack/ironic-python-agent stable/xena: Fix software raid output poisoning  https://review.opendev.org/c/openstack/ironic-python-agent/+/85777221:57
opendevreviewMerged openstack/ironic master: Update sushy-oem-idrac version  https://review.opendev.org/c/openstack/ironic/+/85759722:11
opendevreviewVerification of a change to openstack/ironic bugfix/21.0 failed: Redfish: Consider password part of the session cache  https://review.opendev.org/c/openstack/ironic/+/85619122:11
iurygregorywill check the backports after my dinner =)22:29
JayFI think Julia kicked a couple of them22:30
JayFreally the stuff that matters more now is the stuff with ironic-week-prio going into master22:30
JayFso we can make sure it lands or people have a chance to round trip on feedback w/o missing zed22:30
opendevreviewMerged openstack/ironic-python-agent bugfix/8.3: Fix software raid output poisoning  https://review.opendev.org/c/openstack/ironic-python-agent/+/85706422:50
JayFI'll need to re-run this a few times to gain confidence, but I did some testing (summarized badly here https://etherpad.opendev.org/p/ironic-sqlalchemy20-benchmarks)... 22:51
JayFbasic results are current master: Took 12.000738382339478 seconds to return all 10000 nodes via nodes API call pattern.22:51
JayFcurrent master + Julia's phase 1 patch cherry-picked: Took 12.051380634307861 seconds to return all 10000 nodes via nodes API call pattern.22:51
JayFI'm going to call this probably well within the margin of error22:52
JayFTheJulia: ^ tl;dr performance is roughly equal in my basic testing; I can do something more controlled if you want, but I'm relatively convinced there's no significant perf impact in either direction22:52
opendevreviewMerged openstack/ironic-python-agent master: SoftwareRAID: Enable skipping RAIDS  https://review.opendev.org/c/openstack/ironic-python-agent/+/85299923:21
TheJuliaI wonder what it would be for 100k rows23:26
TheJuliaGranted, takes a ton of time to insert and modify that many….23:27

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!