TheJulia | dtantsur: okay, I grok what is going on and what we need to do. Making progress but I will have to re-write some of the existing methods and checks to go to the new style of sqlalchemy method invocation | 01:32 |
---|---|---|
opendevreview | OpenStack Proposal Bot proposed openstack/ironic master: Imported Translations from Zanata https://review.opendev.org/c/openstack/ironic/+/856004 | 04:21 |
opendevreview | Michal Nasiadka proposed openstack/tenks master: EL9: fix ansible/hypervisor_setup.yml https://review.opendev.org/c/openstack/tenks/+/856230 | 06:04 |
kamlesh6808c | Good morning Ironic ! | 06:41 |
opendevreview | Vanou Ishii proposed openstack/ironic master: [WIP] Deal with iRMC virtual media incompatibility https://review.opendev.org/c/openstack/ironic/+/823790 | 06:55 |
opendevreview | Michal Nasiadka proposed openstack/tenks master: EL9: fix ansible/hypervisor_setup.yml https://review.opendev.org/c/openstack/tenks/+/856230 | 07:14 |
opendevreview | Vanou Ishii proposed openstack/ironic master: [WIP] Deal with iRMC virtual media incompatibility https://review.opendev.org/c/openstack/ironic/+/823790 | 07:30 |
opendevreview | Merged openstack/ironic master: Imported Translations from Zanata https://review.opendev.org/c/openstack/ironic/+/856004 | 08:35 |
ajya | Hi, any reason why not merged backports of this change https://review.opendev.org/q/Id66b87309dd26a2a165b35ac1d81580e4605d629 can't be W+1 all at once? Control order of merging? They all have two +2. | 08:44 |
ajya | Or in other words, please W+1 | 08:44 |
dtantsur | ajya: probably just overlooked. checking now. | 08:44 |
dtantsur | (and yes, we try to keep the ordering) | 08:45 |
ajya | thanks dtantsur | 08:45 |
dtantsur | done! | 08:46 |
opendevreview | Michal Nasiadka proposed openstack/tenks master: EL9: fix ansible/hypervisor_setup.yml https://review.opendev.org/c/openstack/tenks/+/856230 | 09:00 |
opendevreview | waleed mousa proposed openstack/ironic-python-agent master: Update and configure Nvidia nics fw by ironic-python-agent https://review.opendev.org/c/openstack/ironic-python-agent/+/566544 | 10:28 |
opendevreview | Merged openstack/ironic stable/xena: Update raid_type handling for Redfish raid_config https://review.opendev.org/c/openstack/ironic/+/852641 | 10:45 |
opendevreview | Merged openstack/ironic bugfix/18.1: Update raid_type handling for Redfish raid_config https://review.opendev.org/c/openstack/ironic/+/852640 | 10:45 |
opendevreview | Merged openstack/ironic stable/wallaby: Update raid_type handling for Redfish raid_config https://review.opendev.org/c/openstack/ironic/+/852642 | 10:45 |
opendevreview | Merged openstack/ironic-inspector stable/wallaby: Fix SqlAlchemy >1.3.19 support https://review.opendev.org/c/openstack/ironic-inspector/+/854769 | 10:45 |
kubajj | dtantsur: thanks, the patch you created yesterday helped with the test | 11:06 |
dtantsur | nice! | 11:55 |
opendevreview | Michal Nasiadka proposed openstack/tenks master: EL9: fix ansible/hypervisor_setup.yml https://review.opendev.org/c/openstack/tenks/+/856230 | 12:35 |
opendevreview | Michal Nasiadka proposed openstack/tenks master: EL9: fix ansible/hypervisor_setup.yml https://review.opendev.org/c/openstack/tenks/+/856230 | 13:09 |
opendevreview | Mark Goddard proposed openstack/tenks master: EL9: fix ansible/hypervisor_setup.yml https://review.opendev.org/c/openstack/tenks/+/856230 | 14:57 |
opendevreview | Mark Goddard proposed openstack/tenks master: EL9: fix ansible/hypervisor_setup.yml https://review.opendev.org/c/openstack/tenks/+/856230 | 14:58 |
* TheJulia glares at sqlalchemy | 15:04 | |
opendevreview | Radosław Piliszek proposed openstack/tenks master: Use venv instead of virtualenv https://review.opendev.org/c/openstack/tenks/+/856296 | 15:48 |
TheJulia | so tl;dr our node locking does not play nicely | 15:48 |
opendevreview | Radosław Piliszek proposed openstack/tenks master: Use venv instead of virtualenv https://review.opendev.org/c/openstack/tenks/+/856296 | 15:57 |
opendevreview | Radosław Piliszek proposed openstack/tenks master: Use venv instead of virtualenv https://review.opendev.org/c/openstack/tenks/+/856296 | 16:11 |
opendevreview | Radosław Piliszek proposed openstack/tenks master: Use venv instead of virtualenv https://review.opendev.org/c/openstack/tenks/+/856296 | 16:34 |
opendevreview | Radosław Piliszek proposed openstack/tenks master: Use venv instead of virtualenv https://review.opendev.org/c/openstack/tenks/+/856296 | 16:55 |
opendevreview | Radosław Piliszek proposed openstack/tenks master: Use venv instead of virtualenv https://review.opendev.org/c/openstack/tenks/+/856296 | 16:58 |
opendevreview | Radosław Piliszek proposed openstack/tenks master: Use venv instead of virtualenv https://review.opendev.org/c/openstack/tenks/+/856296 | 17:17 |
opendevreview | Radosław Piliszek proposed openstack/tenks master: Use venv instead of virtualenv https://review.opendev.org/c/openstack/tenks/+/856296 | 18:25 |
JayF | BTW; the final Nova->Ironic driver backport is going into stable/train ~nowish | 18:43 |
JayF | so if any of you are operating an old stable release of Ironic+Nova, you may want to ensure you rebuild with those patches | 18:43 |
opendevreview | Radosław Piliszek proposed openstack/tenks master: Use venv instead of virtualenv https://review.opendev.org/c/openstack/tenks/+/856296 | 20:00 |
TheJulia | stevebaker[m]: any chance I can get some eyes, say soemtime tomorrow? | 21:16 |
stevebaker[m] | sure thing | 21:17 |
opendevreview | Julia Kreger proposed openstack/ironic master: WIP: Fix SQLAlchemy 2.0 Compatability https://review.opendev.org/c/openstack/ironic/+/856336 | 21:21 |
TheJulia | I started down ^^^'s path, stephenfin's patch has to be ripped off to test it properly, it is failing some stuff but I don't see *why* | 21:21 |
TheJulia | allocations failures are likely a great place to look, I'll resume tomorrow, but my brain has basically gone to that today | 21:22 |
TheJulia | the commit message has background detail | 21:23 |
JayF | I added that to my (maybe longer than hours left in the day already) review list | 21:26 |
TheJulia | it is definitely a WIP, I've got 7 unit tests, one is cleanup from re-writing locking | 21:26 |
TheJulia | and slightly changing the behavior :( | 21:27 |
JayF | I'm sure it'll take multiple-multiple-multiple round trips for me to grok it anyway lol | 21:27 |
TheJulia | some of the others... are just mistifying | 21:27 |
TheJulia | "why does method get called twice?! Is there a tiny robot pushing a button twice!?!" | 21:27 |
JayF | sqlalchemy is magic | 21:28 |
JayF | and there's always a dark school of magic when there's magic | 21:28 |
* JayF had to fight sqlalchemy a *lot* at a previous job | 21:28 | |
TheJulia | on a plus side, I do *like* where 2.0 is going | 21:28 |
TheJulia | less many ways to do things and more "you do it this way" | 21:28 |
JayF | that can be good, it can also be bad | 21:29 |
JayF | the place I'm thinking of abused the "multiple ways to do things" | 21:29 |
TheJulia | yeah... I suspect we need to audit session creation and look at transaction behavior on them | 21:29 |
TheJulia | it... kind of does that, but they are getting launched early on | 21:30 |
JayF | https://review.opendev.org/c/openstack/ironic/+/855325 one of Dmitry's backports, just needs another to land it | 21:32 |
JayF | if someone will, I'll go ahead and line up the next step of the backport | 21:32 |
TheJulia | done | 21:35 |
opendevreview | Jay Faulkner proposed openstack/ironic stable/xena: Do not reboot into nowhere after BIOS settings with fast-track https://review.opendev.org/c/openstack/ironic/+/856205 | 21:35 |
JayF | eh, or maybe not, that one didn't go in cleanly | 21:36 |
JayF | I'll add it to my list, but it's not going to be first in line to get a rebase-fix | 21:36 |
JayF | NobodyCam: you know if https://review.opendev.org/c/openstack/ironic/+/840986 is going to get some love? I feel bad it's been outstanding so long. I'm removing the ironic-week-prio hashtag from it since it's not reviewable now tho | 21:39 |
NobodyCam | ++ hey hey Jay | 21:40 |
JayF | o/ | 21:40 |
NobodyCam | I will poke the the folks | 21:40 |
NobodyCam | THank you!!! | 21:40 |
JayF | aight | 21:40 |
JayF | no problem :) | 21:40 |
JayF | feel free to ping me on that directly if you need the hashtag readded | 21:40 |
NobodyCam | +++ | 21:40 |
JayF | IDK if you still have the big hammer here or not :) | 21:40 |
NobodyCam | ;) | 21:42 |
JayF | 🤦 | 21:43 |
opendevreview | Verification of a change to openstack/bifrost master failed: Copy shim and grub into tftp and http directories https://review.opendev.org/c/openstack/bifrost/+/849247 | 22:23 |
opendevreview | Merged openstack/ironic bugfix/19.0: Do not reboot into nowhere after BIOS settings with fast-track https://review.opendev.org/c/openstack/ironic/+/855325 | 22:42 |
opendevreview | Stephen Finucane proposed openstack/ironic master: db: Raise warnings on SQLAlchemy deprecation warnings https://review.opendev.org/c/openstack/ironic/+/856345 | 23:09 |
opendevreview | Stephen Finucane proposed openstack/ironic master: tests: Enable SQLAlchemy 2.0 deprecation warnings https://review.opendev.org/c/openstack/ironic/+/856346 | 23:09 |
opendevreview | Stephen Finucane proposed openstack/ironic master: tests: Replace invalid UUIDs https://review.opendev.org/c/openstack/ironic/+/856347 | 23:09 |
opendevreview | Stephen Finucane proposed openstack/ironic master: tests: Comment out prints https://review.opendev.org/c/openstack/ironic/+/856348 | 23:09 |
opendevreview | Stephen Finucane proposed openstack/ironic master: db: Resolve SAWarning warnings https://review.opendev.org/c/openstack/ironic/+/856349 | 23:09 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!