| ajya | Good morning and happy Friday, Ironic! | 06:44 |
|---|---|---|
| ajya | rpittau: re RAID backports - I can take a look at those as there are merge conflicts. Which bugfix branches is it necessary for? 18.1 and 19.0 only? | 06:46 |
| arne_wiebalck | Good morning ajya and Ironic! | 08:08 |
| ajya | hi arne_wiebalck | 08:12 |
| rpittau | good morning ironic! o/ | 08:17 |
| rpittau | ajya: hi! sure thing, supported bugifxbranches are in https://etherpad.opendev.org/p/IronicWhiteBoard at L71 | 08:19 |
| rpittau | ajya: uhm yeah, 19.0 and 18.1, read too fast :) | 08:19 |
| rpittau | ajya: feel free to hijack my patches, I guess I forgot to correct some conflicts | 08:21 |
| ajya | will do, rpittau | 08:26 |
| dtantsur | Friday finally? | 09:09 |
| rpittau | \o/ | 09:09 |
| *** akahat|ruck is now known as akahat | 09:12 | |
| dtantsur | so, we fixed sushy-tools, has anyone looked into ironic-inspector? https://storyboard.openstack.org/#!/story/2010193 | 09:13 |
| rpittau | dtantsur: I think TheJulia has a patch for that | 09:13 |
| rpittau | maybe already merged, not sure | 09:14 |
| rpittau | dtantsur: https://review.opendev.org/c/openstack/ironic-inspector/+/851238 | 09:14 |
| dtantsur | hmm, this is a weird patch, it basically makes everything redundant? | 09:17 |
| dtantsur | how will it even work for 2.1.x? | 09:18 |
| dtantsur | iurygregory, TheJulia, FYI ^^^ is not fixing anything really, many URLs are still broken | 09:22 |
| dtantsur | please avoid 1-core reviews of non-trivial patches | 09:22 |
| rpittau | dtantsur: I just ran unit tests with Werkzeug 2.1.2 with that patch and it passed, haven't really dig into the fix though | 09:22 |
| dtantsur | 2.1.2 works, 2.2.0 fails on most URLs ending with / | 09:22 |
| dtantsur | only /v1/ was fixed | 09:22 |
| rpittau | ok, I see | 09:25 |
| dtantsur | ahhhhh https://github.com/pallets/werkzeug/issues/2467 | 09:34 |
| dtantsur | I guess we're hitting an actual regression and need to exclude 2.2.0 instead | 09:34 |
| dtantsur | 2.2.1 has already been released, trying | 09:36 |
| dtantsur | yep, 2.2.1 fixes it without the awkward hack we landed | 09:36 |
| dtantsur | https://review.opendev.org/c/openstack/requirements/+/851500 | 09:39 |
| opendevreview | Dmitry Tantsur proposed openstack/ironic-inspector master: Remove the incorrect hack for Werkzeug 2.2.0 https://review.opendev.org/c/openstack/ironic-inspector/+/851501 | 09:41 |
| dtantsur | iurygregory, TheJulia ^^^ | 09:41 |
| opendevreview | Dmitry Tantsur proposed openstack/ironic-inspector master: Remove the incorrect hack for Werkzeug 2.2.0 https://review.opendev.org/c/openstack/ironic-inspector/+/851501 | 09:42 |
| opendevreview | Verification of a change to openstack/ironic bugfix/20.2 failed: Fix compatibility with jsonschema>=4.0.0 https://review.opendev.org/c/openstack/ironic/+/851372 | 09:46 |
| * dtantsur loves when large rewrites land without a major version bump :-/ | 09:48 | |
| rpittau | ah alright so it was an actual issue in 2.2.0 | 10:04 |
| dtantsur | yeah | 10:05 |
| dtantsur | I guess we mixed up the sushy-tools and the inspector case, assuming they're the same | 10:05 |
| opendevreview | Verification of a change to openstack/ironic bugfix/20.2 failed: Fix compatibility with jsonschema>=4.0.0 https://review.opendev.org/c/openstack/ironic/+/851372 | 10:11 |
| rpittau | yep, looks like it | 10:12 |
| opendevreview | Verification of a change to openstack/ironic bugfix/19.0 failed: Fix compatibility with jsonschema>=4.0.0 https://review.opendev.org/c/openstack/ironic/+/851374 | 10:51 |
| iurygregory | good morning Ironic | 11:19 |
| iurygregory | dtantsur, ack | 11:20 |
| opendevreview | Verification of a change to openstack/ironic-inspector master failed: Remove the incorrect hack for Werkzeug 2.2.0 https://review.opendev.org/c/openstack/ironic-inspector/+/851501 | 11:20 |
| iurygregory | WOOT?! | 11:28 |
| iurygregory | Warning: Change 851500 in project openstack/requirements does not share a change queue with 851501 in project openstack/ironic-inspector O.o | 11:29 |
| iurygregory | oh ok | 11:30 |
| iurygregory | it has a Depends-On in the requirements patch | 11:30 |
| iurygregory | and it failed in the cross-cinder-py38 | 11:31 |
| dtantsur | asking on #opendev | 11:40 |
| opendevreview | Merged openstack/ironic stable/yoga: Fix compatibility with jsonschema>=4.0.0 https://review.opendev.org/c/openstack/ironic/+/851371 | 12:28 |
| opendevreview | Merged openstack/ironic-inspector master: remove unicode from code https://review.opendev.org/c/openstack/ironic-inspector/+/851313 | 12:28 |
| opendevreview | Jakub Jelinek proposed openstack/ironic-python-agent master: WIP: Enable skipping disks for cleaning https://review.opendev.org/c/openstack/ironic-python-agent/+/850861 | 12:40 |
| dtantsur | iurygregory: apparently we're not supposed to approve changes with unmerged dependencies | 12:42 |
| kubajj | Does anybody know why would tempest not finish cleaning the nodes? https://zuul.opendev.org/t/openstack/build/b3f0df6ade12406590dbc0f48281971f I thought my change should not interfere with it (given that the skip list is not defined). | 12:42 |
| iurygregory | dtantsur, lol :D | 12:42 |
| dtantsur | kubajj: it's a regression in Werkzeug, has nothing to do with you | 12:43 |
| iurygregory | interesting (makes some sense, but zuul was smart to only trigger the merge after the dependencies were merged...) | 12:43 |
| dtantsur | yeah, the decided to get rid of it.. | 12:44 |
| kubajj | Ok, thanks dtantsur . Btw, I have added some tests to the change and updated it with what you've suggested. | 12:45 |
| opendevreview | Jakub Jelinek proposed openstack/ironic-python-agent master: Enable skipping disks for cleaning https://review.opendev.org/c/openstack/ironic-python-agent/+/850861 | 13:04 |
| opendevreview | Merged openstack/ironic bugfix/20.2: Fix compatibility with jsonschema>=4.0.0 https://review.opendev.org/c/openstack/ironic/+/851372 | 13:31 |
| TheJulia | good morning | 13:57 |
| TheJulia | oh yay | 13:59 |
| TheJulia | freaky, I guess we need to double up some of the tests then since our use doesn't actually match reality of clients :\ | 13:59 |
| opendevreview | Aija Jauntēva proposed openstack/ironic bugfix/19.0: Fix redfish RAID failed tasks https://review.opendev.org/c/openstack/ironic/+/848592 | 14:12 |
| opendevreview | Aija Jauntēva proposed openstack/ironic bugfix/19.0: Fix Redfish RAID for non-immediate controllers https://review.opendev.org/c/openstack/ironic/+/851411 | 14:12 |
| opendevreview | Aija Jauntēva proposed openstack/ironic bugfix/19.0: Fix prepare ramdisk for 'wait' states https://review.opendev.org/c/openstack/ironic/+/851524 | 14:12 |
| opendevreview | Aija Jauntēva proposed openstack/ironic bugfix/19.0: Fix Redfish RAID to update raid_config https://review.opendev.org/c/openstack/ironic/+/851525 | 14:12 |
| opendevreview | Aija Jauntēva proposed openstack/ironic bugfix/18.1: Fix redfish RAID failed tasks https://review.opendev.org/c/openstack/ironic/+/848591 | 14:13 |
| opendevreview | Aija Jauntēva proposed openstack/ironic bugfix/18.1: Fix Redfish RAID for non-immediate controllers https://review.opendev.org/c/openstack/ironic/+/851413 | 14:14 |
| opendevreview | Aija Jauntēva proposed openstack/ironic bugfix/18.1: Fix prepare ramdisk for 'wait' states https://review.opendev.org/c/openstack/ironic/+/851526 | 14:14 |
| opendevreview | Aija Jauntēva proposed openstack/ironic bugfix/18.1: Fix Redfish RAID to update raid_config https://review.opendev.org/c/openstack/ironic/+/851527 | 14:14 |
| ajya | ^ though originally they were not dependent on each other directly, chained them for easier merge conflict resolution to match they were merged to master and not mix code for unit test setups | 14:15 |
| rpittau | thanks ajya, looks great | 14:15 |
| arne_wiebalck | we just inspected the first arm node in our cloud :) | 15:24 |
| * arne_wiebalck goes on PTO for 2 weeks now :-D | 15:31 | |
| rpittau | arne_wiebalck: cool! and enjoy! :) | 15:31 |
| arne_wiebalck | rpittau: thanks! | 15:32 |
| rpittau | I'm going just for weekend :/ | 15:32 |
| arne_wiebalck | well, enjoy the week-end then! | 15:32 |
| rpittau | thanks :) | 15:32 |
| rpittau | have a great weekend (or PTO) everyone o/ | 15:32 |
| iurygregory_ | arne_wiebalck, nice! | 15:57 |
| *** iurygregory_ is now known as iurygregory | 15:57 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!