| opendevreview | LiZekun proposed openstack/ironic-inspector master: Remove unicode literal from code https://review.opendev.org/c/openstack/ironic-inspector/+/844709 | 01:08 |
|---|---|---|
| opendevreview | LiZekun proposed openstack/ironic-inspector master: Remove unicode literal from code https://review.opendev.org/c/openstack/ironic-inspector/+/844709 | 01:09 |
| opendevreview | Merged openstack/ironic-python-agent bugfix/8.3: Do not try to guess EFI partition path by its number https://review.opendev.org/c/openstack/ironic-python-agent/+/842563 | 06:38 |
| opendevreview | 江治林 proposed openstack/ironic-python-agent master: Update python testing as per zed cycle testing runtime https://review.opendev.org/c/openstack/ironic-python-agent/+/844738 | 06:44 |
| opendevreview | 江治林 proposed openstack/ironic-python-agent master: Update python testing as per zed cycle testing runtime https://review.opendev.org/c/openstack/ironic-python-agent/+/844738 | 06:44 |
| waleedm | Hi guys, When implementing a clean_setp using ironic-python-agent hardware manager, Can't I pass an argements to that step ? | 12:25 |
| waleedm | @TheJulia, can you help please? | 12:28 |
| TheJulia | waleedm: you should be able to, just mechanics of how are not in my brain at this time | 12:37 |
| waleedm | TheJulia, I defined something like this, https://github.com/wmousa/ironic-python-agent/blob/test/ironic_python_agent/hardware_managers/mlnx.py#L120-L147 | 12:43 |
| waleedm | TheJulia, but it didn't work | 12:44 |
| TheJulia | Does the step get populated agent wise when it runs? In automated cleaning at least, it calls the agent to get the steps from all hardware managers and it returns it back | 12:45 |
| waleedm | TheJulia, I did a manual cleaning using this command "openstack baremetal node clean control-0 --clean-steps '[{"interface": "deploy", "step": "update_nvidia_fw", "args": {"bin_dir_url": "http://10.7.12.161/fw/", "yaml_config": "http://10.7.12.161/config.yaml"}}]'" | 12:48 |
| waleedm | it failed with this error "ERROR ironic.conductor.task_manager [req-1c0b3d93-f2dd-47e1-a7c0-c689dd961c76 - - - - -] Node 52625f69-5876-4671-9096-45fc9dbfc2ab moved to provision state "clean failed" from state "clean wait"; target provision state is "manageable": ironic.common.exception.InvalidParameterValue: clean step {'interface': 'deploy', 'step': 'update_nvidia_fw', 'args': {'bin_dir_url': 'http://10.7.12.161/fw/', 'yaml_config': | 12:49 |
| waleedm | 'http://10.7.12.161/config.yaml'}} has these unexpected arguments: yaml_config, bin_dir_url" | 12:49 |
| TheJulia | Hmmm | 12:49 |
| TheJulia | Because it is preflight checked | 12:49 |
| TheJulia | Hmmmmm | 12:49 |
| TheJulia | Sounds like we’re validating too early | 12:50 |
| TheJulia | Before the agent ramdisk is online, but I’m just guessing. I don’t have the code in front of me at the moment | 12:51 |
| waleedm | TheJulia, bur running the clean_Step without args is OK ! | 12:56 |
| ashinclouds[m] | Weird… that sounds like a definite bug then | 12:56 |
| TheJulia | Err, what I just said on my matrix client | 12:57 |
| waleedm | mmm so ? | 13:06 |
| waleedm | TheJulia, this https://github.com/wmousa/ironic-python-agent/blob/test/ironic_python_agent/hardware_managers/mlnx.py#L132 should be argsinfo ? | 14:11 |
| TheJulia | I dont remember at the moment, just checked out a meeting location for the Summit | 14:26 |
| opendevreview | Iury Gregory Melo Ferreira proposed openstack/ironic-python-agent bugfix/8.3: Create fstab entry with appropriate label https://review.opendev.org/c/openstack/ironic-python-agent/+/844486 | 15:48 |
| opendevreview | Iury Gregory Melo Ferreira proposed openstack/ironic-python-agent bugfix/8.3: Collect a full lsblk output in the ramdisk logs https://review.opendev.org/c/openstack/ironic-python-agent/+/844747 | 18:01 |
| opendevreview | Iury Gregory Melo Ferreira proposed openstack/ironic-python-agent bugfix/8.3: Add `mount` and `parted -l` to the collected commands https://review.opendev.org/c/openstack/ironic-python-agent/+/844748 | 18:02 |
| opendevreview | Iury Gregory Melo Ferreira proposed openstack/ironic-python-agent bugfix/8.3: Multipath Hardware path handling https://review.opendev.org/c/openstack/ironic-python-agent/+/844749 | 18:03 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!