opendevreview | Iury Gregory Melo Ferreira proposed openstack/ironic bugfix/19.0: Fix ironic-lib from source and branch detection in IPA builds https://review.opendev.org/c/openstack/ironic/+/843822 | 00:35 |
---|---|---|
opendevreview | Iury Gregory Melo Ferreira proposed openstack/ironic bugfix/19.0: Fix ironic-lib from source and branch detection in IPA builds https://review.opendev.org/c/openstack/ironic/+/843822 | 00:55 |
opendevreview | Iury Gregory Melo Ferreira proposed openstack/ironic bugfix/19.0: Fix ironic-lib from source and branch detection in IPA builds https://review.opendev.org/c/openstack/ironic/+/843822 | 00:59 |
opendevreview | Steve Baker proposed openstack/sushy-tools master: Use libvirt automatic firmware for UEFI boot mode https://review.opendev.org/c/openstack/sushy-tools/+/841653 | 01:52 |
opendevreview | Steve Baker proposed openstack/sushy-tools master: Implement set_secure_boot for libvirt driver https://review.opendev.org/c/openstack/sushy-tools/+/843557 | 01:52 |
opendevreview | Steve Baker proposed openstack/ironic master: Switch to q35 machine type for test nodes https://review.opendev.org/c/openstack/ironic/+/843558 | 04:37 |
opendevreview | Steve Baker proposed openstack/sushy-tools master: Implement set_secure_boot for libvirt driver https://review.opendev.org/c/openstack/sushy-tools/+/843557 | 04:42 |
rpittau | good morning ironic! o/ | 06:51 |
jssfr | good morning rpittau! | 06:54 |
rpittau | hey jssfr :) | 06:54 |
opendevreview | Riccardo Pittau proposed openstack/ironic-python-agent master: Add ipa-tox-examples job to gate https://review.opendev.org/c/openstack/ironic-python-agent/+/844003 | 07:42 |
opendevreview | Riccardo Pittau proposed openstack/ironic-python-agent master: Drop support for Python 3.6 and 3.7 https://review.opendev.org/c/openstack/ironic-python-agent/+/844004 | 07:49 |
* rpittau hears the call of coffee and painkillers | 08:02 | |
opendevreview | Dmitry Tantsur proposed openstack/ironic master: Remove netboot jobs from the gate https://review.opendev.org/c/openstack/ironic/+/843937 | 08:03 |
opendevreview | Merged openstack/bifrost stable/xena: Fetch uuid if it is not present in the inventory https://review.opendev.org/c/openstack/bifrost/+/831869 | 08:18 |
opendevreview | Harald Jensås proposed openstack/ironic-tempest-plugin master: WIP: Secure RBAC Test Concept https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/842427 | 09:24 |
hjensas | TheJulia: ^^ two options for "expect a failure", a) mock rest_client.RestClient._error_checker or b) with self.assertRaisesRegex(expected_exception, 'error message'). wdyt? | 09:26 |
opendevreview | Merged openstack/bifrost stable/yoga: Set git_branch et al to stable/yoga https://review.opendev.org/c/openstack/bifrost/+/842151 | 10:23 |
opendevreview | Merged openstack/python-ironicclient master: Avoid using 'foo' as invalid JSON test data https://review.opendev.org/c/openstack/python-ironicclient/+/831327 | 10:38 |
iurygregory | good morning Ironic | 10:45 |
iurygregory | if anyone has some time please review https://review.opendev.org/c/openstack/ironic/+/843822 https://review.opendev.org/c/openstack/ironic-python-agent/+/842125 this is to unblock our CI in bugfix/8.3 for IPA and bugfix/19.0 in Ironic | 11:27 |
dtantsur | dmellado: of course I forgot to add a video link to the invite :) just did | 11:30 |
dmellado | lol, was doing that myself | 11:30 |
dmellado | xD | 11:30 |
dtantsur | dmellado: I hear something, but it's breaking up HORRIBLY | 11:32 |
dmellado | pipewire | 11:47 |
dmellado | blame pipewire | 11:47 |
dmellado | xD | 11:48 |
dtantsur | :D | 11:48 |
dtantsur | dmellado: FYI my current bifrost VM uses ~ 3.2G of memory (+ caches) | 11:49 |
dmellado | hmmm fair enough, I'll check about if I can just make it local | 12:10 |
dmellado | may be a bit biased against that due to the amount of memory my current openshift setup uses xD | 12:10 |
TheJulia | good morning | 12:51 |
TheJulia | hjensas: I was thinking more along the lines of enabling an ignore_errors key to be passed in, which would be passed to the requests client *and* bypass the expected success check on all rest api calls | 12:52 |
hjensas | TheJulia: tempest/lib/common/rest_client.py:703 runs self._error_checker(resp, resp_body) and raise errors before self.expected_success() is used. | 12:58 |
TheJulia | ugh | 12:58 |
TheJulia | UGH | 12:58 |
* hjensas is also confused that test_reader_cannot_create_node return 500 in the check job, and 403 in my local env. :-/ | 13:01 | |
TheJulia | hjensas: hmm | 13:02 |
TheJulia | is scope enforcement enabled? I'm guessing yes | 13:02 |
hjensas | in tempes conf, yes I have: [enforce_scope] | 13:03 |
hjensas | ironic_inspector = True | 13:03 |
hjensas | ironic = True | 13:03 |
TheJulia | what about in the service config | 13:03 |
TheJulia | ? | 13:03 |
TheJulia | I believe 403 is correct, fwiw | 13:03 |
hjensas | oh, I don't have enforce_scope = true in [oslo_policy] | 13:04 |
TheJulia | ahh | 13:04 |
TheJulia | Interesting | 13:05 |
TheJulia | sooo many emails... | 13:12 |
TheJulia | does the raised error tempest's internal rest client raises have the original response body on it? | 13:28 |
TheJulia | I'm kind of wondering if we can just capture and re-package it... | 13:28 |
hjensas | I'll check if the exceptions raised include the response body, it does have the faultcode and faultstring atleast. | 13:52 |
hjensas | Is mocking the _error_checker in tempest/lib/common/rest_client.py a bad idea? we can possibly override it in class BaremetalClient instead? | 13:54 |
opendevreview | Mark Goddard proposed openstack/networking-generic-switch master: Support 802.3ad port groups on Cumulus devices https://review.opendev.org/c/openstack/networking-generic-switch/+/844062 | 14:11 |
TheJulia | hjensas: well, it is referenced as self, so overriding it in the RBAC test case does seem... feasible | 14:11 |
opendevreview | Mark Goddard proposed openstack/networking-generic-switch master: Support 802.3ad port groups on Cumulus devices https://review.opendev.org/c/openstack/networking-generic-switch/+/844062 | 14:12 |
TheJulia | I guess I'm not a fan of internally using mock, but it is just for testing... | 14:18 |
TheJulia | The union of least headache and most effective path wins | 14:18 |
hjensas | TheJulia: the raised error contains, resp, response_body, status_code. | 14:22 |
hjensas | also args, message and with_traceback. | 14:22 |
TheJulia | oh, so we could capture the exception and then just process, hand response back, etc | 14:25 |
TheJulia | no mocking required | 14:25 |
hjensas | yes | 14:27 |
TheJulia | That seems pythonic to me :) | 14:38 |
opendevreview | Mark Goddard proposed openstack/networking-generic-switch master: Support 802.3ad port groups on Cumulus devices https://review.opendev.org/c/openstack/networking-generic-switch/+/844062 | 14:51 |
rpittau | good night! o/ | 16:19 |
dtantsur | o/ | 16:27 |
opendevreview | Merged openstack/ironic bugfix/19.0: Fix ironic-lib from source and branch detection in IPA builds https://review.opendev.org/c/openstack/ironic/+/843822 | 17:01 |
opendevreview | Iury Gregory Melo Ferreira proposed openstack/ironic-python-agent bugfix/8.1: Testing CI 8.1 https://review.opendev.org/c/openstack/ironic-python-agent/+/844117 | 17:41 |
opendevreview | Iury Gregory Melo Ferreira proposed openstack/ironic bugfix/18.1: Testing CI https://review.opendev.org/c/openstack/ironic/+/844119 | 17:48 |
iurygregory | ok time to fix ironic bugfix/18.1 :D | 17:55 |
opendevreview | Iury Gregory Melo Ferreira proposed openstack/ironic bugfix/18.1: Fix ironic-lib from source and branch detection in IPA builds https://review.opendev.org/c/openstack/ironic/+/844077 | 18:12 |
opendevreview | Merged openstack/ironic-python-agent bugfix/8.3: Fix bugfix/8.3 https://review.opendev.org/c/openstack/ironic-python-agent/+/842125 | 18:30 |
opendevreview | Iury Gregory Melo Ferreira proposed openstack/ironic bugfix/18.1: Fix tox template and ironic-lib from src and branch detection in IPA https://review.opendev.org/c/openstack/ironic/+/844077 | 18:37 |
opendevreview | Iury Gregory Melo Ferreira proposed openstack/ironic-python-agent bugfix/8.1: Fix 8.1 CI https://review.opendev.org/c/openstack/ironic-python-agent/+/844117 | 18:39 |
opendevreview | Sergey Skripnick proposed openstack/sushy-tools master: Add Chassis to ServiceRoot https://review.opendev.org/c/openstack/sushy-tools/+/844126 | 19:12 |
opendevreview | Merged openstack/ironic-python-agent bugfix/8.3: Make the standalone job voting again https://review.opendev.org/c/openstack/ironic-python-agent/+/827289 | 20:10 |
janders | good morning Ironic o/ | 22:43 |
iurygregory | morning janders o/ | 23:03 |
iurygregory | if any ironic cores are around please check https://review.opendev.org/c/openstack/ironic/+/844077 https://review.opendev.org/c/openstack/ironic-python-agent/+/844117 They are required to fix CI in our bugfix branches =) | 23:06 |
TheJulia | wheeeeee | 23:11 |
* TheJulia is focused on. slides | 23:11 | |
TheJulia | so many slides | 23:12 |
iurygregory | I'm going to look at slides after my dinner XD | 23:12 |
iurygregory | now I finally have a monitor \o/ | 23:12 |
iurygregory | no more small screen to look at code/logs/slides/emails \o/ | 23:13 |
TheJulia | \o/ | 23:21 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!