Friday, 2022-03-11

opendevreviewMerged openstack/ironic-python-agent master: Create fstab entry with appropriate label  https://review.opendev.org/c/openstack/ironic-python-agent/+/83102900:40
opendevreviewMerged openstack/networking-baremetal master: Add Python3 zed unit tests  https://review.opendev.org/c/openstack/networking-baremetal/+/83257501:09
opendevreviewJulia Kreger proposed openstack/ironic-python-agent stable/xena: Create fstab entry with appropriate label  https://review.opendev.org/c/openstack/ironic-python-agent/+/83319301:15
opendevreviewJacob Anders proposed openstack/ironic-python-agent master: Improve efficiency of storage cleaning in mixed media envs  https://review.opendev.org/c/openstack/ironic-python-agent/+/81871201:15
opendevreviewJulia Kreger proposed openstack/ironic-python-agent stable/wallaby: Create fstab entry with appropriate label  https://review.opendev.org/c/openstack/ironic-python-agent/+/83319401:15
opendevreviewHarald Jensås proposed openstack/networking-baremetal master: WIP - OpenConfig YANG and Netconf  https://review.opendev.org/c/openstack/networking-baremetal/+/83226801:40
opendevreviewJacob Anders proposed openstack/ironic-python-agent master: Improve efficiency of storage cleaning in mixed media envs  https://review.opendev.org/c/openstack/ironic-python-agent/+/81871202:22
opendevreviewJacob Anders proposed openstack/ironic-python-agent master: Improve efficiency of storage cleaning in mixed media envs  https://review.opendev.org/c/openstack/ironic-python-agent/+/81871202:38
opendevreviewMerged openstack/ironic stable/wallaby: More fixes for anaconda deploy interface  https://review.opendev.org/c/openstack/ironic/+/83185204:36
rpittaugood morning ironic! o/07:01
MahnoorAsgharGood morning rpittau 07:04
rpittauhey MahnoorAsghar :)07:05
jandershey rpittau MahnoorAsghar and Ironic o/07:14
jandersHappy Friday07:14
rpittauHey janders :)07:17
rpittauHappy Friday!07:17
MahnoorAsgharHappy Friday ^_^07:18
opendevreviewMerged openstack/ironic stable/xena: More fixes for anaconda deploy interface  https://review.opendev.org/c/openstack/ironic/+/83185107:21
opendevreviewMerged openstack/ironic master: Shorten error messages in commonly used modules  https://review.opendev.org/c/openstack/ironic/+/82975507:41
kamlesh6808cHi , Good Morning Ironic !07:48
kamlesh6808cDell is working on improving the test coverage in its third-party CI.We are developing Tempest tests to automate much of the testing we have performed manually. 07:50
kamlesh6808cWe are aiming to leverage as much of the existing tests as possible.07:51
arne_wiebalckGood morning, Ironic!07:51
kamlesh6808cCurrently, I am working raid cleaning step tempest implementation, This execution we are performing and testing on physical baremetal servers .07:51
arne_wiebalckGood morning rpittau janders MahnoorAsghar kamlesh6808c o/07:52
kamlesh6808cIn order to leverage build_raid_and_verify_node method (https://github.com/openstack/ironic-tempest-plugin/blob/37d61a4acf34040c3f4af63a3b2142bfe59d81a1/ironic_tempest_plugin/tests/scenario/baremetal_standalone_manager.py#L580 ) in test cleaning, we are planning to use root device hint as " by path" in order to deploy node (since present hint as “name” doesn’t work on physical BareMetal.)07:52
kamlesh6808ciurygregory : Query is, what would be the best possible way ahead or can we use DRACClient in tempest-ironic-plugin to grab virtual disk information which will get generated during runtime of raid create configuration on Servers ? 07:53
kamlesh6808cHi arne_wiebalck.07:55
rpittauhey arne_wiebalck :)08:06
opendevreviewMerged openstack/ironic-python-agent stable/xena: Create fstab entry with appropriate label  https://review.opendev.org/c/openstack/ironic-python-agent/+/83319308:31
opendevreviewMerged openstack/ironic-python-agent stable/wallaby: Create fstab entry with appropriate label  https://review.opendev.org/c/openstack/ironic-python-agent/+/83319408:31
dtantsurmorning folks09:04
dtantsurjanders: was going to raise the question of the default step priority :) I think keeping it at 0 is sensible for now.09:06
opendevreviewJacob Anders proposed openstack/ironic-python-agent master: Improve efficiency of storage cleaning in mixed media envs  https://review.opendev.org/c/openstack/ironic-python-agent/+/81871209:08
jandersdtantsur ACK - and thank you. Uploaded a new revision and also testing the IPA to be sure-sure everything runs like it did before with 0 default.09:24
jandersdtantsur everything still working as expected with def prio 0 - left a comment with test results.09:46
janders(no surprises there)09:46
dtantsurcool!10:17
arne_wiebalckdtantsur: can I pick your brain for a second? we have had the use case of redeploying without erasing some of the disks, no?10:26
dtantsurarne_wiebalck: I think "rebuild" only erases the root disk (minus ephemeral partitions)10:27
arne_wiebalckdtantsur: right, but one would need to use root device hints to make sure Ironic picks the very same disk, correct? (there is no "this is the current root device" mechanism is my question)10:29
dtantsurarne_wiebalck: yeah, I don't think Ironic has this logic10:29
arne_wiebalckdtantsur: ok ... and I think rebuild could be given another image (in case one needs this)10:32
dtantsuryes10:32
arne_wiebalckdtantsur: concrete use case is to move a ceph node from a cluster into a k8s cluster ... while preserving its daya10:33
arne_wiebalck*data10:33
arne_wiebalck(since I have adopted in production nodes into Ironic, this is now the next level challenge :))10:33
arne_wiebalckdtantsur: maybe some safeguard, like "don't touch disks which match these hints ever" could be useful in situations like this one 10:36
arne_wiebalckdtantsur: e.g. to exempt some data disks from cleaning10:36
arne_wiebalck"don't touch" --> "skip"10:37
dtantsurarne_wiebalck: yeah, I think some metal3 people have also floated this idea10:37
dtantsurcould be useful in some cases10:38
arne_wiebalckdtantsur: yes ... I can add this to the "safeguards" project as an extra10:38
dtantsurarne_wiebalck: in my opinion, it may be even more important than the cleaning limit, but up to you of course10:38
arne_wiebalckdtantsur: it sounds technically easier to do, so we could start with it (as we also have a use case)10:39
arne_wiebalckdtantsur: thanks for your brain, you can have it back now :-D10:40
dtantsurnot much to have, but thank you :D10:40
arne_wiebalckheh10:40
opendevreviewJacob Anders proposed openstack/ironic-python-agent master: Improve efficiency of storage cleaning in mixed media envs  https://review.opendev.org/c/openstack/ironic-python-agent/+/81871211:45
janders^ oops forgot to re-set default priority to 0 in the test :)11:45
iurygregorygood morning Ironic, TGIF!11:57
iurygregoryoh, the person that asked the question is not around anymore11:58
janderssee you next week Ironic o/12:16
jandershave a great weekend everyone12:16
iurygregorybye janders 12:19
iurygregoryIronicers, anyone had a chance to look at http://lists.openstack.org/pipermail/openstack-discuss/2022-March/027647.html ? =)12:19
opendevreviewMerged openstack/ironic master: Anaconda deploy handles configdrive correctly  https://review.opendev.org/c/openstack/ironic/+/82793312:37
iurygregorydtantsur, do you mind if I update https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/828492 ? =)12:38
dtantsuriurygregory: not at all (although I'm not sure we need it still)12:54
iurygregorygotcha12:55
dmelladoo/13:21
dmelladodtantsur:  not sure if you got a notification, but added you as a speaker 13:21
dtantsurdmellado: I don't think so.. but maybe it takes time again?13:21
dmelladocould be... in any case, they acked the change from the org, so no worries13:22
rpittauiurygregory: re PTG slots, I guess we need to exclude option A since we excluded Friday ?13:23
iurygregoryrpittau, in case we really need that 2hrs yes13:24
rpittauthe other 3 seems all reasonable, although option C may be a bit impractical for US west coast inhabitants13:24
iurygregoryoh13:26
iurygregorylet me check13:26
rpittau14:00 UTC is 6:00 Pacific Time13:26
iurygregoryhumm, I was using the previous PTG slots we had so I thought it was ok 13:27
iurygregoryOH GOD13:27
dtantsurdmellado: the schedule is not updated, maybe they're processing it manually13:27
rpittauiurygregory: actually in Aril that would be 7am PDT, so slightly better13:28
iurygregoryrpittau, gotcha!13:28
rpittauanyway, let's see what others think, maybe we can discuss that during the meeting on Monday13:29
iurygregoryyeah13:30
iurygregorykamlesh6808c, re  using DRACClient in ironic-tempest-plugin to grab the information, we need to discuss with the community (feel free to add as topic for next weekly meeting)13:33
kamlesh6808ciurygregory : Sure . Thanks13:35
kamlesh6808ciurygregory: I have updated agenda of next meeting.14:02
iurygregorytks!14:02
iurygregorydtantsur, thoughts on https://review.opendev.org/c/openstack/bifrost/+/822895 ?14:14
iurygregorythe person answered your comment, just wondering if you want something else14:15
dtantsuriurygregory: no brainpower for it today :( if you feel like it's worth a +2 - go ahead14:22
iurygregorydtantsur, no worries =) rlx o/14:23
iurygregoryI will check a few more things 14:23
iurygregorywe are not in a hurry anyway =)14:23
iurygregoryand it's friday so take it slow =)14:23
dtantsuryeah :) it's enough that I have to debug kuber :)14:27
iurygregory++14:31
TheJuliagood morning14:40
iurygregorygood morning TheJulia 14:43
dtantsurmorning TheJulia 14:59
dtantsurwe lived to see another Friday!14:59
TheJulia\o/14:59
opendevreviewMerged openstack/bifrost master: Add `./bifrost-cli deploy` and refactor bifrost-deploy-nodes-dynamic  https://review.opendev.org/c/openstack/bifrost/+/82951715:01
opendevreviewMerged openstack/bifrost master: Update inventory format documentation with more details  https://review.opendev.org/c/openstack/bifrost/+/82974815:01
iurygregoryTheJulia, re networking-baremetal release, only after the final yoga release based on the release meeting15:12
opendevreviewDmitry Tantsur proposed openstack/bifrost master: Trivial: fix my arithmetic  https://review.opendev.org/c/openstack/bifrost/+/83338215:12
dtantsurrpittau, iurygregory ^^15:12
TheJuliaiurygregory: that is insane15:12
TheJulialike, wtaf15:12
iurygregoryTheJulia, because it was only tests that were broken15:12
TheJuliauhh... I think it was more than just the tests15:13
TheJuliaoh wait15:13
* TheJulia looks for the failed job15:13
iurygregorydtantsur, LOL for the commit message15:13
dtantsurwell :)15:13
iurygregoryTheJulia, well in the patch we only fixed tests https://review.opendev.org/c/openstack/networking-baremetal/+/83285815:14
iurygregoryand the configuration of the job...15:14
TheJuliaokay yeah, the the integation job looks like it mostly worked15:15
TheJuliayeah, the only exception neutron recorded was with callbacks from nova15:16
TheJulianevermind15:17
dtantsurlooking for a 2nd +2 on https://review.opendev.org/c/openstack/ironic/+/826930 please15:18
iurygregorylooking15:19
TheJuliawhat about case missmatches15:23
opendevreviewVerification of a change to openstack/bifrost master failed: Remove questionable defaults from the network configuration  https://review.opendev.org/c/openstack/bifrost/+/82975415:24
TheJuliaI guess the risk is lowish15:25
opendevreviewMerged openstack/bifrost master: Make ironic and inspector listen on Unix sockets  https://review.opendev.org/c/openstack/bifrost/+/82712815:46
rpittaubye everyone have a great weekend! o/15:52
dtantsuriurygregory: re slots: I'd go with option A, having Friday as more of a backup.16:01
dtantsur18:00 UTC is a bit late for Europe, especially eastern16:01
dtantsurand I'd prefer you not having to skip Monday :)16:01
iurygregoryyeah16:04
iurygregoryfrom 14-16 there is the PTL interaction, I'm also ok if people want to start a discussion and I can join the last hour 16-1716:05
iurygregoryoh one thing we can also do would be record the PTG discussions (there is an option for that)16:06
dtantsurI hope we don't really need all 16 hours, to be honest. that's a lot.16:06
iurygregoryyeah, like it would be 12 in the EMEA time mostly 16:07
arne_wiebalckbye everyone, see you next week o/17:16
dtantsurhave a great weekend o/17:29
opendevreviewMerged openstack/ironic master: Support img_type Glance property  https://review.opendev.org/c/openstack/ironic/+/82693017:31
opendevreviewMerged openstack/bifrost master: Trivial: fix my arithmetic  https://review.opendev.org/c/openstack/bifrost/+/83338219:29
opendevreviewMerged openstack/ironic-python-agent bugfix/8.3: Use utf-16-le if BOM not present  https://review.opendev.org/c/openstack/ironic-python-agent/+/83158420:11
opendevreviewMerged openstack/ironic-python-agent master: Add non-voting dib CentOS Stream 9 job  https://review.opendev.org/c/openstack/ironic-python-agent/+/83294720:11
jandersI have a release note convention question if anyone is still around20:34
jandersaddressing this comment: https://review.opendev.org/c/openstack/ironic-python-agent/+/818712/21/releasenotes/notes/add-erase-devices-express-1df107c75f2b3627.yaml from arne_wiebalck (thanks!)20:35
jandersIs this the right way to do it: https://paste.openstack.org/show/b9nBdjTHnYpSU5BDNVkB/ ?20:35
opendevreviewMahnoor Asghar proposed openstack/ironic master: [WIP] Create API documentation from docstrings  https://review.opendev.org/c/openstack/ironic/+/82720020:35
jandersI wasn't sure what is the right section here - I thought it may be too much for features20:36
jandersTheJulia JayF iurygregory I figured some of you still may be around :)20:36
iurygregoryI'm20:37
* iurygregory looks20:37
JayF<.< >.> you must have a high perception to have broken my stealth :P20:37
jandersJayF I sensed a disturbance in the Force20:37
JayFjanders: I hate to be a party pooper, but IMO if it takes that much configuration to use; maybe there's a better way to structure it20:38
JayFit sounds awkward written down because configuring it to work that way /is awkward/20:38
JayFthat being said; if that config setup is the way you wanna do it you absolutely communicated it20:38
JayF(it wouldn't be the first feature merged to Ironic that had to be configured in specific awkward ways to work)20:41
jandersJayF Thanks for your feedback. I think there are good reasons to do it like this to start with20:41
JayFYeah; I mean it makes sense; you're just adding it in the hw manager and using existing settings to enable it20:42
JayFit'd be ironic-side changes to make it less complex, or changing defaults20:42
JayFjanders: take my comment as more... wistfully wishing Ironic could be less complex to configure rather than a commentary on this specifically20:42
jandersWe did not want to change the default cleaning behaviour just yet, just give power-users like arne_wiebalck ways to enable this if he wishes to use it20:42
iurygregoryit's worth to mention in some place that you need X,Y,Z configs to have this working, maybe in ironic docs?20:42
jandersiurygregory that is a good idea. Would this be instead the reno upgrade section, or instead of it?20:44
JayFI think the answer is both?20:44
janderssorry 644am on Saturday here20:44
jandershavent had coffee yet20:44
JayFlike, do the release notes then a later follow on to add docs in ironic-proper20:44
JayFgo have a saturday instead of a coffee :D 20:44
JayFIt's 12:45 (midday) where I am, trying to make it to 4pm to get the weekend started :P20:45
jandersI want this change in Yoga, hence going an extra mile20:45
iurygregoryyeah, it's good to mention in the reno you can just add to your paragraph20:45
janders(few more people want it to)20:45
jandersiurygregory so something like this: https://paste.openstack.org/show/bgUUMZuNJmrNn6aSWQbC/ ?20:46
iurygregoryOMG is that the amount of configs we need?20:47
iurygregory=O20:47
JayFiurygregory: that's what I was sayin lol20:48
janderstechnically we only need [conductor]/clean_step_priority_override=deploy.erase_devices_express:520:48
jandersbut then we will run three different cleaning methods20:48
iurygregoryjesus :D 20:48
jandersbifrost sets [deploy]/erase_devices_priority = 0 but this is not a default20:48
janders(just checked)20:48
jandersand Arne asked for [deploy]/enable_nvme_secure_erase and [deploy]/enable_ata_secure_erase to be mentioned specifically20:49
janders(these are the defaults so we can skip them I reckon if you think it's too much)20:49
iurygregoryI wouldn't add to upgrade20:49
JayFmaybe put the configs under features?20:49
JayFsince it's to enable the new feature20:49
JayFthen port these release notes to docs20:49
jandersOK, I can do that20:50
jandersand do we keep all of the configs or trim some?20:50
JayFif someone wants to do this, they'll appreciate the verbosity imo20:50
iurygregory++20:50
jandersOK re-spinning the note20:50
jandershttps://paste.openstack.org/show/bbZF7zSB10zNa8aV4GVm/20:51
jandershow's that?20:51
iurygregorymakes sense, I think we use `` in config options so it will have highlight20:52
jandersjust the option or option+value?20:52
JayF`just puts it in highlighted monospace font`20:53
JayFso I'd do any exact strings that go inside a config file20:53
iurygregoryyeah20:54
jandershttps://paste.openstack.org/show/b65mj8HD0i9TIP2tOFTa/ how about this20:54
opendevreviewRuby Loo proposed openstack/ironic stable/xena: Anaconda deploy handles configdrive correctly  https://review.opendev.org/c/openstack/ironic/+/83341920:56
JayFif double-backtick is right, that lgtm20:56
JayFI thought it was single backtick but my memory of how renos are formatted should not be trusted20:56
JayFas I haven't written one in half a year or more20:56
iurygregoryI think it's single20:56
iurygregoryrunning tox -e releassenotes will tell if is correct 20:57
iurygregoryjanders, for example https://opendev.org/openstack/ironic-python-agent/src/branch/master/releasenotes/notes/add-disk-wait-config-opts-fe805292baca8029.yaml20:57
iurygregoryit's single ` =)20:58
janderstox passed20:58
opendevreviewJacob Anders proposed openstack/ironic-python-agent master: Improve efficiency of storage cleaning in mixed media envs  https://review.opendev.org/c/openstack/ironic-python-agent/+/81871220:59
jandersthanks iurygregory JayF20:59
JayFnp20:59
iurygregoryjanders, yw now go enjoy your weekend =)20:59
TheJuliajanders: can look after lunch21:02
jandersTheJulia no worries, all good21:02
jandershave a good weekend everyone21:02
opendevreviewRuby Loo proposed openstack/ironic stable/xena: Anaconda deploy handles configdrive correctly  https://review.opendev.org/c/openstack/ironic/+/83341921:04
opendevreviewRuby Loo proposed openstack/ironic stable/xena: Anaconda deploy handles configdrive correctly  https://review.opendev.org/c/openstack/ironic/+/83341921:11
opendevreviewRuby Loo proposed openstack/ironic bugfix/20.0: Anaconda deploy handles configdrive correctly  https://review.opendev.org/c/openstack/ironic/+/83342021:15

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!