opendevreview | Merged openstack/ironic-python-agent master: Create fstab entry with appropriate label https://review.opendev.org/c/openstack/ironic-python-agent/+/831029 | 00:40 |
---|---|---|
opendevreview | Merged openstack/networking-baremetal master: Add Python3 zed unit tests https://review.opendev.org/c/openstack/networking-baremetal/+/832575 | 01:09 |
opendevreview | Julia Kreger proposed openstack/ironic-python-agent stable/xena: Create fstab entry with appropriate label https://review.opendev.org/c/openstack/ironic-python-agent/+/833193 | 01:15 |
opendevreview | Jacob Anders proposed openstack/ironic-python-agent master: Improve efficiency of storage cleaning in mixed media envs https://review.opendev.org/c/openstack/ironic-python-agent/+/818712 | 01:15 |
opendevreview | Julia Kreger proposed openstack/ironic-python-agent stable/wallaby: Create fstab entry with appropriate label https://review.opendev.org/c/openstack/ironic-python-agent/+/833194 | 01:15 |
opendevreview | Harald Jensås proposed openstack/networking-baremetal master: WIP - OpenConfig YANG and Netconf https://review.opendev.org/c/openstack/networking-baremetal/+/832268 | 01:40 |
opendevreview | Jacob Anders proposed openstack/ironic-python-agent master: Improve efficiency of storage cleaning in mixed media envs https://review.opendev.org/c/openstack/ironic-python-agent/+/818712 | 02:22 |
opendevreview | Jacob Anders proposed openstack/ironic-python-agent master: Improve efficiency of storage cleaning in mixed media envs https://review.opendev.org/c/openstack/ironic-python-agent/+/818712 | 02:38 |
opendevreview | Merged openstack/ironic stable/wallaby: More fixes for anaconda deploy interface https://review.opendev.org/c/openstack/ironic/+/831852 | 04:36 |
rpittau | good morning ironic! o/ | 07:01 |
MahnoorAsghar | Good morning rpittau | 07:04 |
rpittau | hey MahnoorAsghar :) | 07:05 |
janders | hey rpittau MahnoorAsghar and Ironic o/ | 07:14 |
janders | Happy Friday | 07:14 |
rpittau | Hey janders :) | 07:17 |
rpittau | Happy Friday! | 07:17 |
MahnoorAsghar | Happy Friday ^_^ | 07:18 |
opendevreview | Merged openstack/ironic stable/xena: More fixes for anaconda deploy interface https://review.opendev.org/c/openstack/ironic/+/831851 | 07:21 |
opendevreview | Merged openstack/ironic master: Shorten error messages in commonly used modules https://review.opendev.org/c/openstack/ironic/+/829755 | 07:41 |
kamlesh6808c | Hi , Good Morning Ironic ! | 07:48 |
kamlesh6808c | Dell is working on improving the test coverage in its third-party CI.We are developing Tempest tests to automate much of the testing we have performed manually. | 07:50 |
kamlesh6808c | We are aiming to leverage as much of the existing tests as possible. | 07:51 |
arne_wiebalck | Good morning, Ironic! | 07:51 |
kamlesh6808c | Currently, I am working raid cleaning step tempest implementation, This execution we are performing and testing on physical baremetal servers . | 07:51 |
arne_wiebalck | Good morning rpittau janders MahnoorAsghar kamlesh6808c o/ | 07:52 |
kamlesh6808c | In order to leverage build_raid_and_verify_node method (https://github.com/openstack/ironic-tempest-plugin/blob/37d61a4acf34040c3f4af63a3b2142bfe59d81a1/ironic_tempest_plugin/tests/scenario/baremetal_standalone_manager.py#L580 ) in test cleaning, we are planning to use root device hint as " by path" in order to deploy node (since present hint as “name” doesn’t work on physical BareMetal.) | 07:52 |
kamlesh6808c | iurygregory : Query is, what would be the best possible way ahead or can we use DRACClient in tempest-ironic-plugin to grab virtual disk information which will get generated during runtime of raid create configuration on Servers ? | 07:53 |
kamlesh6808c | Hi arne_wiebalck. | 07:55 |
rpittau | hey arne_wiebalck :) | 08:06 |
opendevreview | Merged openstack/ironic-python-agent stable/xena: Create fstab entry with appropriate label https://review.opendev.org/c/openstack/ironic-python-agent/+/833193 | 08:31 |
opendevreview | Merged openstack/ironic-python-agent stable/wallaby: Create fstab entry with appropriate label https://review.opendev.org/c/openstack/ironic-python-agent/+/833194 | 08:31 |
dtantsur | morning folks | 09:04 |
dtantsur | janders: was going to raise the question of the default step priority :) I think keeping it at 0 is sensible for now. | 09:06 |
opendevreview | Jacob Anders proposed openstack/ironic-python-agent master: Improve efficiency of storage cleaning in mixed media envs https://review.opendev.org/c/openstack/ironic-python-agent/+/818712 | 09:08 |
janders | dtantsur ACK - and thank you. Uploaded a new revision and also testing the IPA to be sure-sure everything runs like it did before with 0 default. | 09:24 |
janders | dtantsur everything still working as expected with def prio 0 - left a comment with test results. | 09:46 |
janders | (no surprises there) | 09:46 |
dtantsur | cool! | 10:17 |
arne_wiebalck | dtantsur: can I pick your brain for a second? we have had the use case of redeploying without erasing some of the disks, no? | 10:26 |
dtantsur | arne_wiebalck: I think "rebuild" only erases the root disk (minus ephemeral partitions) | 10:27 |
arne_wiebalck | dtantsur: right, but one would need to use root device hints to make sure Ironic picks the very same disk, correct? (there is no "this is the current root device" mechanism is my question) | 10:29 |
dtantsur | arne_wiebalck: yeah, I don't think Ironic has this logic | 10:29 |
arne_wiebalck | dtantsur: ok ... and I think rebuild could be given another image (in case one needs this) | 10:32 |
dtantsur | yes | 10:32 |
arne_wiebalck | dtantsur: concrete use case is to move a ceph node from a cluster into a k8s cluster ... while preserving its daya | 10:33 |
arne_wiebalck | *data | 10:33 |
arne_wiebalck | (since I have adopted in production nodes into Ironic, this is now the next level challenge :)) | 10:33 |
arne_wiebalck | dtantsur: maybe some safeguard, like "don't touch disks which match these hints ever" could be useful in situations like this one | 10:36 |
arne_wiebalck | dtantsur: e.g. to exempt some data disks from cleaning | 10:36 |
arne_wiebalck | "don't touch" --> "skip" | 10:37 |
dtantsur | arne_wiebalck: yeah, I think some metal3 people have also floated this idea | 10:37 |
dtantsur | could be useful in some cases | 10:38 |
arne_wiebalck | dtantsur: yes ... I can add this to the "safeguards" project as an extra | 10:38 |
dtantsur | arne_wiebalck: in my opinion, it may be even more important than the cleaning limit, but up to you of course | 10:38 |
arne_wiebalck | dtantsur: it sounds technically easier to do, so we could start with it (as we also have a use case) | 10:39 |
arne_wiebalck | dtantsur: thanks for your brain, you can have it back now :-D | 10:40 |
dtantsur | not much to have, but thank you :D | 10:40 |
arne_wiebalck | heh | 10:40 |
opendevreview | Jacob Anders proposed openstack/ironic-python-agent master: Improve efficiency of storage cleaning in mixed media envs https://review.opendev.org/c/openstack/ironic-python-agent/+/818712 | 11:45 |
janders | ^ oops forgot to re-set default priority to 0 in the test :) | 11:45 |
iurygregory | good morning Ironic, TGIF! | 11:57 |
iurygregory | oh, the person that asked the question is not around anymore | 11:58 |
janders | see you next week Ironic o/ | 12:16 |
janders | have a great weekend everyone | 12:16 |
iurygregory | bye janders | 12:19 |
iurygregory | Ironicers, anyone had a chance to look at http://lists.openstack.org/pipermail/openstack-discuss/2022-March/027647.html ? =) | 12:19 |
opendevreview | Merged openstack/ironic master: Anaconda deploy handles configdrive correctly https://review.opendev.org/c/openstack/ironic/+/827933 | 12:37 |
iurygregory | dtantsur, do you mind if I update https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/828492 ? =) | 12:38 |
dtantsur | iurygregory: not at all (although I'm not sure we need it still) | 12:54 |
iurygregory | gotcha | 12:55 |
dmellado | o/ | 13:21 |
dmellado | dtantsur: not sure if you got a notification, but added you as a speaker | 13:21 |
dtantsur | dmellado: I don't think so.. but maybe it takes time again? | 13:21 |
dmellado | could be... in any case, they acked the change from the org, so no worries | 13:22 |
rpittau | iurygregory: re PTG slots, I guess we need to exclude option A since we excluded Friday ? | 13:23 |
iurygregory | rpittau, in case we really need that 2hrs yes | 13:24 |
rpittau | the other 3 seems all reasonable, although option C may be a bit impractical for US west coast inhabitants | 13:24 |
iurygregory | oh | 13:26 |
iurygregory | let me check | 13:26 |
rpittau | 14:00 UTC is 6:00 Pacific Time | 13:26 |
iurygregory | humm, I was using the previous PTG slots we had so I thought it was ok | 13:27 |
iurygregory | OH GOD | 13:27 |
dtantsur | dmellado: the schedule is not updated, maybe they're processing it manually | 13:27 |
rpittau | iurygregory: actually in Aril that would be 7am PDT, so slightly better | 13:28 |
iurygregory | rpittau, gotcha! | 13:28 |
rpittau | anyway, let's see what others think, maybe we can discuss that during the meeting on Monday | 13:29 |
iurygregory | yeah | 13:30 |
iurygregory | kamlesh6808c, re using DRACClient in ironic-tempest-plugin to grab the information, we need to discuss with the community (feel free to add as topic for next weekly meeting) | 13:33 |
kamlesh6808c | iurygregory : Sure . Thanks | 13:35 |
kamlesh6808c | iurygregory: I have updated agenda of next meeting. | 14:02 |
iurygregory | tks! | 14:02 |
iurygregory | dtantsur, thoughts on https://review.opendev.org/c/openstack/bifrost/+/822895 ? | 14:14 |
iurygregory | the person answered your comment, just wondering if you want something else | 14:15 |
dtantsur | iurygregory: no brainpower for it today :( if you feel like it's worth a +2 - go ahead | 14:22 |
iurygregory | dtantsur, no worries =) rlx o/ | 14:23 |
iurygregory | I will check a few more things | 14:23 |
iurygregory | we are not in a hurry anyway =) | 14:23 |
iurygregory | and it's friday so take it slow =) | 14:23 |
dtantsur | yeah :) it's enough that I have to debug kuber :) | 14:27 |
iurygregory | ++ | 14:31 |
TheJulia | good morning | 14:40 |
iurygregory | good morning TheJulia | 14:43 |
dtantsur | morning TheJulia | 14:59 |
dtantsur | we lived to see another Friday! | 14:59 |
TheJulia | \o/ | 14:59 |
opendevreview | Merged openstack/bifrost master: Add `./bifrost-cli deploy` and refactor bifrost-deploy-nodes-dynamic https://review.opendev.org/c/openstack/bifrost/+/829517 | 15:01 |
opendevreview | Merged openstack/bifrost master: Update inventory format documentation with more details https://review.opendev.org/c/openstack/bifrost/+/829748 | 15:01 |
iurygregory | TheJulia, re networking-baremetal release, only after the final yoga release based on the release meeting | 15:12 |
opendevreview | Dmitry Tantsur proposed openstack/bifrost master: Trivial: fix my arithmetic https://review.opendev.org/c/openstack/bifrost/+/833382 | 15:12 |
dtantsur | rpittau, iurygregory ^^ | 15:12 |
TheJulia | iurygregory: that is insane | 15:12 |
TheJulia | like, wtaf | 15:12 |
iurygregory | TheJulia, because it was only tests that were broken | 15:12 |
TheJulia | uhh... I think it was more than just the tests | 15:13 |
TheJulia | oh wait | 15:13 |
* TheJulia looks for the failed job | 15:13 | |
iurygregory | dtantsur, LOL for the commit message | 15:13 |
dtantsur | well :) | 15:13 |
iurygregory | TheJulia, well in the patch we only fixed tests https://review.opendev.org/c/openstack/networking-baremetal/+/832858 | 15:14 |
iurygregory | and the configuration of the job... | 15:14 |
TheJulia | okay yeah, the the integation job looks like it mostly worked | 15:15 |
TheJulia | yeah, the only exception neutron recorded was with callbacks from nova | 15:16 |
TheJulia | nevermind | 15:17 |
dtantsur | looking for a 2nd +2 on https://review.opendev.org/c/openstack/ironic/+/826930 please | 15:18 |
iurygregory | looking | 15:19 |
TheJulia | what about case missmatches | 15:23 |
opendevreview | Verification of a change to openstack/bifrost master failed: Remove questionable defaults from the network configuration https://review.opendev.org/c/openstack/bifrost/+/829754 | 15:24 |
TheJulia | I guess the risk is lowish | 15:25 |
opendevreview | Merged openstack/bifrost master: Make ironic and inspector listen on Unix sockets https://review.opendev.org/c/openstack/bifrost/+/827128 | 15:46 |
rpittau | bye everyone have a great weekend! o/ | 15:52 |
dtantsur | iurygregory: re slots: I'd go with option A, having Friday as more of a backup. | 16:01 |
dtantsur | 18:00 UTC is a bit late for Europe, especially eastern | 16:01 |
dtantsur | and I'd prefer you not having to skip Monday :) | 16:01 |
iurygregory | yeah | 16:04 |
iurygregory | from 14-16 there is the PTL interaction, I'm also ok if people want to start a discussion and I can join the last hour 16-17 | 16:05 |
iurygregory | oh one thing we can also do would be record the PTG discussions (there is an option for that) | 16:06 |
dtantsur | I hope we don't really need all 16 hours, to be honest. that's a lot. | 16:06 |
iurygregory | yeah, like it would be 12 in the EMEA time mostly | 16:07 |
arne_wiebalck | bye everyone, see you next week o/ | 17:16 |
dtantsur | have a great weekend o/ | 17:29 |
opendevreview | Merged openstack/ironic master: Support img_type Glance property https://review.opendev.org/c/openstack/ironic/+/826930 | 17:31 |
opendevreview | Merged openstack/bifrost master: Trivial: fix my arithmetic https://review.opendev.org/c/openstack/bifrost/+/833382 | 19:29 |
opendevreview | Merged openstack/ironic-python-agent bugfix/8.3: Use utf-16-le if BOM not present https://review.opendev.org/c/openstack/ironic-python-agent/+/831584 | 20:11 |
opendevreview | Merged openstack/ironic-python-agent master: Add non-voting dib CentOS Stream 9 job https://review.opendev.org/c/openstack/ironic-python-agent/+/832947 | 20:11 |
janders | I have a release note convention question if anyone is still around | 20:34 |
janders | addressing this comment: https://review.opendev.org/c/openstack/ironic-python-agent/+/818712/21/releasenotes/notes/add-erase-devices-express-1df107c75f2b3627.yaml from arne_wiebalck (thanks!) | 20:35 |
janders | Is this the right way to do it: https://paste.openstack.org/show/b9nBdjTHnYpSU5BDNVkB/ ? | 20:35 |
opendevreview | Mahnoor Asghar proposed openstack/ironic master: [WIP] Create API documentation from docstrings https://review.opendev.org/c/openstack/ironic/+/827200 | 20:35 |
janders | I wasn't sure what is the right section here - I thought it may be too much for features | 20:36 |
janders | TheJulia JayF iurygregory I figured some of you still may be around :) | 20:36 |
iurygregory | I'm | 20:37 |
* iurygregory looks | 20:37 | |
JayF | <.< >.> you must have a high perception to have broken my stealth :P | 20:37 |
janders | JayF I sensed a disturbance in the Force | 20:37 |
JayF | janders: I hate to be a party pooper, but IMO if it takes that much configuration to use; maybe there's a better way to structure it | 20:38 |
JayF | it sounds awkward written down because configuring it to work that way /is awkward/ | 20:38 |
JayF | that being said; if that config setup is the way you wanna do it you absolutely communicated it | 20:38 |
JayF | (it wouldn't be the first feature merged to Ironic that had to be configured in specific awkward ways to work) | 20:41 |
janders | JayF Thanks for your feedback. I think there are good reasons to do it like this to start with | 20:41 |
JayF | Yeah; I mean it makes sense; you're just adding it in the hw manager and using existing settings to enable it | 20:42 |
JayF | it'd be ironic-side changes to make it less complex, or changing defaults | 20:42 |
JayF | janders: take my comment as more... wistfully wishing Ironic could be less complex to configure rather than a commentary on this specifically | 20:42 |
janders | We did not want to change the default cleaning behaviour just yet, just give power-users like arne_wiebalck ways to enable this if he wishes to use it | 20:42 |
iurygregory | it's worth to mention in some place that you need X,Y,Z configs to have this working, maybe in ironic docs? | 20:42 |
janders | iurygregory that is a good idea. Would this be instead the reno upgrade section, or instead of it? | 20:44 |
JayF | I think the answer is both? | 20:44 |
janders | sorry 644am on Saturday here | 20:44 |
janders | havent had coffee yet | 20:44 |
JayF | like, do the release notes then a later follow on to add docs in ironic-proper | 20:44 |
JayF | go have a saturday instead of a coffee :D | 20:44 |
JayF | It's 12:45 (midday) where I am, trying to make it to 4pm to get the weekend started :P | 20:45 |
janders | I want this change in Yoga, hence going an extra mile | 20:45 |
iurygregory | yeah, it's good to mention in the reno you can just add to your paragraph | 20:45 |
janders | (few more people want it to) | 20:45 |
janders | iurygregory so something like this: https://paste.openstack.org/show/bgUUMZuNJmrNn6aSWQbC/ ? | 20:46 |
iurygregory | OMG is that the amount of configs we need? | 20:47 |
iurygregory | =O | 20:47 |
JayF | iurygregory: that's what I was sayin lol | 20:48 |
janders | technically we only need [conductor]/clean_step_priority_override=deploy.erase_devices_express:5 | 20:48 |
janders | but then we will run three different cleaning methods | 20:48 |
iurygregory | jesus :D | 20:48 |
janders | bifrost sets [deploy]/erase_devices_priority = 0 but this is not a default | 20:48 |
janders | (just checked) | 20:48 |
janders | and Arne asked for [deploy]/enable_nvme_secure_erase and [deploy]/enable_ata_secure_erase to be mentioned specifically | 20:49 |
janders | (these are the defaults so we can skip them I reckon if you think it's too much) | 20:49 |
iurygregory | I wouldn't add to upgrade | 20:49 |
JayF | maybe put the configs under features? | 20:49 |
JayF | since it's to enable the new feature | 20:49 |
JayF | then port these release notes to docs | 20:49 |
janders | OK, I can do that | 20:50 |
janders | and do we keep all of the configs or trim some? | 20:50 |
JayF | if someone wants to do this, they'll appreciate the verbosity imo | 20:50 |
iurygregory | ++ | 20:50 |
janders | OK re-spinning the note | 20:50 |
janders | https://paste.openstack.org/show/bbZF7zSB10zNa8aV4GVm/ | 20:51 |
janders | how's that? | 20:51 |
iurygregory | makes sense, I think we use `` in config options so it will have highlight | 20:52 |
janders | just the option or option+value? | 20:52 |
JayF | `just puts it in highlighted monospace font` | 20:53 |
JayF | so I'd do any exact strings that go inside a config file | 20:53 |
iurygregory | yeah | 20:54 |
janders | https://paste.openstack.org/show/b65mj8HD0i9TIP2tOFTa/ how about this | 20:54 |
opendevreview | Ruby Loo proposed openstack/ironic stable/xena: Anaconda deploy handles configdrive correctly https://review.opendev.org/c/openstack/ironic/+/833419 | 20:56 |
JayF | if double-backtick is right, that lgtm | 20:56 |
JayF | I thought it was single backtick but my memory of how renos are formatted should not be trusted | 20:56 |
JayF | as I haven't written one in half a year or more | 20:56 |
iurygregory | I think it's single | 20:56 |
iurygregory | running tox -e releassenotes will tell if is correct | 20:57 |
iurygregory | janders, for example https://opendev.org/openstack/ironic-python-agent/src/branch/master/releasenotes/notes/add-disk-wait-config-opts-fe805292baca8029.yaml | 20:57 |
iurygregory | it's single ` =) | 20:58 |
janders | tox passed | 20:58 |
opendevreview | Jacob Anders proposed openstack/ironic-python-agent master: Improve efficiency of storage cleaning in mixed media envs https://review.opendev.org/c/openstack/ironic-python-agent/+/818712 | 20:59 |
janders | thanks iurygregory JayF | 20:59 |
JayF | np | 20:59 |
iurygregory | janders, yw now go enjoy your weekend =) | 20:59 |
TheJulia | janders: can look after lunch | 21:02 |
janders | TheJulia no worries, all good | 21:02 |
janders | have a good weekend everyone | 21:02 |
opendevreview | Ruby Loo proposed openstack/ironic stable/xena: Anaconda deploy handles configdrive correctly https://review.opendev.org/c/openstack/ironic/+/833419 | 21:04 |
opendevreview | Ruby Loo proposed openstack/ironic stable/xena: Anaconda deploy handles configdrive correctly https://review.opendev.org/c/openstack/ironic/+/833419 | 21:11 |
opendevreview | Ruby Loo proposed openstack/ironic bugfix/20.0: Anaconda deploy handles configdrive correctly https://review.opendev.org/c/openstack/ironic/+/833420 | 21:15 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!