opendevreview | Steve Baker proposed openstack/python-ironicclient master: Avoid using 'foo' as invalid JSON test data https://review.opendev.org/c/openstack/python-ironicclient/+/831327 | 00:46 |
---|---|---|
stevebaker[m] | This change would be a very easy review for someone ^^ | 00:48 |
opendevreview | Jacob Anders proposed openstack/sushy master: Attempt using Redfish settings resource to get URI https://review.opendev.org/c/openstack/sushy/+/830553 | 01:36 |
opendevreview | Jacob Anders proposed openstack/sushy master: Attempt using Redfish settings resource to get URI https://review.opendev.org/c/openstack/sushy/+/830553 | 01:38 |
*** pmannidi is now known as pmannidi|Lunch | 04:06 | |
*** pmannidi|Lunch is now known as pmannidi | 04:55 | |
opendevreview | Jacob Anders proposed openstack/sushy master: Re-trying InsertMedia call with TransferProtocolType if required https://review.opendev.org/c/openstack/sushy/+/830322 | 06:20 |
rpittau | good morning ironic! o/ | 07:54 |
arne_wiebalck | Good morning, rpittau and Ironic! | 08:09 |
rpittau | hey arne_wiebalck :) | 08:09 |
opendevreview | Roman Popelka proposed openstack/ironic-tempest-plugin master: Ironic scenario manager cleanup https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/831159 | 08:31 |
dtantsur | o/ | 08:47 |
rpittau | hey dtantsur :) | 08:48 |
opendevreview | Roman Popelka proposed openstack/ironic-tempest-plugin master: Ironic scenario manager cleanup https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/831160 | 08:51 |
opendevreview | Dmitry Tantsur proposed openstack/ironic master: [Trivial] Fix formatting in troubleshooting docs https://review.opendev.org/c/openstack/ironic/+/831348 | 09:23 |
opendevreview | Jacob Anders proposed openstack/sushy master: Re-trying InsertMedia call with TransferProtocolType if required https://review.opendev.org/c/openstack/sushy/+/830322 | 09:53 |
opendevreview | Merged openstack/sushy master: Attempt using Redfish settings resource to get URI https://review.opendev.org/c/openstack/sushy/+/830553 | 09:53 |
opendevreview | Jacob Anders proposed openstack/sushy master: Re-trying InsertMedia call with TransferProtocolType if required https://review.opendev.org/c/openstack/sushy/+/830322 | 09:55 |
opendevreview | Dmitry Tantsur proposed openstack/ironic master: Troubleshooting guide: node locked error https://review.opendev.org/c/openstack/ironic/+/831351 | 10:00 |
dtantsur | I'm surprised we don't have ^^^ yet | 10:00 |
dtantsur | arne_wiebalck: as an operator, you review is very welcome ^^^ | 10:01 |
MahnoorAsghar | o/ | 10:08 |
arne_wiebalck | dtantsur: uh, that is awesome, thanks! | 10:14 |
arne_wiebalck | dtantsur: I was just having one of these yesterday or so. | 10:14 |
arne_wiebalck | dtantsur: from what I remember, there are situations where a conductor restart is necessary to release the lock, no? | 10:15 |
dtantsur | arne_wiebalck: if it's hopelessly stuck, yes. I think we cover it somewhere in the same document though. | 10:15 |
arne_wiebalck | dtantsur: maybe good to reference it as a last resort with warning signs around it | 10:16 |
dtantsur | yeah, lemme do it | 10:16 |
arne_wiebalck | dtantsur: cool, thanks! | 10:16 |
opendevreview | Dmitry Tantsur proposed openstack/ironic master: Troubleshooting guide: node locked error https://review.opendev.org/c/openstack/ironic/+/831351 | 10:21 |
dtantsur | arne_wiebalck: ^^ | 10:21 |
opendevreview | Jacob Anders proposed openstack/sushy master: Follow up to Attempt using Redfish settings resource to get URI https://review.opendev.org/c/openstack/sushy/+/831355 | 10:32 |
opendevreview | Dmitry Tantsur proposed openstack/ironic master: Troubleshooting guide: node locked error https://review.opendev.org/c/openstack/ironic/+/831351 | 10:44 |
iurygregory | good morning Ironic o/ | 11:31 |
janders | hey iurygregory o/ | 11:33 |
iurygregory | o/ | 11:33 |
TheJulia | good morning | 14:05 |
dtantsur | morning TheJulia | 14:10 |
* arne_wiebalck moved our Ironic deployment to Secure RBAC ... kind of | 14:23 | |
iurygregory | good morning TheJulia | 14:26 |
rpittau | good morning TheJulia :) | 14:26 |
arne_wiebalck | system_scope not enforced, but new defaults plus yaml instead of json | 14:34 |
TheJulia | yaml override policies? | 14:46 |
arne_wiebalck | yep | 15:03 |
opendevreview | Mahnoor Asghar proposed openstack/ironic master: [WIP] Create API documentation from docstrings https://review.opendev.org/c/openstack/ironic/+/827200 | 15:04 |
arne_wiebalck | we have the hardware colleagues which need access to the API without being OpenStack wide admins | 15:05 |
arne_wiebalck | this is one of the things we define there | 15:05 |
rloo | arne_wiebalck: ditto with us. On my list to use secure RBAC too. Any gotchas? | 15:06 |
arne_wiebalck | rloo: we have nova use a specific account in project scope, we needed to account for this (I did not want to change Ironic and Nova at the same time) | 15:08 |
arne_wiebalck | rloo: moving to system scope may also need some coordination between various projects in our deployment, so this has been postponed | 15:08 |
arne_wiebalck | rloo: if there are multiple policy files, like an old yaml, this can create confusion | 15:09 |
rloo | arne_wiebalck: thx, good to know! | 15:09 |
arne_wiebalck | rloo: equally, if you start with a generated one which was created before TheJulia 's patch to the oslo sample generator | 15:09 |
arne_wiebalck | rloo: a generated policy file | 15:09 |
opendevreview | Merged openstack/ironic master: Add more sources to redfish firmware upgrade https://review.opendev.org/c/openstack/ironic/+/822781 | 15:10 |
rloo | we have policy files from ocata... | 15:10 |
arne_wiebalck | rloo: some rules are only in code (by design), but this did not fit with us, so I touched this as well :) | 15:10 |
opendevreview | Merged openstack/ironic master: Add known issue for iDRAC Swift firmware update https://review.opendev.org/c/openstack/ironic/+/822782 | 15:10 |
arne_wiebalck | rloo: as these cannot be overridden from what I saw, e.g. list_all is system scope | 15:11 |
arne_wiebalck | rloo: there is also an issue with relying on default rules, at least for us | 15:11 |
rloo | hmm, the rules in code will be the hard ones to get around, err, i mean deal with. ha ha. | 15:11 |
arne_wiebalck | rloo: somehow the code was falling back to the old defaults, so I put the new defaults in the file | 15:12 |
rloo | that... doesn't sound good. | 15:12 |
arne_wiebalck | rloo: but then oslo complained these are redundant, so I removed them, which made it fall back on the old ones ... | 15:12 |
rloo | sigh | 15:13 |
arne_wiebalck | rloo: in the end, I slightly modified the rule, so it looks new and not default and everyone is happy :-D | 15:13 |
rloo | which release? I'm looking at using it in wallaby. | 15:13 |
arne_wiebalck | rloo: I would recommend a lot of testing | 15:13 |
arne_wiebalck | rloo: our nova (stein) removes nodes when access to Ironic is denied, this is why I tried to be cautious | 15:14 |
arne_wiebalck | rloo: this is all on wallaby for Ironic | 15:14 |
rloo | oh right, you had mentioned that about nova, before. | 15:14 |
arne_wiebalck | rloo: no Ironic is ok, but permission denied removes nodes ... which kind of makes sense | 15:14 |
rloo | we're using all wallaby... | 15:15 |
arne_wiebalck | rloo: but is no fun when it removes a few thousand nodes and their allocations | 15:15 |
rloo | yeah, no fun removing one, let alone thousands. sigh. | 15:15 |
arne_wiebalck | rloo: after stein, nova has a tool to fix the allocations ... but our nova is just too old for this | 15:16 |
arne_wiebalck | rloo: the good thing is, we should be able to give projects now access to see "their" nodes | 15:16 |
arne_wiebalck | rloo: even if not instantiated | 15:17 |
rloo | yeah, that'll be awesome. | 15:17 |
TheJulia | arne_wiebalck: did you file a bug against oslo.policy for the duplicate complaint? | 16:40 |
arne_wiebalck | TheJulia: not yet, I will try to reproduce this in our qa env and if I can file a bug | 16:43 |
TheJulia | arne_wiebalck: okay, I spoke with some or our folks about it yesterday and the issue I was looking at last week. I think we may end up having to head in a little different of a path or several paths simultaneously | 16:44 |
TheJulia | but, To be determined | 16:44 |
arne_wiebalck | TheJulia: with regards to policy generation and deprecated policies? | 16:48 |
TheJulia | arne_wiebalck: yes | 16:52 |
TheJulia | since there is a feature expected for horizon translation | 16:53 |
opendevreview | Julia Kreger proposed openstack/sushy master: Fix session authentication issues https://review.opendev.org/c/openstack/sushy/+/821324 | 17:24 |
rpittau | good night! o/ | 17:32 |
TheJulia | goodnight rpittau | 17:32 |
arne_wiebalck | TheJulia: seems I can reproduce in qa, I have filed https://bugs.launchpad.net/oslo.policy/+bug/1962602 now | 17:38 |
TheJulia | arne_wiebalck: thanks | 17:39 |
arne_wiebalck | bye everyone o/ | 18:02 |
opendevreview | Radosław Piliszek proposed openstack/tenks master: [CI] Stop overriding default python https://review.opendev.org/c/openstack/tenks/+/831434 | 18:37 |
opendevreview | Radosław Piliszek proposed openstack/tenks master: [WIP] Add Debian support https://review.opendev.org/c/openstack/tenks/+/830675 | 18:37 |
opendevreview | Radosław Piliszek proposed openstack/tenks master: [WIP] Add Debian support https://review.opendev.org/c/openstack/tenks/+/830675 | 18:53 |
dtantsur | o/ | 19:00 |
janders | good morning Ironic o/ | 20:11 |
TheJulia | janders: your up early | 20:12 |
TheJulia | And good morning! | 20:12 |
janders | hey TheJulia :) | 20:12 |
janders | yes I am :) | 20:12 |
janders | looking for a second review for https://review.opendev.org/c/openstack/sushy/+/831355 (it's a very small/simple patch) if anyone has time | 20:13 |
TheJulia | I can likely take a look in a little bit | 20:13 |
janders | thank you :) | 20:15 |
TheJulia | janders: shoudl we have a unit test enhancement to ensure that on a empty response we still have saved an etag? | 20:16 |
janders | (just refreshing my memory of how it was done prior to my changes) | 20:23 |
*** dtantsur_ is now known as dtantsur | 20:24 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!