Tuesday, 2022-02-22

*** pmannidi is now known as pmannidi|Away00:03
opendevreviewVerification of a change to openstack/ironic-lib stable/xena failed: Add platform:base-py[2|3] to bindep  https://review.opendev.org/c/openstack/ironic-lib/+/83020100:21
arne_wiebalckGood morning, Ironic!07:21
rpittaugood morning ironic! o/07:34
opendevreviewRiccardo Pittau proposed openstack/ironic-python-agent master: Determine codec based on sytem endianness  https://review.opendev.org/c/openstack/ironic-python-agent/+/83026407:41
fmuyassarovHello folks. We would like to disabled usage of TLSv1_1, and TLSv1_2 in Ironic conductor and instead use TLSv1_3. Setting [ssl]_version to TLSv1_3 doesn't seem to block 1_0 and 1_1. How can we disable TLS versions prior to 1.3?07:49
opendevreviewHarald Jensås proposed openstack/ironic-lib master: Remove python version 2 pkgs from bindep  https://review.opendev.org/c/openstack/ironic-lib/+/83031907:50
jandersGood Morning arne_wiebalck rpittau fmuyassarov and Ironic o/07:55
rpittauhey janders :)07:57
fmuyassarovgood morning janders 07:58
opendevreviewJacob Anders proposed openstack/sushy master: Re-trying InsertMedia call with TransferProtocolType if required  https://review.opendev.org/c/openstack/sushy/+/83032208:25
opendevreviewJacob Anders proposed openstack/sushy master: Re-trying InsertMedia call with TransferProtocolType if required  https://review.opendev.org/c/openstack/sushy/+/83032208:28
dtantsurmorning folks08:54
dtantsurfmuyassarov: I wonder if switching to the combined ironic process will make this problem no longer important08:55
dtantsuror do you use a multi-conductor setup?08:55
arne_wiebalckhey janders rpittau fmuyassarov dtantsur o/09:17
rpittauhey arne_wiebalck :)09:18
MahnoorAsgharGood morning Ironic09:48
opendevreviewMerged openstack/tenks master: [CI] Optimise irrelevant files  https://review.opendev.org/c/openstack/tenks/+/83027209:58
opendevreviewAija Jauntēva proposed openstack/ironic master: Update python-dracclient version  https://review.opendev.org/c/openstack/ironic/+/83034810:38
iurygregorygood morning Ironic o/10:52
dtantsurmorning iurygregory 10:56
dtantsurfolks, another fallout from the CI refactoring: https://review.opendev.org/c/openstack/ironic-python-agent/+/829719 (needed to fix the IPA CI)10:56
opendevreviewDmitry Tantsur proposed openstack/ironic stable/xena: Build the new cirros image even when netboot is the default  https://review.opendev.org/c/openstack/ironic/+/83035210:58
opendevreviewDmitry Tantsur proposed openstack/ironic stable/wallaby: Build the new cirros image even when netboot is the default  https://review.opendev.org/c/openstack/ironic/+/83035310:58
opendevreviewDmitry Tantsur proposed openstack/ironic stable/victoria: Build the new cirros image even when netboot is the default  https://review.opendev.org/c/openstack/ironic/+/83035410:58
opendevreviewDmitry Tantsur proposed openstack/ironic bugfix/19.0: Build the new cirros image even when netboot is the default  https://review.opendev.org/c/openstack/ironic/+/83035510:58
opendevreviewMerged openstack/ironic-lib stable/xena: Add platform:base-py[2|3] to bindep  https://review.opendev.org/c/openstack/ironic-lib/+/83020111:07
arne_wiebalckis it correct that the sample policy we produce has the same target multiple times? https://docs.openstack.org/ironic/latest/configuration/sample-policy.html11:12
* dtantsur has no clue11:16
arne_wiebalckit seems wrong to have a target specified multiple times as FWIU these will go into a hash and the last one wins11:31
arne_wiebalckTheJulia: ^^11:32
opendevreviewDmitry Tantsur proposed openstack/ironic-python-agent stable/xena: Stop defaulting the standalone job to netboot; use the correct boot mode  https://review.opendev.org/c/openstack/ironic-python-agent/+/82972111:32
opendevreviewDmitry Tantsur proposed openstack/ironic-python-agent bugfix/8.4: Stop defaulting the standalone job to netboot; use the correct boot mode  https://review.opendev.org/c/openstack/ironic-python-agent/+/83035611:33
opendevreviewDmitry Tantsur proposed openstack/ironic-python-agent bugfix/8.3: Stop defaulting the standalone job to netboot; use the correct boot mode  https://review.opendev.org/c/openstack/ironic-python-agent/+/82972211:33
dtantsurso many backports to do...11:33
opendevreviewDmitry Tantsur proposed openstack/ironic-python-agent master: [WIP] Create mount points before mounting  https://review.opendev.org/c/openstack/ironic-python-agent/+/82906711:42
opendevreviewDmitry Tantsur proposed openstack/ironic-python-agent master: [WIP] Create mount points before mounting  https://review.opendev.org/c/openstack/ironic-python-agent/+/82906711:43
dtantsurrpittau: FYI the job change in https://opendev.org/openstack/ironic/commit/be0ebde0107e1addff5b4bb96d038f8bb804224f is wrong, we need to revert it11:50
dtantsuror at least apply something different to ironic, I'll check it11:51
opendevreviewDmitry Tantsur proposed openstack/ironic bugfix/18.1: CI: use a custom cirros partition image instead of the default  https://review.opendev.org/c/openstack/ironic/+/82967811:52
dtantsurrpittau: maybe like this ^^^11:52
opendevreviewDmitry Tantsur proposed openstack/ironic bugfix/18.1: CI: use a custom cirros partition image instead of the default  https://review.opendev.org/c/openstack/ironic/+/82967811:55
rpittaudtantsur: I'll check that after lunch, wasn't that working before?11:56
dtantsurrpittau: well, it was silently using stable/xena instead of the patch in question :)11:56
opendevreviewDmitry Tantsur proposed openstack/ironic-inspector master: DNM test the CI  https://review.opendev.org/c/openstack/ironic-inspector/+/83039712:00
rpittauApplying bugfix 18.1 to ironic should work12:01
rpittauAs it's done for ipa12:01
rpittauAnyway, I need a bigger screen for that than my phone's :)12:02
dtantsur:D12:06
opendevreviewJacob Anders proposed openstack/sushy master: Re-trying InsertMedia call with TransferProtocolType if required  https://review.opendev.org/c/openstack/sushy/+/83032212:14
opendevreviewVerification of a change to openstack/ironic-python-agent master failed: Stop defaulting the standalone job to netboot; use the correct boot mode  https://review.opendev.org/c/openstack/ironic-python-agent/+/82971913:00
iurygregoryreally zuul? =(13:03
dtantsuryeaah :(13:05
dtantsurhonestly, I would like to stop hacking on the CI at some point this week :D I have job to do13:05
opendevreviewMerged openstack/python-ironic-inspector-client master: Ensure tox.ini is ASCII  https://review.opendev.org/c/openstack/python-ironic-inspector-client/+/82983013:16
TheJuliais zuul needing cookies?13:40
dtantsuralways13:41
TheJulia:)13:41
opendevreviewJulia Kreger proposed openstack/ironic-python-agent-builder stable/wallaby: Use native Centos 8 Stream for dib images  https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/83035814:07
* TheJulia hopes that clears up CI issues for stable/wallaby14:14
opendevreviewRiccardo Pittau proposed openstack/ironic master: [WIP] Use pycdlib to extract deploy iso  https://review.opendev.org/c/openstack/ironic/+/81912114:25
arne_wiebalckTheJulia: is it correct that the sample policy we produce has the same targets multiple times? https://docs.openstack.org/ironic/latest/configuration/sample-policy.html (e.g. "baremetal:node:get")14:27
TheJuliaarne_wiebalck: so we added some new policy targets, and the fallback is baremetal:node:get in the deprecated set14:46
TheJuliasince there was no *real* way to delineate it for previous usage14:47
arne_wiebalckTheJulia: right, but this is not new targets, it is the same target defined multiple times14:47
arne_wiebalcklike "baremetal:node:get" is defined multiple times as a target with several rules14:48
opendevreviewRiccardo Pittau proposed openstack/ironic master: [WIP] Use pycdlib to extract deploy iso  https://review.opendev.org/c/openstack/ironic/+/81912114:48
TheJuliaarne_wiebalck: all deprecated14:48
TheJuliaso yes, it does look like it doesn't de-deuplicate deprecated rules14:48
arne_wiebalckthe not commented lines in the policy file are used, no?14:49
TheJuliaI wonder if it is "parent_rule": "current_rule" sort of relationship14:51
TheJuliasame thing occurs with baremetal:node:update\14:51
arne_wiebalckand with others ...14:51
TheJuliaif commented out, it is the default14:51
arne_wiebalckright14:51
TheJuliawell, if freshly generated, it is all the default14:51
TheJulia:)14:51
arne_wiebalckisn't https://docs.openstack.org/ironic/latest/configuration/sample-policy.html what would be generated?14:52
arne_wiebalckor where does that come from?14:52
TheJuliait is generated from the code14:52
arne_wiebalckright14:53
* TheJulia wonders if the deprecated rule enumeration just renders confusing output14:53
arne_wiebalckis it only confusing or actually wrong?14:54
opendevreviewRiccardo Pittau proposed openstack/ironic-python-agent master: Use utf-16-le if BOM not present  https://review.opendev.org/c/openstack/ironic-python-agent/+/83026414:54
arne_wiebalckoslo does not complain about a target defined multiple times14:55
TheJuliaI'm starting to think the rendered output is actually wrong14:55
TheJuliain part because we had to add rules14:56
TheJuliaarne_wiebalck: when your generating, are you passing any options and do have enforce_scope and enforce_new_defaults in your config?14:56
arne_wiebalckTheJulia: we started with a policy file generated with tox IIRC15:00
TheJuliaokay, that gives me a starting point15:00
arne_wiebalckit is basically the policy sample we have in the docs15:01
opendevreviewMerged openstack/ironic stable/xena: Build the new cirros image even when netboot is the default  https://review.opendev.org/c/openstack/ironic/+/83035215:17
TheJuliaarne_wiebalck: https://bugs.launchpad.net/oslo.policy/+bug/1945336 sound familiar? 16:21
arne_wiebalckTheJulia: boom16:21
arne_wiebalckTheJulia: I think that is it.16:22
TheJuliahttps://bugs.launchpad.net/oslo.policy/+bug/1870187 makes me sad16:22
arne_wiebalckuh, that would have been nice to know :)16:25
arne_wiebalckinstead of starting from the (buggy) sample file, we could have had one with our overrides16:27
TheJuliayeah, so tripleo is just starting with outright overrides, fwiw16:27
TheJuliabut we have the expertise to handle that16:27
* TheJulia tries to trigger an internal discussion regarding oslo policy16:28
arne_wiebalckI wonder if the policy generator has the same bug as the sample generator.16:29
arne_wiebalckit seems likely16:29
TheJuliayeah16:29
opendevreviewMerged openstack/ironic bugfix/19.0: Build the new cirros image even when netboot is the default  https://review.opendev.org/c/openstack/ironic/+/83035516:31
TheJuliaarne_wiebalck: yeah, same code, just slightly different entry points16:33
arne_wiebalcknot surprising16:33
arne_wiebalckthe sample policy file has 1400 lines and I guess many will start from it16:34
TheJuliayeah16:35
TheJuliaI'm reading the generator code now16:35
opendevreviewMerged openstack/ironic bugfix/18.1: CI: use a custom cirros partition image instead of the default  https://review.opendev.org/c/openstack/ironic/+/82967816:41
TheJuliaoh wow, the way it displays deprecated rules is awful16:41
TheJuliait is in format of "old_rule_name": "new_rule_name"16:43
TheJuliatalk about confusing16:44
arne_wiebalckheh16:48
arne_wiebalckthere is another thing: unless I define some of the *default* rules explicitly, e.g. for "baremetal:node:list" I get deprecation warnings16:52
arne_wiebalckbut if I add them, I get "this rule is redundant" warnings16:52
TheJuliayeah, I'm staring at the code trying to think how to cleanly solve this16:54
TheJuliaI *think* the first thing is to just strip deprecated rules by default16:56
arne_wiebalckyou're looking at the oslo generator code?16:57
TheJuliayes16:58
arne_wiebalckyeah ... one thing I did at some point was to remove all comments, so I could actually read the policy file17:01
TheJuliayeah17:01
TheJuliaI'm working on a change to by default comment this stuff out17:02
TheJuliasince it is inherently wrong if the names have changed17:02
TheJuliaarne_wiebalck: how does https://paste.openstack.org/show/812868/ look?17:06
arne_wiebalckTheJulia: thanks! There seems a 'defined' or 'introduced' missing. Also: how about not using the 'target':'rule' format for a rule replacement ... or is there any reason for this?17:10
* arne_wiebalck will step away for a moment17:12
TheJuliaso, I don't know the reason behind target:rule17:13
TheJuliaor in this case, deprecated target:rule17:13
TheJuliaI think I'm going to have to document some stuff based upon code state17:13
rpittaugood night! o/17:13
opendevreviewVerification of a change to openstack/ironic stable/wallaby failed: Build the new cirros image even when netboot is the default  https://review.opendev.org/c/openstack/ironic/+/83035317:14
arne_wiebalcktarget:rule is fine, I just find that deprecated target:rule does not make any sense ... or does it?17:17
* arne_wiebalck really steps away :)17:17
opendevreviewMerged openstack/ironic-python-agent-builder stable/xena: Create random character devices so systemd does not crash  https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/83020017:19
TheJuliaoh, I think I see what is going on17:19
TheJuliaartifact of someone trying to keep explicit policy files a thing after policy in code was a thinh17:19
* TheJulia seeks clarifcation and sees the person's irc client has been idle for over 64 hours17:20
dtantsursee you tomorrow folks o/17:33
arne_wiebalckTheJulia: this is for the above bug about deprecated rules marked active ?17:59
TheJuliawell, I'm trying to decipher intent18:00
TheJuliabut basically yes as well18:00
arne_wiebalckright, it seems intertwined18:00
TheJuliaIndeed18:01
TheJuliaI *feel* like the intent was more to help map for version compatability18:01
TheJuliabut at the same time, we shouldn't be publishing a bunch of deprecated things in latest18:02
opendevreviewMerged openstack/ironic-python-agent master: Stop defaulting the standalone job to netboot; use the correct boot mode  https://review.opendev.org/c/openstack/ironic-python-agent/+/82971918:04
arne_wiebalckyes, the idea was to help understand what changed18:04
arne_wiebalckfixing the missing comment but should have priority imo18:06
TheJuliaI'm just going to do it as an all in one change and see what the reviewer ssay18:07
arne_wiebalckcomments are easily ignored ... but with this rules active, it gets really confusing :-D18:07
TheJuliasince this is a bit confusing/insane18:07
arne_wiebalcktotally18:07
arne_wiebalckthanks for picking this up, TheJulia 18:08
arne_wiebalckbye everyone o/18:37
opendevreviewMerged openstack/ironic stable/victoria: Build the new cirros image even when netboot is the default  https://review.opendev.org/c/openstack/ironic/+/83035418:43
TheJuliaarne_wiebalck: change posted to oslo.policy19:26
stevebaker[m]good morning20:01
arne_wiebalckstevebaker[m]: good morning!20:09
arne_wiebalckTheJulia: awesome, thanks20:09
arne_wiebalckTheJulia: there was an option already to have the deprecated rules added?20:10
TheJuliaarne_wiebalck: not one that could be toggled20:10
TheJuliagood morning stevebaker[m] 20:10
arne_wiebalckTheJulia: right, but in the _yield_yaml function20:10
arne_wiebalckTheJulia: the change looks good to me20:11
arne_wiebalckTheJulia: and imo it has the potential to save a lot of operators a lot of hassle :)20:12
TheJuliaarne_wiebalck: thanks!20:24
TheJuliastevebaker[m]: if you wouldn't mind, a quick review on https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/830358 would be appreciatec20:24
TheJuliaappreciated20:24
arne_wiebalckTheJulia: I will see if I can try the change tomorrow and then leave a review.20:25
arne_wiebalckbye everyone o/20:25
stevebaker[m]TheJulia: done!20:29
TheJuliastevebaker[m]: thanks!20:32
TheJuliaarne_wiebalck: that would be much appreciated20:32
opendevreviewMerged openstack/ironic-python-agent-builder stable/wallaby: Use native Centos 8 Stream for dib images  https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/83035821:59
iurygregoryI've pushed the patch with the Cycle Highlights for our project https://review.opendev.org/c/openstack/releases/+/830530 feel free to provide feedback =)22:48
opendevreviewJacob Anders proposed openstack/sushy master: Re-trying InsertMedia call with TransferProtocolType if required  https://review.opendev.org/c/openstack/sushy/+/83032223:17

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!