Tuesday, 2021-09-14

*** pmannidi is now known as pmannidi|brb00:14
*** pmannidi|brb is now known as pmannidi01:02
opendevreviewSteve Baker proposed openstack/bifrost master: WIP support grub network boot  https://review.opendev.org/c/openstack/bifrost/+/80722001:33
stevebakerTheJulia: soz I found something else https://review.opendev.org/c/openstack/tripleo-heat-templates/+/80274002:08
*** pmannidi is now known as pmannidi|Lunch04:12
*** pmannidi|Lunch is now known as pmannidi04:57
opendevreviewSteve Baker proposed openstack/bifrost master: WIP support grub network boot  https://review.opendev.org/c/openstack/bifrost/+/80722005:04
opendevreviewVerification of a change to openstack/ironic master failed: Fix idrac-wsman set_power_state to wait on HW  https://review.opendev.org/c/openstack/ironic/+/80809805:46
arne_wiebalckGood morning, Ironic!06:15
arne_wiebalckiurygregory: could you please have a look and give a /lgtm on https://github.com/metal3-io/ironic-hardware-inventory-recorder-image/pull/12 ?06:44
iurygregorygood morning arne_wiebalck and Ironic o/06:55
iurygregoryarne_wiebalck, sure in a few I will take a look06:55
arne_wiebalckty06:55
iurygregoryarne_wiebalck, I think I can only approve (not add lgtm) =(07:20
iurygregoryI will ask Derek or Bob to take a look07:21
*** hjensas is now known as hjensas|afk07:27
arne_wiebalckhmm ... from the workflow it looked liked reviewers can do /lgtm07:28
arne_wiebalckanyway :)07:28
arne_wiebalckthanks for trying07:28
iurygregoryhummm yeah I thought so also =( maybe they didn't update for this repo?07:29
arne_wiebalckFWIW, I got a notification saying you approved the PR07:29
arne_wiebalckmaybe it just takes some time until this is picked up and actually merged?07:29
iurygregoryYeah I approved the PR07:34
iurygregorybut I also added the lgtm ....07:34
iurygregorybut the bot didn't add the label07:35
opendevreviewAija Jauntēva proposed openstack/ironic master: Fix clear foreign config in idrac-redfish RAID  https://review.opendev.org/c/openstack/ironic/+/80484807:39
arne_wiebalckiurygregory: hmm, yeah, I see07:40
iurygregoryarne_wiebalck, that is why gerrit >>>>>>> github <307:41
arne_wiebalckheh07:41
opendevreviewAija Jauntēva proposed openstack/ironic master: Fix idrac-wsman set_power_state to wait on HW  https://review.opendev.org/c/openstack/ironic/+/80809807:58
opendevreviewVerification of a change to openstack/ironic master failed: Fix iDRAC import configuration job with errors  https://review.opendev.org/c/openstack/ironic/+/80543109:15
opendevreviewIury Gregory Melo Ferreira proposed openstack/ironic-inspector master: Fix sqlalchemy  https://review.opendev.org/c/openstack/ironic-inspector/+/80891709:17
opendevreviewIury Gregory Melo Ferreira proposed openstack/ironic-inspector master: Fix sqlalchemy  https://review.opendev.org/c/openstack/ironic-inspector/+/80891709:30
opendevreviewMerged openstack/ironic-python-agent-builder master: Use Ubuntu Focal instead of the default Bionic  https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/80819809:39
iurygregoryarne_wiebalck, if you have some time can you look at the inspector fix I pushed? (inspector CI is broken atm) =)09:45
opendevreviewVerification of a change to openstack/ironic master failed: Fix iDRAC import configuration job with errors  https://review.opendev.org/c/openstack/ironic/+/80543109:46
iurygregoryarne_wiebalck, I can change to data without problems =)10:04
ajyaany idea why many tests are failing with reno version conflict, e.g., https://review.opendev.org/c/openstack/ironic/+/808098 10:09
* iurygregory looks10:10
iurygregorythis is the first time I see this failure tbh10:16
iurygregoryI'm wondering if there was some bump in u-c that is causing this10:17
iurygregoryok, the change in the u-c is 1month old...10:19
iurygregoryI'm wondering if we can solve this by just bumping reno version... so pip will not complain10:27
iurygregoryok, a lot of projects are using reno>=3.1.0 like us... wondering if they are also affected.. maybe is a new version of pip that was released10:32
ajyathis is another patch failing https://review.opendev.org/c/openstack/ironic/+/805431 10:34
ajyait seems they started failing earlier today10:35
iurygregoryyeah I just saw, I've asked infra10:36
ajyathanks10:37
opendevreviewVerification of a change to openstack/bifrost master failed: Keystone: consolidate uWSGI config, drop non-existing plugin  https://review.opendev.org/c/openstack/bifrost/+/80612110:45
iurygregoryYAY10:46
iurygregoryour CI is broken \o/10:46
ajyaas expected :)10:47
iurygregoryyes10:48
iurygregory(╯°□°)╯︵ ┻━┻ CI10:49
arne_wiebalckiurygregory: I was just wondering if I missed sth :)11:53
opendevreviewVerification of a change to openstack/ironic master failed: Fix in-band cleaning for ramdisk and anaconda deploy  https://review.opendev.org/c/openstack/ironic/+/80718712:40
opendevreviewVerification of a change to openstack/ironic master failed: Move ramdisk deploy to its own module  https://review.opendev.org/c/openstack/ironic/+/80759012:40
iurygregoryajya, feel free to recheck now (the issues from mirror01 should be fixed now)13:09
ajyaiurygregory: thanks, will do, also will update one patch that got feedback13:11
iurygregoryack13:12
TheJuliagood morning13:13
TheJuliaiurygregory: what is broken?13:14
* TheJulia pokes at the docs job locally and gets different errors13:30
opendevreviewMerged openstack/ironic-python-agent-builder master: Remove support for iSCSI deploy from the DIB builder  https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/80821413:33
TheJuliaWell, that is a good sign13:35
TheJuliaoh, it is a junk file that is getting pulled in locally13:36
TheJuliadoh13:36
iurygregoryTheJulia, seems like it was an issue with some of the mirrors13:37
iurygregoryops not mirrors but the  pypi's cdn 13:38
iurygregoryseems like we can release ipa-builder \o/13:40
iurygregoryok, maybe we want to see if CI is happy about https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/776507 ?13:41
TheJuliaiurygregory: I guess, it would be good to know *why* of course13:44
opendevreviewAija Jauntēva proposed openstack/ironic master: Fix clear foreign config in idrac-redfish RAID  https://review.opendev.org/c/openstack/ironic/+/80484813:44
iurygregoryTheJulia, "we're just proxying through whatever pypi's serving, and their cdn seems to sometimes serve obsolete content around montreal canada" =D13:45
iurygregoryfrom the #opendev channel according to fungi =)13:45
TheJuliasweet13:46
TheJuliaiurygregory: why was in regards to the ipa-b patch13:46
iurygregoryoh!13:46
iurygregoryyeah, we don't have much information to understand why Riccardo wants to bump the version .-.13:47
opendevreviewIury Gregory Melo Ferreira proposed openstack/ironic master: Support HttpHeaders in create_subscription  https://review.opendev.org/c/openstack/ironic/+/80685913:48
iurygregoryTheJulia, when you have some time today https://review.opendev.org/c/openstack/ironic-inspector/+/808917 quick fix for inspector CI (requirements only runs the cross job against ironic so I forgot to push a patch to inspector)13:50
TheJuliaapproved13:57
TheJuliaiurygregory: I'd really prefer if we can get https://review.opendev.org/c/openstack/ironic/+/808806 into the release13:58
TheJulias/if/that/13:58
iurygregorywill look at it now13:58
TheJuliareview jam?14:00
iurygregoryI can join14:01
TheJuliawell, if nobody else is going to join, it is kind of pointless I gues14:01
TheJuliaunless we want to just cooridnate reviews to wrap things up14:01
iurygregoryyeah, I know I have meeting right after the review jam :D14:02
TheJuliame too14:02
ajyaI can join the jam14:03
TheJuliaWell, I'm on it and doing reviews14:04
TheJuliahttps://review.opendev.org/c/openstack/ironic/+/75583614:08
TheJuliahttps://review.opendev.org/c/openstack/ironic-python-agent/+/80351014:16
opendevreviewVerification of a change to openstack/ironic master failed: Move ramdisk deploy to its own module  https://review.opendev.org/c/openstack/ironic/+/80759014:29
iurygregoryhttps://review.opendev.org/c/openstack/ironic/+/80441614:29
opendevreviewVerification of a change to openstack/ironic master failed: Fix in-band cleaning for ramdisk and anaconda deploy  https://review.opendev.org/c/openstack/ironic/+/80718714:29
opendevreviewMerged openstack/ironic-inspector master: Fix sqlalchemy  https://review.opendev.org/c/openstack/ironic-inspector/+/80891714:31
TheJuliahttps://review.opendev.org/c/openstack/ironic-inspector/+/80757814:39
TheJuliahttps://review.opendev.org/c/openstack/ironic/+/80385514:49
TheJuliahttps://storyboard.openstack.org/#!/story/200298014:51
opendevreviewMerged openstack/ironic-inspector master: Update parameters for authtoken middleware  https://review.opendev.org/c/openstack/ironic-inspector/+/80544315:05
opendevreviewMerged openstack/bifrost master: Keystone: consolidate uWSGI config, drop non-existing plugin  https://review.opendev.org/c/openstack/bifrost/+/80612115:41
ajyaCI is back to green on my patches too 16:00
ajyastevebaker, TheJulia can you please revisit previously reviewed patch when you have time https://review.opendev.org/c/openstack/ironic/+/808098 Thanks16:00
ajyaand besides Julia another core reviewer maybe can take a look at this https://review.opendev.org/c/openstack/ironic/+/804112 16:01
opendevreviewAija Jauntēva proposed openstack/ironic master: Fix idrac-wsman set_power_state to wait on HW  https://review.opendev.org/c/openstack/ironic/+/80809816:02
opendevreviewDerek Higgins proposed openstack/ironic-lib master: Allow qemu-img to write out zeros to disk  https://review.opendev.org/c/openstack/ironic-lib/+/80899316:03
opendevreviewMerged openstack/ironic master: Fix driver task pattern to reduce periodic db load  https://review.opendev.org/c/openstack/ironic/+/80880617:12
opendevreviewMerged openstack/ironic master: Fix iDRAC import configuration job with errors  https://review.opendev.org/c/openstack/ironic/+/80543117:12
opendevreviewMerged openstack/ironic master: Fix in-band cleaning for ramdisk and anaconda deploy  https://review.opendev.org/c/openstack/ironic/+/80718717:16
opendevreviewMerged openstack/ironic master: Implements node history: database  https://review.opendev.org/c/openstack/ironic/+/76800917:16
opendevreviewVerification of a change to openstack/ironic master failed: Move ramdisk deploy to its own module  https://review.opendev.org/c/openstack/ironic/+/80759017:33
opendevreviewJulia Kreger proposed openstack/ironic master: API endpoints to get node history  https://review.opendev.org/c/openstack/ironic/+/80385519:14
opendevreviewJulia Kreger proposed openstack/ironic master: Facilitate asset copy for bootloader ops  https://review.opendev.org/c/openstack/ironic/+/80681519:20
stevebakerajya: sure thing19:24
opendevreviewMerged openstack/ironic master: Record node history and manage events in db  https://review.opendev.org/c/openstack/ironic/+/80329220:04
opendevreviewMerged openstack/metalsmith master: Add Python3 yoga unit tests  https://review.opendev.org/c/openstack/metalsmith/+/80825320:50
opendevreviewMerged openstack/ironic master: Fix idrac-wsman set_power_state to wait on HW  https://review.opendev.org/c/openstack/ironic/+/80809820:58
opendevreviewJulia Kreger proposed openstack/ironic stable/wallaby: Fix idrac-wsman set_power_state to wait on HW  https://review.opendev.org/c/openstack/ironic/+/80897921:16
opendevreviewJulia Kreger proposed openstack/ironic stable/victoria: Fix idrac-wsman set_power_state to wait on HW  https://review.opendev.org/c/openstack/ironic/+/80898021:16
opendevreviewJulia Kreger proposed openstack/ironic stable/ussuri: Fix idrac-wsman set_power_state to wait on HW  https://review.opendev.org/c/openstack/ironic/+/80898121:17
opendevreviewJulia Kreger proposed openstack/ironic stable/train: Fix idrac-wsman set_power_state to wait on HW  https://review.opendev.org/c/openstack/ironic/+/80898221:17
opendevreviewVerification of a change to openstack/ironic bugfix/18.1 failed: Improve edge-case debugging for deployment and cleaning  https://review.opendev.org/c/openstack/ironic/+/80726221:35
opendevreviewMerged openstack/ironic master: Document eject_vmedia for Redfish  https://review.opendev.org/c/openstack/ironic/+/80820121:39
stevebakerTheJulia: something I'll need to look into at some point, this bifrost job fails but returns SUCCESS to gerrit https://zuul.opendev.org/t/openstack/build/269cc992ef054c298ad392ea56e02552/log/job-output.txt#22943 https://review.opendev.org/c/openstack/bifrost/+/80722022:04
opendevreviewJulia Kreger proposed openstack/ironic master: API endpoints to get node history  https://review.opendev.org/c/openstack/ironic/+/80385522:15
TheJuliastevebaker: log collection is returning the rc 023:13
TheJuliajob is returning rc 223:13
TheJuliaso yeah... the runner script needs to be fixed23:14
TheJuliaI thought that was fixed.... *ages* ago23:14
stevebakerI'm not seeing anything obvious in old unmerged reviews23:21
opendevreviewVerification of a change to openstack/ironic master failed: Add support for fields in drivers API  https://review.opendev.org/c/openstack/ironic/+/80441623:23
TheJuliahmm23:25
TheJuliacould tee be suppressing it?!23:25
TheJuliaplaybooks/ci/run.yaml23:25
stevebakerTheJulia: I don't see a tee23:31
stevebakermaybe the on_exit function needs to return its own error code23:32
TheJuliaohh yes23:33
opendevreviewJulia Kreger proposed openstack/bifrost master: Re-exit with exit code  https://review.opendev.org/c/openstack/bifrost/+/80901823:34
stevebakerI'm not seeing any examples or docs which discuss this23:36
TheJuliaI guess we will see?23:37
stevebakerthe search results for "man trap" are amusingly unhelpful23:38
TheJuliarofl23:39
stevebakerTheJulia: oh! this (-e) suggests we need a trap on ERR, as well as EXIT https://www.gnu.org/software/bash/manual/html_node/The-Set-Builtin.html23:41
opendevreviewJulia Kreger proposed openstack/bifrost master: Re-exit with exit code  https://review.opendev.org/c/openstack/bifrost/+/80901823:48
opendevreviewJulia Kreger proposed openstack/bifrost master: Explicitly trap on ERR  https://review.opendev.org/c/openstack/bifrost/+/80901823:50

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!