Monday, 2021-09-06

*** pmannidi is now known as pmannidi|brb00:03
*** pmannidi|brb is now known as pmannidi00:54
arne_wiebalckGood morning, Ironic!05:22
iurygregorygood morning arne_wiebalck and Ironic o/06:06
arne_wiebalckhey iurygregory o/06:06
opendevreviewAija Jauntēva proposed openstack/ironic master: Fix clear foreign config in idrac-redfish RAID  https://review.opendev.org/c/openstack/ironic/+/80484808:05
ameya49Hi Team, While doing testing related to secure boot when secure boot is already enabled on server, observed console screen with UEFI error as UEFI0072. Query : Does ironic (ironic or ironic python agent or other repo) do authorization of certificates?09:31
dtantsurgood morning ironic, happy Monday09:32
dtantsurameya49: there is no certificate management yet, I think. maybe the iLO driver does it, I need to check, but nothing in the generic code.09:32
Nisha_Agarwaldtantsur, good morning09:33
dtantsurhi Nisha, long time no see. how are you?09:33
Nisha_Agarwaldtantsur, :) yes i am doing fine09:33
iurygregorygood morning dtantsur 09:33
ameya49Thanks @dtantsur09:33
dtantsurameya49: in theory, redfish allows us to manage secure boot keys (although not all vendors/models expose this feature). But we haven't got there.09:34
Nisha_Agarwaldtantsur, how are you ? :) 09:35
dtantsuroh, I'm not too bad. looking forward to the 2nd summer vacation, hopefully next week09:35
Nisha_Agarwaldtantsur, need one help...is it possible to review https://review.opendev.org/c/openstack/ironic/+/79956209:35
dtantsurI'll throw it on my list, need to figure out something urgent right now09:36
Nisha_Agarwaldtantsur, i am just driving it to take it to closure09:36
Nisha_Agarwaldtantsur, sure09:36
Nisha_Agarwalthanks09:36
* iurygregory adds the hashtag to the patch09:36
ameya49@dtantsur : Can you please help me to know how currently the authorization is happening, through bootloader? or any references, links?09:39
dtantsurameya49: ironic doesn't do anything beyond the generic secure boot, so any generic resource will help09:40
ameya49Thanks for the inputs @dtantsur09:41
*** pmannidi is now known as pmannidi|AFK10:48
timeuTheJulia: thanks for the heads up regarding the Operator Round Table. If nothing catastrophic happens, will join 12:08
iurygregoryIf anyone has more knowledge about postgresql I would appreciate some help to fix the unittests to unblock oslo.db 11.0.0 https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_48e/807278/15/check/openstack-tox-cover/48e5c07/testr_results.html :D , MySQL is already fixed https://review.opendev.org/c/openstack/ironic/+/80727812:38
dtantsurI haven't touched postresql for a while13:00
dtantsurI know it's more strict than MySQL in many aspects13:00
opendevreviewTadeas Kot proposed openstack/ironic-inspector master: Add support for state selector in the list introspection  https://review.opendev.org/c/openstack/ironic-inspector/+/80757813:04
iurygregoryI think it's probably something related to how I'm using the engine with connection, but since I can't reproduce things locally I can only try to guess :D13:04
timeuiurygregory: AFAIk Postgres is more strict with SQL errors within transactions. As far as I can tell the unique constraint error in line 1017: https://review.opendev.org/c/openstack/ironic/+/807278/15/ironic/tests/unit/db/sqlalchemy/test_migrations.py#1017 will cause the transaction to be aborted and thus the call on line 1021 will fail. I guess you need to catch the error13:30
timeuand rollback the transaction and start a new one13:31
iurygregorytimeu, oh wow D: 13:31
* iurygregory wondering if MySQL will be happy if we do a rollback :D13:32
timeuanother option is to use nested transactions with savepoints: https://docs.sqlalchemy.org/en/14/orm/session_transaction.html#using-savepoint13:33
iurygregorytks timeu !13:36
opendevreviewIury Gregory Melo Ferreira proposed openstack/ironic master: Fix to unblock oslodb 11.0.0  https://review.opendev.org/c/openstack/ironic/+/80727813:42
*** sshnaidm_ is now known as sshnaidm|off14:01
opendevreviewDmitry Tantsur proposed openstack/ironic master: Fix in-band cleaning for ramdisk and anaconda deploy  https://review.opendev.org/c/openstack/ironic/+/80718714:02
opendevreviewIury Gregory Melo Ferreira proposed openstack/ironic master: Fix to unblock oslodb 11.0.0  https://review.opendev.org/c/openstack/ironic/+/80727814:05
opendevreviewDmitry Tantsur proposed openstack/ironic master: Move ramdisk deploy to its own module  https://review.opendev.org/c/openstack/ironic/+/80759014:31
timeuiurygregory: I think you need to create a new nested transactions after the rollback of the first nested transaction, because otherwise the second rollback will abort  the main transaction and then the SQL insert on line 1036 will fail.14:35
iurygregorytimeu, oh ok o/14:36
iurygregoryso I need one for each rollback 14:36
timeuI would say for each SQL exception you need a nested transaction 14:38
iurygregorysomething like https://paste.opendev.org/show/808605/ ?14:39
timeuyes exactly 14:39
iurygregorytimeu, ack tks!14:39
timeuI don't think nested transactions/savepoints can be re-used once they are committed/rollbacked 14:40
iurygregoryI see =)14:40
opendevreviewIury Gregory Melo Ferreira proposed openstack/ironic master: Fix to unblock oslodb 11.0.0  https://review.opendev.org/c/openstack/ironic/+/80727814:40
timeulet's cross the fingers that I am right ;-)14:41
iurygregory:D yeah14:41
iurygregoryif any ironic core has some time for a quick review to save some CI resources https://review.opendev.org/c/openstack/ironic-inspector/+/807394 we should avoid running inspector jobs when we are just editing ironic unit tests =) 14:43
iurygregorytimeu, it worked \o/14:53
iurygregory<insert happy dance gif>14:53
opendevreviewIury Gregory Melo Ferreira proposed openstack/ironic master: Fix to unblock oslodb 11.0.0  https://review.opendev.org/c/openstack/ironic/+/80727814:59
iurygregorypushing a new patchset without the Depends-On in the requirements change (CI please be happy again :D)14:59
opendevreviewDmitry Tantsur proposed openstack/ironic master: [WIP] Refactor agent mixins, decompose AgentDeployMixin  https://review.opendev.org/c/openstack/ironic/+/80759715:07
dtantsuriurygregory: what's with self.engine vs just engine? are they different?15:08
iurygregorydtantsur, I didn't notice that the tests have engine as parameter... my bad15:12
iurygregorylet me fix =)15:13
opendevreviewIury Gregory Melo Ferreira proposed openstack/ironic master: Fix to unblock oslodb 11.0.0  https://review.opendev.org/c/openstack/ironic/+/80727815:15
iurygregorynow it should be ok :D15:30
iurygregorysee you tomorrow Ironic o/15:30
arne_wiebalckbye iurygregory o/15:31
arne_wiebalckdtantsur: I removed our ipmi wrapper, set the protocol version explicitly on the corresponding nodes, and all (higher level) retries seem to be gone now.15:44
dtantsur"gone" as in "no longer work" or "no longer needed"?15:47
arne_wiebalckdtantsur: the retries are no longer triggered15:50
arne_wiebalckdtantsur: which means the lower ones you had in mind are catching things15:51
dtantsuraha, nice15:51
arne_wiebalckdtantsur: which is what we wanted :)15:51
dtantsurmaybe the wrapper is not passing the output/exit code correctly?15:51
arne_wiebalckthat is it, yes, it does not relay it15:52
arne_wiebalckand rather than adding it, I removed it :)15:52
arne_wiebalckthe controllers are on cs8 now, so they have a newer version of ipmitool15:52
arne_wiebalckwhich should cover the initial cipher issue15:52
arne_wiebalck(and which seems it really does)15:53
arne_wiebalckso, we moved back to a more default setup :)15:53
arne_wiebalckthanks again for your doubts ;)15:53
dtantsurno problem, call me again when you need someone to nitpick on your patches :D16:01
arne_wiebalckheh16:09
arne_wiebalckbye everyone o/17:13
timeuiurygregory: woaah nice \o/18:04
opendevreviewTadeas Kot proposed openstack/ironic-inspector master: Add support for state selector in the list introspection  https://review.opendev.org/c/openstack/ironic-inspector/+/80757819:06
jandersgood morning Ironic23:32

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!