*** pmannidi is now known as pmannidi|brb | 00:03 | |
*** pmannidi|brb is now known as pmannidi | 00:54 | |
arne_wiebalck | Good morning, Ironic! | 05:22 |
---|---|---|
iurygregory | good morning arne_wiebalck and Ironic o/ | 06:06 |
arne_wiebalck | hey iurygregory o/ | 06:06 |
opendevreview | Aija Jauntēva proposed openstack/ironic master: Fix clear foreign config in idrac-redfish RAID https://review.opendev.org/c/openstack/ironic/+/804848 | 08:05 |
ameya49 | Hi Team, While doing testing related to secure boot when secure boot is already enabled on server, observed console screen with UEFI error as UEFI0072. Query : Does ironic (ironic or ironic python agent or other repo) do authorization of certificates? | 09:31 |
dtantsur | good morning ironic, happy Monday | 09:32 |
dtantsur | ameya49: there is no certificate management yet, I think. maybe the iLO driver does it, I need to check, but nothing in the generic code. | 09:32 |
Nisha_Agarwal | dtantsur, good morning | 09:33 |
dtantsur | hi Nisha, long time no see. how are you? | 09:33 |
Nisha_Agarwal | dtantsur, :) yes i am doing fine | 09:33 |
iurygregory | good morning dtantsur | 09:33 |
ameya49 | Thanks @dtantsur | 09:33 |
dtantsur | ameya49: in theory, redfish allows us to manage secure boot keys (although not all vendors/models expose this feature). But we haven't got there. | 09:34 |
Nisha_Agarwal | dtantsur, how are you ? :) | 09:35 |
dtantsur | oh, I'm not too bad. looking forward to the 2nd summer vacation, hopefully next week | 09:35 |
Nisha_Agarwal | dtantsur, need one help...is it possible to review https://review.opendev.org/c/openstack/ironic/+/799562 | 09:35 |
dtantsur | I'll throw it on my list, need to figure out something urgent right now | 09:36 |
Nisha_Agarwal | dtantsur, i am just driving it to take it to closure | 09:36 |
Nisha_Agarwal | dtantsur, sure | 09:36 |
Nisha_Agarwal | thanks | 09:36 |
* iurygregory adds the hashtag to the patch | 09:36 | |
ameya49 | @dtantsur : Can you please help me to know how currently the authorization is happening, through bootloader? or any references, links? | 09:39 |
dtantsur | ameya49: ironic doesn't do anything beyond the generic secure boot, so any generic resource will help | 09:40 |
ameya49 | Thanks for the inputs @dtantsur | 09:41 |
*** pmannidi is now known as pmannidi|AFK | 10:48 | |
timeu | TheJulia: thanks for the heads up regarding the Operator Round Table. If nothing catastrophic happens, will join | 12:08 |
iurygregory | If anyone has more knowledge about postgresql I would appreciate some help to fix the unittests to unblock oslo.db 11.0.0 https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_48e/807278/15/check/openstack-tox-cover/48e5c07/testr_results.html :D , MySQL is already fixed https://review.opendev.org/c/openstack/ironic/+/807278 | 12:38 |
dtantsur | I haven't touched postresql for a while | 13:00 |
dtantsur | I know it's more strict than MySQL in many aspects | 13:00 |
opendevreview | Tadeas Kot proposed openstack/ironic-inspector master: Add support for state selector in the list introspection https://review.opendev.org/c/openstack/ironic-inspector/+/807578 | 13:04 |
iurygregory | I think it's probably something related to how I'm using the engine with connection, but since I can't reproduce things locally I can only try to guess :D | 13:04 |
timeu | iurygregory: AFAIk Postgres is more strict with SQL errors within transactions. As far as I can tell the unique constraint error in line 1017: https://review.opendev.org/c/openstack/ironic/+/807278/15/ironic/tests/unit/db/sqlalchemy/test_migrations.py#1017 will cause the transaction to be aborted and thus the call on line 1021 will fail. I guess you need to catch the error | 13:30 |
timeu | and rollback the transaction and start a new one | 13:31 |
iurygregory | timeu, oh wow D: | 13:31 |
* iurygregory wondering if MySQL will be happy if we do a rollback :D | 13:32 | |
timeu | another option is to use nested transactions with savepoints: https://docs.sqlalchemy.org/en/14/orm/session_transaction.html#using-savepoint | 13:33 |
iurygregory | tks timeu ! | 13:36 |
opendevreview | Iury Gregory Melo Ferreira proposed openstack/ironic master: Fix to unblock oslodb 11.0.0 https://review.opendev.org/c/openstack/ironic/+/807278 | 13:42 |
*** sshnaidm_ is now known as sshnaidm|off | 14:01 | |
opendevreview | Dmitry Tantsur proposed openstack/ironic master: Fix in-band cleaning for ramdisk and anaconda deploy https://review.opendev.org/c/openstack/ironic/+/807187 | 14:02 |
opendevreview | Iury Gregory Melo Ferreira proposed openstack/ironic master: Fix to unblock oslodb 11.0.0 https://review.opendev.org/c/openstack/ironic/+/807278 | 14:05 |
opendevreview | Dmitry Tantsur proposed openstack/ironic master: Move ramdisk deploy to its own module https://review.opendev.org/c/openstack/ironic/+/807590 | 14:31 |
timeu | iurygregory: I think you need to create a new nested transactions after the rollback of the first nested transaction, because otherwise the second rollback will abort the main transaction and then the SQL insert on line 1036 will fail. | 14:35 |
iurygregory | timeu, oh ok o/ | 14:36 |
iurygregory | so I need one for each rollback | 14:36 |
timeu | I would say for each SQL exception you need a nested transaction | 14:38 |
iurygregory | something like https://paste.opendev.org/show/808605/ ? | 14:39 |
timeu | yes exactly | 14:39 |
iurygregory | timeu, ack tks! | 14:39 |
timeu | I don't think nested transactions/savepoints can be re-used once they are committed/rollbacked | 14:40 |
iurygregory | I see =) | 14:40 |
opendevreview | Iury Gregory Melo Ferreira proposed openstack/ironic master: Fix to unblock oslodb 11.0.0 https://review.opendev.org/c/openstack/ironic/+/807278 | 14:40 |
timeu | let's cross the fingers that I am right ;-) | 14:41 |
iurygregory | :D yeah | 14:41 |
iurygregory | if any ironic core has some time for a quick review to save some CI resources https://review.opendev.org/c/openstack/ironic-inspector/+/807394 we should avoid running inspector jobs when we are just editing ironic unit tests =) | 14:43 |
iurygregory | timeu, it worked \o/ | 14:53 |
iurygregory | <insert happy dance gif> | 14:53 |
opendevreview | Iury Gregory Melo Ferreira proposed openstack/ironic master: Fix to unblock oslodb 11.0.0 https://review.opendev.org/c/openstack/ironic/+/807278 | 14:59 |
iurygregory | pushing a new patchset without the Depends-On in the requirements change (CI please be happy again :D) | 14:59 |
opendevreview | Dmitry Tantsur proposed openstack/ironic master: [WIP] Refactor agent mixins, decompose AgentDeployMixin https://review.opendev.org/c/openstack/ironic/+/807597 | 15:07 |
dtantsur | iurygregory: what's with self.engine vs just engine? are they different? | 15:08 |
iurygregory | dtantsur, I didn't notice that the tests have engine as parameter... my bad | 15:12 |
iurygregory | let me fix =) | 15:13 |
opendevreview | Iury Gregory Melo Ferreira proposed openstack/ironic master: Fix to unblock oslodb 11.0.0 https://review.opendev.org/c/openstack/ironic/+/807278 | 15:15 |
iurygregory | now it should be ok :D | 15:30 |
iurygregory | see you tomorrow Ironic o/ | 15:30 |
arne_wiebalck | bye iurygregory o/ | 15:31 |
arne_wiebalck | dtantsur: I removed our ipmi wrapper, set the protocol version explicitly on the corresponding nodes, and all (higher level) retries seem to be gone now. | 15:44 |
dtantsur | "gone" as in "no longer work" or "no longer needed"? | 15:47 |
arne_wiebalck | dtantsur: the retries are no longer triggered | 15:50 |
arne_wiebalck | dtantsur: which means the lower ones you had in mind are catching things | 15:51 |
dtantsur | aha, nice | 15:51 |
arne_wiebalck | dtantsur: which is what we wanted :) | 15:51 |
dtantsur | maybe the wrapper is not passing the output/exit code correctly? | 15:51 |
arne_wiebalck | that is it, yes, it does not relay it | 15:52 |
arne_wiebalck | and rather than adding it, I removed it :) | 15:52 |
arne_wiebalck | the controllers are on cs8 now, so they have a newer version of ipmitool | 15:52 |
arne_wiebalck | which should cover the initial cipher issue | 15:52 |
arne_wiebalck | (and which seems it really does) | 15:53 |
arne_wiebalck | so, we moved back to a more default setup :) | 15:53 |
arne_wiebalck | thanks again for your doubts ;) | 15:53 |
dtantsur | no problem, call me again when you need someone to nitpick on your patches :D | 16:01 |
arne_wiebalck | heh | 16:09 |
arne_wiebalck | bye everyone o/ | 17:13 |
timeu | iurygregory: woaah nice \o/ | 18:04 |
opendevreview | Tadeas Kot proposed openstack/ironic-inspector master: Add support for state selector in the list introspection https://review.opendev.org/c/openstack/ironic-inspector/+/807578 | 19:06 |
janders | good morning Ironic | 23:32 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!