| opendevreview | Jay Faulkner proposed openstack/ironic-python-agent-builder master: Allow configuration of paths to prune https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/802965 | 00:14 |
|---|---|---|
| opendevreview | Merged openstack/ironic stable/ussuri: Refactor iDRAC OEM extension manager calls https://review.opendev.org/c/openstack/ironic/+/795524 | 00:14 |
| opendevreview | Steve Baker proposed openstack/ironic stable/wallaby: Defer checking image size until instance info is built https://review.opendev.org/c/openstack/ironic/+/802978 | 00:27 |
| *** pmannidi is now known as pmannidi|brb | 01:29 | |
| *** pmannidi|brb is now known as pmannidi | 01:59 | |
| *** pmannidi is now known as pmannidi|AFK | 03:14 | |
| *** pmannidi|AFK is now known as pmannidi | 04:48 | |
| iurygregory | good morning Ironic, happy Friday! | 05:48 |
| cenne | morning iurygregory | 07:15 |
| iurygregory | morning cenne o/ | 07:15 |
| *** rpittau|afk is now known as rpittau | 07:21 | |
| rpittau | good morning ironic! o/ | 07:21 |
| cenne | morning rpittau | 07:25 |
| rpittau | hey cenne :) | 07:25 |
| iurygregory | morning rpittau o/ | 07:26 |
| rpittau | hey iurygregory :) | 07:26 |
| opendevreview | Riccardo Pittau proposed openstack/ironic-python-agent master: Increase version of hacking and pycodestyle https://review.opendev.org/c/openstack/ironic-python-agent/+/802903 | 07:32 |
| janders | hey irygregory cenne rpittau and Ironic o/ | 07:57 |
| rpittau | hey janders :) | 07:57 |
| janders | Happy Friday - and bonus is it's not FFriday this time :) | 07:57 |
| rpittau | heh I feel like this week has been super slow compared to the precedent one! | 07:58 |
| janders | in my case maybe not slow, but definitely slower! :) | 08:01 |
| janders | if you guys have the bandwidth I'd appreciate reviews on https://review.opendev.org/c/openstack/sushy/+/802690 | 08:01 |
| janders | I tested the patch in the lab today, worked 10/10 | 08:01 |
| janders | rpittau: what would be involved in making this possible to test on OCP? I know there are a couple people who would be keen to try this end to end | 08:02 |
| rpittau | I'll have a look in a couple of minutes, after 2nd breakfast :) | 08:02 |
| janders | rpittau: no worries, no rush :) | 08:02 |
| janders | rpittau (for after you're back) I expect we need to re-spin ironic-image to include this, but not sure if I should just open a PR to include this (possibly upstream and downstream) or is there a better, fit-for-purpose process (hotfix etc)? | 08:03 |
| iurygregory | hey janders o/ | 08:12 |
| iurygregory | ping missed :D irygregory is not in this channel hehe | 08:12 |
| iurygregory | I'm wondering if in the scenario for patch vmedia they need Inserted/WriteProtected... | 08:18 |
| iurygregory | we don't have any Lenovo to test right? | 08:19 |
| rpittau | don't those will be set by default ? | 08:19 |
| iurygregory | even if they are using patch and not action? | 08:19 |
| iurygregory | who knows :D | 08:20 |
| janders | I will see if I can find any examples of PATCH in my test report | 08:20 |
| iurygregory | this scenario was specific for Lenovo afaik | 08:20 |
| janders | Supermicro 5039 uses Patch and doesn't allow setting Inserted either | 08:20 |
| janders | but - ask you said - mileage may vary | 08:21 |
| rpittau | that's fantastic | 08:21 |
| iurygregory | timeu, by any chance can you test if Inserted and WriteProtected are required for Lenovo when trying to use vmedia? | 08:21 |
| iurygregory | since you added the support in sushy https://github.com/openstack/sushy/commit/9e5a103565e204b9358e10580cd0346391be9bec | 08:21 |
| iurygregory | and we are trying to change the payload that we will send in https://review.opendev.org/c/openstack/sushy/+/802690/5/sushy/resources/manager/virtual_media.py#115 =) | 08:22 |
| janders | iurygregory if need be we can change the logics so that dropping Inserted/WriteProtected only happens if use_patch is not set | 08:24 |
| iurygregory | janders, yeah, just wondering if it would be required or not (things can be different between lenovo and SMC :D | 08:27 |
| iurygregory | I'm ok with the approach and ofc we can fix later if it breaks Lenovo =X | 08:28 |
| janders | I'd be quite happy to pre-emptively change my fix to treat PATCH and action based approaches differently. What do you guys think? Worth it? | 08:29 |
| iurygregory | I wish we had a lenovo server so we could just test the patch hehe | 08:30 |
| janders | can you think of any disadvantages of making this conditional on use_patch being set, other than extra work? | 08:31 |
| iurygregory | to me it would be only the extra logic we would need to add | 08:32 |
| iurygregory | in general lgtm | 08:32 |
| janders | thank you iurygregory | 08:32 |
| janders | rpittau dtantsur (when you're around) what do you guys think? | 08:33 |
| janders | I'm happy either way, just letting my engineering paranoia speak out :) | 08:33 |
| rpittau | janders: I had a glance to the latest change and it should be ok | 08:34 |
| janders | I will go get some dinner, will be back later, can re-spin and re-submit the patch with default-attribute-removal being conditional on use_patch being set or not | 08:34 |
| janders | rpittau: so we just leave it as-is for the time being? | 08:34 |
| janders | (that has it's merits, too, as quite a few people need the fix sooner than later it seems) | 08:34 |
| cenne | hey janders o/ | 08:36 |
| cenne | all the best on your patch | 08:37 |
| janders | thanks cenne :) | 08:37 |
| timeu | iurygregory: yes can test this. Should I install the sushy branch of the PR ? | 08:39 |
| rpittau | janders: I believe the sushy patch can stay as it is, yeah\ | 08:41 |
| iurygregory | timeu, you can probably test without the patch (just doing a curl sending only the Image in the payload) | 08:41 |
| timeu | will have a look today although i am not sure if constructing the url for me is faster than checking out the sushy branch (I have basically the steps written down to mount in the vmedia slot when I was testing my patch) | 08:43 |
| iurygregory | oh | 08:43 |
| iurygregory | so go ahead and apply the sushy pathc :D | 08:43 |
| iurygregory | patch* | 08:43 |
| iurygregory | if works for you and you can +1 the review it will be awesome =) | 08:44 |
| janders | timeu: you can literally swap out sushy/resources/manager/virtual_media.py with the one from the patch | 08:45 |
| janders | it's quite a simple one | 08:45 |
| janders | (if that makes things easier) | 08:45 |
| timeu | yes will do | 08:45 |
| janders | timeu thank you! | 08:46 |
| timeu | jandersiurygregory,: Unfortunately it seems that the patch breaks the patch code path: https://pastebin.com/dLZ2vLWN | 09:12 |
| timeu | janders & iurygregory: (no hopefully properly pinged): https://pastebin.com/dLZ2vLWN | 09:14 |
| janders | timeu: thank you for testing. I will change the logic so that it doesn't change behavior for patch, only for InsertAction. I will upload the revised one shortly (having dinner) | 09:15 |
| timeu | sounds good I can test it again | 09:16 |
| *** pmannidi is now known as pmannidi|AFK | 09:29 | |
| iurygregory | tks timeu! | 09:39 |
| janders | timeu iurygregory awesome, on it, will upload updated patch shortly | 09:52 |
| janders | timeu: what model of Lenovo are you testing on? I will put this in as a note | 09:58 |
| iurygregory | janders, in the releasenote for https://github.com/openstack/sushy/commit/9e5a103565e204b9358e10580cd0346391be9bec there is the model =) | 10:02 |
| opendevreview | Jacob Anders proposed openstack/sushy master: Removing optional fields from insert_media payload https://review.opendev.org/c/openstack/sushy/+/802690 | 10:16 |
| janders | ^ this should work on both SuperMicro X11 and Lenovo SD530. Re-testing it in the lab on Dell/HP/SuperMicro now | 10:17 |
| iurygregory | janders, tks! | 10:19 |
| janders | ok, SuperMicro X11 still works | 10:21 |
| janders | let's see if there is no regrssion on Dell/HP | 10:21 |
| janders | Dell's cool | 10:22 |
| janders | HP is cool, too | 10:23 |
| janders | timeu would you have time to re-test with https://review.opendev.org/c/openstack/sushy/+/802690/6 (should be the latest)? | 10:24 |
| janders | I hope this will work on both SuperMicro X11 and your Lenovo | 10:24 |
| janders | allright, wrapping up for the night (gotta prepare for a trip starting early tomorrow) | 10:28 |
| janders | I might drop in check messages briefly a little later | 10:28 |
| janders | see you on Monday Ironic o/ | 10:28 |
| janders | have a great weekend everyone | 10:28 |
| dtantsur | g'd afternoon ironic! | 10:29 |
| dtantsur | happy Friday, have a nice weekend janders | 10:29 |
| janders | thank you dtantsur :) | 10:29 |
| janders | (I managed to break vmedia on Lenovo while you were offline :) | 10:29 |
| janders | hopefully all fixed now | 10:29 |
| dtantsur | \o/ | 10:29 |
| janders | have a great weekend too dtantsur | 10:29 |
| iurygregory | have a great weekend janders o/ | 10:32 |
| cenne | bye janders | 10:40 |
| cenne | Good afternoon dtantsur | 10:40 |
| opendevreview | cenne proposed openstack/ironic master: Add api endpoint for setting boot_mode and secure_boot state https://review.opendev.org/c/openstack/ironic/+/800084 | 10:55 |
| cenne | Hay all, can I get a review here please ^ | 10:57 |
| opendevreview | Verification of a change to openstack/ironic stable/wallaby failed: Fix regression in ramdisk deploy kernel parameters https://review.opendev.org/c/openstack/ironic/+/802664 | 11:03 |
| opendevreview | Dmitry Tantsur proposed openstack/bifrost master: [WIP] Move Nginx code to a new role bifrost-nginx-install https://review.opendev.org/c/openstack/bifrost/+/802532 | 11:18 |
| timeu | janders & iurygregory: tested the last patchset and it now works again on Lenovo nodes (FYI: so far I only tested my original patch * the new one SD530, but we also plan to test it on SD670 and other node types). | 11:30 |
| iurygregory | timeu, tks for the feedback! | 11:31 |
| opendevreview | Dmitry Tantsur proposed openstack/bifrost master: DNM test the upgrade job https://review.opendev.org/c/openstack/bifrost/+/800673 | 11:38 |
| janders | timeu iurygregory thanks! | 11:43 |
| janders | and \o/ | 11:43 |
| opendevreview | Dmitry Tantsur proposed openstack/bifrost master: [WIP] Move Nginx code to a new role bifrost-nginx-install https://review.opendev.org/c/openstack/bifrost/+/802532 | 11:59 |
| opendevreview | Riccardo Pittau proposed openstack/ironic master: Add lower-constraints job to current development branch https://review.opendev.org/c/openstack/ironic/+/801350 | 12:20 |
| opendevreview | Riccardo Pittau proposed openstack/ironic-python-agent master: Increase version of hacking and pycodestyle https://review.opendev.org/c/openstack/ironic-python-agent/+/802903 | 12:34 |
| opendevreview | Dmitry Tantsur proposed openstack/bifrost master: DNM test the upgrade job https://review.opendev.org/c/openstack/bifrost/+/800673 | 13:05 |
| dtantsur | Fedora 34 breaks bifrost \o/ | 13:09 |
| iurygregory | yay! | 13:10 |
| iurygregory | I haven't tested in F34 only C8 | 13:10 |
| rpittau | interesting, how? | 13:11 |
| rpittau | I think I tested it recently | 13:11 |
| opendevreview | Dmitry Tantsur proposed openstack/bifrost master: [WIP] Move Nginx code to a new role bifrost-nginx-install https://review.opendev.org/c/openstack/bifrost/+/802532 | 13:13 |
| opendevreview | Dmitry Tantsur proposed openstack/bifrost master: Drop external tftp service in favor to use dnsmasq's one https://review.opendev.org/c/openstack/bifrost/+/782531 | 13:21 |
| dtantsur | TheJulia: FYI ^^^ | 13:21 |
| dtantsur | rpittau, iurygregory, xinetd has been removed apparently | 13:22 |
| TheJulia | good morning dtantsur | 13:22 |
| dtantsur | morning | 13:22 |
| TheJulia | dtantsur: awesome | 13:22 |
| iurygregory | dtantsur, oh nice! | 13:23 |
| rpittau | ah... ok | 13:32 |
| opendevreview | Dmitry Tantsur proposed openstack/bifrost master: Drop external tftp service in favor to use dnsmasq's one https://review.opendev.org/c/openstack/bifrost/+/782531 | 13:42 |
| opendevreview | Jay Faulkner proposed openstack/ironic-python-agent-builder master: Allow configuration of paths to prune https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/802965 | 13:46 |
| cenne | quick quesn: in controllers api is `@args.validate(node_ident=args.uuid_or_name, target=args.boolean)` supposed to validate 0/1 | 13:51 |
| TheJulia | cenne: 0/1 ? | 13:52 |
| cenne | Are integer 0,1 valid booleans for the api basically. | 13:52 |
| cenne | Instead of false /true | 13:53 |
| TheJulia | I guess they *could* be interpretted as such but they may not be | 13:53 |
| TheJulia | the docs use strings true/false | 13:53 |
| cenne | I am writing tests, and took the case of 0 being passed for secureboot state. I was expecting it to fail. Should I change the case to a sucess case? | 13:55 |
| TheJulia | I suspect so | 13:56 |
| cenne | okay. thanks. | 13:56 |
| rpittau | bye, have a great weekend! o/ | 14:07 |
| *** rpittau is now known as rpittau|afk | 14:07 | |
| -opendevstatus- NOTICE: There will be a brief outage of the Gerrit service on review.opendev.org starting at 15:00 UTC today as part of a routine project rename maintenance: http://lists.opendev.org/pipermail/service-announce/2021-July/000023.html | 14:11 | |
| dtantsur | cenne: I think we do allow 0/1 for booleans, although we don't document it | 14:14 |
| dtantsur | it's probably a property of the underlying library | 14:14 |
| dtantsur | (and the fact that booleans are integers in Python) | 14:14 |
| dtantsur | isinstance(True, int) is True | 14:15 |
| cenne | hmm. also found 'f' / 't' / 'on' / 'off' etc as allowed values (from the error the api emits.) | 14:15 |
| dtantsur | okay, this is probably a side effect of using oslo_utils.strutils.bool_from_string then | 14:15 |
| dtantsur | but it's useful to remember that in Python True == 1 and False == 0 | 14:15 |
| cenne | It didn't take 2 as True :) Seems like it has it's own mind :p | 14:16 |
| cenne | ack on the True == 1 , False ==0 | 14:16 |
| * dtantsur would prefer boolean to be a different type, but python used to be much closer to C | 14:17 | |
| opendevreview | Merged openstack/ironic stable/wallaby: Fix regression in ramdisk deploy kernel parameters https://review.opendev.org/c/openstack/ironic/+/802664 | 14:22 |
| opendevreview | Merged openstack/ironic-inspector master: Do not reset FSM when ironic ports cant be queried https://review.opendev.org/c/openstack/ironic-inspector/+/791251 | 14:28 |
| -opendevstatus- NOTICE: There will be a brief outage of the Gerrit service on review.opendev.org in the next few minutes as part of a routine project rename maintenance: http://lists.opendev.org/pipermail/service-announce/2021-July/000023.html | 15:00 | |
| iurygregory | bye everyone, have a great weekend! | 15:56 |
| cenne | Bye iurygregory. Happy weekend | 15:58 |
| opendevreview | cenne proposed openstack/ironic master: Add api endpoint for setting boot_mode and secure_boot state https://review.opendev.org/c/openstack/ironic/+/800084 | 16:16 |
| opendevreview | Merged openstack/ironic-python-agent-builder master: Allow configuration of paths to prune https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/802965 | 17:51 |
| *** melwitt is now known as jgwentworth | 17:55 | |
| dtantsur | undionly.kpxe that I get through TFTP is one byte smaller than the same file in /tftpboot | 18:29 |
| dtantsur | let's hope this one byte does not matter | 18:29 |
| dtantsur | have a great weekend folks! | 18:29 |
| opendevreview | Dmitry Tantsur proposed openstack/bifrost master: Drop external tftp service in favor to use dnsmasq's one https://review.opendev.org/c/openstack/bifrost/+/782531 | 18:31 |
| opendevreview | Dmitry Tantsur proposed openstack/bifrost master: DNM test the upgrade job https://review.opendev.org/c/openstack/bifrost/+/800673 | 18:38 |
| cenne | happy weekend dtantsur | 19:05 |
| cenne | o/ | 19:05 |
| cenne | I'll take leave too, bye everyone o/ | 19:08 |
| * cenne needs sleep. and a safe spot to wait and see some things take their course. | 19:15 | |
| *** pmannidi|AFK is now known as pmannidi | 22:05 | |
| NobodyCam | good afternoon Ironic Folks... | 22:30 |
| NobodyCam | and ofc... | 22:30 |
| NobodyCam | TGIF | 22:30 |
| NobodyCam | just thinking out loud but wouldn't be cool to have openstack baremetal chassis deploy ... to deploy a hole chassis is a single command | 22:32 |
| *** pmannidi is now known as pmannidi|AFK | 23:49 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!